[INFO] updating cached repository Jordan-McCallum/distributed-hangman-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Jordan-McCallum/distributed-hangman-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Jordan-McCallum/distributed-hangman-rust" "work/ex/clippy-test-run/sources/stable/gh/Jordan-McCallum/distributed-hangman-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Jordan-McCallum/distributed-hangman-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Jordan-McCallum/distributed-hangman-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jordan-McCallum/distributed-hangman-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jordan-McCallum/distributed-hangman-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 057928d1b45db0de35c8408a867a1a588ff95663 [INFO] sha for GitHub repo Jordan-McCallum/distributed-hangman-rust: 057928d1b45db0de35c8408a867a1a588ff95663 [INFO] validating manifest of Jordan-McCallum/distributed-hangman-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Jordan-McCallum/distributed-hangman-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Jordan-McCallum/distributed-hangman-rust [INFO] finished frobbing Jordan-McCallum/distributed-hangman-rust [INFO] frobbed toml for Jordan-McCallum/distributed-hangman-rust written to work/ex/clippy-test-run/sources/stable/gh/Jordan-McCallum/distributed-hangman-rust/Cargo.toml [INFO] started frobbing Jordan-McCallum/distributed-hangman-rust [INFO] finished frobbing Jordan-McCallum/distributed-hangman-rust [INFO] frobbed toml for Jordan-McCallum/distributed-hangman-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jordan-McCallum/distributed-hangman-rust/Cargo.toml [INFO] crate Jordan-McCallum/distributed-hangman-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Jordan-McCallum/distributed-hangman-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jordan-McCallum/distributed-hangman-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] de149eb217fd01e95bc3edea9cf338f34e2298afc6a918226c4685528627321e [INFO] running `"docker" "start" "-a" "de149eb217fd01e95bc3edea9cf338f34e2298afc6a918226c4685528627321e"` [INFO] [stderr] Checking destributed-hangman v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/server/lib/connection.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod connection { [INFO] [stderr] 2 | | use std::io::{ErrorKind, Read, Write, BufRead, BufReader}; [INFO] [stderr] 3 | | use std::net::{TcpStream, TcpListener}; [INFO] [stderr] 4 | | use std::sync::mpsc::{Sender, self}; [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server/lib/connection.rs:54:11 [INFO] [stderr] | [INFO] [stderr] 54 | } return ans; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ans` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/server/lib/game.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod game { [INFO] [stderr] 2 | | pub fn play_game() { [INFO] [stderr] 3 | | [INFO] [stderr] 4 | | } [INFO] [stderr] 5 | | [INFO] [stderr] 6 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/server/lib/connection.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod connection { [INFO] [stderr] 2 | | use std::io::{ErrorKind, Read, Write, BufRead, BufReader}; [INFO] [stderr] 3 | | use std::net::{TcpStream, TcpListener}; [INFO] [stderr] 4 | | use std::sync::mpsc::{Sender, self}; [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server/lib/connection.rs:54:11 [INFO] [stderr] | [INFO] [stderr] 54 | } return ans; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ans` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/server/lib/game.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod game { [INFO] [stderr] 2 | | pub fn play_game() { [INFO] [stderr] 3 | | [INFO] [stderr] 4 | | } [INFO] [stderr] 5 | | [INFO] [stderr] 6 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/client/lib/connection.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod connection { [INFO] [stderr] 2 | | use std::io::{self, ErrorKind, Read, Write}; [INFO] [stderr] 3 | | use std::net::TcpStream; [INFO] [stderr] 4 | | use std::sync::mpsc::{self, TryRecvError, Sender}; [INFO] [stderr] ... | [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/lib/connection.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | return ans; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ans` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/client/lib/game.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod game { [INFO] [stderr] 2 | | use std::io::{self, Read, Write}; [INFO] [stderr] 3 | | use std::sync::mpsc::{Sender, Receiver}; [INFO] [stderr] 4 | | use std::process::Command; [INFO] [stderr] ... | [INFO] [stderr] 30 | | [INFO] [stderr] 31 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Read`, `Write` [INFO] [stderr] --> src/client/lib/game.rs:2:25 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io::{self, Read, Write}; [INFO] [stderr] | ^^^^ ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/lib/game.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | return line_int; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `line_int` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rx` [INFO] [stderr] --> src/client/lib/game.rs:7:43 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn game_init(tx: &Sender, rx: &Receiver){ [INFO] [stderr] | ^^ help: consider using `_rx` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/client/lib/connection.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | / let mut ans: bool = false; [INFO] [stderr] 80 | | if msg.to_string() == "Success" { ans = true; } [INFO] [stderr] | |_______________________________________________________^ help: it is more idiomatic to write: `let ans = if msg.to_string() == "Success" { true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/client/lib/connection.rs:80:12 [INFO] [stderr] | [INFO] [stderr] 80 | if msg.to_string() == "Success" { ans = true; } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `msg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/client/lib/connection.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod connection { [INFO] [stderr] 2 | | use std::io::{self, ErrorKind, Read, Write}; [INFO] [stderr] 3 | | use std::net::TcpStream; [INFO] [stderr] 4 | | use std::sync::mpsc::{self, TryRecvError, Sender}; [INFO] [stderr] ... | [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/lib/connection.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | return ans; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ans` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/client/lib/game.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod game { [INFO] [stderr] 2 | | use std::io::{self, Read, Write}; [INFO] [stderr] 3 | | use std::sync::mpsc::{Sender, Receiver}; [INFO] [stderr] 4 | | use std::process::Command; [INFO] [stderr] ... | [INFO] [stderr] 30 | | [INFO] [stderr] 31 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Read`, `Write` [INFO] [stderr] --> src/client/lib/game.rs:2:25 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io::{self, Read, Write}; [INFO] [stderr] | ^^^^ ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client/lib/game.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | return line_int; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `line_int` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/server/lib/connection.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / let mut _buf = String::new(); [INFO] [stderr] 58 | | if auth == true {_buf = "Success".trim().to_string();} [INFO] [stderr] 59 | | else {_buf = "Fail".trim().to_string();} [INFO] [stderr] | |________________________________________________^ help: it is more idiomatic to write: `let _buf = if auth == true { "Success".trim().to_string() } else { "Fail".trim().to_string() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/server/lib/connection.rs:58:12 [INFO] [stderr] | [INFO] [stderr] 58 | if auth == true {_buf = "Success".trim().to_string();} [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `auth` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/server/lib/connection.rs:63:26 [INFO] [stderr] | [INFO] [stderr] 63 | fn recieve_info(msg: &String, tx:&Sender){ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server/lib/connection.rs:64:40 [INFO] [stderr] | [INFO] [stderr] 64 | let vec: Vec<&str> = msg.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/server/lib/connection.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / let mut _buf = String::new(); [INFO] [stderr] 58 | | if auth == true {_buf = "Success".trim().to_string();} [INFO] [stderr] 59 | | else {_buf = "Fail".trim().to_string();} [INFO] [stderr] | |________________________________________________^ help: it is more idiomatic to write: `let _buf = if auth == true { "Success".trim().to_string() } else { "Fail".trim().to_string() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/server/lib/connection.rs:58:12 [INFO] [stderr] | [INFO] [stderr] 58 | if auth == true {_buf = "Success".trim().to_string();} [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `auth` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/server/lib/connection.rs:63:26 [INFO] [stderr] | [INFO] [stderr] 63 | fn recieve_info(msg: &String, tx:&Sender){ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server/lib/connection.rs:64:40 [INFO] [stderr] | [INFO] [stderr] 64 | let vec: Vec<&str> = msg.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rx` [INFO] [stderr] --> src/client/lib/game.rs:7:43 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn game_init(tx: &Sender, rx: &Receiver){ [INFO] [stderr] | ^^ help: consider using `_rx` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/client/lib/connection.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | / let mut ans: bool = false; [INFO] [stderr] 80 | | if msg.to_string() == "Success" { ans = true; } [INFO] [stderr] | |_______________________________________________________^ help: it is more idiomatic to write: `let ans = if msg.to_string() == "Success" { true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/client/lib/connection.rs:80:12 [INFO] [stderr] | [INFO] [stderr] 80 | if msg.to_string() == "Success" { ans = true; } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `msg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.27s [INFO] running `"docker" "inspect" "de149eb217fd01e95bc3edea9cf338f34e2298afc6a918226c4685528627321e"` [INFO] running `"docker" "rm" "-f" "de149eb217fd01e95bc3edea9cf338f34e2298afc6a918226c4685528627321e"` [INFO] [stdout] de149eb217fd01e95bc3edea9cf338f34e2298afc6a918226c4685528627321e