[INFO] updating cached repository JoonHoSon/rust_hello [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/JoonHoSon/rust_hello [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/JoonHoSon/rust_hello" "work/ex/clippy-test-run/sources/stable/gh/JoonHoSon/rust_hello"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JoonHoSon/rust_hello'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/JoonHoSon/rust_hello" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoonHoSon/rust_hello"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoonHoSon/rust_hello'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 60cb280a60fc5090b13fd63585ae767d3180e5a3 [INFO] sha for GitHub repo JoonHoSon/rust_hello: 60cb280a60fc5090b13fd63585ae767d3180e5a3 [INFO] validating manifest of JoonHoSon/rust_hello on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of JoonHoSon/rust_hello on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing JoonHoSon/rust_hello [INFO] finished frobbing JoonHoSon/rust_hello [INFO] frobbed toml for JoonHoSon/rust_hello written to work/ex/clippy-test-run/sources/stable/gh/JoonHoSon/rust_hello/Cargo.toml [INFO] started frobbing JoonHoSon/rust_hello [INFO] finished frobbing JoonHoSon/rust_hello [INFO] frobbed toml for JoonHoSon/rust_hello written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoonHoSon/rust_hello/Cargo.toml [INFO] crate JoonHoSon/rust_hello has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting JoonHoSon/rust_hello against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoonHoSon/rust_hello:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 018e4688950ae8e84f3b7c5733b810993afd3aae302ff99c779f9536ee0a90c4 [INFO] running `"docker" "start" "-a" "018e4688950ae8e84f3b7c5733b810993afd3aae302ff99c779f9536ee0a90c4"` [INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other binary targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a binary target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/src/main.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autobins = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] warning: path `/opt/crater/workdir/src/main.rs` was erroneously implicitly accepted for binary `hello-joonho`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] Checking hello v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:16:54 [INFO] [stderr] | [INFO] [stderr] 16 | println!("named placeholder => {holder}", holder="Wow!"); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:16:54 [INFO] [stderr] | [INFO] [stderr] 16 | println!("named placeholder => {holder}", holder="Wow!"); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib/mod.rs:5:27 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn return_none(x: i8) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib/mod.rs:9:30 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn take(v: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib/mod.rs:5:27 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn return_none(x: i8) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib/mod.rs:9:30 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn take(v: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib/mod.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | v[0] = v[0] + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `v[0] += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib/mod.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | v[1] = v[1] * 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `v[1] *= 3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | v[0] = v[0] + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `v[0] += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib/mod.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | v[0] = v[0] + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `v[0] += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib/mod.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | v[1] = v[1] * 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `v[1] *= 3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | v[0] = v[0] + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `v[0] += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.78s [INFO] running `"docker" "inspect" "018e4688950ae8e84f3b7c5733b810993afd3aae302ff99c779f9536ee0a90c4"` [INFO] running `"docker" "rm" "-f" "018e4688950ae8e84f3b7c5733b810993afd3aae302ff99c779f9536ee0a90c4"` [INFO] [stdout] 018e4688950ae8e84f3b7c5733b810993afd3aae302ff99c779f9536ee0a90c4