[INFO] updating cached repository JonW27/graphics-polygons [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/JonW27/graphics-polygons [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/JonW27/graphics-polygons" "work/ex/clippy-test-run/sources/stable/gh/JonW27/graphics-polygons"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JonW27/graphics-polygons'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/JonW27/graphics-polygons" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JonW27/graphics-polygons"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JonW27/graphics-polygons'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2d9e407667268bcb4aece5344b954079e3b93b4e [INFO] sha for GitHub repo JonW27/graphics-polygons: 2d9e407667268bcb4aece5344b954079e3b93b4e [INFO] validating manifest of JonW27/graphics-polygons on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of JonW27/graphics-polygons on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing JonW27/graphics-polygons [INFO] finished frobbing JonW27/graphics-polygons [INFO] frobbed toml for JonW27/graphics-polygons written to work/ex/clippy-test-run/sources/stable/gh/JonW27/graphics-polygons/Cargo.toml [INFO] started frobbing JonW27/graphics-polygons [INFO] finished frobbing JonW27/graphics-polygons [INFO] frobbed toml for JonW27/graphics-polygons written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JonW27/graphics-polygons/Cargo.toml [INFO] crate JonW27/graphics-polygons has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting JonW27/graphics-polygons against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JonW27/graphics-polygons:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cec45e7a6697d44047f610d2b2bed4f2b845e45d9b3940c1218dd58a8af56eb0 [INFO] running `"docker" "start" "-a" "cec45e7a6697d44047f610d2b2bed4f2b845e45d9b3940c1218dd58a8af56eb0"` [INFO] [stderr] Checking inji v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/draw.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | let (l, mut k) = (p.lastcol - 2, 0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/draw.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | let i = k as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/draw.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | let n : [f64; 3] = get_surface_normal(p, i); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/matrix.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/draw.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | let (l, mut k) = (p.lastcol - 2, 0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/parser.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | let f = File::open(f_name); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/draw.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | let i = k as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/draw.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | let n : [f64; 3] = get_surface_normal(p, i); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/matrix.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/parser.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | let f = File::open(f_name); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/display.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return screen; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `screen` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/display.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return screen; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `screen` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/display.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | &screen[tmp].push(DEFAULT_COLOR); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `screen[tmp].push(DEFAULT_COLOR);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/display.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | pic.write(ppm.as_bytes()).expect("Could not write to file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/draw.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn add_polygon(polygons : &mut Matrix, x0 : f64, y0 : f64, z0 : f64, x1 : f64, y1 : f64, z1 : f64, x2 : f64, y2 : f64, z2 : f64){ [INFO] [stderr] 11 | | add_point(polygons, x0, y0, z0); [INFO] [stderr] 12 | | add_point(polygons, x1, y1, z1); [INFO] [stderr] 13 | | add_point(polygons, x2, y2, z2); [INFO] [stderr] 14 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/draw.rs:111:18 [INFO] [stderr] | [INFO] [stderr] 111 | for j in 0..step+1 { [INFO] [stderr] | ^^^^^^^^^ help: use: `0..=step` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/draw.rs:147:18 [INFO] [stderr] | [INFO] [stderr] 147 | for j in 0..step+1 { [INFO] [stderr] | ^^^^^^^^^ help: use: `0..=step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/draw.rs:174:1 [INFO] [stderr] | [INFO] [stderr] 174 | / pub fn add_curve( points : &mut Matrix, mut x0 : f64, mut y0 : f64, x1 : f64, y1 : f64, x2 : f64, y2 : f64, x3 : f64, y3 : f64, step : f64, curve_type : i64){ [INFO] [stderr] 175 | | let x_coefs = generate_curve_coefs(x0, x1, x2, x3, curve_type); [INFO] [stderr] 176 | | let y_coefs = generate_curve_coefs(y0, y1, y2, y3, curve_type); [INFO] [stderr] 177 | | let step = step as i64 * 100; [INFO] [stderr] ... | [INFO] [stderr] 185 | | } [INFO] [stderr] 186 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/draw.rs:218:24 [INFO] [stderr] | [INFO] [stderr] 218 | past_point_x = m[0][i].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `m[0][i]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/draw.rs:219:24 [INFO] [stderr] | [INFO] [stderr] 219 | past_point_y = m[1][i].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `m[1][i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/draw.rs:228:23 [INFO] [stderr] | [INFO] [stderr] 228 | let (A, B) = (my, -1 * (mx)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/matrix.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | &tmp[tmp_a].push(0.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tmp[tmp_a].push(0.);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:39:43 [INFO] [stderr] | [INFO] [stderr] 39 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:53:43 [INFO] [stderr] | [INFO] [stderr] 53 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:58:43 [INFO] [stderr] | [INFO] [stderr] 58 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:63:43 [INFO] [stderr] | [INFO] [stderr] 63 | let args = lines[cnt+1].split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:79:43 [INFO] [stderr] | [INFO] [stderr] 79 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:84:43 [INFO] [stderr] | [INFO] [stderr] 84 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:89:43 [INFO] [stderr] | [INFO] [stderr] 89 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:94:43 [INFO] [stderr] | [INFO] [stderr] 94 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:99:43 [INFO] [stderr] | [INFO] [stderr] 99 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:104:43 [INFO] [stderr] | [INFO] [stderr] 104 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `inji`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/display.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | &screen[tmp].push(DEFAULT_COLOR); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `screen[tmp].push(DEFAULT_COLOR);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/display.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | pic.write(ppm.as_bytes()).expect("Could not write to file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/draw.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn add_polygon(polygons : &mut Matrix, x0 : f64, y0 : f64, z0 : f64, x1 : f64, y1 : f64, z1 : f64, x2 : f64, y2 : f64, z2 : f64){ [INFO] [stderr] 11 | | add_point(polygons, x0, y0, z0); [INFO] [stderr] 12 | | add_point(polygons, x1, y1, z1); [INFO] [stderr] 13 | | add_point(polygons, x2, y2, z2); [INFO] [stderr] 14 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/draw.rs:111:18 [INFO] [stderr] | [INFO] [stderr] 111 | for j in 0..step+1 { [INFO] [stderr] | ^^^^^^^^^ help: use: `0..=step` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/draw.rs:147:18 [INFO] [stderr] | [INFO] [stderr] 147 | for j in 0..step+1 { [INFO] [stderr] | ^^^^^^^^^ help: use: `0..=step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/draw.rs:174:1 [INFO] [stderr] | [INFO] [stderr] 174 | / pub fn add_curve( points : &mut Matrix, mut x0 : f64, mut y0 : f64, x1 : f64, y1 : f64, x2 : f64, y2 : f64, x3 : f64, y3 : f64, step : f64, curve_type : i64){ [INFO] [stderr] 175 | | let x_coefs = generate_curve_coefs(x0, x1, x2, x3, curve_type); [INFO] [stderr] 176 | | let y_coefs = generate_curve_coefs(y0, y1, y2, y3, curve_type); [INFO] [stderr] 177 | | let step = step as i64 * 100; [INFO] [stderr] ... | [INFO] [stderr] 185 | | } [INFO] [stderr] 186 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/draw.rs:218:24 [INFO] [stderr] | [INFO] [stderr] 218 | past_point_x = m[0][i].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `m[0][i]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/draw.rs:219:24 [INFO] [stderr] | [INFO] [stderr] 219 | past_point_y = m[1][i].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `m[1][i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/draw.rs:228:23 [INFO] [stderr] | [INFO] [stderr] 228 | let (A, B) = (my, -1 * (mx)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/matrix.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | &tmp[tmp_a].push(0.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tmp[tmp_a].push(0.);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:39:43 [INFO] [stderr] | [INFO] [stderr] 39 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:53:43 [INFO] [stderr] | [INFO] [stderr] 53 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:58:43 [INFO] [stderr] | [INFO] [stderr] 58 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:63:43 [INFO] [stderr] | [INFO] [stderr] 63 | let args = lines[cnt+1].split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:79:43 [INFO] [stderr] | [INFO] [stderr] 79 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:84:43 [INFO] [stderr] | [INFO] [stderr] 84 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:89:43 [INFO] [stderr] | [INFO] [stderr] 89 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:94:43 [INFO] [stderr] | [INFO] [stderr] 94 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:99:43 [INFO] [stderr] | [INFO] [stderr] 99 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:104:43 [INFO] [stderr] | [INFO] [stderr] 104 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `inji`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "cec45e7a6697d44047f610d2b2bed4f2b845e45d9b3940c1218dd58a8af56eb0"` [INFO] running `"docker" "rm" "-f" "cec45e7a6697d44047f610d2b2bed4f2b845e45d9b3940c1218dd58a8af56eb0"` [INFO] [stdout] cec45e7a6697d44047f610d2b2bed4f2b845e45d9b3940c1218dd58a8af56eb0