[INFO] updating cached repository JoelEager/Rust-Collision-Detector
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/JoelEager/Rust-Collision-Detector
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/JoelEager/Rust-Collision-Detector" "work/ex/clippy-test-run/sources/stable/gh/JoelEager/Rust-Collision-Detector"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JoelEager/Rust-Collision-Detector'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/JoelEager/Rust-Collision-Detector" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoelEager/Rust-Collision-Detector"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoelEager/Rust-Collision-Detector'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a574a2f334935f6c1a4b6a2997b7eda019628ff1
[INFO] sha for GitHub repo JoelEager/Rust-Collision-Detector: a574a2f334935f6c1a4b6a2997b7eda019628ff1
[INFO] validating manifest of JoelEager/Rust-Collision-Detector on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of JoelEager/Rust-Collision-Detector on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing JoelEager/Rust-Collision-Detector
[INFO] finished frobbing JoelEager/Rust-Collision-Detector
[INFO] frobbed toml for JoelEager/Rust-Collision-Detector written to work/ex/clippy-test-run/sources/stable/gh/JoelEager/Rust-Collision-Detector/Cargo.toml
[INFO] started frobbing JoelEager/Rust-Collision-Detector
[INFO] finished frobbing JoelEager/Rust-Collision-Detector
[INFO] frobbed toml for JoelEager/Rust-Collision-Detector written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoelEager/Rust-Collision-Detector/Cargo.toml
[INFO] crate JoelEager/Rust-Collision-Detector has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting JoelEager/Rust-Collision-Detector against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoelEager/Rust-Collision-Detector:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a87451d6c41e76555d8c2e783e39517d0e01effee110a55b5a06a4f8a055cbb9
[INFO] running `"docker" "start" "-a" "a87451d6c41e76555d8c2e783e39517d0e01effee110a55b5a06a4f8a055cbb9"`
[INFO] [stderr]     Checking rust-collision-detector v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sat.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 | /     return match max_dist {
[INFO] [stderr] 15 | |         &Some(max_dist) if estimated_dist > max_dist.powi(2) => false,
[INFO] [stderr] 16 | |         &Some(_) | &None => run_sat(poly1, poly2)
[INFO] [stderr] 17 | |     };
[INFO] [stderr]    | |______^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 14 |     match max_dist {
[INFO] [stderr] 15 |         &Some(max_dist) if estimated_dist > max_dist.powi(2) => false,
[INFO] [stderr] 16 |         &Some(_) | &None => run_sat(poly1, poly2)
[INFO] [stderr] 17 |     }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sat.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 |     return true;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sat.rs:41:5
[INFO] [stderr]    |
[INFO] [stderr] 41 |     return Vector(point2.0 - point1.0, point2.1 - point1.1);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vector(point2.0 - point1.0, point2.1 - point1.1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sat.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 |     return edges;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `edges`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sat.rs:57:5
[INFO] [stderr]    |
[INFO] [stderr] 57 |     return Vector(vector.1, -vector.0);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vector(vector.1, -vector.0)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sat.rs:62:5
[INFO] [stderr]    |
[INFO] [stderr] 62 |     return vector1.0 * vector2.0 + vector1.1 * vector2.1;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `vector1.0 * vector2.0 + vector1.1 * vector2.1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sat.rs:83:5
[INFO] [stderr]    |
[INFO] [stderr] 83 |     return Vector(min.unwrap(), max.unwrap());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vector(min.unwrap(), max.unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sat.rs:88:5
[INFO] [stderr]    |
[INFO] [stderr] 88 |     return projection1.0 <= projection2.1 && projection2.0 <= projection1.1
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `projection1.0 <= projection2.1 && projection2.0 <= projection1.1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 |     return start.to(PreciseTime::now());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `start.to(PreciseTime::now())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 |         return args[1].parse().ok();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `args[1].parse().ok()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:51:9
[INFO] [stderr]    |
[INFO] [stderr] 51 |         return None;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sat.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 | /     return match max_dist {
[INFO] [stderr] 15 | |         &Some(max_dist) if estimated_dist > max_dist.powi(2) => false,
[INFO] [stderr] 16 | |         &Some(_) | &None => run_sat(poly1, poly2)
[INFO] [stderr] 17 | |     };
[INFO] [stderr]    | |______^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 14 |     match max_dist {
[INFO] [stderr] 15 |         &Some(max_dist) if estimated_dist > max_dist.powi(2) => false,
[INFO] [stderr] 16 |         &Some(_) | &None => run_sat(poly1, poly2)
[INFO] [stderr] 17 |     }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sat.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 |     return true;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sat.rs:41:5
[INFO] [stderr]    |
[INFO] [stderr] 41 |     return Vector(point2.0 - point1.0, point2.1 - point1.1);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vector(point2.0 - point1.0, point2.1 - point1.1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sat.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 |     return edges;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `edges`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sat.rs:57:5
[INFO] [stderr]    |
[INFO] [stderr] 57 |     return Vector(vector.1, -vector.0);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vector(vector.1, -vector.0)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sat.rs:62:5
[INFO] [stderr]    |
[INFO] [stderr] 62 |     return vector1.0 * vector2.0 + vector1.1 * vector2.1;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `vector1.0 * vector2.0 + vector1.1 * vector2.1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sat.rs:83:5
[INFO] [stderr]    |
[INFO] [stderr] 83 |     return Vector(min.unwrap(), max.unwrap());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vector(min.unwrap(), max.unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sat.rs:88:5
[INFO] [stderr]    |
[INFO] [stderr] 88 |     return projection1.0 <= projection2.1 && projection2.0 <= projection1.1
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `projection1.0 <= projection2.1 && projection2.0 <= projection1.1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 |     return start.to(PreciseTime::now());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `start.to(PreciseTime::now())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 |         return args[1].parse().ok();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `args[1].parse().ok()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:51:9
[INFO] [stderr]    |
[INFO] [stderr] 51 |         return None;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/sat.rs:6:67
[INFO] [stderr]   |
[INFO] [stderr] 6 | pub fn has_collided(poly1: &[Vector], poly2: &[Vector], max_dist: &Option<f32>) -> bool {
[INFO] [stderr]   |                                                                   ^^^^^^^^^^^^ help: consider passing by value instead: `Option<f32>`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/sat.rs:14:12
[INFO] [stderr]    |
[INFO] [stderr] 14 |       return match max_dist {
[INFO] [stderr]    |  ____________^
[INFO] [stderr] 15 | |         &Some(max_dist) if estimated_dist > max_dist.powi(2) => false,
[INFO] [stderr] 16 | |         &Some(_) | &None => run_sat(poly1, poly2)
[INFO] [stderr] 17 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 14 |     return match *max_dist {
[INFO] [stderr] 15 |         Some(max_dist) if estimated_dist > max_dist.powi(2) => false,
[INFO] [stderr] 16 |         Some(_) | None => run_sat(poly1, poly2)
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/sat.rs:6:67
[INFO] [stderr]   |
[INFO] [stderr] 6 | pub fn has_collided(poly1: &[Vector], poly2: &[Vector], max_dist: &Option<f32>) -> bool {
[INFO] [stderr]   |                                                                   ^^^^^^^^^^^^ help: consider passing by value instead: `Option<f32>`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/sat.rs:14:12
[INFO] [stderr]    |
[INFO] [stderr] 14 |       return match max_dist {
[INFO] [stderr]    |  ____________^
[INFO] [stderr] 15 | |         &Some(max_dist) if estimated_dist > max_dist.powi(2) => false,
[INFO] [stderr] 16 | |         &Some(_) | &None => run_sat(poly1, poly2)
[INFO] [stderr] 17 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 14 |     return match *max_dist {
[INFO] [stderr] 15 |         Some(max_dist) if estimated_dist > max_dist.powi(2) => false,
[INFO] [stderr] 16 |         Some(_) | None => run_sat(poly1, poly2)
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.58s
[INFO] running `"docker" "inspect" "a87451d6c41e76555d8c2e783e39517d0e01effee110a55b5a06a4f8a055cbb9"`
[INFO] running `"docker" "rm" "-f" "a87451d6c41e76555d8c2e783e39517d0e01effee110a55b5a06a4f8a055cbb9"`
[INFO] [stdout] a87451d6c41e76555d8c2e783e39517d0e01effee110a55b5a06a4f8a055cbb9