[INFO] updating cached repository JasonZell/CS408_Rust_Project [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/JasonZell/CS408_Rust_Project [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/JasonZell/CS408_Rust_Project" "work/ex/clippy-test-run/sources/stable/gh/JasonZell/CS408_Rust_Project"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JasonZell/CS408_Rust_Project'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/JasonZell/CS408_Rust_Project" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JasonZell/CS408_Rust_Project"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JasonZell/CS408_Rust_Project'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fa23d4dd09b6eb5ef61e8a9918d2e507285a91e6 [INFO] sha for GitHub repo JasonZell/CS408_Rust_Project: fa23d4dd09b6eb5ef61e8a9918d2e507285a91e6 [INFO] validating manifest of JasonZell/CS408_Rust_Project on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of JasonZell/CS408_Rust_Project on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing JasonZell/CS408_Rust_Project [INFO] finished frobbing JasonZell/CS408_Rust_Project [INFO] frobbed toml for JasonZell/CS408_Rust_Project written to work/ex/clippy-test-run/sources/stable/gh/JasonZell/CS408_Rust_Project/Cargo.toml [INFO] started frobbing JasonZell/CS408_Rust_Project [INFO] finished frobbing JasonZell/CS408_Rust_Project [INFO] frobbed toml for JasonZell/CS408_Rust_Project written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JasonZell/CS408_Rust_Project/Cargo.toml [INFO] crate JasonZell/CS408_Rust_Project has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting JasonZell/CS408_Rust_Project against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JasonZell/CS408_Rust_Project:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b47268a9d0764a0d007c65a03ba2169a5cadb38717c013c84dff74aca96be1ba [INFO] running `"docker" "start" "-a" "b47268a9d0764a0d007c65a03ba2169a5cadb38717c013c84dff74aca96be1ba"` [INFO] [stderr] Checking CS408_Rust_Project v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: crate `CS408_Rust_Project` should have a snake case name such as `cs408_rust_project` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:93:21 [INFO] [stderr] | [INFO] [stderr] 93 | word_count = word_count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `word_count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:94:21 [INFO] [stderr] | [INFO] [stderr] 94 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:97:29 [INFO] [stderr] | [INFO] [stderr] 97 | sentence_count = sentence_count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sentence_count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:101:21 [INFO] [stderr] | [INFO] [stderr] 101 | / match first_char { [INFO] [stderr] 102 | | Some(c) => [INFO] [stderr] 103 | | { [INFO] [stderr] 104 | | // entry function will try to get the value base on key, if key doesn't exist, it will insert the key with value of 1 [INFO] [stderr] ... | [INFO] [stderr] 108 | | None => {}, [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 101 | if let Some(c) = first_char { [INFO] [stderr] 102 | // entry function will try to get the value base on key, if key doesn't exist, it will insert the key with value of 1 [INFO] [stderr] 103 | let count = alpha_frequency.entry(c.to_ascii_uppercase()).or_insert(1); [INFO] [stderr] 104 | *count += 1; [INFO] [stderr] 105 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | paragraph_count = paragraph_count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `paragraph_count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `alpha_array`. [INFO] [stderr] --> src/main.rs:165:14 [INFO] [stderr] | [INFO] [stderr] 165 | for i in 0..26 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] warning: crate `CS408_Rust_Project` should have a snake case name such as `cs408_rust_project` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 165 | for in &alpha_array { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:166:44 [INFO] [stderr] | [INFO] [stderr] 166 | println!("{} : {} ",alpha_array[i],alpha_frequency.get(&alpha_array[i]).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&alpha_frequency[&alpha_array[i]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:93:21 [INFO] [stderr] | [INFO] [stderr] 93 | word_count = word_count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `word_count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:94:21 [INFO] [stderr] | [INFO] [stderr] 94 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:97:29 [INFO] [stderr] | [INFO] [stderr] 97 | sentence_count = sentence_count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sentence_count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:101:21 [INFO] [stderr] | [INFO] [stderr] 101 | / match first_char { [INFO] [stderr] 102 | | Some(c) => [INFO] [stderr] 103 | | { [INFO] [stderr] 104 | | // entry function will try to get the value base on key, if key doesn't exist, it will insert the key with value of 1 [INFO] [stderr] ... | [INFO] [stderr] 108 | | None => {}, [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 101 | if let Some(c) = first_char { [INFO] [stderr] 102 | // entry function will try to get the value base on key, if key doesn't exist, it will insert the key with value of 1 [INFO] [stderr] 103 | let count = alpha_frequency.entry(c.to_ascii_uppercase()).or_insert(1); [INFO] [stderr] 104 | *count += 1; [INFO] [stderr] 105 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | paragraph_count = paragraph_count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `paragraph_count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `alpha_array`. [INFO] [stderr] --> src/main.rs:165:14 [INFO] [stderr] | [INFO] [stderr] 165 | for i in 0..26 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 165 | for in &alpha_array { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:166:44 [INFO] [stderr] | [INFO] [stderr] 166 | println!("{} : {} ",alpha_array[i],alpha_frequency.get(&alpha_array[i]).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&alpha_frequency[&alpha_array[i]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.69s [INFO] running `"docker" "inspect" "b47268a9d0764a0d007c65a03ba2169a5cadb38717c013c84dff74aca96be1ba"` [INFO] running `"docker" "rm" "-f" "b47268a9d0764a0d007c65a03ba2169a5cadb38717c013c84dff74aca96be1ba"` [INFO] [stdout] b47268a9d0764a0d007c65a03ba2169a5cadb38717c013c84dff74aca96be1ba