[INFO] updating cached repository Januson/rustler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Januson/rustler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Januson/rustler" "work/ex/clippy-test-run/sources/stable/gh/Januson/rustler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Januson/rustler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Januson/rustler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Januson/rustler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Januson/rustler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7852ce24367b7a07ee7875e00c78a56941c470f1 [INFO] sha for GitHub repo Januson/rustler: 7852ce24367b7a07ee7875e00c78a56941c470f1 [INFO] validating manifest of Januson/rustler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Januson/rustler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Januson/rustler [INFO] finished frobbing Januson/rustler [INFO] frobbed toml for Januson/rustler written to work/ex/clippy-test-run/sources/stable/gh/Januson/rustler/Cargo.toml [INFO] started frobbing Januson/rustler [INFO] finished frobbing Januson/rustler [INFO] frobbed toml for Januson/rustler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Januson/rustler/Cargo.toml [INFO] crate Januson/rustler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Januson/rustler against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Januson/rustler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e25cf38cf546323505f5acfe8f36ac843a0d0aec0e72a006d5d4560486b10ffb [INFO] running `"docker" "start" "-a" "e25cf38cf546323505f5acfe8f36ac843a0d0aec0e72a006d5d4560486b10ffb"` [INFO] [stderr] Checking rustler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/euler/p004.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return max_pal; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `max_pal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:19:67 [INFO] [stderr] | [INFO] [stderr] 19 | print_problem(3, "Largest prime factor", largest_prime_factor(600851475143)); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `600_851_475_143` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/euler/p001.rs:15:37 [INFO] [stderr] | [INFO] [stderr] 15 | assert_eq!(sum_multiples(1000), 233168); [INFO] [stderr] | ^^^^^^ help: consider: `233_168` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/euler/p002.rs:35:36 [INFO] [stderr] | [INFO] [stderr] 35 | assert_eq!(sum_even_fib(), 4613732); [INFO] [stderr] | ^^^^^^^ help: consider: `4_613_732` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/euler/p004.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return max_pal; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `max_pal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:19:67 [INFO] [stderr] | [INFO] [stderr] 19 | print_problem(3, "Largest prime factor", largest_prime_factor(600851475143)); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `600_851_475_143` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/euler/p003.rs:21:16 [INFO] [stderr] | [INFO] [stderr] 21 | fn is_prime(x: &u64) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/euler/p003.rs:22:14 [INFO] [stderr] | [INFO] [stderr] 22 | for i in 2..(x / 2 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `2..=x / 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/euler/p004.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | / let db; [INFO] [stderr] 7 | | if a % 11 == 0 { [INFO] [stderr] 8 | | b = 999; [INFO] [stderr] 9 | | db = 1; [INFO] [stderr] ... | [INFO] [stderr] 12 | | db = 11; [INFO] [stderr] 13 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let db = if a % 11 == 0 { ..; 1 } else { ..; 11 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/euler/p006.rs:4:14 [INFO] [stderr] | [INFO] [stderr] 4 | for i in 1..(n + 1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/euler/p003.rs:21:16 [INFO] [stderr] | [INFO] [stderr] 21 | fn is_prime(x: &u64) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/euler/p003.rs:22:14 [INFO] [stderr] | [INFO] [stderr] 22 | for i in 2..(x / 2 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `2..=x / 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/euler/p004.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | / let db; [INFO] [stderr] 7 | | if a % 11 == 0 { [INFO] [stderr] 8 | | b = 999; [INFO] [stderr] 9 | | db = 1; [INFO] [stderr] ... | [INFO] [stderr] 12 | | db = 11; [INFO] [stderr] 13 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let db = if a % 11 == 0 { ..; 1 } else { ..; 11 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/euler/p006.rs:4:14 [INFO] [stderr] | [INFO] [stderr] 4 | for i in 1..(n + 1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.37s [INFO] running `"docker" "inspect" "e25cf38cf546323505f5acfe8f36ac843a0d0aec0e72a006d5d4560486b10ffb"` [INFO] running `"docker" "rm" "-f" "e25cf38cf546323505f5acfe8f36ac843a0d0aec0e72a006d5d4560486b10ffb"` [INFO] [stdout] e25cf38cf546323505f5acfe8f36ac843a0d0aec0e72a006d5d4560486b10ffb