[INFO] updating cached repository JamieSK/battleships [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/JamieSK/battleships [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/JamieSK/battleships" "work/ex/clippy-test-run/sources/stable/gh/JamieSK/battleships"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JamieSK/battleships'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/JamieSK/battleships" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JamieSK/battleships"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JamieSK/battleships'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 989e6c2315ef3dc08bf94e0e5f882545a1364c62 [INFO] sha for GitHub repo JamieSK/battleships: 989e6c2315ef3dc08bf94e0e5f882545a1364c62 [INFO] validating manifest of JamieSK/battleships on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of JamieSK/battleships on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing JamieSK/battleships [INFO] finished frobbing JamieSK/battleships [INFO] frobbed toml for JamieSK/battleships written to work/ex/clippy-test-run/sources/stable/gh/JamieSK/battleships/Cargo.toml [INFO] started frobbing JamieSK/battleships [INFO] finished frobbing JamieSK/battleships [INFO] frobbed toml for JamieSK/battleships written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JamieSK/battleships/Cargo.toml [INFO] crate JamieSK/battleships has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting JamieSK/battleships against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JamieSK/battleships:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 73250b74cdd1466360f6cccb33586f8148622eb715404fb40c20d8b52d70ea8a [INFO] running `"docker" "start" "-a" "73250b74cdd1466360f6cccb33586f8148622eb715404fb40c20d8b52d70ea8a"` [INFO] [stderr] Checking battleships v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | return Ok("Placed ship."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok("Placed ship.")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | return Ok("Placed ship."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok("Placed ship.")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | return Ok("Placed ship."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok("Placed ship.")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | return Ok("Placed ship."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok("Placed ship.")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Battleships` [INFO] [stderr] --> src/lib.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> Battleships { [INFO] [stderr] 34 | | Battleships { [INFO] [stderr] 35 | | player_1: Board { [INFO] [stderr] 36 | | ships_board: vec![vec![Cell { contents: None, hit: false }; 10]; 10], [INFO] [stderr] ... | [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | impl Default for Battleships { [INFO] [stderr] 33 | fn default() -> Self { [INFO] [stderr] 34 | Self::new() [INFO] [stderr] 35 | } [INFO] [stderr] 36 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:80:21 [INFO] [stderr] | [INFO] [stderr] 80 | / match self.player_1.ships_board[cell.x][cell.y].contents { [INFO] [stderr] 81 | | Some(_) => return Err("There's already a ship there."), [INFO] [stderr] 82 | | None => {}, [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let Some(_) = self.player_1.ships_board[cell.x][cell.y].contents { return Err("There's already a ship there.") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | / match self.player_2.ships_board[cell.x][cell.y].contents { [INFO] [stderr] 98 | | Some(_) => return Err("There's already a ship there."), [INFO] [stderr] 99 | | None => {}, [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let Some(_) = self.player_2.ships_board[cell.x][cell.y].contents { return Err("There's already a ship there.") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | / match cell.hit { [INFO] [stderr] 132 | | true => Err("You've already fired at that cell."), [INFO] [stderr] 133 | | false => { [INFO] [stderr] 134 | | self.hit_cell(&point, other_player); [INFO] [stderr] ... | [INFO] [stderr] 156 | | } [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 131 | if cell.hit { Err("You've already fired at that cell.") } else { [INFO] [stderr] 132 | self.hit_cell(&point, other_player); [INFO] [stderr] 133 | match cell.contents { [INFO] [stderr] 134 | Some(ref ship) => { [INFO] [stderr] 135 | match self.sunk_ship(ship, other_player) { [INFO] [stderr] 136 | true => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:137:25 [INFO] [stderr] | [INFO] [stderr] 137 | / match self.sunk_ship(ship, other_player) { [INFO] [stderr] 138 | | true => { [INFO] [stderr] 139 | | let mut ships_left = self.ships_left(other_player); [INFO] [stderr] 140 | | *ships_left -= 1; [INFO] [stderr] ... | [INFO] [stderr] 148 | | }, [INFO] [stderr] 149 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 137 | if self.sunk_ship(ship, other_player) { [INFO] [stderr] 138 | let mut ships_left = self.ships_left(other_player); [INFO] [stderr] 139 | *ships_left -= 1; [INFO] [stderr] 140 | match *ships_left { [INFO] [stderr] 141 | 0 => Ok("You sank all my battleships!"), [INFO] [stderr] 142 | _ => Ok("You sank my battleship!"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Battleships` [INFO] [stderr] --> src/lib.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> Battleships { [INFO] [stderr] 34 | | Battleships { [INFO] [stderr] 35 | | player_1: Board { [INFO] [stderr] 36 | | ships_board: vec![vec![Cell { contents: None, hit: false }; 10]; 10], [INFO] [stderr] ... | [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | impl Default for Battleships { [INFO] [stderr] 33 | fn default() -> Self { [INFO] [stderr] 34 | Self::new() [INFO] [stderr] 35 | } [INFO] [stderr] 36 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:80:21 [INFO] [stderr] | [INFO] [stderr] 80 | / match self.player_1.ships_board[cell.x][cell.y].contents { [INFO] [stderr] 81 | | Some(_) => return Err("There's already a ship there."), [INFO] [stderr] 82 | | None => {}, [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let Some(_) = self.player_1.ships_board[cell.x][cell.y].contents { return Err("There's already a ship there.") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | / match self.player_2.ships_board[cell.x][cell.y].contents { [INFO] [stderr] 98 | | Some(_) => return Err("There's already a ship there."), [INFO] [stderr] 99 | | None => {}, [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let Some(_) = self.player_2.ships_board[cell.x][cell.y].contents { return Err("There's already a ship there.") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | / match cell.hit { [INFO] [stderr] 132 | | true => Err("You've already fired at that cell."), [INFO] [stderr] 133 | | false => { [INFO] [stderr] 134 | | self.hit_cell(&point, other_player); [INFO] [stderr] ... | [INFO] [stderr] 156 | | } [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 131 | if cell.hit { Err("You've already fired at that cell.") } else { [INFO] [stderr] 132 | self.hit_cell(&point, other_player); [INFO] [stderr] 133 | match cell.contents { [INFO] [stderr] 134 | Some(ref ship) => { [INFO] [stderr] 135 | match self.sunk_ship(ship, other_player) { [INFO] [stderr] 136 | true => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:137:25 [INFO] [stderr] | [INFO] [stderr] 137 | / match self.sunk_ship(ship, other_player) { [INFO] [stderr] 138 | | true => { [INFO] [stderr] 139 | | let mut ships_left = self.ships_left(other_player); [INFO] [stderr] 140 | | *ships_left -= 1; [INFO] [stderr] ... | [INFO] [stderr] 148 | | }, [INFO] [stderr] 149 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 137 | if self.sunk_ship(ship, other_player) { [INFO] [stderr] 138 | let mut ships_left = self.ships_left(other_player); [INFO] [stderr] 139 | *ships_left -= 1; [INFO] [stderr] 140 | match *ships_left { [INFO] [stderr] 141 | 0 => Ok("You sank all my battleships!"), [INFO] [stderr] 142 | _ => Ok("You sank my battleship!"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.89s [INFO] running `"docker" "inspect" "73250b74cdd1466360f6cccb33586f8148622eb715404fb40c20d8b52d70ea8a"` [INFO] running `"docker" "rm" "-f" "73250b74cdd1466360f6cccb33586f8148622eb715404fb40c20d8b52d70ea8a"` [INFO] [stdout] 73250b74cdd1466360f6cccb33586f8148622eb715404fb40c20d8b52d70ea8a