[INFO] updating cached repository Jafosterja/Battleships-Rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Jafosterja/Battleships-Rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Jafosterja/Battleships-Rust" "work/ex/clippy-test-run/sources/stable/gh/Jafosterja/Battleships-Rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Jafosterja/Battleships-Rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Jafosterja/Battleships-Rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jafosterja/Battleships-Rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jafosterja/Battleships-Rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c2e33ce0c663abb0f075c742eedb9e6b26cd270b [INFO] sha for GitHub repo Jafosterja/Battleships-Rust: c2e33ce0c663abb0f075c742eedb9e6b26cd270b [INFO] validating manifest of Jafosterja/Battleships-Rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Jafosterja/Battleships-Rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Jafosterja/Battleships-Rust [INFO] finished frobbing Jafosterja/Battleships-Rust [INFO] frobbed toml for Jafosterja/Battleships-Rust written to work/ex/clippy-test-run/sources/stable/gh/Jafosterja/Battleships-Rust/Cargo.toml [INFO] started frobbing Jafosterja/Battleships-Rust [INFO] finished frobbing Jafosterja/Battleships-Rust [INFO] frobbed toml for Jafosterja/Battleships-Rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jafosterja/Battleships-Rust/Cargo.toml [INFO] crate Jafosterja/Battleships-Rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Jafosterja/Battleships-Rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jafosterja/Battleships-Rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c13c8953d02151e62619054bc4e49ae6e8ea5eb5b0193b66392c53104b173c70 [INFO] running `"docker" "start" "-a" "c13c8953d02151e62619054bc4e49ae6e8ea5eb5b0193b66392c53104b173c70"` [INFO] [stderr] Checking Battleships-Rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ship.rs:133:21 [INFO] [stderr] | [INFO] [stderr] 133 | let d = Cords{x : x_initial, y : (y_initial as i8) - 3, hit : false}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/ship.rs:134:21 [INFO] [stderr] | [INFO] [stderr] 134 | let e = Cords{x : x_initial, y : (y_initial as i8) - 4, hit : false}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ship.rs:144:21 [INFO] [stderr] | [INFO] [stderr] 144 | let d = Cords{x : x_initial, y : (y_initial as i8) + 3, hit : false}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/ship.rs:145:21 [INFO] [stderr] | [INFO] [stderr] 145 | let e = Cords{x : x_initial, y : (y_initial as i8) + 4, hit : false}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ship.rs:155:21 [INFO] [stderr] | [INFO] [stderr] 155 | let d = Cords{x : convert_int_to_char(s + 3), y : (y_initial as i8), hit : false}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/ship.rs:156:21 [INFO] [stderr] | [INFO] [stderr] 156 | let e = Cords{x : convert_int_to_char(s + 4), y : (y_initial as i8), hit : false}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ship.rs:165:21 [INFO] [stderr] | [INFO] [stderr] 165 | let d = Cords{x : convert_int_to_char(s - 3), y : (y_initial as i8), hit : false}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/ship.rs:166:21 [INFO] [stderr] | [INFO] [stderr] 166 | let e = Cords{x : convert_int_to_char(s - 4), y : (y_initial as i8), hit : false}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ship.rs:330:21 [INFO] [stderr] | [INFO] [stderr] 330 | let d = Cords{x : x_initial, y : (y_initial as i8) - 3, hit : false}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ship.rs:340:21 [INFO] [stderr] | [INFO] [stderr] 340 | let d = Cords{x : x_initial, y : (y_initial as i8) + 3, hit : false}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ship.rs:350:21 [INFO] [stderr] | [INFO] [stderr] 350 | let d = Cords{x : convert_int_to_char(s + 3), y : (y_initial as i8), hit : false}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ship.rs:359:21 [INFO] [stderr] | [INFO] [stderr] 359 | let d = Cords{x : convert_int_to_char(s - 3), y : (y_initial as i8), hit : false}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/tests.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | let e = Cords{x : 'A', y : 5, hit : false}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/player.rs:41:27 [INFO] [stderr] | [INFO] [stderr] 41 | let check = Cords{x : x, y : (y as i8), hit : false}; [INFO] [stderr] | ^^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:167:59 [INFO] [stderr] | [INFO] [stderr] 167 | let cords = Cords{x : convert_int_to_char(k), y : y, hit : false}; [INFO] [stderr] | ^^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ship.rs:133:21 [INFO] [stderr] | [INFO] [stderr] 133 | let d = Cords{x : x_initial, y : (y_initial as i8) - 3, hit : false}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/ship.rs:134:21 [INFO] [stderr] | [INFO] [stderr] 134 | let e = Cords{x : x_initial, y : (y_initial as i8) - 4, hit : false}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ship.rs:144:21 [INFO] [stderr] | [INFO] [stderr] 144 | let d = Cords{x : x_initial, y : (y_initial as i8) + 3, hit : false}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/ship.rs:145:21 [INFO] [stderr] | [INFO] [stderr] 145 | let e = Cords{x : x_initial, y : (y_initial as i8) + 4, hit : false}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ship.rs:155:21 [INFO] [stderr] | [INFO] [stderr] 155 | let d = Cords{x : convert_int_to_char(s + 3), y : (y_initial as i8), hit : false}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/ship.rs:156:21 [INFO] [stderr] | [INFO] [stderr] 156 | let e = Cords{x : convert_int_to_char(s + 4), y : (y_initial as i8), hit : false}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ship.rs:165:21 [INFO] [stderr] | [INFO] [stderr] 165 | let d = Cords{x : convert_int_to_char(s - 3), y : (y_initial as i8), hit : false}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/ship.rs:166:21 [INFO] [stderr] | [INFO] [stderr] 166 | let e = Cords{x : convert_int_to_char(s - 4), y : (y_initial as i8), hit : false}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ship.rs:330:21 [INFO] [stderr] | [INFO] [stderr] 330 | let d = Cords{x : x_initial, y : (y_initial as i8) - 3, hit : false}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ship.rs:340:21 [INFO] [stderr] | [INFO] [stderr] 340 | let d = Cords{x : x_initial, y : (y_initial as i8) + 3, hit : false}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ship.rs:350:21 [INFO] [stderr] | [INFO] [stderr] 350 | let d = Cords{x : convert_int_to_char(s + 3), y : (y_initial as i8), hit : false}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ship.rs:359:21 [INFO] [stderr] | [INFO] [stderr] 359 | let d = Cords{x : convert_int_to_char(s - 3), y : (y_initial as i8), hit : false}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/tests.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | let e = Cords{x : 'A', y : 5, hit : false}; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/player.rs:41:27 [INFO] [stderr] | [INFO] [stderr] 41 | let check = Cords{x : x, y : (y as i8), hit : false}; [INFO] [stderr] | ^^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:167:59 [INFO] [stderr] | [INFO] [stderr] 167 | let cords = Cords{x : convert_int_to_char(k), y : y, hit : false}; [INFO] [stderr] | ^^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/ship.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | else{ [INFO] [stderr] | _________________^ [INFO] [stderr] 43 | | if self.cordinates[p].y == test.y && self.cordinates[p].x == test.x{ [INFO] [stderr] 44 | | self.cordinates[p].hit = true; [INFO] [stderr] 45 | | return self; [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 42 | elseif self.cordinates[p].y == test.y && self.cordinates[p].x == test.x{ [INFO] [stderr] 43 | self.cordinates[p].hit = true; [INFO] [stderr] 44 | return self; [INFO] [stderr] 45 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return x; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | return &self.shiptype; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.shiptype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return -1//otherwise there is no ship at these cords and print the defualt [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `-1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:78:26 [INFO] [stderr] | [INFO] [stderr] 78 | "Carrier" => return 'C', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'C'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:79:29 [INFO] [stderr] | [INFO] [stderr] 79 | "Battleship" => return 'B', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'B'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:80:26 [INFO] [stderr] | [INFO] [stderr] 80 | "Cruiser" => return 'R', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'R'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:81:22 [INFO] [stderr] | [INFO] [stderr] 81 | "sub" => return 'S', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'S'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:82:28 [INFO] [stderr] | [INFO] [stderr] 82 | "Destroyer" => return 'D', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'D'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:83:18 [INFO] [stderr] | [INFO] [stderr] 83 | _ => return 'U' [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'U'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:175:16 [INFO] [stderr] | [INFO] [stderr] 175 | 'N' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:176:16 [INFO] [stderr] | [INFO] [stderr] 176 | 'S' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:177:16 [INFO] [stderr] | [INFO] [stderr] 177 | 'E' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:178:16 [INFO] [stderr] | [INFO] [stderr] 178 | 'W' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | return false}, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:185:14 [INFO] [stderr] | [INFO] [stderr] 185 | 1 => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:186:14 [INFO] [stderr] | [INFO] [stderr] 186 | 2 => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:187:14 [INFO] [stderr] | [INFO] [stderr] 187 | 3 => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:188:14 [INFO] [stderr] | [INFO] [stderr] 188 | 4 => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:189:14 [INFO] [stderr] | [INFO] [stderr] 189 | 5 => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:190:14 [INFO] [stderr] | [INFO] [stderr] 190 | 6 => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:191:14 [INFO] [stderr] | [INFO] [stderr] 191 | 7 => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:192:14 [INFO] [stderr] | [INFO] [stderr] 192 | 8 => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:193:14 [INFO] [stderr] | [INFO] [stderr] 193 | 9 => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:194:15 [INFO] [stderr] | [INFO] [stderr] 194 | 10 => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:195:14 [INFO] [stderr] | [INFO] [stderr] 195 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:200:14 [INFO] [stderr] | [INFO] [stderr] 200 | 0 => return 'T', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'T'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:201:14 [INFO] [stderr] | [INFO] [stderr] 201 | 1 => return 'A', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'A'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:202:14 [INFO] [stderr] | [INFO] [stderr] 202 | 2 => return 'B', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'B'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:203:14 [INFO] [stderr] | [INFO] [stderr] 203 | 3 => return 'C', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'C'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:204:14 [INFO] [stderr] | [INFO] [stderr] 204 | 4 => return 'D', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'D'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:205:14 [INFO] [stderr] | [INFO] [stderr] 205 | 5 => return 'E', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'E'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:206:14 [INFO] [stderr] | [INFO] [stderr] 206 | 6 => return 'F', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'F'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:207:14 [INFO] [stderr] | [INFO] [stderr] 207 | 7 => return 'G', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'G'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:208:14 [INFO] [stderr] | [INFO] [stderr] 208 | 8 => return 'H', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'H'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:209:14 [INFO] [stderr] | [INFO] [stderr] 209 | 9 => return 'I', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'I'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:210:15 [INFO] [stderr] | [INFO] [stderr] 210 | 10 => return 'J', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'J'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:211:15 [INFO] [stderr] | [INFO] [stderr] 211 | 11 => return 'W', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'W'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:212:14 [INFO] [stderr] | [INFO] [stderr] 212 | _ => return 'Z' [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'Z'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:218:20 [INFO] [stderr] | [INFO] [stderr] 218 | 'A' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:219:20 [INFO] [stderr] | [INFO] [stderr] 219 | 'B' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:220:20 [INFO] [stderr] | [INFO] [stderr] 220 | 'C' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:221:20 [INFO] [stderr] | [INFO] [stderr] 221 | 'D' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:222:20 [INFO] [stderr] | [INFO] [stderr] 222 | 'E' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:223:20 [INFO] [stderr] | [INFO] [stderr] 223 | 'F' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:224:20 [INFO] [stderr] | [INFO] [stderr] 224 | 'G' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:225:20 [INFO] [stderr] | [INFO] [stderr] 225 | 'H' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:226:20 [INFO] [stderr] | [INFO] [stderr] 226 | 'I' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:227:20 [INFO] [stderr] | [INFO] [stderr] 227 | 'J' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | return false}, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:234:20 [INFO] [stderr] | [INFO] [stderr] 234 | 'T' => return 0, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:235:20 [INFO] [stderr] | [INFO] [stderr] 235 | 'A' => return 1, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:236:20 [INFO] [stderr] | [INFO] [stderr] 236 | 'B' => return 2, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:237:20 [INFO] [stderr] | [INFO] [stderr] 237 | 'C' => return 3, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:238:20 [INFO] [stderr] | [INFO] [stderr] 238 | 'D' => return 4, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:239:20 [INFO] [stderr] | [INFO] [stderr] 239 | 'E' => return 5, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:240:20 [INFO] [stderr] | [INFO] [stderr] 240 | 'F' => return 6, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:241:20 [INFO] [stderr] | [INFO] [stderr] 241 | 'G' => return 7, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:242:20 [INFO] [stderr] | [INFO] [stderr] 242 | 'H' => return 8, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:243:20 [INFO] [stderr] | [INFO] [stderr] 243 | 'I' => return 9, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:244:20 [INFO] [stderr] | [INFO] [stderr] 244 | 'J' => return 10, [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:245:20 [INFO] [stderr] | [INFO] [stderr] 245 | 'W' => return 11, [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `11` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:246:18 [INFO] [stderr] | [INFO] [stderr] 246 | _ => return 20 [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `20` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:279:5 [INFO] [stderr] | [INFO] [stderr] 279 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tests.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | return player; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tests.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return Ship{ shiptype : "Carrier".to_string(), cordinates: [a,b,c,d,e], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ship{ shiptype : "Carrier".to_string(), cordinates: [a,b,c,d,e], status : false, index : 0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tests.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | return Ship{ shiptype : "Battleship".to_string(), cordinates: [a,b,c,d, Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ship{ shiptype : "Battleship".to_string(), cordinates: [a,b,c,d, Default::default()], status : false, index : 0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tests.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | return Ship{ shiptype : "Cruiser".to_string(), cordinates: [a,b,c,Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ship{ shiptype : "Cruiser".to_string(), cordinates: [a,b,c,Default::default(),Default::default()], status : false, index : 0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tests.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | return Ship{ shiptype : "sub".to_string(), cordinates: [a,b,c,Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ship{ shiptype : "sub".to_string(), cordinates: [a,b,c,Default::default(),Default::default()], status : false, index : 0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tests.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | return Ship{ shiptype : "sub".to_string(), cordinates: [a,b,Default::default(),Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ship{ shiptype : "sub".to_string(), cordinates: [a,b,Default::default(),Default::default(),Default::default()], status : false, index : 0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/player.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/player.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/player.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return self [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/player.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/player.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | return player; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:157:11 [INFO] [stderr] | [INFO] [stderr] 157 | if(y == 10) [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/ship.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | else{ [INFO] [stderr] | _________________^ [INFO] [stderr] 43 | | if self.cordinates[p].y == test.y && self.cordinates[p].x == test.x{ [INFO] [stderr] 44 | | self.cordinates[p].hit = true; [INFO] [stderr] 45 | | return self; [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 42 | elseif self.cordinates[p].y == test.y && self.cordinates[p].x == test.x{ [INFO] [stderr] 43 | self.cordinates[p].hit = true; [INFO] [stderr] 44 | return self; [INFO] [stderr] 45 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return x; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | return &self.shiptype; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.shiptype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return -1//otherwise there is no ship at these cords and print the defualt [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `-1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:78:26 [INFO] [stderr] | [INFO] [stderr] 78 | "Carrier" => return 'C', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'C'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:79:29 [INFO] [stderr] | [INFO] [stderr] 79 | "Battleship" => return 'B', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'B'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:80:26 [INFO] [stderr] | [INFO] [stderr] 80 | "Cruiser" => return 'R', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'R'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:81:22 [INFO] [stderr] | [INFO] [stderr] 81 | "sub" => return 'S', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'S'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:82:28 [INFO] [stderr] | [INFO] [stderr] 82 | "Destroyer" => return 'D', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'D'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:83:18 [INFO] [stderr] | [INFO] [stderr] 83 | _ => return 'U' [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'U'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:175:16 [INFO] [stderr] | [INFO] [stderr] 175 | 'N' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:176:16 [INFO] [stderr] | [INFO] [stderr] 176 | 'S' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:177:16 [INFO] [stderr] | [INFO] [stderr] 177 | 'E' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:178:16 [INFO] [stderr] | [INFO] [stderr] 178 | 'W' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | return false}, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:185:14 [INFO] [stderr] | [INFO] [stderr] 185 | 1 => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:186:14 [INFO] [stderr] | [INFO] [stderr] 186 | 2 => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:187:14 [INFO] [stderr] | [INFO] [stderr] 187 | 3 => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:188:14 [INFO] [stderr] | [INFO] [stderr] 188 | 4 => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:189:14 [INFO] [stderr] | [INFO] [stderr] 189 | 5 => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:190:14 [INFO] [stderr] | [INFO] [stderr] 190 | 6 => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:191:14 [INFO] [stderr] | [INFO] [stderr] 191 | 7 => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:192:14 [INFO] [stderr] | [INFO] [stderr] 192 | 8 => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:193:14 [INFO] [stderr] | [INFO] [stderr] 193 | 9 => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:194:15 [INFO] [stderr] | [INFO] [stderr] 194 | 10 => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:195:14 [INFO] [stderr] | [INFO] [stderr] 195 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:200:14 [INFO] [stderr] | [INFO] [stderr] 200 | 0 => return 'T', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'T'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:201:14 [INFO] [stderr] | [INFO] [stderr] 201 | 1 => return 'A', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'A'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:202:14 [INFO] [stderr] | [INFO] [stderr] 202 | 2 => return 'B', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'B'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:203:14 [INFO] [stderr] | [INFO] [stderr] 203 | 3 => return 'C', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'C'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:204:14 [INFO] [stderr] | [INFO] [stderr] 204 | 4 => return 'D', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'D'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:205:14 [INFO] [stderr] | [INFO] [stderr] 205 | 5 => return 'E', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'E'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:206:14 [INFO] [stderr] | [INFO] [stderr] 206 | 6 => return 'F', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'F'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:207:14 [INFO] [stderr] | [INFO] [stderr] 207 | 7 => return 'G', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'G'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:208:14 [INFO] [stderr] | [INFO] [stderr] 208 | 8 => return 'H', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'H'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:209:14 [INFO] [stderr] | [INFO] [stderr] 209 | 9 => return 'I', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'I'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:210:15 [INFO] [stderr] | [INFO] [stderr] 210 | 10 => return 'J', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'J'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:211:15 [INFO] [stderr] | [INFO] [stderr] 211 | 11 => return 'W', [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'W'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:212:14 [INFO] [stderr] | [INFO] [stderr] 212 | _ => return 'Z' [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `'Z'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:218:20 [INFO] [stderr] | [INFO] [stderr] 218 | 'A' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:219:20 [INFO] [stderr] | [INFO] [stderr] 219 | 'B' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:220:20 [INFO] [stderr] | [INFO] [stderr] 220 | 'C' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:221:20 [INFO] [stderr] | [INFO] [stderr] 221 | 'D' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:222:20 [INFO] [stderr] | [INFO] [stderr] 222 | 'E' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:223:20 [INFO] [stderr] | [INFO] [stderr] 223 | 'F' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:224:20 [INFO] [stderr] | [INFO] [stderr] 224 | 'G' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:225:20 [INFO] [stderr] | [INFO] [stderr] 225 | 'H' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:226:20 [INFO] [stderr] | [INFO] [stderr] 226 | 'I' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:227:20 [INFO] [stderr] | [INFO] [stderr] 227 | 'J' => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | return false}, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:234:20 [INFO] [stderr] | [INFO] [stderr] 234 | 'T' => return 0, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:235:20 [INFO] [stderr] | [INFO] [stderr] 235 | 'A' => return 1, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:236:20 [INFO] [stderr] | [INFO] [stderr] 236 | 'B' => return 2, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:237:20 [INFO] [stderr] | [INFO] [stderr] 237 | 'C' => return 3, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:238:20 [INFO] [stderr] | [INFO] [stderr] 238 | 'D' => return 4, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:239:20 [INFO] [stderr] | [INFO] [stderr] 239 | 'E' => return 5, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:240:20 [INFO] [stderr] | [INFO] [stderr] 240 | 'F' => return 6, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:241:20 [INFO] [stderr] | [INFO] [stderr] 241 | 'G' => return 7, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:242:20 [INFO] [stderr] | [INFO] [stderr] 242 | 'H' => return 8, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:243:20 [INFO] [stderr] | [INFO] [stderr] 243 | 'I' => return 9, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:244:20 [INFO] [stderr] | [INFO] [stderr] 244 | 'J' => return 10, [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:245:20 [INFO] [stderr] | [INFO] [stderr] 245 | 'W' => return 11, [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `11` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:246:18 [INFO] [stderr] | [INFO] [stderr] 246 | _ => return 20 [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `20` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:279:5 [INFO] [stderr] | [INFO] [stderr] 279 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tests.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | return player; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tests.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return Ship{ shiptype : "Carrier".to_string(), cordinates: [a,b,c,d,e], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ship{ shiptype : "Carrier".to_string(), cordinates: [a,b,c,d,e], status : false, index : 0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tests.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | return Ship{ shiptype : "Battleship".to_string(), cordinates: [a,b,c,d, Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ship{ shiptype : "Battleship".to_string(), cordinates: [a,b,c,d, Default::default()], status : false, index : 0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tests.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | return Ship{ shiptype : "Cruiser".to_string(), cordinates: [a,b,c,Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ship{ shiptype : "Cruiser".to_string(), cordinates: [a,b,c,Default::default(),Default::default()], status : false, index : 0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tests.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | return Ship{ shiptype : "sub".to_string(), cordinates: [a,b,c,Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ship{ shiptype : "sub".to_string(), cordinates: [a,b,c,Default::default(),Default::default()], status : false, index : 0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tests.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | return Ship{ shiptype : "sub".to_string(), cordinates: [a,b,Default::default(),Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ship{ shiptype : "sub".to_string(), cordinates: [a,b,Default::default(),Default::default(),Default::default()], status : false, index : 0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/player.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/player.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/player.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return self [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/player.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/player.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | return player; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:157:11 [INFO] [stderr] | [INFO] [stderr] 157 | if(y == 10) [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `dir_initial` is never read [INFO] [stderr] --> src/ship.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | let mut dir_initial = ' '; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `x_initial` is never read [INFO] [stderr] --> src/ship.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | let mut x_initial = ' '; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `y_initial` is never read [INFO] [stderr] --> src/ship.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | let mut y_initial = 0; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/ship.rs:129:21 [INFO] [stderr] | [INFO] [stderr] 129 | let s = convert_char_to_int(&x_initial); [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/ship.rs:139:21 [INFO] [stderr] | [INFO] [stderr] 139 | let s = convert_char_to_int(&x_initial); [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `dir_initial` is never read [INFO] [stderr] --> src/ship.rs:286:17 [INFO] [stderr] | [INFO] [stderr] 286 | let mut dir_initial = ' '; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `x_initial` is never read [INFO] [stderr] --> src/ship.rs:287:17 [INFO] [stderr] | [INFO] [stderr] 287 | let mut x_initial = ' '; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `y_initial` is never read [INFO] [stderr] --> src/ship.rs:288:17 [INFO] [stderr] | [INFO] [stderr] 288 | let mut y_initial = 0; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/ship.rs:326:21 [INFO] [stderr] | [INFO] [stderr] 326 | let s = convert_char_to_int(&x_initial); [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/ship.rs:335:21 [INFO] [stderr] | [INFO] [stderr] 335 | let s = convert_char_to_int(&x_initial); [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `dir_initial` is never read [INFO] [stderr] --> src/ship.rs:371:17 [INFO] [stderr] | [INFO] [stderr] 371 | let mut dir_initial = ' '; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `x_initial` is never read [INFO] [stderr] --> src/ship.rs:372:17 [INFO] [stderr] | [INFO] [stderr] 372 | let mut x_initial = ' '; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `y_initial` is never read [INFO] [stderr] --> src/ship.rs:373:17 [INFO] [stderr] | [INFO] [stderr] 373 | let mut y_initial = 0; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/ship.rs:411:21 [INFO] [stderr] | [INFO] [stderr] 411 | let s = convert_char_to_int(&x_initial); [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/ship.rs:419:21 [INFO] [stderr] | [INFO] [stderr] 419 | let s = convert_char_to_int(&x_initial); [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `dir_initial` is never read [INFO] [stderr] --> src/ship.rs:452:17 [INFO] [stderr] | [INFO] [stderr] 452 | let mut dir_initial = ' '; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `x_initial` is never read [INFO] [stderr] --> src/ship.rs:453:17 [INFO] [stderr] | [INFO] [stderr] 453 | let mut x_initial = ' '; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `y_initial` is never read [INFO] [stderr] --> src/ship.rs:454:17 [INFO] [stderr] | [INFO] [stderr] 454 | let mut y_initial = 0; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/ship.rs:495:21 [INFO] [stderr] | [INFO] [stderr] 495 | let s = convert_char_to_int(&x_initial); [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `dir_initial` is never read [INFO] [stderr] --> src/ship.rs:534:17 [INFO] [stderr] | [INFO] [stderr] 534 | let mut dir_initial = ' '; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `x_initial` is never read [INFO] [stderr] --> src/ship.rs:535:17 [INFO] [stderr] | [INFO] [stderr] 535 | let mut x_initial = ' '; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `y_initial` is never read [INFO] [stderr] --> src/ship.rs:536:17 [INFO] [stderr] | [INFO] [stderr] 536 | let mut y_initial = 0; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/ship.rs:574:21 [INFO] [stderr] | [INFO] [stderr] 574 | let s = convert_char_to_int(&x_initial); [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `check_if_hit` is never read [INFO] [stderr] --> src/main.rs:168:21 [INFO] [stderr] | [INFO] [stderr] 168 | let mut check_if_hit = 0; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `result_addr` [INFO] [stderr] --> src/main.rs:199:27 [INFO] [stderr] | [INFO] [stderr] 199 | let (mut result_sock, result_addr) = listener.accept().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_result_addr` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | let mut t_ip = ip.trim().to_owned() + ":80"; [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ship.rs:577:21 [INFO] [stderr] | [INFO] [stderr] 577 | let mut Destroyer = Ship{ shiptype : "Destroyer".to_string(), cordinates: [a,b,Default::default(),Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ship.rs:583:21 [INFO] [stderr] | [INFO] [stderr] 583 | let mut Destroyer = Ship{ shiptype : "Destroyer".to_string(), cordinates: [a,b,Default::default(),Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ship.rs:591:21 [INFO] [stderr] | [INFO] [stderr] 591 | let mut Destroyer = Ship{ shiptype : "Destroyer".to_string(), cordinates: [a,b,Default::default(),Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ship.rs:598:21 [INFO] [stderr] | [INFO] [stderr] 598 | let mut Destroyer = Ship{ shiptype : "Destroyer".to_string(), cordinates: [a,b,Default::default(),Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: function is never used: `build_test_player` [INFO] [stderr] --> src/tests.rs:54:1 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn build_test_player() -> Player{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `build_test_carr` [INFO] [stderr] --> src/tests.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn build_test_carr() -> Ship{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `build_test_bs` [INFO] [stderr] --> src/tests.rs:71:1 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn build_test_bs() -> Ship{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `build_test_cruiser` [INFO] [stderr] --> src/tests.rs:78:1 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn build_test_cruiser() -> Ship{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `build_test_sub` [INFO] [stderr] --> src/tests.rs:84:1 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn build_test_sub() -> Ship{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `build_test_dest` [INFO] [stderr] --> src/tests.rs:90:1 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn build_test_dest() -> Ship{//build a test destroyer [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: crate `Battleships_Rust` should have a snake case name such as `battleships_rust` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/ship.rs:39:16 [INFO] [stderr] | [INFO] [stderr] 39 | if self.cordinates[p].hit == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.cordinates[p].hit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/ship.rs:54:16 [INFO] [stderr] | [INFO] [stderr] 54 | if self.cordinates[p].hit == false{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.cordinates[p].hit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ship.rs:173:33 [INFO] [stderr] | [INFO] [stderr] 173 | pub fn check_if_dir_valid(dir : &char) -> bool{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] warning: value assigned to `dir_initial` is never read [INFO] [stderr] --> src/ship.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | let mut dir_initial = ' '; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `x_initial` is never read [INFO] [stderr] --> src/ship.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | let mut x_initial = ' '; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `y_initial` is never read [INFO] [stderr] --> src/ship.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | let mut y_initial = 0; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/ship.rs:129:21 [INFO] [stderr] | [INFO] [stderr] 129 | let s = convert_char_to_int(&x_initial); [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/ship.rs:139:21 [INFO] [stderr] | [INFO] [stderr] 139 | let s = convert_char_to_int(&x_initial); [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `dir_initial` is never read [INFO] [stderr] --> src/ship.rs:286:17 [INFO] [stderr] | [INFO] [stderr] 286 | let mut dir_initial = ' '; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `x_initial` is never read [INFO] [stderr] --> src/ship.rs:287:17 [INFO] [stderr] | [INFO] [stderr] 287 | let mut x_initial = ' '; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `y_initial` is never read [INFO] [stderr] --> src/ship.rs:288:17 [INFO] [stderr] | [INFO] [stderr] 288 | let mut y_initial = 0; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/ship.rs:326:21 [INFO] [stderr] | [INFO] [stderr] 326 | let s = convert_char_to_int(&x_initial); [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/ship.rs:335:21 [INFO] [stderr] | [INFO] [stderr] 335 | let s = convert_char_to_int(&x_initial); [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `dir_initial` is never read [INFO] [stderr] --> src/ship.rs:371:17 [INFO] [stderr] | [INFO] [stderr] 371 | let mut dir_initial = ' '; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `x_initial` is never read [INFO] [stderr] --> src/ship.rs:372:17 [INFO] [stderr] | [INFO] [stderr] 372 | let mut x_initial = ' '; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `y_initial` is never read [INFO] [stderr] --> src/ship.rs:373:17 [INFO] [stderr] | [INFO] [stderr] 373 | let mut y_initial = 0; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/ship.rs:411:21 [INFO] [stderr] | [INFO] [stderr] 411 | let s = convert_char_to_int(&x_initial); [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/ship.rs:419:21 [INFO] [stderr] | [INFO] [stderr] 419 | let s = convert_char_to_int(&x_initial); [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `dir_initial` is never read [INFO] [stderr] --> src/ship.rs:452:17 [INFO] [stderr] | [INFO] [stderr] 452 | let mut dir_initial = ' '; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `x_initial` is never read [INFO] [stderr] --> src/ship.rs:453:17 [INFO] [stderr] | [INFO] [stderr] 453 | let mut x_initial = ' '; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `y_initial` is never read [INFO] [stderr] --> src/ship.rs:454:17 [INFO] [stderr] | [INFO] [stderr] 454 | let mut y_initial = 0; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/ship.rs:495:21 [INFO] [stderr] | [INFO] [stderr] 495 | let s = convert_char_to_int(&x_initial); [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `dir_initial` is never read [INFO] [stderr] --> src/ship.rs:534:17 [INFO] [stderr] | [INFO] [stderr] 534 | let mut dir_initial = ' '; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `x_initial` is never read [INFO] [stderr] --> src/ship.rs:535:17 [INFO] [stderr] | [INFO] [stderr] 535 | let mut x_initial = ' '; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `y_initial` is never read [INFO] [stderr] --> src/ship.rs:536:17 [INFO] [stderr] | [INFO] [stderr] 536 | let mut y_initial = 0; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/ship.rs:574:21 [INFO] [stderr] | [INFO] [stderr] 574 | let s = convert_char_to_int(&x_initial); [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `check_if_hit` is never read [INFO] [stderr] --> src/main.rs:168:21 [INFO] [stderr] | [INFO] [stderr] 168 | let mut check_if_hit = 0; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `result_addr` [INFO] [stderr] --> src/main.rs:199:27 [INFO] [stderr] | [INFO] [stderr] 199 | let (mut result_sock, result_addr) = listener.accept().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_result_addr` instead [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ship.rs:183:32 [INFO] [stderr] | [INFO] [stderr] 183 | pub fn check_if_y_is_valid(x : &usize) -> bool{ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ship.rs:216:32 [INFO] [stderr] | [INFO] [stderr] 216 | pub fn check_if_x_is_valid(x : &char) -> bool{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ship.rs:232:32 [INFO] [stderr] | [INFO] [stderr] 232 | pub fn convert_char_to_int(x : &char) -> usize{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ship.rs:249:25 [INFO] [stderr] | [INFO] [stderr] 249 | pub fn check_setup(dir: &char, x: &char, y: &usize, size: i8) -> bool{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ship.rs:249:35 [INFO] [stderr] | [INFO] [stderr] 249 | pub fn check_setup(dir: &char, x: &char, y: &usize, size: i8) -> bool{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ship.rs:249:45 [INFO] [stderr] | [INFO] [stderr] 249 | pub fn check_setup(dir: &char, x: &char, y: &usize, size: i8) -> bool{ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: variable `Battleship` should have a snake case name such as `battleship` [INFO] [stderr] --> src/ship.rs:331:21 [INFO] [stderr] | [INFO] [stderr] 331 | let Battleship = Ship{ shiptype : "Battleship".to_string(), cordinates: [a,b,c,d,Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `Battleship` should have a snake case name such as `battleship` [INFO] [stderr] --> src/ship.rs:341:21 [INFO] [stderr] | [INFO] [stderr] 341 | let Battleship = Ship{ shiptype : "Battleship".to_string(), cordinates: [a,b,c,d,Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | let mut t_ip = ip.trim().to_owned() + ":80"; [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `Battleship` should have a snake case name such as `battleship` [INFO] [stderr] --> src/ship.rs:351:21 [INFO] [stderr] | [INFO] [stderr] 351 | let Battleship = Ship{ shiptype : "Battleship".to_string(), cordinates: [a,b,c,d,Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `Battleship` should have a snake case name such as `battleship` [INFO] [stderr] --> src/ship.rs:360:21 [INFO] [stderr] | [INFO] [stderr] 360 | let Battleship = Ship{ shiptype : "Battleship".to_string(), cordinates: [a,b,c,d,Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `Cruiser` should have a snake case name such as `cruiser` [INFO] [stderr] --> src/ship.rs:415:21 [INFO] [stderr] | [INFO] [stderr] 415 | let Cruiser = Ship{ shiptype : "Cruiser".to_string(), cordinates: [a,b,c,Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `Cruiser` should have a snake case name such as `cruiser` [INFO] [stderr] --> src/ship.rs:424:21 [INFO] [stderr] | [INFO] [stderr] 424 | let Cruiser = Ship{ shiptype : "Cruiser".to_string(), cordinates: [a,b,c,Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `Cruiser` should have a snake case name such as `cruiser` [INFO] [stderr] --> src/ship.rs:433:21 [INFO] [stderr] | [INFO] [stderr] 433 | let Cruiser = Ship{ shiptype : "Cruiser".to_string(), cordinates: [a,b,c,Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `Cruiser` should have a snake case name such as `cruiser` [INFO] [stderr] --> src/ship.rs:441:21 [INFO] [stderr] | [INFO] [stderr] 441 | let Cruiser = Ship{ shiptype : "Cruiser".to_string(), cordinates: [a,b,c,Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `Destroyer` should have a snake case name such as `destroyer` [INFO] [stderr] --> src/ship.rs:577:21 [INFO] [stderr] | [INFO] [stderr] 577 | let mut Destroyer = Ship{ shiptype : "Destroyer".to_string(), cordinates: [a,b,Default::default(),Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `Destroyer` should have a snake case name such as `destroyer` [INFO] [stderr] --> src/ship.rs:583:21 [INFO] [stderr] | [INFO] [stderr] 583 | let mut Destroyer = Ship{ shiptype : "Destroyer".to_string(), cordinates: [a,b,Default::default(),Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `Destroyer` should have a snake case name such as `destroyer` [INFO] [stderr] --> src/ship.rs:591:21 [INFO] [stderr] | [INFO] [stderr] 591 | let mut Destroyer = Ship{ shiptype : "Destroyer".to_string(), cordinates: [a,b,Default::default(),Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `Destroyer` should have a snake case name such as `destroyer` [INFO] [stderr] --> src/ship.rs:598:21 [INFO] [stderr] | [INFO] [stderr] 598 | let mut Destroyer = Ship{ shiptype : "Destroyer".to_string(), cordinates: [a,b,Default::default(),Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/player.rs:16:12 [INFO] [stderr] | [INFO] [stderr] 16 | if test.check_if_dead() == false{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!test.check_if_dead()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/player.rs:35:12 [INFO] [stderr] | [INFO] [stderr] 35 | if self.alive == true{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.alive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/player.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | self.index = self.index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.index += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ship.rs:577:21 [INFO] [stderr] | [INFO] [stderr] 577 | let mut Destroyer = Ship{ shiptype : "Destroyer".to_string(), cordinates: [a,b,Default::default(),Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ship.rs:583:21 [INFO] [stderr] | [INFO] [stderr] 583 | let mut Destroyer = Ship{ shiptype : "Destroyer".to_string(), cordinates: [a,b,Default::default(),Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:74:33 [INFO] [stderr] | [INFO] [stderr] 74 | println!("{}, {}",x,y_t.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `y_t` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ship.rs:591:21 [INFO] [stderr] | [INFO] [stderr] 591 | let mut Destroyer = Ship{ shiptype : "Destroyer".to_string(), cordinates: [a,b,Default::default(),Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:77:16 [INFO] [stderr] | [INFO] [stderr] 77 | if checkstat == false{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!checkstat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ship.rs:598:21 [INFO] [stderr] | [INFO] [stderr] 598 | let mut Destroyer = Ship{ shiptype : "Destroyer".to_string(), cordinates: [a,b,Default::default(),Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | if test == true{ [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `test` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | if test == true{ [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `test` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | if test == true{ [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `test` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | if test == true{ [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `test` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | if test == true{ [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `test` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:173:24 [INFO] [stderr] | [INFO] [stderr] 173 | if player.myships[ships].cordinates[check_if_hit as usize].hit == true{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `player.myships[ships].cordinates[check_if_hit as usize].hit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:185:16 [INFO] [stderr] | [INFO] [stderr] 185 | if check_ships == false{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!check_ships` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: crate `Battleships_Rust` should have a snake case name such as `battleships_rust` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/ship.rs:39:16 [INFO] [stderr] | [INFO] [stderr] 39 | if self.cordinates[p].hit == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.cordinates[p].hit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/ship.rs:54:16 [INFO] [stderr] | [INFO] [stderr] 54 | if self.cordinates[p].hit == false{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.cordinates[p].hit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:205:29 [INFO] [stderr] | [INFO] [stderr] 205 | println!("{}, {}",x,y_t.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `y_t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:208:12 [INFO] [stderr] | [INFO] [stderr] 208 | if checkstat == false{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!checkstat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ship.rs:173:33 [INFO] [stderr] | [INFO] [stderr] 173 | pub fn check_if_dir_valid(dir : &char) -> bool{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ship.rs:183:32 [INFO] [stderr] | [INFO] [stderr] 183 | pub fn check_if_y_is_valid(x : &usize) -> bool{ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ship.rs:216:32 [INFO] [stderr] | [INFO] [stderr] 216 | pub fn check_if_x_is_valid(x : &char) -> bool{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ship.rs:232:32 [INFO] [stderr] | [INFO] [stderr] 232 | pub fn convert_char_to_int(x : &char) -> usize{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ship.rs:249:25 [INFO] [stderr] | [INFO] [stderr] 249 | pub fn check_setup(dir: &char, x: &char, y: &usize, size: i8) -> bool{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ship.rs:249:35 [INFO] [stderr] | [INFO] [stderr] 249 | pub fn check_setup(dir: &char, x: &char, y: &usize, size: i8) -> bool{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ship.rs:249:45 [INFO] [stderr] | [INFO] [stderr] 249 | pub fn check_setup(dir: &char, x: &char, y: &usize, size: i8) -> bool{ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: variable `Battleship` should have a snake case name such as `battleship` [INFO] [stderr] --> src/ship.rs:331:21 [INFO] [stderr] | [INFO] [stderr] 331 | let Battleship = Ship{ shiptype : "Battleship".to_string(), cordinates: [a,b,c,d,Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `Battleship` should have a snake case name such as `battleship` [INFO] [stderr] --> src/ship.rs:341:21 [INFO] [stderr] | [INFO] [stderr] 341 | let Battleship = Ship{ shiptype : "Battleship".to_string(), cordinates: [a,b,c,d,Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `Battleship` should have a snake case name such as `battleship` [INFO] [stderr] --> src/ship.rs:351:21 [INFO] [stderr] | [INFO] [stderr] 351 | let Battleship = Ship{ shiptype : "Battleship".to_string(), cordinates: [a,b,c,d,Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `Battleship` should have a snake case name such as `battleship` [INFO] [stderr] --> src/ship.rs:360:21 [INFO] [stderr] | [INFO] [stderr] 360 | let Battleship = Ship{ shiptype : "Battleship".to_string(), cordinates: [a,b,c,d,Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `Cruiser` should have a snake case name such as `cruiser` [INFO] [stderr] --> src/ship.rs:415:21 [INFO] [stderr] | [INFO] [stderr] 415 | let Cruiser = Ship{ shiptype : "Cruiser".to_string(), cordinates: [a,b,c,Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `Cruiser` should have a snake case name such as `cruiser` [INFO] [stderr] --> src/ship.rs:424:21 [INFO] [stderr] | [INFO] [stderr] 424 | let Cruiser = Ship{ shiptype : "Cruiser".to_string(), cordinates: [a,b,c,Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `Cruiser` should have a snake case name such as `cruiser` [INFO] [stderr] --> src/ship.rs:433:21 [INFO] [stderr] | [INFO] [stderr] 433 | let Cruiser = Ship{ shiptype : "Cruiser".to_string(), cordinates: [a,b,c,Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `Cruiser` should have a snake case name such as `cruiser` [INFO] [stderr] --> src/ship.rs:441:21 [INFO] [stderr] | [INFO] [stderr] 441 | let Cruiser = Ship{ shiptype : "Cruiser".to_string(), cordinates: [a,b,c,Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `Destroyer` should have a snake case name such as `destroyer` [INFO] [stderr] --> src/ship.rs:577:21 [INFO] [stderr] | [INFO] [stderr] 577 | let mut Destroyer = Ship{ shiptype : "Destroyer".to_string(), cordinates: [a,b,Default::default(),Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `Destroyer` should have a snake case name such as `destroyer` [INFO] [stderr] --> src/ship.rs:583:21 [INFO] [stderr] | [INFO] [stderr] 583 | let mut Destroyer = Ship{ shiptype : "Destroyer".to_string(), cordinates: [a,b,Default::default(),Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `Destroyer` should have a snake case name such as `destroyer` [INFO] [stderr] --> src/ship.rs:591:21 [INFO] [stderr] | [INFO] [stderr] 591 | let mut Destroyer = Ship{ shiptype : "Destroyer".to_string(), cordinates: [a,b,Default::default(),Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `Destroyer` should have a snake case name such as `destroyer` [INFO] [stderr] --> src/ship.rs:598:21 [INFO] [stderr] | [INFO] [stderr] 598 | let mut Destroyer = Ship{ shiptype : "Destroyer".to_string(), cordinates: [a,b,Default::default(),Default::default(),Default::default()], status : false, index : 0}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/player.rs:16:12 [INFO] [stderr] | [INFO] [stderr] 16 | if test.check_if_dead() == false{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!test.check_if_dead()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/player.rs:35:12 [INFO] [stderr] | [INFO] [stderr] 35 | if self.alive == true{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.alive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/player.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | self.index = self.index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.index += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:74:33 [INFO] [stderr] | [INFO] [stderr] 74 | println!("{}, {}",x,y_t.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `y_t` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:77:16 [INFO] [stderr] | [INFO] [stderr] 77 | if checkstat == false{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!checkstat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | if test == true{ [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `test` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | if test == true{ [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `test` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | if test == true{ [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `test` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | if test == true{ [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `test` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | if test == true{ [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `test` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:173:24 [INFO] [stderr] | [INFO] [stderr] 173 | if player.myships[ships].cordinates[check_if_hit as usize].hit == true{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `player.myships[ships].cordinates[check_if_hit as usize].hit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:185:16 [INFO] [stderr] | [INFO] [stderr] 185 | if check_ships == false{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!check_ships` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:205:29 [INFO] [stderr] | [INFO] [stderr] 205 | println!("{}, {}",x,y_t.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `y_t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:208:12 [INFO] [stderr] | [INFO] [stderr] 208 | if checkstat == false{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!checkstat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.80s [INFO] running `"docker" "inspect" "c13c8953d02151e62619054bc4e49ae6e8ea5eb5b0193b66392c53104b173c70"` [INFO] running `"docker" "rm" "-f" "c13c8953d02151e62619054bc4e49ae6e8ea5eb5b0193b66392c53104b173c70"` [INFO] [stdout] c13c8953d02151e62619054bc4e49ae6e8ea5eb5b0193b66392c53104b173c70