[INFO] updating cached repository IsSuEat/gbemu [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/IsSuEat/gbemu [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/IsSuEat/gbemu" "work/ex/clippy-test-run/sources/stable/gh/IsSuEat/gbemu"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/IsSuEat/gbemu'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/IsSuEat/gbemu" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/IsSuEat/gbemu"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/IsSuEat/gbemu'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c2befe9e2772a6d14d809225895e9b959500076d [INFO] sha for GitHub repo IsSuEat/gbemu: c2befe9e2772a6d14d809225895e9b959500076d [INFO] validating manifest of IsSuEat/gbemu on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of IsSuEat/gbemu on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing IsSuEat/gbemu [INFO] finished frobbing IsSuEat/gbemu [INFO] frobbed toml for IsSuEat/gbemu written to work/ex/clippy-test-run/sources/stable/gh/IsSuEat/gbemu/Cargo.toml [INFO] started frobbing IsSuEat/gbemu [INFO] finished frobbing IsSuEat/gbemu [INFO] frobbed toml for IsSuEat/gbemu written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/IsSuEat/gbemu/Cargo.toml [INFO] crate IsSuEat/gbemu has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting IsSuEat/gbemu against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/IsSuEat/gbemu:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2b9584d888ffd4c5b4f403560e43a913a3f94527f59c974ab635978d0d8fd46c [INFO] running `"docker" "start" "-a" "2b9584d888ffd4c5b4f403560e43a913a3f94527f59c974ab635978d0d8fd46c"` [INFO] [stderr] Checking gbemu v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `Instruction` [INFO] [stderr] --> src/cpu/mod.rs:5:28 [INFO] [stderr] | [INFO] [stderr] 5 | use cpu::opcodes::{OpCode, Instruction}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/cpu/mod.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | opcode [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/cpu/mod.rs:66:22 [INFO] [stderr] | [INFO] [stderr] 66 | let opcode = OpCode::from(value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Instruction` [INFO] [stderr] --> src/cpu/mod.rs:5:28 [INFO] [stderr] | [INFO] [stderr] 5 | use cpu::opcodes::{OpCode, Instruction}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/cpu/mod.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | opcode [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/cpu/mod.rs:66:22 [INFO] [stderr] | [INFO] [stderr] 66 | let opcode = OpCode::from(value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `address` [INFO] [stderr] --> src/cpu/mmu.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn read(address: u16) -> u8 { [INFO] [stderr] | ^^^^^^^ help: consider using `_address` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `opcode` [INFO] [stderr] --> src/cpu/mod.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | let opcode = self.fetch_opcode(); [INFO] [stderr] | ^^^^^^ help: consider using `_opcode` instead [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `CARTRIDGE_ROM_SIZE` [INFO] [stderr] --> src/cartridge.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const CARTRIDGE_ROM_SIZE: usize = 0x0148; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `CARTRIDGE_RAM_SIZE` [INFO] [stderr] --> src/cartridge.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const CARTRIDGE_RAM_SIZE: usize = 0x0149; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `cpu` [INFO] [stderr] --> src/console.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | cpu: Cpu, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `opcode` [INFO] [stderr] --> src/cpu/opcodes.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | opcode: OpCode, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `CLOCKCYCLES` [INFO] [stderr] --> src/cpu/mod.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const CLOCKCYCLES: f32 = 4.19; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MACHINECYCLES` [INFO] [stderr] --> src/cpu/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const MACHINECYCLES: f32 = 1.05; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `a` [INFO] [stderr] --> src/cpu/mod.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | a: u8, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `b` [INFO] [stderr] --> src/cpu/mod.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | b: u8, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `c` [INFO] [stderr] --> src/cpu/mod.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | c: u8, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `d` [INFO] [stderr] --> src/cpu/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | d: u8, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `e` [INFO] [stderr] --> src/cpu/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | e: u8, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `h` [INFO] [stderr] --> src/cpu/mod.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | h: u8, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `l` [INFO] [stderr] --> src/cpu/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | l: u8, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `stack_pointer` [INFO] [stderr] --> src/cpu/mod.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | stack_pointer: u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `program_counter` [INFO] [stderr] --> src/cpu/mod.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | program_counter: u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `work_ram` [INFO] [stderr] --> src/cpu/mod.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | work_ram: [u8; 8 * 1024], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `registers` [INFO] [stderr] --> src/cpu/mod.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | registers: Registers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `mmu` [INFO] [stderr] --> src/cpu/mod.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | mmu: Mmu, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `cycle` [INFO] [stderr] --> src/cpu/mod.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | fn cycle(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `fetch_opcode` [INFO] [stderr] --> src/cpu/mod.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | fn fetch_opcode(&self) -> OpCode { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/cartridge.rs:34:22 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn new(path: &String) -> Cartridge { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/console.rs:13:16 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn new(self) -> Console { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: unused variable: `address` [INFO] [stderr] --> src/cpu/mmu.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn read(address: u16) -> u8 { [INFO] [stderr] | ^^^^^^^ help: consider using `_address` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `opcode` [INFO] [stderr] --> src/cpu/mod.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | let opcode = self.fetch_opcode(); [INFO] [stderr] | ^^^^^^ help: consider using `_opcode` instead [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cpu::mmu::Mmu` [INFO] [stderr] --> src/cpu/mmu.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Mmu { [INFO] [stderr] 11 | | Mmu { [INFO] [stderr] 12 | | cartridge: None, [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `CARTRIDGE_ROM_SIZE` [INFO] [stderr] --> src/cartridge.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const CARTRIDGE_ROM_SIZE: usize = 0x0148; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `CARTRIDGE_RAM_SIZE` [INFO] [stderr] --> src/cartridge.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const CARTRIDGE_RAM_SIZE: usize = 0x0149; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `cart_type` [INFO] [stderr] --> src/cartridge.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | cart_type: CartridgeType, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `cpu` [INFO] [stderr] --> src/console.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | cpu: Cpu, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `opcode` [INFO] [stderr] --> src/cpu/opcodes.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | opcode: OpCode, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `CLOCKCYCLES` [INFO] [stderr] --> src/cpu/mod.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const CLOCKCYCLES: f32 = 4.19; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MACHINECYCLES` [INFO] [stderr] --> src/cpu/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const MACHINECYCLES: f32 = 1.05; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `a` [INFO] [stderr] --> src/cpu/mod.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | a: u8, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `b` [INFO] [stderr] --> src/cpu/mod.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | b: u8, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `c` [INFO] [stderr] --> src/cpu/mod.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | c: u8, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `d` [INFO] [stderr] --> src/cpu/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | d: u8, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `e` [INFO] [stderr] --> src/cpu/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | e: u8, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `h` [INFO] [stderr] --> src/cpu/mod.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | h: u8, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `l` [INFO] [stderr] --> src/cpu/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | l: u8, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `stack_pointer` [INFO] [stderr] --> src/cpu/mod.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | stack_pointer: u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `program_counter` [INFO] [stderr] --> src/cpu/mod.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | program_counter: u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `work_ram` [INFO] [stderr] --> src/cpu/mod.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | work_ram: [u8; 8 * 1024], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `registers` [INFO] [stderr] --> src/cpu/mod.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | registers: Registers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `mmu` [INFO] [stderr] --> src/cpu/mod.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | mmu: Mmu, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `cycle` [INFO] [stderr] --> src/cpu/mod.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | fn cycle(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `fetch_opcode` [INFO] [stderr] --> src/cpu/mod.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | fn fetch_opcode(&self) -> OpCode { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/cartridge.rs:34:22 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn new(path: &String) -> Cartridge { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cpu::Registers` [INFO] [stderr] --> src/cpu/mod.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new() -> Registers { [INFO] [stderr] 25 | | Registers { [INFO] [stderr] 26 | | a: 0, [INFO] [stderr] 27 | | b: 0, [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/console.rs:13:16 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn new(self) -> Console { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cpu::mmu::Mmu` [INFO] [stderr] --> src/cpu/mmu.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Mmu { [INFO] [stderr] 11 | | Mmu { [INFO] [stderr] 12 | | cartridge: None, [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cpu::Registers` [INFO] [stderr] --> src/cpu/mod.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new() -> Registers { [INFO] [stderr] 25 | | Registers { [INFO] [stderr] 26 | | a: 0, [INFO] [stderr] 27 | | b: 0, [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `gbemu::cartridge::Cartridge` [INFO] [stderr] --> src/bin/gbemu.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use gbemu::cartridge::Cartridge; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `gbemu::cartridge::Cartridge` [INFO] [stderr] --> src/bin/gbemu.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use gbemu::cartridge::Cartridge; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.16s [INFO] running `"docker" "inspect" "2b9584d888ffd4c5b4f403560e43a913a3f94527f59c974ab635978d0d8fd46c"` [INFO] running `"docker" "rm" "-f" "2b9584d888ffd4c5b4f403560e43a913a3f94527f59c974ab635978d0d8fd46c"` [INFO] [stdout] 2b9584d888ffd4c5b4f403560e43a913a3f94527f59c974ab635978d0d8fd46c