[INFO] updating cached repository IQ-Inc/iarmap [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/IQ-Inc/iarmap [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/IQ-Inc/iarmap" "work/ex/clippy-test-run/sources/stable/gh/IQ-Inc/iarmap"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/IQ-Inc/iarmap'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/IQ-Inc/iarmap" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/IQ-Inc/iarmap"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/IQ-Inc/iarmap'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0fe6f2bdfadf142e86c48cc7c7e9510d3128871a [INFO] sha for GitHub repo IQ-Inc/iarmap: 0fe6f2bdfadf142e86c48cc7c7e9510d3128871a [INFO] validating manifest of IQ-Inc/iarmap on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of IQ-Inc/iarmap on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing IQ-Inc/iarmap [INFO] finished frobbing IQ-Inc/iarmap [INFO] frobbed toml for IQ-Inc/iarmap written to work/ex/clippy-test-run/sources/stable/gh/IQ-Inc/iarmap/Cargo.toml [INFO] started frobbing IQ-Inc/iarmap [INFO] finished frobbing IQ-Inc/iarmap [INFO] frobbed toml for IQ-Inc/iarmap written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/IQ-Inc/iarmap/Cargo.toml [INFO] crate IQ-Inc/iarmap has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting IQ-Inc/iarmap against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/IQ-Inc/iarmap:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0e08e038bd74152d1c70d8c09d7735d16352527718849a7efb70b8d9211ac42f [INFO] running `"docker" "start" "-a" "0e08e038bd74152d1c70d8c09d7735d16352527718849a7efb70b8d9211ac42f"` [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking iarmap v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | return Err("Failed to parse"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Failed to parse")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | return Err("Failed to parse"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Failed to parse")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/summary/mod.rs:36:36 [INFO] [stderr] | [INFO] [stderr] 36 | named!(stars, take_while!(|c| c == '*' as u8)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'*' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/summary/mod.rs:61:31 [INFO] [stderr] | [INFO] [stderr] 61 | take_while!(|x| (x == ' ' as u8) || (x == '-' as u8)) >> (nbytes) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/summary/mod.rs:61:51 [INFO] [stderr] | [INFO] [stderr] 61 | take_while!(|x| (x == ' ' as u8) || (x == '-' as u8)) >> (nbytes) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'-' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:57:12 [INFO] [stderr] | [INFO] [stderr] 57 | if let Err(_) = reader.read_to_end(&mut buffer) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 58 | | return Err("Failed to read"); [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____- help: try this: `if reader.read_to_end(&mut buffer).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> bin/analytics.rs:71:34 [INFO] [stderr] | [INFO] [stderr] 71 | fn show_module_differences(left: &Vec, right: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ObjModuleTable]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> bin/analytics.rs:71:63 [INFO] [stderr] | [INFO] [stderr] 71 | fn show_module_differences(left: &Vec, right: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ObjModuleTable]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/summary/module.rs:262:18 [INFO] [stderr] | [INFO] [stderr] 262 | let bs = " 123 4 56 ".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b" 123 4 56 "` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/summary/module.rs:268:18 [INFO] [stderr] | [INFO] [stderr] 268 | let bs = " MVC_State_Observer_Interface.o ".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b" MVC_State_Observer_Interface.o "` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/summary/module.rs:276:18 [INFO] [stderr] | [INFO] [stderr] 276 | let bs = " 1 360".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b" 1 360"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> bin/analytics.rs:71:34 [INFO] [stderr] | [INFO] [stderr] 71 | fn show_module_differences(left: &Vec, right: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ObjModuleTable]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> bin/analytics.rs:71:63 [INFO] [stderr] | [INFO] [stderr] 71 | fn show_module_differences(left: &Vec, right: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ObjModuleTable]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> bin/main.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / if let &Err(ref msg) = &args { [INFO] [stderr] 35 | | println!("Error: {}", msg); [INFO] [stderr] 36 | | std::process::exit(1); [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 34 | if let Err(ref msg) = args { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> bin/main.rs:52:8 [INFO] [stderr] | [INFO] [stderr] 52 | if left.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `left.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> bin/main.rs:55:15 [INFO] [stderr] | [INFO] [stderr] 55 | } else if right.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `right.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> bin/main.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / if let &Err(ref msg) = &args { [INFO] [stderr] 35 | | println!("Error: {}", msg); [INFO] [stderr] 36 | | std::process::exit(1); [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 34 | if let Err(ref msg) = args { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> bin/main.rs:52:8 [INFO] [stderr] | [INFO] [stderr] 52 | if left.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `left.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> bin/main.rs:55:15 [INFO] [stderr] | [INFO] [stderr] 55 | } else if right.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `right.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/summary/mod.rs:36:36 [INFO] [stderr] | [INFO] [stderr] 36 | named!(stars, take_while!(|c| c == '*' as u8)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'*' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/summary/mod.rs:61:31 [INFO] [stderr] | [INFO] [stderr] 61 | take_while!(|x| (x == ' ' as u8) || (x == '-' as u8)) >> (nbytes) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/summary/mod.rs:61:51 [INFO] [stderr] | [INFO] [stderr] 61 | take_while!(|x| (x == ' ' as u8) || (x == '-' as u8)) >> (nbytes) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'-' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/summary/mod.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | let h = "******************************************************************************* [INFO] [stderr] | _________________^ [INFO] [stderr] 117 | | *** MODULE SUMMARY [INFO] [stderr] 118 | | ***" [INFO] [stderr] 119 | | .as_bytes(); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 116 | let h = b"******************************************************************************* [INFO] [stderr] 117 | *** MODULE SUMMARY [INFO] [stderr] 118 | ***"; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/summary/mod.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | let h = " Module ro code ro data rw data [INFO] [stderr] | _________________^ [INFO] [stderr] 127 | | ------ ------- ------- -------" [INFO] [stderr] 128 | | .as_bytes(); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 126 | let h = b" Module ro code ro data rw data [INFO] [stderr] 127 | ------ ------- ------- -------"; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/summary/mod.rs:240:9 [INFO] [stderr] | [INFO] [stderr] 240 | / if let &Done(remaining, _) = &result { [INFO] [stderr] 241 | | println!("{}", str::from_utf8(remaining).unwrap()); [INFO] [stderr] 242 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 240 | if let Done(remaining, _) = result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/summary/mod.rs:250:21 [INFO] [stderr] | [INFO] [stderr] 250 | let input = " [INFO] [stderr] | _____________________^ [INFO] [stderr] 251 | | Here's some other content we don't care about... [INFO] [stderr] 252 | | There's a lot of other content we don't care about, [INFO] [stderr] 253 | | but we just ramble here to simulate that 'other content.' [INFO] [stderr] ... | [INFO] [stderr] 257 | | ***" [INFO] [stderr] 258 | | .as_bytes(); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 250 | let input = b" [INFO] [stderr] 251 | Here's some other content we don't care about... [INFO] [stderr] 252 | There's a lot of other content we don't care about, [INFO] [stderr] 253 | but we just ramble here to simulate that 'other content.' [INFO] [stderr] 254 | [INFO] [stderr] 255 | ******************************************************************************* [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/summary/mod.rs:267:21 [INFO] [stderr] | [INFO] [stderr] 267 | let input = "FileSys.a: [3] [INFO] [stderr] | _____________________^ [INFO] [stderr] 268 | | FAT_CheckDisk.o 2 924 48 16 [INFO] [stderr] 269 | | FAT_Dir.o 536 24 [INFO] [stderr] 270 | | -------------------------------------------------------- [INFO] [stderr] ... | [INFO] [stderr] 286 | | .iar.dynexit$$Limit 0x200044e0 -- Gb - Linker created -" [INFO] [stderr] 287 | | .as_bytes(); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 267 | let input = b"FileSys.a: [3] [INFO] [stderr] 268 | FAT_CheckDisk.o 2 924 48 16 [INFO] [stderr] 269 | FAT_Dir.o 536 24 [INFO] [stderr] 270 | -------------------------------------------------------- [INFO] [stderr] 271 | Total: 68 [INFO] [stderr] 272 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/summary/mod.rs:298:20 [INFO] [stderr] | [INFO] [stderr] 298 | let rest = "******************************************************************************* [INFO] [stderr] | ____________________^ [INFO] [stderr] 299 | | *** ENTRY LIST [INFO] [stderr] 300 | | *** [INFO] [stderr] 301 | | [INFO] [stderr] ... | [INFO] [stderr] 305 | | .iar.dynexit$$Limit 0x200044e0 -- Gb - Linker created -" [INFO] [stderr] 306 | | .as_bytes(); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 298 | let rest = b"******************************************************************************* [INFO] [stderr] 299 | *** ENTRY LIST [INFO] [stderr] 300 | *** [INFO] [stderr] 301 | [INFO] [stderr] 302 | Entry Address Size Type Object [INFO] [stderr] 303 | ----- ------- ---- ---- ------ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:57:12 [INFO] [stderr] | [INFO] [stderr] 57 | if let Err(_) = reader.read_to_end(&mut buffer) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 58 | | return Err("Failed to read"); [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____- help: try this: `if reader.read_to_end(&mut buffer).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.45s [INFO] running `"docker" "inspect" "0e08e038bd74152d1c70d8c09d7735d16352527718849a7efb70b8d9211ac42f"` [INFO] running `"docker" "rm" "-f" "0e08e038bd74152d1c70d8c09d7735d16352527718849a7efb70b8d9211ac42f"` [INFO] [stdout] 0e08e038bd74152d1c70d8c09d7735d16352527718849a7efb70b8d9211ac42f