[INFO] updating cached repository IGI-111/xit [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/IGI-111/xit [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/IGI-111/xit" "work/ex/clippy-test-run/sources/stable/gh/IGI-111/xit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/IGI-111/xit'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/IGI-111/xit" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/IGI-111/xit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/IGI-111/xit'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4fe077f01c63f192246a4a9364ee165c572c4edd [INFO] sha for GitHub repo IGI-111/xit: 4fe077f01c63f192246a4a9364ee165c572c4edd [INFO] validating manifest of IGI-111/xit on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of IGI-111/xit on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing IGI-111/xit [INFO] finished frobbing IGI-111/xit [INFO] frobbed toml for IGI-111/xit written to work/ex/clippy-test-run/sources/stable/gh/IGI-111/xit/Cargo.toml [INFO] started frobbing IGI-111/xit [INFO] finished frobbing IGI-111/xit [INFO] frobbed toml for IGI-111/xit written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/IGI-111/xit/Cargo.toml [INFO] crate IGI-111/xit has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting IGI-111/xit against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/IGI-111/xit:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9fa6556e8d77d605469b2e86706f32a5aef604631d9a314c451689f870e0ad82 [INFO] running `"docker" "start" "-a" "9fa6556e8d77d605469b2e86706f32a5aef604631d9a314c451689f870e0ad82"` [INFO] [stderr] Checking termion v1.3.0 [INFO] [stderr] Checking serde_json v0.9.10 [INFO] [stderr] Checking xit v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:46:14 [INFO] [stderr] | [INFO] [stderr] 46 | rpc_tx_map: rpc_tx_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rpc_tx_map` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:46:14 [INFO] [stderr] | [INFO] [stderr] 46 | rpc_tx_map: rpc_tx_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rpc_tx_map` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Duration`, `Instant` [INFO] [stderr] --> src/main.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | use std::time::{Instant, Duration}; [INFO] [stderr] | ^^^^^^^ ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `self` [INFO] [stderr] --> src/main.rs:15:23 [INFO] [stderr] | [INFO] [stderr] 15 | use std::sync::mpsc::{self, Receiver}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/main.rs:16:37 [INFO] [stderr] | [INFO] [stderr] 16 | use std::io::{stdin, stdout, Write, Read, BufWriter}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Duration`, `Instant` [INFO] [stderr] --> src/main.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | use std::time::{Instant, Duration}; [INFO] [stderr] | ^^^^^^^ ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `self` [INFO] [stderr] --> src/main.rs:15:23 [INFO] [stderr] | [INFO] [stderr] 15 | use std::sync::mpsc::{self, Receiver}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/main.rs:16:37 [INFO] [stderr] | [INFO] [stderr] 16 | use std::io::{stdin, stdout, Write, Read, BufWriter}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/core.rs:41:35 [INFO] [stderr] | [INFO] [stderr] 41 | writeln!(io::stderr(), "[core] {}", line).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/core.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | self.stdin.write(str_msg.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | let ref view_id = core.new_view(""); [INFO] [stderr] | ----^^^^^^^^^^^--------------------- help: try: `let view_id = &core.new_view("");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `xit`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/core.rs:41:35 [INFO] [stderr] | [INFO] [stderr] 41 | writeln!(io::stderr(), "[core] {}", line).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/core.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | self.stdin.write(str_msg.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | let ref view_id = core.new_view(""); [INFO] [stderr] | ----^^^^^^^^^^^--------------------- help: try: `let view_id = &core.new_view("");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `xit`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9fa6556e8d77d605469b2e86706f32a5aef604631d9a314c451689f870e0ad82"` [INFO] running `"docker" "rm" "-f" "9fa6556e8d77d605469b2e86706f32a5aef604631d9a314c451689f870e0ad82"` [INFO] [stdout] 9fa6556e8d77d605469b2e86706f32a5aef604631d9a314c451689f870e0ad82