[INFO] updating cached repository ICimpoes/rusty-train [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ICimpoes/rusty-train [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ICimpoes/rusty-train" "work/ex/clippy-test-run/sources/stable/gh/ICimpoes/rusty-train"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ICimpoes/rusty-train'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ICimpoes/rusty-train" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ICimpoes/rusty-train"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ICimpoes/rusty-train'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f5849823762ca3e361642003d886bc612bb14d8c [INFO] sha for GitHub repo ICimpoes/rusty-train: f5849823762ca3e361642003d886bc612bb14d8c [INFO] validating manifest of ICimpoes/rusty-train on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ICimpoes/rusty-train on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ICimpoes/rusty-train [INFO] finished frobbing ICimpoes/rusty-train [INFO] frobbed toml for ICimpoes/rusty-train written to work/ex/clippy-test-run/sources/stable/gh/ICimpoes/rusty-train/Cargo.toml [INFO] started frobbing ICimpoes/rusty-train [INFO] finished frobbing ICimpoes/rusty-train [INFO] frobbed toml for ICimpoes/rusty-train written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ICimpoes/rusty-train/Cargo.toml [INFO] crate ICimpoes/rusty-train has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ICimpoes/rusty-train against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ICimpoes/rusty-train:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 804e11a2acc214fc2714872d8d63f17b8aca592edc38164db56a4406e214b5d9 [INFO] running `"docker" "start" "-a" "804e11a2acc214fc2714872d8d63f17b8aca592edc38164db56a4406e214b5d9"` [INFO] [stderr] Checking rusty-train v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: function is never used: `middle_function` [INFO] [stderr] --> src/communicator/lib/mod.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn middle_function() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `middle_secret_function` [INFO] [stderr] --> src/communicator/lib/mod.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | fn middle_secret_function() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `inner_function` [INFO] [stderr] --> src/communicator/lib/mod.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn inner_function() {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `secret_function` [INFO] [stderr] --> src/communicator/lib/mod.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | fn secret_function() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `inner_function` [INFO] [stderr] --> src/communicator/lib/mod.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn inner_function() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `try_me` [INFO] [stderr] --> src/communicator/lib/mod.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | fn try_me() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `prints_and_returns_10` [INFO] [stderr] --> src/communicator/lib/mod.rs:89:1 [INFO] [stderr] | [INFO] [stderr] 89 | fn prints_and_returns_10(a: i32) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `middle_function` [INFO] [stderr] --> src/communicator/lib/mod.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn middle_function() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `middle_secret_function` [INFO] [stderr] --> src/communicator/lib/mod.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | fn middle_secret_function() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `inner_function` [INFO] [stderr] --> src/communicator/lib/mod.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn inner_function() {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `secret_function` [INFO] [stderr] --> src/communicator/lib/mod.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | fn secret_function() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `inner_function` [INFO] [stderr] --> src/communicator/lib/mod.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn inner_function() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `try_me` [INFO] [stderr] --> src/communicator/lib/mod.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | fn try_me() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/chapter3/bin/main.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | some_string [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/chapter3/bin/main.rs:120:23 [INFO] [stderr] | [INFO] [stderr] 120 | let some_string = String::from("hello"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/chapter3/bin/main.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | s [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/chapter3/bin/main.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | let s = String::from("hello"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v` [INFO] [stderr] --> src/errors/bin/main.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | let v = vec![1, 2, 3]; [INFO] [stderr] | ^ help: consider using `_v` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `f` [INFO] [stderr] --> src/errors/bin/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | let f = match f { [INFO] [stderr] | ^ help: consider using `_f` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_username_from_file` [INFO] [stderr] --> src/errors/bin/main.rs:44:1 [INFO] [stderr] | [INFO] [stderr] 44 | fn read_username_from_file() -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_username_from_file2` [INFO] [stderr] --> src/errors/bin/main.rs:60:1 [INFO] [stderr] | [INFO] [stderr] 60 | fn read_username_from_file2() -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/chapter3/bin/main.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | some_string [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/chapter3/bin/main.rs:120:23 [INFO] [stderr] | [INFO] [stderr] 120 | let some_string = String::from("hello"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/chapter3/bin/main.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | s [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/chapter3/bin/main.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | let s = String::from("hello"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: function `openFile` should have a snake case name such as `open_file` [INFO] [stderr] --> src/errors/bin/main.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | / fn openFile() { [INFO] [stderr] 21 | | let f = File::open("hello.txt"); [INFO] [stderr] 22 | | [INFO] [stderr] 23 | | let f = match f { [INFO] [stderr] ... | [INFO] [stderr] 40 | | }; [INFO] [stderr] 41 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let f =` [INFO] [stderr] --> src/errors/bin/main.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / let f = match f { [INFO] [stderr] 24 | | Ok(file) => { [INFO] [stderr] 25 | | println!("Success: {:?}", file.metadata()) [INFO] [stderr] 26 | | } [INFO] [stderr] ... | [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t` [INFO] [stderr] --> src/traits/bin/main.rs:83:24 [INFO] [stderr] | [INFO] [stderr] 83 | fn some_function(t: T, u: U) -> i32 [INFO] [stderr] | ^ help: consider using `_t` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `u` [INFO] [stderr] --> src/traits/bin/main.rs:83:30 [INFO] [stderr] | [INFO] [stderr] 83 | fn some_function(t: T, u: U) -> i32 [INFO] [stderr] | ^ help: consider using `_u` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t` [INFO] [stderr] --> src/traits/bin/main.rs:83:24 [INFO] [stderr] | [INFO] [stderr] 83 | fn some_function(t: T, u: U) -> i32 [INFO] [stderr] | ^ help: consider using `_t` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `u` [INFO] [stderr] --> src/traits/bin/main.rs:83:30 [INFO] [stderr] | [INFO] [stderr] 83 | fn some_function(t: T, u: U) -> i32 [INFO] [stderr] | ^ help: consider using `_u` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ip_type` [INFO] [stderr] --> src/chapter6/bin/main.rs:1:10 [INFO] [stderr] | [INFO] [stderr] 1 | fn route(ip_type: IpAddrKind) { } [INFO] [stderr] | ^^^^^^^ help: consider using `_ip_type` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/chapter6/bin/main.rs:32:35 [INFO] [stderr] | [INFO] [stderr] 32 | let x = some_string.and_then(|x: &str| Some("sf")); [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `six` [INFO] [stderr] --> src/chapter6/bin/main.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | let six = IpAddrKind::V6; [INFO] [stderr] | ^^^ help: consider using `_six` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `home` [INFO] [stderr] --> src/chapter6/bin/main.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | let home = IpAddr::V4(String::from("127.0.0.1")); [INFO] [stderr] | ^^^^ help: consider using `_home` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `loopback` [INFO] [stderr] --> src/chapter6/bin/main.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | let loopback = IpAddr::V6(String::from("::1")); [INFO] [stderr] | ^^^^^^^^ help: consider using `_loopback` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `home` [INFO] [stderr] --> src/chapter6/bin/main.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | let home = IpAddr2::V4(127, 0, 0, 1); [INFO] [stderr] | ^^^^ help: consider using `_home` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `loopback` [INFO] [stderr] --> src/chapter6/bin/main.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let loopback = IpAddr2::V6(String::from("::1")); [INFO] [stderr] | ^^^^^^^^ help: consider using `_loopback` instead [INFO] [stderr] [INFO] [stderr] warning: variable `count` is assigned to, but never used [INFO] [stderr] --> src/chapter6/bin/main.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | let mut count = 0; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_count` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `count` is never read [INFO] [stderr] --> src/chapter6/bin/main.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | count += 1; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Red`, `Yellow` [INFO] [stderr] --> src/chapter7/bin/main.rs:3:34 [INFO] [stderr] | [INFO] [stderr] 3 | use communicator::TrafficLight::{Red, Yellow}; [INFO] [stderr] | ^^^ ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `some_function` [INFO] [stderr] --> src/traits/bin/main.rs:83:1 [INFO] [stderr] | [INFO] [stderr] 83 | / fn some_function(t: T, u: U) -> i32 [INFO] [stderr] 84 | | where T: std::fmt::Display + Clone, [INFO] [stderr] 85 | | U: Clone + std::fmt::Debug { [INFO] [stderr] 86 | | 1 [INFO] [stderr] 87 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Pair` [INFO] [stderr] --> src/traits/bin/main.rs:92:1 [INFO] [stderr] | [INFO] [stderr] 92 | struct Pair { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/traits/bin/main.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | fn new(x: T, y: T) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `cmp_display` [INFO] [stderr] --> src/traits/bin/main.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | fn cmp_display(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `some_function` [INFO] [stderr] --> src/traits/bin/main.rs:83:1 [INFO] [stderr] | [INFO] [stderr] 83 | / fn some_function(t: T, u: U) -> i32 [INFO] [stderr] 84 | | where T: std::fmt::Display + Clone, [INFO] [stderr] 85 | | U: Clone + std::fmt::Debug { [INFO] [stderr] 86 | | 1 [INFO] [stderr] 87 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Pair` [INFO] [stderr] --> src/traits/bin/main.rs:92:1 [INFO] [stderr] | [INFO] [stderr] 92 | struct Pair { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/traits/bin/main.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | fn new(x: T, y: T) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `cmp_display` [INFO] [stderr] --> src/traits/bin/main.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | fn cmp_display(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Quit` [INFO] [stderr] --> src/chapter6/bin/main.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | Quit, [INFO] [stderr] | ^^^^ [INFO] [stderr] warning: unused variable: `black` [INFO] [stderr] --> src/chapter3/bin/main.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | let black = Color(0, 0, 0); [INFO] [stderr] | ^^^^^ help: consider using `_black` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `origin` [INFO] [stderr] --> src/chapter3/bin/main.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | let origin = Point(0, 0, 0); [INFO] [stderr] | ^^^^^^ help: consider using `_origin` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `black` [INFO] [stderr] --> src/chapter3/bin/main.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | let black = Color(0, 0, 0); [INFO] [stderr] | ^^^^^ help: consider using `_black` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `origin` [INFO] [stderr] --> src/chapter3/bin/main.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | let origin = Point(0, 0, 0); [INFO] [stderr] | ^^^^^^ help: consider using `_origin` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `gives_ownership` [INFO] [stderr] --> src/chapter3/bin/main.rs:119:1 [INFO] [stderr] | [INFO] [stderr] 119 | fn gives_ownership() -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `takes_and_gives_back` [INFO] [stderr] --> src/chapter3/bin/main.rs:124:1 [INFO] [stderr] | [INFO] [stderr] 124 | fn takes_and_gives_back(a_string: String) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `no_dangle` [INFO] [stderr] --> src/chapter3/bin/main.rs:149:1 [INFO] [stderr] | [INFO] [stderr] 149 | fn no_dangle() -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `build_user` [INFO] [stderr] --> src/chapter3/bin/main.rs:187:1 [INFO] [stderr] | [INFO] [stderr] 187 | fn build_user(email: String, username: String) -> User { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `red` [INFO] [stderr] --> src/chapter7/bin/main.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | let red = Red; [INFO] [stderr] | ^^^ help: consider using `_red` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `yellow` [INFO] [stderr] --> src/chapter7/bin/main.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | let yellow = Yellow; [INFO] [stderr] | ^^^^^^ help: consider using `_yellow` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `green` [INFO] [stderr] --> src/chapter7/bin/main.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | let green = communicator::TrafficLight::Green; [INFO] [stderr] | ^^^^^ help: consider using `_green` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `green` [INFO] [stderr] --> src/chapter7/bin/main.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | let green = Green; [INFO] [stderr] | ^^^^^ help: consider using `_green` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `gives_ownership` [INFO] [stderr] --> src/chapter3/bin/main.rs:119:1 [INFO] [stderr] | [INFO] [stderr] 119 | fn gives_ownership() -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `takes_and_gives_back` [INFO] [stderr] --> src/chapter3/bin/main.rs:124:1 [INFO] [stderr] | [INFO] [stderr] 124 | fn takes_and_gives_back(a_string: String) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `no_dangle` [INFO] [stderr] --> src/chapter3/bin/main.rs:149:1 [INFO] [stderr] | [INFO] [stderr] 149 | fn no_dangle() -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `build_user` [INFO] [stderr] --> src/chapter3/bin/main.rs:187:1 [INFO] [stderr] | [INFO] [stderr] 187 | fn build_user(email: String, username: String) -> User { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/chapter3/bin/main.rs:134:25 [INFO] [stderr] | [INFO] [stderr] 134 | fn calculate_length2(s: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/chapter3/bin/main.rs:155:18 [INFO] [stderr] | [INFO] [stderr] 155 | fn first_word(s: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/chapter3/bin/main.rs:134:25 [INFO] [stderr] | [INFO] [stderr] 134 | fn calculate_length2(s: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/chapter3/bin/main.rs:155:18 [INFO] [stderr] | [INFO] [stderr] 155 | fn first_word(s: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Move` [INFO] [stderr] --> src/chapter6/bin/main.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | Move { x: i32, y: i32 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ChangeColor` [INFO] [stderr] --> src/chapter6/bin/main.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | ChangeColor(i32, i32, i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Alaska` [INFO] [stderr] --> src/chapter6/bin/main.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | Alaska, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Nickel` [INFO] [stderr] --> src/chapter6/bin/main.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | Nickel, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `black` [INFO] [stderr] --> src/chapter5/bin/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | let black = Color(0, 0, 0); [INFO] [stderr] | ^^^^^ help: consider using `_black` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `origin` [INFO] [stderr] --> src/chapter5/bin/main.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | let origin = Point(0, 0, 0); [INFO] [stderr] | ^^^^^^ help: consider using `_origin` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `build_user` [INFO] [stderr] --> src/chapter5/bin/main.rs:103:1 [INFO] [stderr] | [INFO] [stderr] 103 | fn build_user(email: String, username: String) -> User { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/lifetimes/bin/main.rs:5:13 [INFO] [stderr] | [INFO] [stderr] 5 | let s: &'static str = "asdsa"; [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/lifetimes/bin/main.rs:40:29 [INFO] [stderr] | [INFO] [stderr] 40 | fn longest2<'a>(x: &'a str, y: &str) -> &'a str { [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/lifetimes/bin/main.rs:44:29 [INFO] [stderr] | [INFO] [stderr] 44 | fn longest3<'a>(x: &'a str, y: &str) -> &'a str { [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `longest3` [INFO] [stderr] --> src/lifetimes/bin/main.rs:44:1 [INFO] [stderr] | [INFO] [stderr] 44 | fn longest3<'a>(x: &'a str, y: &str) -> &'a str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `a` [INFO] [stderr] --> src/lifetimes/bin/main.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | a: String, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `level` [INFO] [stderr] --> src/lifetimes/bin/main.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | fn level(&self) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `a` [INFO] [stderr] --> src/lifetimes/bin/main.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | fn a(&self) -> &str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `longest_with_an_announcement` [INFO] [stderr] --> src/lifetimes/bin/main.rs:67:1 [INFO] [stderr] | [INFO] [stderr] 67 | / fn longest_with_an_announcement<'a, T>(x: &'a str, y: &'a str, ann: T) -> &'a str [INFO] [stderr] 68 | | where T: Display [INFO] [stderr] 69 | | { [INFO] [stderr] 70 | | println!("Announcement! {}", ann); [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v` [INFO] [stderr] --> src/errors/bin/main.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | let v = vec![1, 2, 3]; [INFO] [stderr] | ^ help: consider using `_v` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `f` [INFO] [stderr] --> src/errors/bin/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | let f = match f { [INFO] [stderr] | ^ help: consider using `_f` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_username_from_file` [INFO] [stderr] --> src/errors/bin/main.rs:44:1 [INFO] [stderr] | [INFO] [stderr] 44 | fn read_username_from_file() -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_username_from_file2` [INFO] [stderr] --> src/errors/bin/main.rs:60:1 [INFO] [stderr] | [INFO] [stderr] 60 | fn read_username_from_file2() -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function `openFile` should have a snake case name such as `open_file` [INFO] [stderr] --> src/errors/bin/main.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | / fn openFile() { [INFO] [stderr] 21 | | let f = File::open("hello.txt"); [INFO] [stderr] 22 | | [INFO] [stderr] 23 | | let f = match f { [INFO] [stderr] ... | [INFO] [stderr] 40 | | }; [INFO] [stderr] 41 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let f =` [INFO] [stderr] --> src/errors/bin/main.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / let f = match f { [INFO] [stderr] 24 | | Ok(file) => { [INFO] [stderr] 25 | | println!("Success: {:?}", file.metadata()) [INFO] [stderr] 26 | | } [INFO] [stderr] ... | [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/lifetimes/bin/main.rs:5:13 [INFO] [stderr] | [INFO] [stderr] 5 | let s: &'static str = "asdsa"; [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/collections/bin/main.rs:181:14 [INFO] [stderr] | [INFO] [stderr] 181 | t += (*i as f32); [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/lifetimes/bin/main.rs:40:29 [INFO] [stderr] | [INFO] [stderr] 40 | fn longest2<'a>(x: &'a str, y: &str) -> &'a str { [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/lifetimes/bin/main.rs:44:29 [INFO] [stderr] | [INFO] [stderr] 44 | fn longest3<'a>(x: &'a str, y: &str) -> &'a str { [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `longest3` [INFO] [stderr] --> src/lifetimes/bin/main.rs:44:1 [INFO] [stderr] | [INFO] [stderr] 44 | fn longest3<'a>(x: &'a str, y: &str) -> &'a str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `a` [INFO] [stderr] --> src/lifetimes/bin/main.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | a: String, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `level` [INFO] [stderr] --> src/lifetimes/bin/main.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | fn level(&self) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `a` [INFO] [stderr] --> src/lifetimes/bin/main.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | fn a(&self) -> &str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `longest_with_an_announcement` [INFO] [stderr] --> src/lifetimes/bin/main.rs:67:1 [INFO] [stderr] | [INFO] [stderr] 67 | / fn longest_with_an_announcement<'a, T>(x: &'a str, y: &'a str, ann: T) -> &'a str [INFO] [stderr] 68 | | where T: Display [INFO] [stderr] 69 | | { [INFO] [stderr] 70 | | println!("Announcement! {}", ann); [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `black` [INFO] [stderr] --> src/chapter5/bin/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | let black = Color(0, 0, 0); [INFO] [stderr] | ^^^^^ help: consider using `_black` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `origin` [INFO] [stderr] --> src/chapter5/bin/main.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | let origin = Point(0, 0, 0); [INFO] [stderr] | ^^^^^^ help: consider using `_origin` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `build_user` [INFO] [stderr] --> src/chapter5/bin/main.rs:103:1 [INFO] [stderr] | [INFO] [stderr] 103 | fn build_user(email: String, username: String) -> User { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `max_ch` [INFO] [stderr] --> src/generics/bin/main.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | fn max_ch(list: &[char]) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/generics/bin/main.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / let mut m: Option = Some(Ordering::Equal); [INFO] [stderr] 98 | | if &self.x > &other.x { [INFO] [stderr] 99 | | m = Some(Ordering::Greater); [INFO] [stderr] 100 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let m = if &self.x > &other.x { Some(Ordering::Greater) } else { Some(Ordering::Equal) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/generics/bin/main.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | &self.x == &other.x [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 111 | self.x == other.x [INFO] [stderr] | ^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/generics/bin/main.rs:116:29 [INFO] [stderr] | [INFO] [stderr] 116 | fn distance_from_origin(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s1` [INFO] [stderr] --> src/collections/bin/main.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | let s1 = String::from("hello"); [INFO] [stderr] | ^^ help: consider using `_s1` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `scores` [INFO] [stderr] --> src/collections/bin/main.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | let scores: HashMap<_, _> = zipped.collect(); [INFO] [stderr] | ^^^^^^ help: consider using `_scores` instead [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/collections/bin/main.rs:181:14 [INFO] [stderr] | [INFO] [stderr] 181 | t += (*i as f32); [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Red`, `Yellow` [INFO] [stderr] --> src/chapter7/bin/main.rs:3:34 [INFO] [stderr] | [INFO] [stderr] 3 | use communicator::TrafficLight::{Red, Yellow}; [INFO] [stderr] | ^^^ ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `red` [INFO] [stderr] --> src/chapter7/bin/main.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | let red = Red; [INFO] [stderr] | ^^^ help: consider using `_red` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `yellow` [INFO] [stderr] --> src/chapter7/bin/main.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | let yellow = Yellow; [INFO] [stderr] | ^^^^^^ help: consider using `_yellow` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `green` [INFO] [stderr] --> src/chapter7/bin/main.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | let green = communicator::TrafficLight::Green; [INFO] [stderr] | ^^^^^ help: consider using `_green` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `green` [INFO] [stderr] --> src/chapter7/bin/main.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | let green = Green; [INFO] [stderr] | ^^^^^ help: consider using `_green` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/collections/bin/main.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | let mut s = String::new(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `max_ch` [INFO] [stderr] --> src/generics/bin/main.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | fn max_ch(list: &[char]) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/collections/bin/main.rs:178:12 [INFO] [stderr] | [INFO] [stderr] 178 | fn mean(l: &Vec) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/collections/bin/main.rs:205:29 [INFO] [stderr] | [INFO] [stderr] 205 | let v = people.entry(d).or_insert(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/collections/bin/main.rs:209:65 [INFO] [stderr] | [INFO] [stderr] 209 | fn get_and_sort(people: &mut HashMap>, dep: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/generics/bin/main.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / let mut m: Option = Some(Ordering::Equal); [INFO] [stderr] 98 | | if &self.x > &other.x { [INFO] [stderr] 99 | | m = Some(Ordering::Greater); [INFO] [stderr] 100 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let m = if &self.x > &other.x { Some(Ordering::Greater) } else { Some(Ordering::Equal) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/generics/bin/main.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | &self.x == &other.x [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 111 | self.x == other.x [INFO] [stderr] | ^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/generics/bin/main.rs:116:29 [INFO] [stderr] | [INFO] [stderr] 116 | fn distance_from_origin(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s1` [INFO] [stderr] --> src/collections/bin/main.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | let s1 = String::from("hello"); [INFO] [stderr] | ^^ help: consider using `_s1` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `scores` [INFO] [stderr] --> src/collections/bin/main.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | let scores: HashMap<_, _> = zipped.collect(); [INFO] [stderr] | ^^^^^^ help: consider using `_scores` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/collections/bin/main.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | let mut s = String::new(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/collections/bin/main.rs:178:12 [INFO] [stderr] | [INFO] [stderr] 178 | fn mean(l: &Vec) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/collections/bin/main.rs:205:29 [INFO] [stderr] | [INFO] [stderr] 205 | let v = people.entry(d).or_insert(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/collections/bin/main.rs:209:65 [INFO] [stderr] | [INFO] [stderr] 209 | fn get_and_sort(people: &mut HashMap>, dep: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ip_type` [INFO] [stderr] --> src/chapter6/bin/main.rs:1:10 [INFO] [stderr] | [INFO] [stderr] 1 | fn route(ip_type: IpAddrKind) { } [INFO] [stderr] | ^^^^^^^ help: consider using `_ip_type` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/chapter6/bin/main.rs:32:35 [INFO] [stderr] | [INFO] [stderr] 32 | let x = some_string.and_then(|x: &str| Some("sf")); [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `six` [INFO] [stderr] --> src/chapter6/bin/main.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | let six = IpAddrKind::V6; [INFO] [stderr] | ^^^ help: consider using `_six` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `home` [INFO] [stderr] --> src/chapter6/bin/main.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | let home = IpAddr::V4(String::from("127.0.0.1")); [INFO] [stderr] | ^^^^ help: consider using `_home` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `loopback` [INFO] [stderr] --> src/chapter6/bin/main.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | let loopback = IpAddr::V6(String::from("::1")); [INFO] [stderr] | ^^^^^^^^ help: consider using `_loopback` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `home` [INFO] [stderr] --> src/chapter6/bin/main.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | let home = IpAddr2::V4(127, 0, 0, 1); [INFO] [stderr] | ^^^^ help: consider using `_home` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `loopback` [INFO] [stderr] --> src/chapter6/bin/main.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let loopback = IpAddr2::V6(String::from("::1")); [INFO] [stderr] | ^^^^^^^^ help: consider using `_loopback` instead [INFO] [stderr] [INFO] [stderr] warning: variable `count` is assigned to, but never used [INFO] [stderr] --> src/chapter6/bin/main.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | let mut count = 0; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_count` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `count` is never read [INFO] [stderr] --> src/chapter6/bin/main.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | count += 1; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Quit` [INFO] [stderr] --> src/chapter6/bin/main.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | Quit, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Move` [INFO] [stderr] --> src/chapter6/bin/main.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | Move { x: i32, y: i32 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ChangeColor` [INFO] [stderr] --> src/chapter6/bin/main.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | ChangeColor(i32, i32, i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Alaska` [INFO] [stderr] --> src/chapter6/bin/main.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | Alaska, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Nickel` [INFO] [stderr] --> src/chapter6/bin/main.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | Nickel, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.51s [INFO] running `"docker" "inspect" "804e11a2acc214fc2714872d8d63f17b8aca592edc38164db56a4406e214b5d9"` [INFO] running `"docker" "rm" "-f" "804e11a2acc214fc2714872d8d63f17b8aca592edc38164db56a4406e214b5d9"` [INFO] [stdout] 804e11a2acc214fc2714872d8d63f17b8aca592edc38164db56a4406e214b5d9