[INFO] updating cached repository Hrysa/rust-snowflake [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Hrysa/rust-snowflake [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Hrysa/rust-snowflake" "work/ex/clippy-test-run/sources/stable/gh/Hrysa/rust-snowflake"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Hrysa/rust-snowflake'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Hrysa/rust-snowflake" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Hrysa/rust-snowflake"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Hrysa/rust-snowflake'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ad5625be79792f721c90823fb4188129f54c30e5 [INFO] sha for GitHub repo Hrysa/rust-snowflake: ad5625be79792f721c90823fb4188129f54c30e5 [INFO] validating manifest of Hrysa/rust-snowflake on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Hrysa/rust-snowflake on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Hrysa/rust-snowflake [INFO] finished frobbing Hrysa/rust-snowflake [INFO] frobbed toml for Hrysa/rust-snowflake written to work/ex/clippy-test-run/sources/stable/gh/Hrysa/rust-snowflake/Cargo.toml [INFO] started frobbing Hrysa/rust-snowflake [INFO] finished frobbing Hrysa/rust-snowflake [INFO] frobbed toml for Hrysa/rust-snowflake written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Hrysa/rust-snowflake/Cargo.toml [INFO] crate Hrysa/rust-snowflake has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Hrysa/rust-snowflake against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Hrysa/rust-snowflake:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ea5b8a194f061e7da8db0d1657afbe87436992afcb92049f07557fda265f45d4 [INFO] running `"docker" "start" "-a" "ea5b8a194f061e7da8db0d1657afbe87436992afcb92049f07557fda265f45d4"` [INFO] [stderr] Checking rust-snowflake v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:17:37 [INFO] [stderr] | [INFO] [stderr] 17 | const TIMESTAMP_OFFSET_EPOCH: i64 = 1540062491000; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_540_062_491_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:98:20 [INFO] [stderr] | [INFO] [stderr] 98 | let c_id = id << offset - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `id << (offset - 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | d_id >> offset - 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `d_id >> (offset - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:17:37 [INFO] [stderr] | [INFO] [stderr] 17 | const TIMESTAMP_OFFSET_EPOCH: i64 = 1540062491000; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_540_062_491_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:98:20 [INFO] [stderr] | [INFO] [stderr] 98 | let c_id = id << offset - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `id << (offset - 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | d_id >> offset - 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `d_id >> (offset - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:21:45 [INFO] [stderr] | [INFO] [stderr] 21 | let time = (duration.as_secs() * 1000 + duration.subsec_nanos() as u64 / 1_000_000) as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:21:45 [INFO] [stderr] | [INFO] [stderr] 21 | let time = (duration.as_secs() * 1000 + duration.subsec_nanos() as u64 / 1_000_000) as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.61s [INFO] running `"docker" "inspect" "ea5b8a194f061e7da8db0d1657afbe87436992afcb92049f07557fda265f45d4"` [INFO] running `"docker" "rm" "-f" "ea5b8a194f061e7da8db0d1657afbe87436992afcb92049f07557fda265f45d4"` [INFO] [stdout] ea5b8a194f061e7da8db0d1657afbe87436992afcb92049f07557fda265f45d4