[INFO] updating cached repository Hoverbear/fun_with_futures [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Hoverbear/fun_with_futures [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Hoverbear/fun_with_futures" "work/ex/clippy-test-run/sources/stable/gh/Hoverbear/fun_with_futures"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Hoverbear/fun_with_futures'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Hoverbear/fun_with_futures" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Hoverbear/fun_with_futures"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Hoverbear/fun_with_futures'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f38c3217ee90ed003259aa2d331372bf5e80608e [INFO] sha for GitHub repo Hoverbear/fun_with_futures: f38c3217ee90ed003259aa2d331372bf5e80608e [INFO] validating manifest of Hoverbear/fun_with_futures on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Hoverbear/fun_with_futures on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Hoverbear/fun_with_futures [INFO] finished frobbing Hoverbear/fun_with_futures [INFO] frobbed toml for Hoverbear/fun_with_futures written to work/ex/clippy-test-run/sources/stable/gh/Hoverbear/fun_with_futures/Cargo.toml [INFO] started frobbing Hoverbear/fun_with_futures [INFO] finished frobbing Hoverbear/fun_with_futures [INFO] frobbed toml for Hoverbear/fun_with_futures written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Hoverbear/fun_with_futures/Cargo.toml [INFO] crate Hoverbear/fun_with_futures has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Hoverbear/fun_with_futures against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Hoverbear/fun_with_futures:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d6b91252ddedb2a75471d29a93984376b1f740fb1c7133e01bc3242182172810 [INFO] running `"docker" "start" "-a" "d6b91252ddedb2a75471d29a93984376b1f740fb1c7133e01bc3242182172810"` [INFO] [stderr] Checking fun_with_futures v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/11-tokio-full.rs:76:55 [INFO] [stderr] | [INFO] [stderr] 76 | Ok(Some(ExampleRequest::Get { url: url })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/11-tokio-full.rs:79:56 [INFO] [stderr] | [INFO] [stderr] 79 | Ok(Some(ExampleRequest::Post { url: url, content: content })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/11-tokio-full.rs:79:66 [INFO] [stderr] | [INFO] [stderr] 79 | Ok(Some(ExampleRequest::Post { url: url, content: content })) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/10-tokio-codec-http.rs:72:55 [INFO] [stderr] | [INFO] [stderr] 72 | Ok(Some(ExampleRequest::Get { url: url })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/10-tokio-codec-http.rs:75:56 [INFO] [stderr] | [INFO] [stderr] 75 | Ok(Some(ExampleRequest::Post { url: url, content: content })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/10-tokio-codec-http.rs:75:66 [INFO] [stderr] | [INFO] [stderr] 75 | Ok(Some(ExampleRequest::Post { url: url, content: content })) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/10-tokio-codec-http.rs:107:35 [INFO] [stderr] | [INFO] [stderr] 107 | ExampleResponse::Ok { content: content } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/6-tokio-get.rs:10:16 [INFO] [stderr] | [INFO] [stderr] 10 | const DOMAIN: &'static str = "google.com"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/8-tokio-codec-buffer.rs:12:19 [INFO] [stderr] | [INFO] [stderr] 12 | const LISTEN_TO: &'static str = "0.0.0.0:8080"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/7-tokio-server.rs:11:19 [INFO] [stderr] | [INFO] [stderr] 11 | const LISTEN_TO: &'static str = "0.0.0.0:8080"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/10-tokio-codec-http.rs:13:19 [INFO] [stderr] | [INFO] [stderr] 13 | const LISTEN_TO: &'static str = "0.0.0.0:8080"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/11-tokio-full.rs:16:19 [INFO] [stderr] | [INFO] [stderr] 16 | const LISTEN_TO: &'static str = "0.0.0.0:8080"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused variable: `url` [INFO] [stderr] --> examples/10-tokio-codec-http.rs:103:36 [INFO] [stderr] | [INFO] [stderr] 103 | ExampleRequest::Get { url: url } => { [INFO] [stderr] | ^^^ help: consider using `_url` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `url` [INFO] [stderr] --> examples/10-tokio-codec-http.rs:106:37 [INFO] [stderr] | [INFO] [stderr] 106 | ExampleRequest::Post { url: url, content: content } => { [INFO] [stderr] | ^^^ help: consider using `_url` instead [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> examples/11-tokio-full.rs:55:43 [INFO] [stderr] | [INFO] [stderr] 55 | let method = headers.find(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> examples/11-tokio-full.rs:61:40 [INFO] [stderr] | [INFO] [stderr] 61 | let url = headers.find(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the `url:` in this pattern is redundant [INFO] [stderr] --> examples/11-tokio-full.rs:151:35 [INFO] [stderr] | [INFO] [stderr] 151 | ExampleRequest::Get { url: url } => { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_shorthand_field_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: the `url:` in this pattern is redundant [INFO] [stderr] --> examples/11-tokio-full.rs:157:36 [INFO] [stderr] | [INFO] [stderr] 157 | ExampleRequest::Post { url: url, content: content } => { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this [INFO] [stderr] [INFO] [stderr] warning: the `content:` in this pattern is redundant [INFO] [stderr] --> examples/11-tokio-full.rs:157:46 [INFO] [stderr] | [INFO] [stderr] 157 | ExampleRequest::Post { url: url, content: content } => { [INFO] [stderr] | --------^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> examples/10-tokio-codec-http.rs:51:43 [INFO] [stderr] | [INFO] [stderr] 51 | let method = headers.find(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> examples/10-tokio-codec-http.rs:57:40 [INFO] [stderr] | [INFO] [stderr] 57 | let url = headers.find(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the `url:` in this pattern is redundant [INFO] [stderr] --> examples/10-tokio-codec-http.rs:103:31 [INFO] [stderr] | [INFO] [stderr] 103 | ExampleRequest::Get { url: url } => { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_shorthand_field_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: the `url:` in this pattern is redundant [INFO] [stderr] --> examples/10-tokio-codec-http.rs:106:32 [INFO] [stderr] | [INFO] [stderr] 106 | ExampleRequest::Post { url: url, content: content } => { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this [INFO] [stderr] [INFO] [stderr] warning: the `content:` in this pattern is redundant [INFO] [stderr] --> examples/10-tokio-codec-http.rs:106:42 [INFO] [stderr] | [INFO] [stderr] 106 | ExampleRequest::Post { url: url, content: content } => { [INFO] [stderr] | --------^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/9-tokio-codec-lines.rs:13:19 [INFO] [stderr] | [INFO] [stderr] 13 | const LISTEN_TO: &'static str = "0.0.0.0:8080"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> examples/3-stream.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | Err(_) => panic!("Oh no!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.57s [INFO] running `"docker" "inspect" "d6b91252ddedb2a75471d29a93984376b1f740fb1c7133e01bc3242182172810"` [INFO] running `"docker" "rm" "-f" "d6b91252ddedb2a75471d29a93984376b1f740fb1c7133e01bc3242182172810"` [INFO] [stdout] d6b91252ddedb2a75471d29a93984376b1f740fb1c7133e01bc3242182172810