[INFO] updating cached repository Hopson97/Asciimon [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Hopson97/Asciimon [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Hopson97/Asciimon" "work/ex/clippy-test-run/sources/stable/gh/Hopson97/Asciimon"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Hopson97/Asciimon'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Hopson97/Asciimon" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Hopson97/Asciimon"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Hopson97/Asciimon'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 26f7f6b7df563dce9e59c765acf2a3ddff48c6fd [INFO] sha for GitHub repo Hopson97/Asciimon: 26f7f6b7df563dce9e59c765acf2a3ddff48c6fd [INFO] validating manifest of Hopson97/Asciimon on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Hopson97/Asciimon on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Hopson97/Asciimon [INFO] finished frobbing Hopson97/Asciimon [INFO] frobbed toml for Hopson97/Asciimon written to work/ex/clippy-test-run/sources/stable/gh/Hopson97/Asciimon/Cargo.toml [INFO] started frobbing Hopson97/Asciimon [INFO] finished frobbing Hopson97/Asciimon [INFO] frobbed toml for Hopson97/Asciimon written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Hopson97/Asciimon/Cargo.toml [INFO] crate Hopson97/Asciimon has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Hopson97/Asciimon against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Hopson97/Asciimon:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a14f88ba2e0174811691142d24915e77865b8be360ab3c13c80f69058d3c7984 [INFO] running `"docker" "start" "-a" "a14f88ba2e0174811691142d24915e77865b8be360ab3c13c80f69058d3c7984"` [INFO] [stderr] Checking asciimon v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/world/chunk.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | tile_data: tile_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tile_data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/world/chunk.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | tile_data: tile_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tile_data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/game/world/chunk.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `ChunkLoadData` [INFO] [stderr] --> src/game/world/mod.rs:10:26 [INFO] [stderr] | [INFO] [stderr] 10 | use self::chunk_loader::{ChunkLoadData, load_chunk, extract_pos_from_path}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/game/world/chunk.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `ChunkLoadData` [INFO] [stderr] --> src/game/world/mod.rs:10:26 [INFO] [stderr] | [INFO] [stderr] 10 | use self::chunk_loader::{ChunkLoadData, load_chunk, extract_pos_from_path}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Write` [INFO] [stderr] --> src/game/mod.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | use std::io::{stdin, Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Write` [INFO] [stderr] --> src/game/mod.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | use std::io::{stdin, Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `console` [INFO] [stderr] --> src/game/game_state/state_explore.rs:171:49 [INFO] [stderr] | [INFO] [stderr] 171 | fn draw(&mut self, renderer: &mut Renderer, console: &mut Console) { [INFO] [stderr] | ^^^^^^^ help: consider using `_console` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/game/mod.rs:85:51 [INFO] [stderr] | [INFO] [stderr] 85 | Some(UpdateResult::TransitionPush(state)) => {} [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `console` [INFO] [stderr] --> src/game/game_state/state_explore.rs:171:49 [INFO] [stderr] | [INFO] [stderr] 171 | fn draw(&mut self, renderer: &mut Renderer, console: &mut Console) { [INFO] [stderr] | ^^^^^^^ help: consider using `_console` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/game/mod.rs:85:51 [INFO] [stderr] | [INFO] [stderr] 85 | Some(UpdateResult::TransitionPush(state)) => {} [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `size` [INFO] [stderr] --> src/graphics/renderer.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | size: Vector2D, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `size` [INFO] [stderr] --> src/graphics/renderer.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn size(&self) -> Vector2D { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `draw_sprite` [INFO] [stderr] --> src/graphics/renderer.rs:172:5 [INFO] [stderr] | [INFO] [stderr] 172 | pub fn draw_sprite(&self, section: &str, sprite: &Sprite) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Sprite` [INFO] [stderr] --> src/graphics/sprite.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub struct Sprite { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/graphics/sprite.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn new() -> Sprite { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `with_capacity` [INFO] [stderr] --> src/graphics/sprite.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn with_capacity(capacity: usize) -> Sprite { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `square` [INFO] [stderr] --> src/graphics/sprite.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn square(width: i32, height: i32, fill: char) -> Sprite { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `render_data` [INFO] [stderr] --> src/graphics/sprite.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn render_data(&self) -> &Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `UI_BACKGROUND` [INFO] [stderr] --> src/graphics/colour.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / pub const $name: Colour = Colour { [INFO] [stderr] 14 | | r: $r, [INFO] [stderr] 15 | | g: $g, [INFO] [stderr] 16 | | b: $b, [INFO] [stderr] 17 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] ::: src/game/mod.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | define_colour!(UI_BACKGROUND, 50, 50, 50); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ZERO` [INFO] [stderr] --> src/util/vector.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub const ZERO: Vector2D = Vector2D { x: 0, y: 0 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `cast` [INFO] [stderr] --> src/util/vector.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn cast>(self) -> Vector2D { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/graphics/colour.rs:26:29 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn ansi_text_string(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/graphics/colour.rs:30:27 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn ansi_bg_string(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/graphics/colour.rs:35:20 [INFO] [stderr] | [INFO] [stderr] 35 | fn ansi_string(&self, id: u8) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: field is never used: `size` [INFO] [stderr] --> src/graphics/renderer.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | size: Vector2D, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `size` [INFO] [stderr] --> src/graphics/renderer.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn size(&self) -> Vector2D { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `draw_sprite` [INFO] [stderr] --> src/graphics/renderer.rs:172:5 [INFO] [stderr] | [INFO] [stderr] 172 | pub fn draw_sprite(&self, section: &str, sprite: &Sprite) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Sprite` [INFO] [stderr] --> src/graphics/sprite.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub struct Sprite { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/graphics/sprite.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn new() -> Sprite { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `with_capacity` [INFO] [stderr] --> src/graphics/sprite.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn with_capacity(capacity: usize) -> Sprite { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `square` [INFO] [stderr] --> src/graphics/sprite.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn square(width: i32, height: i32, fill: char) -> Sprite { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `render_data` [INFO] [stderr] --> src/graphics/sprite.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn render_data(&self) -> &Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `UI_BACKGROUND` [INFO] [stderr] --> src/graphics/colour.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / pub const $name: Colour = Colour { [INFO] [stderr] 14 | | r: $r, [INFO] [stderr] 15 | | g: $g, [INFO] [stderr] 16 | | b: $b, [INFO] [stderr] 17 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] ::: src/game/mod.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | define_colour!(UI_BACKGROUND, 50, 50, 50); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ZERO` [INFO] [stderr] --> src/util/vector.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub const ZERO: Vector2D = Vector2D { x: 0, y: 0 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `cast` [INFO] [stderr] --> src/util/vector.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn cast>(self) -> Vector2D { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/graphics/colour.rs:26:29 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn ansi_text_string(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/graphics/colour.rs:30:27 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn ansi_bg_string(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/graphics/colour.rs:35:20 [INFO] [stderr] | [INFO] [stderr] 35 | fn ansi_string(&self, id: u8) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/game/world/chunk_loader.rs:92:8 [INFO] [stderr] | [INFO] [stderr] 92 | if !(data.portal_ids.len() == data.portal_positions.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `data.portal_ids.len() != data.portal_positions.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/game/world/chunk_loader.rs:92:8 [INFO] [stderr] | [INFO] [stderr] 92 | if !(data.portal_ids.len() == data.portal_positions.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `data.portal_ids.len() != data.portal_positions.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game/world/chunk_loader.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | / match ch { [INFO] [stderr] 134 | | '1' => { [INFO] [stderr] 135 | | let y = data.tile_data.len() as i32; [INFO] [stderr] 136 | | data.portal_positions.push(Vector2D::new(x as i32, y)) [INFO] [stderr] 137 | | }, [INFO] [stderr] 138 | | _ => {} [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 133 | if let '1' = ch { [INFO] [stderr] 134 | let y = data.tile_data.len() as i32; [INFO] [stderr] 135 | data.portal_positions.push(Vector2D::new(x as i32, y)) [INFO] [stderr] 136 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/game/world/chunk_loader.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | Err(_) => panic!("Map ID must be a integral value!") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game/world/chunk_loader.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | / match ch { [INFO] [stderr] 134 | | '1' => { [INFO] [stderr] 135 | | let y = data.tile_data.len() as i32; [INFO] [stderr] 136 | | data.portal_positions.push(Vector2D::new(x as i32, y)) [INFO] [stderr] 137 | | }, [INFO] [stderr] 138 | | _ => {} [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 133 | if let '1' = ch { [INFO] [stderr] 134 | let y = data.tile_data.len() as i32; [INFO] [stderr] 135 | data.portal_positions.push(Vector2D::new(x as i32, y)) [INFO] [stderr] 136 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/game/world/chunk_loader.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | Err(_) => panic!("Map ID must be a integral value!") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.71s [INFO] running `"docker" "inspect" "a14f88ba2e0174811691142d24915e77865b8be360ab3c13c80f69058d3c7984"` [INFO] running `"docker" "rm" "-f" "a14f88ba2e0174811691142d24915e77865b8be360ab3c13c80f69058d3c7984"` [INFO] [stdout] a14f88ba2e0174811691142d24915e77865b8be360ab3c13c80f69058d3c7984