[INFO] updating cached repository Henning-K/sandbox [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Henning-K/sandbox [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Henning-K/sandbox" "work/ex/clippy-test-run/sources/stable/gh/Henning-K/sandbox"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Henning-K/sandbox'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Henning-K/sandbox" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Henning-K/sandbox"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Henning-K/sandbox'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d52793850a090de1f17fdfe9fda1208e092d6de6 [INFO] sha for GitHub repo Henning-K/sandbox: d52793850a090de1f17fdfe9fda1208e092d6de6 [INFO] validating manifest of Henning-K/sandbox on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Henning-K/sandbox on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Henning-K/sandbox [INFO] finished frobbing Henning-K/sandbox [INFO] frobbed toml for Henning-K/sandbox written to work/ex/clippy-test-run/sources/stable/gh/Henning-K/sandbox/Cargo.toml [INFO] started frobbing Henning-K/sandbox [INFO] finished frobbing Henning-K/sandbox [INFO] frobbed toml for Henning-K/sandbox written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Henning-K/sandbox/Cargo.toml [INFO] crate Henning-K/sandbox has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Henning-K/sandbox against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Henning-K/sandbox:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1f5825fb8f4ef279423018381604dd84c09f4b43fb9210b6f215868de94aa274 [INFO] running `"docker" "start" "-a" "1f5825fb8f4ef279423018381604dd84c09f4b43fb9210b6f215868de94aa274"` [INFO] [stderr] Checking num_cpus v1.0.0 [INFO] [stderr] Checking sandbox v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/base64.rs:7:45 [INFO] [stderr] | [INFO] [stderr] 7 | let mut it = inp.encode_utf16().map(|e| e as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(e)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/bignum.rs:61:30 [INFO] [stderr] | [INFO] [stderr] 61 | result.push(temp % 10u8); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/bignum.rs:62:26 [INFO] [stderr] | [INFO] [stderr] 62 | carry = temp / 10u8; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/thread_testing.rs:60:16 [INFO] [stderr] | [INFO] [stderr] 60 | if let Err(_) = h.join() { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 61 | | return Err("Joining child thread returned an error.".to_string()); [INFO] [stderr] 62 | | } [INFO] [stderr] | |_________- help: try this: `if h.join().is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sandbox`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/base64.rs:7:45 [INFO] [stderr] | [INFO] [stderr] 7 | let mut it = inp.encode_utf16().map(|e| e as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(e)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/bignum.rs:61:30 [INFO] [stderr] | [INFO] [stderr] 61 | result.push(temp % 10u8); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/bignum.rs:62:26 [INFO] [stderr] | [INFO] [stderr] 62 | carry = temp / 10u8; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/bignum.rs:102:42 [INFO] [stderr] | [INFO] [stderr] 102 | let biguint2 = BigUInt::from_buf(&vec![0u8;2]); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&[0u8; 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/bignum.rs:111:42 [INFO] [stderr] | [INFO] [stderr] 111 | let biguint2 = BigUInt::from_buf(&vec![2u8, 1]); // 0+12 [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&[2u8, 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/thread_testing.rs:60:16 [INFO] [stderr] | [INFO] [stderr] 60 | if let Err(_) = h.join() { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 61 | | return Err("Joining child thread returned an error.".to_string()); [INFO] [stderr] 62 | | } [INFO] [stderr] | |_________- help: try this: `if h.join().is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sandbox`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "1f5825fb8f4ef279423018381604dd84c09f4b43fb9210b6f215868de94aa274"` [INFO] running `"docker" "rm" "-f" "1f5825fb8f4ef279423018381604dd84c09f4b43fb9210b6f215868de94aa274"` [INFO] [stdout] 1f5825fb8f4ef279423018381604dd84c09f4b43fb9210b6f215868de94aa274