[INFO] updating cached repository HarukiUchito/rust_cp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/HarukiUchito/rust_cp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/HarukiUchito/rust_cp" "work/ex/clippy-test-run/sources/stable/gh/HarukiUchito/rust_cp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/HarukiUchito/rust_cp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/HarukiUchito/rust_cp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HarukiUchito/rust_cp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HarukiUchito/rust_cp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f1ecc8bf5bfd6722ec78a62b804a06f55300e09f [INFO] sha for GitHub repo HarukiUchito/rust_cp: f1ecc8bf5bfd6722ec78a62b804a06f55300e09f [INFO] validating manifest of HarukiUchito/rust_cp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of HarukiUchito/rust_cp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing HarukiUchito/rust_cp [INFO] finished frobbing HarukiUchito/rust_cp [INFO] frobbed toml for HarukiUchito/rust_cp written to work/ex/clippy-test-run/sources/stable/gh/HarukiUchito/rust_cp/Cargo.toml [INFO] started frobbing HarukiUchito/rust_cp [INFO] finished frobbing HarukiUchito/rust_cp [INFO] frobbed toml for HarukiUchito/rust_cp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HarukiUchito/rust_cp/Cargo.toml [INFO] crate HarukiUchito/rust_cp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting HarukiUchito/rust_cp against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HarukiUchito/rust_cp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5b85d641490c6370184d47c03c9d819a2b6020e343e126b666c0ac5a949c8478 [INFO] running `"docker" "start" "-a" "5b85d641490c6370184d47c03c9d819a2b6020e343e126b666c0ac5a949c8478"` [INFO] [stderr] Checking competitive_programming v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/tdpc_a_partial_sum.rs:40:19 [INFO] [stderr] | [INFO] [stderr] 40 | Scanner { cin: cin } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/dp_sugoroku.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/fight_against_traffic.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/aoj_dijkstra.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/longest_common_subsequence.rs:14:19 [INFO] [stderr] | [INFO] [stderr] 14 | Scanner { cin: cin } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/upper_bound.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/euler_phi.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/bfs.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/bfs.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/bfs.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return cnt == i_num [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cnt == i_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/bfs.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | t [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 130 | parse_tuple!(A, B); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/bfs.rs:124:25 [INFO] [stderr] | [INFO] [stderr] 124 | let t = ($($t::parse(tokens.next().unwrap())),*); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 130 | parse_tuple!(A, B); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/bfs.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | t [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 131 | parse_tuple!(A, B, C); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/bfs.rs:124:25 [INFO] [stderr] | [INFO] [stderr] 124 | let t = ($($t::parse(tokens.next().unwrap())),*); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 131 | parse_tuple!(A, B, C); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/dp_sugoroku.rs:97:35 [INFO] [stderr] | [INFO] [stderr] 97 | fn is_max_i64(num: i64) -> bool { if num == i64::max_value() { true } else { false } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `num == i64::max_value()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/longest_common_subsequence.rs:33:19 [INFO] [stderr] | [INFO] [stderr] 33 | fn common_num(s1: &Vec, s2: &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/longest_common_subsequence.rs:33:35 [INFO] [stderr] | [INFO] [stderr] 33 | fn common_num(s1: &Vec, s2: &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `dp`. [INFO] [stderr] --> src/bin/dp_sugoroku.rs:114:14 [INFO] [stderr] | [INFO] [stderr] 114 | for i in 0..N1 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 114 | for in dp.iter().take(N1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/euler_phi.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/euler_phi.rs:168:16 [INFO] [stderr] | [INFO] [stderr] 168 | let size = 1000002; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_002` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/tdpc_a_partial_sum.rs:23:14 [INFO] [stderr] | [INFO] [stderr] 23 | for i in 1..n + 1 { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/bfs.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / if x < 0 || y < 0 || x >= width || y >= height { [INFO] [stderr] 10 | | return false; [INFO] [stderr] 11 | | } else { [INFO] [stderr] 12 | | return true; [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `return !(x < 0 || y < 0 || x >= width || y >= height)` [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/fight_against_traffic.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / if num == i64::max_value() { [INFO] [stderr] 59 | | true [INFO] [stderr] 60 | | } else { [INFO] [stderr] 61 | | false [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `num == i64::max_value()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/fight_against_traffic.rs:65:15 [INFO] [stderr] | [INFO] [stderr] 65 | fn bfs(graph: &Vec>, start: usize) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/bfs.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | fn bfs(field: &Vec>, (sx, sy): (i32, i32), i_num: i32) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/fight_against_traffic.rs:90:29 [INFO] [stderr] | [INFO] [stderr] 90 | fn bfs_distance_list(graph: &Vec>, start: usize) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/fight_against_traffic.rs:112:31 [INFO] [stderr] | [INFO] [stderr] 112 | fn bfs_distance_matrix(graph: &Vec>, start: usize) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/upper_bound.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / if num == i64::max_value() { [INFO] [stderr] 57 | | true [INFO] [stderr] 58 | | } else { [INFO] [stderr] 59 | | false [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `num == i64::max_value()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `va`. [INFO] [stderr] --> src/bin/upper_bound.rs:119:14 [INFO] [stderr] | [INFO] [stderr] 119 | for i in 0..N { [INFO] [stderr] | ^^^^ [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/main.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 119 | for in va.iter().take(N) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/mst_build.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/bin/people_on_a_line.rs:48:20 [INFO] [stderr] | [INFO] [stderr] 48 | let (l, r, d): (usize, usize, i64) = (sc.read(), sc.read(), sc.read()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/people_on_a_line.rs:63:19 [INFO] [stderr] | [INFO] [stderr] 63 | Scanner { cin: cin } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/euler_phi.rs:97:35 [INFO] [stderr] | [INFO] [stderr] 97 | fn is_max_i64(num: i64) -> bool { if num == i64::max_value() { true } else { false } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `num == i64::max_value()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `f` [INFO] [stderr] --> src/bin/euler_phi.rs:149:14 [INFO] [stderr] | [INFO] [stderr] 149 | for i in 0..n { f[i] = i as u64; } [INFO] [stderr] | ^^^^ [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/upper_bound.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 149 | for (i, ) in f.iter_mut().enumerate().take(n) { f[i] = i as u64; } [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/connectivity.rs:76:19 [INFO] [stderr] | [INFO] [stderr] 76 | Scanner { cin: cin } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/fight_against_traffic.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/mst_build.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/tdpc_d_dice.rs:94:19 [INFO] [stderr] | [INFO] [stderr] 94 | Scanner { cin: cin } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/mst_build.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/bin/mst_build.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | if nbc == 0 { if !dfs(g, color, nb, -c) { return false; } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if nbc == 0 && !dfs(g, color, nb, -c) { return false; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/bin/mst_build.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | if color[i] == 0 { if !dfs(graph, &mut color, i, 1) { return (false, 0, 0); } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if color[i] == 0 && !dfs(graph, &mut color, i, 1) { return (false, 0, 0); }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/mst_build.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | return index; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/mst_build.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | return self.parent[index]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.parent[index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bin/main.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | let mut pr = ContestPrinter::new(); [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/upper_bound.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / if num == i64::max_value() { [INFO] [stderr] 57 | | true [INFO] [stderr] 58 | | } else { [INFO] [stderr] 59 | | false [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `num == i64::max_value()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `va`. [INFO] [stderr] --> src/bin/upper_bound.rs:119:14 [INFO] [stderr] | [INFO] [stderr] 119 | for i in 0..N { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 119 | for in va.iter().take(N) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/mst_build.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/bin/mst_build.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | if nbc == 0 { if !dfs(g, color, nb, -c) { return false; } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if nbc == 0 && !dfs(g, color, nb, -c) { return false; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/bin/mst_build.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | if color[i] == 0 { if !dfs(graph, &mut color, i, 1) { return (false, 0, 0); } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if color[i] == 0 && !dfs(graph, &mut color, i, 1) { return (false, 0, 0); }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/mst_build.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | return index; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/mst_build.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | return self.parent[index]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.parent[index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/people_on_a_line.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/people_on_a_line.rs:15:29 [INFO] [stderr] | [INFO] [stderr] 15 | let mut visited: [bool; 100005] = [false; 100005]; [INFO] [stderr] | ^^^^^^ help: consider: `100_005` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/people_on_a_line.rs:15:47 [INFO] [stderr] | [INFO] [stderr] 15 | let mut visited: [bool; 100005] = [false; 100005]; [INFO] [stderr] | ^^^^^^ help: consider: `100_005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/people_on_a_line.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | let mut node: [i64; 100005] = [0; 100005]; [INFO] [stderr] | ^^^^^^ help: consider: `100_005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/people_on_a_line.rs:16:39 [INFO] [stderr] | [INFO] [stderr] 16 | let mut node: [i64; 100005] = [0; 100005]; [INFO] [stderr] | ^^^^^^ help: consider: `100_005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/people_on_a_line.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | for n in 0..100000 { [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/people_on_a_line.rs:45:60 [INFO] [stderr] | [INFO] [stderr] 45 | let mut lrd: Vec> = vec![Vec::new(); 100000]; [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/mst_build.rs:125:35 [INFO] [stderr] | [INFO] [stderr] 125 | fn is_max_i64(num: i64) -> bool { if num == i64::max_value() { true } else { false } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `num == i64::max_value()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/mst_build.rs:128:24 [INFO] [stderr] | [INFO] [stderr] 128 | fn is_bipartite(graph: &Vec>) -> (bool, usize, usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/mst_build.rs:131:15 [INFO] [stderr] | [INFO] [stderr] 131 | fn dfs(g: &Vec>, color: &mut Vec, v: usize, c: i32) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `psx`. [INFO] [stderr] --> src/bin/mst_build.rs:237:14 [INFO] [stderr] | [INFO] [stderr] 237 | for i in 1..N { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 237 | for in psx.iter().take(N).skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `psy`. [INFO] [stderr] --> src/bin/mst_build.rs:243:14 [INFO] [stderr] | [INFO] [stderr] 243 | for i in 1..N { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 243 | for in psy.iter().take(N).skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/connectivity.rs:22:12 [INFO] [stderr] | [INFO] [stderr] 22 | paths: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/connectivity.rs:65:36 [INFO] [stderr] | [INFO] [stderr] 65 | if i < n-1 { print!("{} ", cncts.get(&(c1[i], c2[i])).unwrap()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&cncts[&(c1[i], c2[i])]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/connectivity.rs:66:31 [INFO] [stderr] | [INFO] [stderr] 66 | else { println!("{}", cncts.get(&(c1[i], c2[i])).unwrap()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&cncts[&(c1[i], c2[i])]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/mst_build.rs:125:35 [INFO] [stderr] | [INFO] [stderr] 125 | fn is_max_i64(num: i64) -> bool { if num == i64::max_value() { true } else { false } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `num == i64::max_value()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/mst_build.rs:128:24 [INFO] [stderr] | [INFO] [stderr] 128 | fn is_bipartite(graph: &Vec>) -> (bool, usize, usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/mst_build.rs:131:15 [INFO] [stderr] | [INFO] [stderr] 131 | fn dfs(g: &Vec>, color: &mut Vec, v: usize, c: i32) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/baumu_tree.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `psx`. [INFO] [stderr] --> src/bin/mst_build.rs:237:14 [INFO] [stderr] | [INFO] [stderr] 237 | for i in 1..N { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 237 | for in psx.iter().take(N).skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `psy`. [INFO] [stderr] --> src/bin/mst_build.rs:243:14 [INFO] [stderr] | [INFO] [stderr] 243 | for i in 1..N { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 243 | for in psy.iter().take(N).skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/people_on_a_line.rs:12:11 [INFO] [stderr] | [INFO] [stderr] 12 | cmap: &Vec> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<(usize, i64)>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/fight_against_traffic.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / if num == i64::max_value() { [INFO] [stderr] 59 | | true [INFO] [stderr] 60 | | } else { [INFO] [stderr] 61 | | false [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `num == i64::max_value()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/fight_against_traffic.rs:65:15 [INFO] [stderr] | [INFO] [stderr] 65 | fn bfs(graph: &Vec>, start: usize) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/euler_phi.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/fight_against_traffic.rs:90:29 [INFO] [stderr] | [INFO] [stderr] 90 | fn bfs_distance_list(graph: &Vec>, start: usize) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/fight_against_traffic.rs:112:31 [INFO] [stderr] | [INFO] [stderr] 112 | fn bfs_distance_matrix(graph: &Vec>, start: usize) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/aoj_dijkstra.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/euler_phi.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/euler_phi.rs:168:16 [INFO] [stderr] | [INFO] [stderr] 168 | let size = 1000002; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_002` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/shorten_diameter.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/baumu_tree.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | return index; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/baumu_tree.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | return self.parent[index]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.parent[index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/knapsack_dp.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/knapsack_dp.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/knapsack_dp.rs:28:28 [INFO] [stderr] | [INFO] [stderr] 28 | if index == ws.len() { return 0; } [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/knapsack_dp.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | t [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 105 | parse_tuple!(A, B); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/knapsack_dp.rs:99:25 [INFO] [stderr] | [INFO] [stderr] 99 | let t = ($($t::parse(tokens.next().unwrap())),*); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 105 | parse_tuple!(A, B); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/knapsack_dp.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | t [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 106 | parse_tuple!(A, B, C); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/knapsack_dp.rs:99:25 [INFO] [stderr] | [INFO] [stderr] 99 | let t = ($($t::parse(tokens.next().unwrap())),*); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 106 | parse_tuple!(A, B, C); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/knapsack_dp.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / if x < 0 || y < 0 || x >= width || y >= height { [INFO] [stderr] 10 | | return false; [INFO] [stderr] 11 | | } else { [INFO] [stderr] 12 | | return true; [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `return !(x < 0 || y < 0 || x >= width || y >= height)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/knapsack_dp.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | ws: &Vec, vs: &Vec, dp: &mut Vec>>, [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/knapsack_dp.rs:25:24 [INFO] [stderr] | [INFO] [stderr] 25 | ws: &Vec, vs: &Vec, dp: &mut Vec>>, [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/euler_phi.rs:97:35 [INFO] [stderr] | [INFO] [stderr] 97 | fn is_max_i64(num: i64) -> bool { if num == i64::max_value() { true } else { false } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `num == i64::max_value()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `f` [INFO] [stderr] --> src/bin/euler_phi.rs:149:14 [INFO] [stderr] | [INFO] [stderr] 149 | for i in 0..n { f[i] = i as u64; } [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 149 | for (i, ) in f.iter_mut().enumerate().take(n) { f[i] = i as u64; } [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/bfs.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/bfs.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/bfs.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return cnt == i_num [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cnt == i_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/bfs.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | t [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 130 | parse_tuple!(A, B); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/bfs.rs:124:25 [INFO] [stderr] | [INFO] [stderr] 124 | let t = ($($t::parse(tokens.next().unwrap())),*); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 130 | parse_tuple!(A, B); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/bfs.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | t [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 131 | parse_tuple!(A, B, C); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/bfs.rs:124:25 [INFO] [stderr] | [INFO] [stderr] 124 | let t = ($($t::parse(tokens.next().unwrap())),*); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 131 | parse_tuple!(A, B, C); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.edge_node_num[x].1` [INFO] [stderr] --> src/bin/baumu_tree.rs:127:44 [INFO] [stderr] | [INFO] [stderr] 127 | self.edge_node_num[y].1 += self.edge_node_num[x].1 + 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.edge_node_num[y].1` [INFO] [stderr] --> src/bin/baumu_tree.rs:131:44 [INFO] [stderr] | [INFO] [stderr] 131 | self.edge_node_num[x].1 += self.edge_node_num[y].1 + 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/knapsack_dp.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/knapsack_dp.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/knapsack_dp.rs:28:28 [INFO] [stderr] | [INFO] [stderr] 28 | if index == ws.len() { return 0; } [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/knapsack_dp.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | t [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 105 | parse_tuple!(A, B); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/knapsack_dp.rs:99:25 [INFO] [stderr] | [INFO] [stderr] 99 | let t = ($($t::parse(tokens.next().unwrap())),*); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 105 | parse_tuple!(A, B); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/knapsack_dp.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | t [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 106 | parse_tuple!(A, B, C); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/knapsack_dp.rs:99:25 [INFO] [stderr] | [INFO] [stderr] 99 | let t = ($($t::parse(tokens.next().unwrap())),*); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 106 | parse_tuple!(A, B, C); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/shorten_diameter.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/tdpc_a_partial_sum.rs:40:19 [INFO] [stderr] | [INFO] [stderr] 40 | Scanner { cin: cin } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/knapsack_dp.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / if x < 0 || y < 0 || x >= width || y >= height { [INFO] [stderr] 10 | | return false; [INFO] [stderr] 11 | | } else { [INFO] [stderr] 12 | | return true; [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `return !(x < 0 || y < 0 || x >= width || y >= height)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/knapsack_dp.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | ws: &Vec, vs: &Vec, dp: &mut Vec>>, [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/knapsack_dp.rs:25:24 [INFO] [stderr] | [INFO] [stderr] 25 | ws: &Vec, vs: &Vec, dp: &mut Vec>>, [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/circle_and_points.rs:124:19 [INFO] [stderr] | [INFO] [stderr] 124 | Scanner { cin: cin } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/longest_common_subsequence.rs:14:19 [INFO] [stderr] | [INFO] [stderr] 14 | Scanner { cin: cin } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/shorten_diameter.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / if num == i64::max_value() { [INFO] [stderr] 58 | | true [INFO] [stderr] 59 | | } else { [INFO] [stderr] 60 | | false [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `num == i64::max_value()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/shorten_diameter.rs:64:15 [INFO] [stderr] | [INFO] [stderr] 64 | fn bfs(graph: &Vec>, start: Vec, d: usize) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `ab`. [INFO] [stderr] --> src/bin/shorten_diameter.rs:109:18 [INFO] [stderr] | [INFO] [stderr] 109 | for i in 0..ab.len() {; // center edge [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 109 | for in &ab {; // center edge [INFO] [stderr] | ^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/bfs.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / if x < 0 || y < 0 || x >= width || y >= height { [INFO] [stderr] 10 | | return false; [INFO] [stderr] 11 | | } else { [INFO] [stderr] 12 | | return true; [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `return !(x < 0 || y < 0 || x >= width || y >= height)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/shorten_diameter.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / if num == i64::max_value() { [INFO] [stderr] 58 | | true [INFO] [stderr] 59 | | } else { [INFO] [stderr] 60 | | false [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `num == i64::max_value()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/shorten_diameter.rs:64:15 [INFO] [stderr] | [INFO] [stderr] 64 | fn bfs(graph: &Vec>, start: Vec, d: usize) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `ab`. [INFO] [stderr] --> src/bin/shorten_diameter.rs:109:18 [INFO] [stderr] | [INFO] [stderr] 109 | for i in 0..ab.len() {; // center edge [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 109 | for in &ab {; // center edge [INFO] [stderr] | ^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/bfs.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | fn bfs(field: &Vec>, (sx, sy): (i32, i32), i_num: i32) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/tdpc_a_partial_sum.rs:23:14 [INFO] [stderr] | [INFO] [stderr] 23 | for i in 1..n + 1 { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/okumasu_keisan.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/dp_sugoroku.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/cp.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/prime_factor_prime.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/prime_factor_prime.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/circle_and_points.rs:99:32 [INFO] [stderr] | [INFO] [stderr] 99 | if self.x == other.x { return self.y.cmp(&other.y); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.y.cmp(&other.y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/circle_and_points.rs:100:16 [INFO] [stderr] | [INFO] [stderr] 100 | else { return self.x.cmp(&other.x); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x.cmp(&other.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/circle_and_points.rs:106:32 [INFO] [stderr] | [INFO] [stderr] 106 | if self.x == other.x { return self.y.partial_cmp(&other.y); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.y.partial_cmp(&other.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/circle_and_points.rs:107:16 [INFO] [stderr] | [INFO] [stderr] 107 | else { return self.x.partial_cmp(&other.x); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x.partial_cmp(&other.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `ps` [INFO] [stderr] --> src/bin/circle_and_points.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | for k in 0..n { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 43 | for (k, ) in ps.iter().enumerate().take(n) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/cp.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/longest_common_subsequence.rs:33:19 [INFO] [stderr] | [INFO] [stderr] 33 | fn common_num(s1: &Vec, s2: &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/longest_common_subsequence.rs:33:35 [INFO] [stderr] | [INFO] [stderr] 33 | fn common_num(s1: &Vec, s2: &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/dp_sugoroku.rs:97:35 [INFO] [stderr] | [INFO] [stderr] 97 | fn is_max_i64(num: i64) -> bool { if num == i64::max_value() { true } else { false } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `num == i64::max_value()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/prime_factor_prime.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `dp`. [INFO] [stderr] --> src/bin/dp_sugoroku.rs:114:14 [INFO] [stderr] | [INFO] [stderr] 114 | for i in 0..N1 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 114 | for in dp.iter().take(N1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/prime_factor_prime.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/cp.rs:97:35 [INFO] [stderr] | [INFO] [stderr] 97 | fn is_max_i64(num: i64) -> bool { if num == i64::max_value() { true } else { false } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `num == i64::max_value()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/cp.rs:121:14 [INFO] [stderr] | [INFO] [stderr] 121 | for i in 1..H-A+1 { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=H-A` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/cp.rs:129:14 [INFO] [stderr] | [INFO] [stderr] 129 | for i in 1..B+1 { [INFO] [stderr] | ^^^^^^ help: use: `1..=B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/cp.rs:133:14 [INFO] [stderr] | [INFO] [stderr] 133 | for i in B+1..W+1 { [INFO] [stderr] | ^^^^^^^^ help: use: `B+1..=W` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/cp.rs:141:14 [INFO] [stderr] | [INFO] [stderr] 141 | for i in 1..A+1 { AA *= i; AA %= MOD; } [INFO] [stderr] | ^^^^^^ help: use: `1..=A` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `f` [INFO] [stderr] --> src/bin/prime_factor_prime.rs:149:14 [INFO] [stderr] | [INFO] [stderr] 149 | for i in 0..n { f[i] = i as u64; } [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 149 | for (i, ) in f.iter_mut().enumerate().take(n) { f[i] = i as u64; } [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/prime_factor_prime.rs:165:35 [INFO] [stderr] | [INFO] [stderr] 165 | fn is_max_i64(num: i64) -> bool { if num == i64::max_value() { true } else { false } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `num == i64::max_value()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/prime_factor_prime.rs:176:32 [INFO] [stderr] | [INFO] [stderr] 176 | let mut nums: Vec = (L..R+1).collect(); [INFO] [stderr] | ^^^^^^^^ help: use: `(L..=R)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/bin/prime_factor_prime.rs:194:21 [INFO] [stderr] | [INFO] [stderr] 194 | if is_prime(pfp as i64) { [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(pfp)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/baumu_tree.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `f` [INFO] [stderr] --> src/bin/prime_factor_prime.rs:149:14 [INFO] [stderr] | [INFO] [stderr] 149 | for i in 0..n { f[i] = i as u64; } [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 149 | for (i, ) in f.iter_mut().enumerate().take(n) { f[i] = i as u64; } [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/prime_factor_prime.rs:165:35 [INFO] [stderr] | [INFO] [stderr] 165 | fn is_max_i64(num: i64) -> bool { if num == i64::max_value() { true } else { false } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `num == i64::max_value()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/prime_factor_prime.rs:176:32 [INFO] [stderr] | [INFO] [stderr] 176 | let mut nums: Vec = (L..R+1).collect(); [INFO] [stderr] | ^^^^^^^^ help: use: `(L..=R)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/bin/prime_factor_prime.rs:194:21 [INFO] [stderr] | [INFO] [stderr] 194 | if is_prime(pfp as i64) { [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(pfp)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/irohachan_masume.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/okumasu_keisan.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / if num == i64::max_value() { [INFO] [stderr] 58 | | true [INFO] [stderr] 59 | | } else { [INFO] [stderr] 60 | | false [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `num == i64::max_value()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `va`. [INFO] [stderr] --> src/bin/okumasu_keisan.rs:113:18 [INFO] [stderr] | [INFO] [stderr] 113 | for i in 0..N { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 113 | for in va.iter().take(N) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/bin/people_on_a_line.rs:48:20 [INFO] [stderr] | [INFO] [stderr] 48 | let (l, r, d): (usize, usize, i64) = (sc.read(), sc.read(), sc.read()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/people_on_a_line.rs:63:19 [INFO] [stderr] | [INFO] [stderr] 63 | Scanner { cin: cin } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/union_find.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/tdpc_d_dice.rs:94:19 [INFO] [stderr] | [INFO] [stderr] 94 | Scanner { cin: cin } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/connectivity.rs:76:19 [INFO] [stderr] | [INFO] [stderr] 76 | Scanner { cin: cin } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/baumu_tree.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | return index; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/baumu_tree.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | return self.parent[index]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.parent[index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/cp.rs:97:35 [INFO] [stderr] | [INFO] [stderr] 97 | fn is_max_i64(num: i64) -> bool { if num == i64::max_value() { true } else { false } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `num == i64::max_value()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/cp.rs:121:14 [INFO] [stderr] | [INFO] [stderr] 121 | for i in 1..H-A+1 { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=H-A` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/cp.rs:129:14 [INFO] [stderr] | [INFO] [stderr] 129 | for i in 1..B+1 { [INFO] [stderr] | ^^^^^^ help: use: `1..=B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/cp.rs:133:14 [INFO] [stderr] | [INFO] [stderr] 133 | for i in B+1..W+1 { [INFO] [stderr] | ^^^^^^^^ help: use: `B+1..=W` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/cp.rs:141:14 [INFO] [stderr] | [INFO] [stderr] 141 | for i in 1..A+1 { AA *= i; AA %= MOD; } [INFO] [stderr] | ^^^^^^ help: use: `1..=A` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/aoj_bellman_ford.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/aoj_bellman_ford.rs:170:19 [INFO] [stderr] | [INFO] [stderr] 170 | Scanner { cin: cin } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.edge_node_num[x].1` [INFO] [stderr] --> src/bin/baumu_tree.rs:127:44 [INFO] [stderr] | [INFO] [stderr] 127 | self.edge_node_num[y].1 += self.edge_node_num[x].1 + 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.edge_node_num[y].1` [INFO] [stderr] --> src/bin/baumu_tree.rs:131:44 [INFO] [stderr] | [INFO] [stderr] 131 | self.edge_node_num[x].1 += self.edge_node_num[y].1 + 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/people_on_a_line.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/people_on_a_line.rs:15:29 [INFO] [stderr] | [INFO] [stderr] 15 | let mut visited: [bool; 100005] = [false; 100005]; [INFO] [stderr] | ^^^^^^ help: consider: `100_005` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/people_on_a_line.rs:15:47 [INFO] [stderr] | [INFO] [stderr] 15 | let mut visited: [bool; 100005] = [false; 100005]; [INFO] [stderr] | ^^^^^^ help: consider: `100_005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/people_on_a_line.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | let mut node: [i64; 100005] = [0; 100005]; [INFO] [stderr] | ^^^^^^ help: consider: `100_005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/people_on_a_line.rs:16:39 [INFO] [stderr] | [INFO] [stderr] 16 | let mut node: [i64; 100005] = [0; 100005]; [INFO] [stderr] | ^^^^^^ help: consider: `100_005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/people_on_a_line.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | for n in 0..100000 { [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/people_on_a_line.rs:45:60 [INFO] [stderr] | [INFO] [stderr] 45 | let mut lrd: Vec> = vec![Vec::new(); 100000]; [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/union_find.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | return index; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/union_find.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | return self.parent[index]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.parent[index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/people_on_a_line.rs:12:11 [INFO] [stderr] | [INFO] [stderr] 12 | cmap: &Vec> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<(usize, i64)>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/irohachan_masume.rs:99:35 [INFO] [stderr] | [INFO] [stderr] 99 | fn is_max_i64(num: i64) -> bool { if num == i64::max_value() { true } else { false } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `num == i64::max_value()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/irohachan_masume.rs:117:14 [INFO] [stderr] | [INFO] [stderr] 117 | for i in 1..W+H+1 { c *= i; c %= MOD; } [INFO] [stderr] | ^^^^^^^^ help: use: `1..=W+H` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/irohachan_masume.rs:120:14 [INFO] [stderr] | [INFO] [stderr] 120 | for i in 1..W+1 { m *= i; m %= MOD; } [INFO] [stderr] | ^^^^^^ help: use: `1..=W` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/irohachan_masume.rs:121:14 [INFO] [stderr] | [INFO] [stderr] 121 | for i in 1..H+1 { [INFO] [stderr] | ^^^^^^ help: use: `1..=H` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/main.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/connectivity.rs:22:12 [INFO] [stderr] | [INFO] [stderr] 22 | paths: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/union_find.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/connectivity.rs:65:36 [INFO] [stderr] | [INFO] [stderr] 65 | if i < n-1 { print!("{} ", cncts.get(&(c1[i], c2[i])).unwrap()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&cncts[&(c1[i], c2[i])]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/connectivity.rs:66:31 [INFO] [stderr] | [INFO] [stderr] 66 | else { println!("{}", cncts.get(&(c1[i], c2[i])).unwrap()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&cncts[&(c1[i], c2[i])]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/3n_numbers.rs:61:19 [INFO] [stderr] | [INFO] [stderr] 61 | Scanner { cin: cin } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/okumasu_keisan.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/aoj_bellman_ford.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/aoj_bellman_ford.rs:170:19 [INFO] [stderr] | [INFO] [stderr] 170 | Scanner { cin: cin } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/union_find.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | return index; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/union_find.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | return self.parent[index]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.parent[index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bin/main.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | let mut pr = ContestPrinter::new(); [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/dfs.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/dfs.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/dfs.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/dfs.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | t [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 115 | parse_tuple!(A, B); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/dfs.rs:109:25 [INFO] [stderr] | [INFO] [stderr] 109 | let t = ($($t::parse(tokens.next().unwrap())),*); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 115 | parse_tuple!(A, B); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/dfs.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | t [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 116 | parse_tuple!(A, B, C); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/dfs.rs:109:25 [INFO] [stderr] | [INFO] [stderr] 109 | let t = ($($t::parse(tokens.next().unwrap())),*); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 116 | parse_tuple!(A, B, C); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/circle_and_points.rs:124:19 [INFO] [stderr] | [INFO] [stderr] 124 | Scanner { cin: cin } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cin` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/3n_numbers.rs:61:19 [INFO] [stderr] | [INFO] [stderr] 61 | Scanner { cin: cin } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/dfs.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / if x < 0 || y < 0 || x >= width || y >= height { [INFO] [stderr] 10 | | return false; [INFO] [stderr] 11 | | } else { [INFO] [stderr] 12 | | return true; [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `return !(x < 0 || y < 0 || x >= width || y >= height)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/3n_numbers.rs:25:14 [INFO] [stderr] | [INFO] [stderr] 25 | for i in 1..(n+1) { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/3n_numbers.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | for i in 1..(n+1) { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/3n_numbers.rs:52:14 [INFO] [stderr] | [INFO] [stderr] 52 | for k in 0..(n+1) { ans = max(ans, half1[k] - half2[k]); } [INFO] [stderr] | ^^^^^^^^ help: use: `0..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/irohachan_masume.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/okumasu_keisan.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / if num == i64::max_value() { [INFO] [stderr] 58 | | true [INFO] [stderr] 59 | | } else { [INFO] [stderr] 60 | | false [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `num == i64::max_value()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `va`. [INFO] [stderr] --> src/bin/okumasu_keisan.rs:113:18 [INFO] [stderr] | [INFO] [stderr] 113 | for i in 0..N { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 113 | for in va.iter().take(N) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/3n_numbers.rs:25:14 [INFO] [stderr] | [INFO] [stderr] 25 | for i in 1..(n+1) { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/3n_numbers.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | for i in 1..(n+1) { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/3n_numbers.rs:52:14 [INFO] [stderr] | [INFO] [stderr] 52 | for k in 0..(n+1) { ans = max(ans, half1[k] - half2[k]); } [INFO] [stderr] | ^^^^^^^^ help: use: `0..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/circle_and_points.rs:99:32 [INFO] [stderr] | [INFO] [stderr] 99 | if self.x == other.x { return self.y.cmp(&other.y); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.y.cmp(&other.y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/circle_and_points.rs:100:16 [INFO] [stderr] | [INFO] [stderr] 100 | else { return self.x.cmp(&other.x); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x.cmp(&other.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/circle_and_points.rs:106:32 [INFO] [stderr] | [INFO] [stderr] 106 | if self.x == other.x { return self.y.partial_cmp(&other.y); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.y.partial_cmp(&other.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/circle_and_points.rs:107:16 [INFO] [stderr] | [INFO] [stderr] 107 | else { return self.x.partial_cmp(&other.x); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x.partial_cmp(&other.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `ps` [INFO] [stderr] --> src/bin/circle_and_points.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | for k in 0..n { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 43 | for (k, ) in ps.iter().enumerate().take(n) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/irohachan_masume.rs:99:35 [INFO] [stderr] | [INFO] [stderr] 99 | fn is_max_i64(num: i64) -> bool { if num == i64::max_value() { true } else { false } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `num == i64::max_value()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/irohachan_masume.rs:117:14 [INFO] [stderr] | [INFO] [stderr] 117 | for i in 1..W+H+1 { c *= i; c %= MOD; } [INFO] [stderr] | ^^^^^^^^ help: use: `1..=W+H` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/irohachan_masume.rs:120:14 [INFO] [stderr] | [INFO] [stderr] 120 | for i in 1..W+1 { m *= i; m %= MOD; } [INFO] [stderr] | ^^^^^^ help: use: `1..=W` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/irohachan_masume.rs:121:14 [INFO] [stderr] | [INFO] [stderr] 121 | for i in 1..H+1 { [INFO] [stderr] | ^^^^^^ help: use: `1..=H` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/dfs.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/dfs.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/dfs.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/dfs.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | t [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 115 | parse_tuple!(A, B); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/dfs.rs:109:25 [INFO] [stderr] | [INFO] [stderr] 109 | let t = ($($t::parse(tokens.next().unwrap())),*); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 115 | parse_tuple!(A, B); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/dfs.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | t [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 116 | parse_tuple!(A, B, C); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/dfs.rs:109:25 [INFO] [stderr] | [INFO] [stderr] 109 | let t = ($($t::parse(tokens.next().unwrap())),*); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 116 | parse_tuple!(A, B, C); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/bin/dfs.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / if x < 0 || y < 0 || x >= width || y >= height { [INFO] [stderr] 10 | | return false; [INFO] [stderr] 11 | | } else { [INFO] [stderr] 12 | | return true; [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `return !(x < 0 || y < 0 || x >= width || y >= height)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.56s [INFO] running `"docker" "inspect" "5b85d641490c6370184d47c03c9d819a2b6020e343e126b666c0ac5a949c8478"` [INFO] running `"docker" "rm" "-f" "5b85d641490c6370184d47c03c9d819a2b6020e343e126b666c0ac5a949c8478"` [INFO] [stdout] 5b85d641490c6370184d47c03c9d819a2b6020e343e126b666c0ac5a949c8478