[INFO] updating cached repository HakanPayat/file_shorten [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/HakanPayat/file_shorten [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/HakanPayat/file_shorten" "work/ex/clippy-test-run/sources/stable/gh/HakanPayat/file_shorten"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/HakanPayat/file_shorten'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/HakanPayat/file_shorten" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HakanPayat/file_shorten"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HakanPayat/file_shorten'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4f7f2aa739f6bf50580ed6d99f9f7f97ca9f994d [INFO] sha for GitHub repo HakanPayat/file_shorten: 4f7f2aa739f6bf50580ed6d99f9f7f97ca9f994d [INFO] validating manifest of HakanPayat/file_shorten on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of HakanPayat/file_shorten on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing HakanPayat/file_shorten [INFO] finished frobbing HakanPayat/file_shorten [INFO] frobbed toml for HakanPayat/file_shorten written to work/ex/clippy-test-run/sources/stable/gh/HakanPayat/file_shorten/Cargo.toml [INFO] started frobbing HakanPayat/file_shorten [INFO] finished frobbing HakanPayat/file_shorten [INFO] frobbed toml for HakanPayat/file_shorten written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HakanPayat/file_shorten/Cargo.toml [INFO] crate HakanPayat/file_shorten has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting HakanPayat/file_shorten against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HakanPayat/file_shorten:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bfd470eb1d529e28f37d77c8cb31313c8bf14802a6c66e49ea3294c393ef84ed [INFO] running `"docker" "start" "-a" "bfd470eb1d529e28f37d77c8cb31313c8bf14802a6c66e49ea3294c393ef84ed"` [INFO] [stderr] Checking file_shorten v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: method is never used: `decode` [INFO] [stderr] --> src/main.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | fn decode(&self, val: u8) -> char { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `decode_vec_u8` [INFO] [stderr] --> src/main.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | fn decode_vec_u8(&self, text: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `decode_string` [INFO] [stderr] --> src/main.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | fn decode_string(&self, text: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / match file.read_to_string(&mut example_text) { [INFO] [stderr] 19 | | Err(why) => panic!("Couldn't read: {}", why), [INFO] [stderr] 20 | | Ok(_) => (), [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_string(&mut example_text) { panic!("Couldn't read: {}", why) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:95:35 [INFO] [stderr] | [INFO] [stderr] 95 | fn decode_vec_u8(&self, text: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:104:35 [INFO] [stderr] | [INFO] [stderr] 104 | fn decode_string(&self, text: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: method is never used: `decode` [INFO] [stderr] --> src/main.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | fn decode(&self, val: u8) -> char { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `decode_vec_u8` [INFO] [stderr] --> src/main.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | fn decode_vec_u8(&self, text: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `decode_string` [INFO] [stderr] --> src/main.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | fn decode_string(&self, text: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / match file.read_to_string(&mut example_text) { [INFO] [stderr] 19 | | Err(why) => panic!("Couldn't read: {}", why), [INFO] [stderr] 20 | | Ok(_) => (), [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_string(&mut example_text) { panic!("Couldn't read: {}", why) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:95:35 [INFO] [stderr] | [INFO] [stderr] 95 | fn decode_vec_u8(&self, text: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:104:35 [INFO] [stderr] | [INFO] [stderr] 104 | fn decode_string(&self, text: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.70s [INFO] running `"docker" "inspect" "bfd470eb1d529e28f37d77c8cb31313c8bf14802a6c66e49ea3294c393ef84ed"` [INFO] running `"docker" "rm" "-f" "bfd470eb1d529e28f37d77c8cb31313c8bf14802a6c66e49ea3294c393ef84ed"` [INFO] [stdout] bfd470eb1d529e28f37d77c8cb31313c8bf14802a6c66e49ea3294c393ef84ed