[INFO] updating cached repository HParker/climbpro [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/HParker/climbpro [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/HParker/climbpro" "work/ex/clippy-test-run/sources/stable/gh/HParker/climbpro"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/HParker/climbpro'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/HParker/climbpro" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HParker/climbpro"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HParker/climbpro'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6aef808999f7e059459e1d446727b1f5bf2ab92a [INFO] sha for GitHub repo HParker/climbpro: 6aef808999f7e059459e1d446727b1f5bf2ab92a [INFO] validating manifest of HParker/climbpro on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of HParker/climbpro on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing HParker/climbpro [INFO] finished frobbing HParker/climbpro [INFO] frobbed toml for HParker/climbpro written to work/ex/clippy-test-run/sources/stable/gh/HParker/climbpro/Cargo.toml [INFO] started frobbing HParker/climbpro [INFO] finished frobbing HParker/climbpro [INFO] frobbed toml for HParker/climbpro written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HParker/climbpro/Cargo.toml [INFO] crate HParker/climbpro has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting HParker/climbpro against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/HParker/climbpro:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2eda7baca6c9091fb509d755821261ba1d95c5f34547df0cc81bdc923f01f032 [INFO] running `"docker" "start" "-a" "2eda7baca6c9091fb509d755821261ba1d95c5f34547df0cc81bdc923f01f032"` [INFO] [stderr] Checking climbpro v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:154:22 [INFO] [stderr] | [INFO] [stderr] 154 | (row << (width - 1) - piece.origin.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `row << ((width - 1) - piece.origin.1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:439:22 [INFO] [stderr] | [INFO] [stderr] 439 | (row << (width - 1) - piece.origin.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `row << ((width - 1) - piece.origin.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:449:43 [INFO] [stderr] | [INFO] [stderr] 449 | ((area[piece.origin.0 + y] & (row << (width - 1) - piece.origin.1)) != 0b0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `row << ((width - 1) - piece.origin.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:154:22 [INFO] [stderr] | [INFO] [stderr] 154 | (row << (width - 1) - piece.origin.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `row << ((width - 1) - piece.origin.1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:439:22 [INFO] [stderr] | [INFO] [stderr] 439 | (row << (width - 1) - piece.origin.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `row << ((width - 1) - piece.origin.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:449:43 [INFO] [stderr] | [INFO] [stderr] 449 | ((area[piece.origin.0 + y] & (row << (width - 1) - piece.origin.1)) != 0b0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `row << ((width - 1) - piece.origin.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `LBOT` [INFO] [stderr] --> src/main.rs:118:1 [INFO] [stderr] | [INFO] [stderr] 118 | / static LBOT: Shape = Shape { [INFO] [stderr] 119 | | id: 8, [INFO] [stderr] 120 | | collider: [0b100, 0b110, 0b000], [INFO] [stderr] 121 | | // X 0 O [INFO] [stderr] ... | [INFO] [stderr] 125 | | width: 2, [INFO] [stderr] 126 | | }; [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `RTOP` [INFO] [stderr] --> src/main.rs:128:1 [INFO] [stderr] | [INFO] [stderr] 128 | / static RTOP: Shape = Shape { [INFO] [stderr] 129 | | id: 9, [INFO] [stderr] 130 | | collider: [0b110, 0b010, 0b000], [INFO] [stderr] 131 | | // X X O [INFO] [stderr] ... | [INFO] [stderr] 135 | | width: 2, [INFO] [stderr] 136 | | }; [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `SQUARE` [INFO] [stderr] --> src/main.rs:138:1 [INFO] [stderr] | [INFO] [stderr] 138 | / static SQUARE: Shape = Shape { [INFO] [stderr] 139 | | id: 7, [INFO] [stderr] 140 | | collider: [0b110, 0b110, 0b000], [INFO] [stderr] 141 | | // X X O [INFO] [stderr] ... | [INFO] [stderr] 145 | | width: 2, [INFO] [stderr] 146 | | }; [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `ten_board` [INFO] [stderr] --> src/main.rs:165:1 [INFO] [stderr] | [INFO] [stderr] 165 | fn ten_board() -> Board { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `fifteen_board` [INFO] [stderr] --> src/main.rs:304:1 [INFO] [stderr] | [INFO] [stderr] 304 | fn fifteen_board() -> Board { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | / area[piece.origin.0 + y] = area[piece.origin.0 + y] | [INFO] [stderr] 154 | | (row << (width - 1) - piece.origin.1); [INFO] [stderr] | |_________________________________________________________^ help: replace it with: `area[piece.origin.0 + y] |= (row << (width - 1) - piece.origin.1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:438:17 [INFO] [stderr] | [INFO] [stderr] 438 | / area[piece.origin.0 + y] = area[piece.origin.0 + y] | [INFO] [stderr] 439 | | (row << (width - 1) - piece.origin.1); [INFO] [stderr] | |_________________________________________________________^ help: replace it with: `area[piece.origin.0 + y] |= (row << (width - 1) - piece.origin.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:497:9 [INFO] [stderr] | [INFO] [stderr] 497 | / match layer.iter().find(|b| goal(b)) { [INFO] [stderr] 498 | | Some(b) => { [INFO] [stderr] 499 | | println!("found the goal!"); [INFO] [stderr] 500 | | show(&b.pieces, b.height, b.width); [INFO] [stderr] ... | [INFO] [stderr] 503 | | None => {} [INFO] [stderr] 504 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 497 | if let Some(b) = layer.iter().find(|b| goal(b)) { [INFO] [stderr] 498 | println!("found the goal!"); [INFO] [stderr] 499 | show(&b.pieces, b.height, b.width); [INFO] [stderr] 500 | break; [INFO] [stderr] 501 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `LBOT` [INFO] [stderr] --> src/main.rs:118:1 [INFO] [stderr] | [INFO] [stderr] 118 | / static LBOT: Shape = Shape { [INFO] [stderr] 119 | | id: 8, [INFO] [stderr] 120 | | collider: [0b100, 0b110, 0b000], [INFO] [stderr] 121 | | // X 0 O [INFO] [stderr] ... | [INFO] [stderr] 125 | | width: 2, [INFO] [stderr] 126 | | }; [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `RTOP` [INFO] [stderr] --> src/main.rs:128:1 [INFO] [stderr] | [INFO] [stderr] 128 | / static RTOP: Shape = Shape { [INFO] [stderr] 129 | | id: 9, [INFO] [stderr] 130 | | collider: [0b110, 0b010, 0b000], [INFO] [stderr] 131 | | // X X O [INFO] [stderr] ... | [INFO] [stderr] 135 | | width: 2, [INFO] [stderr] 136 | | }; [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `SQUARE` [INFO] [stderr] --> src/main.rs:138:1 [INFO] [stderr] | [INFO] [stderr] 138 | / static SQUARE: Shape = Shape { [INFO] [stderr] 139 | | id: 7, [INFO] [stderr] 140 | | collider: [0b110, 0b110, 0b000], [INFO] [stderr] 141 | | // X X O [INFO] [stderr] ... | [INFO] [stderr] 145 | | width: 2, [INFO] [stderr] 146 | | }; [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `ten_board` [INFO] [stderr] --> src/main.rs:165:1 [INFO] [stderr] | [INFO] [stderr] 165 | fn ten_board() -> Board { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `fifteen_board` [INFO] [stderr] --> src/main.rs:304:1 [INFO] [stderr] | [INFO] [stderr] 304 | fn fifteen_board() -> Board { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | / area[piece.origin.0 + y] = area[piece.origin.0 + y] | [INFO] [stderr] 154 | | (row << (width - 1) - piece.origin.1); [INFO] [stderr] | |_________________________________________________________^ help: replace it with: `area[piece.origin.0 + y] |= (row << (width - 1) - piece.origin.1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:438:17 [INFO] [stderr] | [INFO] [stderr] 438 | / area[piece.origin.0 + y] = area[piece.origin.0 + y] | [INFO] [stderr] 439 | | (row << (width - 1) - piece.origin.1); [INFO] [stderr] | |_________________________________________________________^ help: replace it with: `area[piece.origin.0 + y] |= (row << (width - 1) - piece.origin.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:497:9 [INFO] [stderr] | [INFO] [stderr] 497 | / match layer.iter().find(|b| goal(b)) { [INFO] [stderr] 498 | | Some(b) => { [INFO] [stderr] 499 | | println!("found the goal!"); [INFO] [stderr] 500 | | show(&b.pieces, b.height, b.width); [INFO] [stderr] ... | [INFO] [stderr] 503 | | None => {} [INFO] [stderr] 504 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 497 | if let Some(b) = layer.iter().find(|b| goal(b)) { [INFO] [stderr] 498 | println!("found the goal!"); [INFO] [stderr] 499 | show(&b.pieces, b.height, b.width); [INFO] [stderr] 500 | break; [INFO] [stderr] 501 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.72s [INFO] running `"docker" "inspect" "2eda7baca6c9091fb509d755821261ba1d95c5f34547df0cc81bdc923f01f032"` [INFO] running `"docker" "rm" "-f" "2eda7baca6c9091fb509d755821261ba1d95c5f34547df0cc81bdc923f01f032"` [INFO] [stdout] 2eda7baca6c9091fb509d755821261ba1d95c5f34547df0cc81bdc923f01f032