[INFO] updating cached repository H2CO3/sudoku [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/H2CO3/sudoku [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/H2CO3/sudoku" "work/ex/clippy-test-run/sources/stable/gh/H2CO3/sudoku"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/H2CO3/sudoku'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/H2CO3/sudoku" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/H2CO3/sudoku"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/H2CO3/sudoku'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8e62adee840042e0fa2e6b961626bce4a08b0889 [INFO] sha for GitHub repo H2CO3/sudoku: 8e62adee840042e0fa2e6b961626bce4a08b0889 [INFO] validating manifest of H2CO3/sudoku on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of H2CO3/sudoku on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing H2CO3/sudoku [INFO] finished frobbing H2CO3/sudoku [INFO] frobbed toml for H2CO3/sudoku written to work/ex/clippy-test-run/sources/stable/gh/H2CO3/sudoku/Cargo.toml [INFO] started frobbing H2CO3/sudoku [INFO] finished frobbing H2CO3/sudoku [INFO] frobbed toml for H2CO3/sudoku written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/H2CO3/sudoku/Cargo.toml [INFO] crate H2CO3/sudoku has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting H2CO3/sudoku against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/H2CO3/sudoku:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d46a6b02d2121bd4a66bb15ca75f4c680e581c54fefdb866e24468784064865d [INFO] running `"docker" "start" "-a" "d46a6b02d2121bd4a66bb15ca75f4c680e581c54fefdb866e24468784064865d"` [INFO] [stderr] Checking sudoku v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | write!(f, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | write!(f, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s2` [INFO] [stderr] --> src/main.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | let s2 = Grid { [INFO] [stderr] | ^^ help: consider using `_s2` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s2` [INFO] [stderr] --> src/main.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | let s2 = Grid { [INFO] [stderr] | ^^ help: consider using `_s2` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:26:35 [INFO] [stderr] | [INFO] [stderr] 26 | let mut numbers: Vec<_> = (1..size as u8 + 1).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `(1..=size as u8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:26:35 [INFO] [stderr] | [INFO] [stderr] 26 | let mut numbers: Vec<_> = (1..size as u8 + 1).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `(1..=size as u8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.54s [INFO] running `"docker" "inspect" "d46a6b02d2121bd4a66bb15ca75f4c680e581c54fefdb866e24468784064865d"` [INFO] running `"docker" "rm" "-f" "d46a6b02d2121bd4a66bb15ca75f4c680e581c54fefdb866e24468784064865d"` [INFO] [stdout] d46a6b02d2121bd4a66bb15ca75f4c680e581c54fefdb866e24468784064865d