[INFO] updating cached repository Gregory-Meyer/spinlock-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Gregory-Meyer/spinlock-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Gregory-Meyer/spinlock-rs" "work/ex/clippy-test-run/sources/stable/gh/Gregory-Meyer/spinlock-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Gregory-Meyer/spinlock-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Gregory-Meyer/spinlock-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Gregory-Meyer/spinlock-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Gregory-Meyer/spinlock-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0adbb47c6d77538ee23bbb30aea3f59079bd1ae4 [INFO] sha for GitHub repo Gregory-Meyer/spinlock-rs: 0adbb47c6d77538ee23bbb30aea3f59079bd1ae4 [INFO] validating manifest of Gregory-Meyer/spinlock-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Gregory-Meyer/spinlock-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Gregory-Meyer/spinlock-rs [INFO] finished frobbing Gregory-Meyer/spinlock-rs [INFO] frobbed toml for Gregory-Meyer/spinlock-rs written to work/ex/clippy-test-run/sources/stable/gh/Gregory-Meyer/spinlock-rs/Cargo.toml [INFO] started frobbing Gregory-Meyer/spinlock-rs [INFO] finished frobbing Gregory-Meyer/spinlock-rs [INFO] frobbed toml for Gregory-Meyer/spinlock-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Gregory-Meyer/spinlock-rs/Cargo.toml [INFO] crate Gregory-Meyer/spinlock-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Gregory-Meyer/spinlock-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Gregory-Meyer/spinlock-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d72bec84ab6cba6a181cd99a0db196b5a20c23c6b63ec11b9dfbd86fbc6b796a [INFO] running `"docker" "start" "-a" "d72bec84ab6cba6a181cd99a0db196b5a20c23c6b63ec11b9dfbd86fbc6b796a"` [INFO] [stderr] Checking spinlock v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: method is never used: `into_inner` [INFO] [stderr] --> src/spinlock.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn into_inner(self) -> std::sync::LockResult where T: Sized { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_mut` [INFO] [stderr] --> src/spinlock.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn get_mut(&mut self) -> std::sync::LockResult<&mut T> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:23:19 [INFO] [stderr] | [INFO] [stderr] 23 | let threads = (0..NUM_THREADS).into_iter().map(|_| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..NUM_THREADS)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: method is never used: `into_inner` [INFO] [stderr] --> src/spinlock.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn into_inner(self) -> std::sync::LockResult where T: Sized { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_mut` [INFO] [stderr] --> src/spinlock.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn get_mut(&mut self) -> std::sync::LockResult<&mut T> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/spinlock.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | / match spinlock.lock() { [INFO] [stderr] 238 | | Ok(_) => { [INFO] [stderr] 239 | | panic!(); [INFO] [stderr] 240 | | } [INFO] [stderr] 241 | | _ => (), [INFO] [stderr] 242 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 237 | if let Ok(_) = spinlock.lock() { [INFO] [stderr] 238 | panic!(); [INFO] [stderr] 239 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:23:19 [INFO] [stderr] | [INFO] [stderr] 23 | let threads = (0..NUM_THREADS).into_iter().map(|_| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..NUM_THREADS)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.94s [INFO] running `"docker" "inspect" "d72bec84ab6cba6a181cd99a0db196b5a20c23c6b63ec11b9dfbd86fbc6b796a"` [INFO] running `"docker" "rm" "-f" "d72bec84ab6cba6a181cd99a0db196b5a20c23c6b63ec11b9dfbd86fbc6b796a"` [INFO] [stdout] d72bec84ab6cba6a181cd99a0db196b5a20c23c6b63ec11b9dfbd86fbc6b796a