[INFO] updating cached repository Gregory-Meyer/coreutils-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Gregory-Meyer/coreutils-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Gregory-Meyer/coreutils-rs" "work/ex/clippy-test-run/sources/stable/gh/Gregory-Meyer/coreutils-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Gregory-Meyer/coreutils-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Gregory-Meyer/coreutils-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Gregory-Meyer/coreutils-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Gregory-Meyer/coreutils-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c5dd2d84b476a51dea8700515374973e66796d5a [INFO] sha for GitHub repo Gregory-Meyer/coreutils-rs: c5dd2d84b476a51dea8700515374973e66796d5a [INFO] validating manifest of Gregory-Meyer/coreutils-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Gregory-Meyer/coreutils-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Gregory-Meyer/coreutils-rs [INFO] finished frobbing Gregory-Meyer/coreutils-rs [INFO] frobbed toml for Gregory-Meyer/coreutils-rs written to work/ex/clippy-test-run/sources/stable/gh/Gregory-Meyer/coreutils-rs/Cargo.toml [INFO] started frobbing Gregory-Meyer/coreutils-rs [INFO] finished frobbing Gregory-Meyer/coreutils-rs [INFO] frobbed toml for Gregory-Meyer/coreutils-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Gregory-Meyer/coreutils-rs/Cargo.toml [INFO] crate Gregory-Meyer/coreutils-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Gregory-Meyer/coreutils-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Gregory-Meyer/coreutils-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] afeb6998570df97fdd1e11a9c1cae170b738494ba02c016655a7ee30a1b1d5d1 [INFO] running `"docker" "start" "-a" "afeb6998570df97fdd1e11a9c1cae170b738494ba02c016655a7ee30a1b1d5d1"` [INFO] [stderr] Checking coreutils v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: function is never used: `reverse_split_buffer` [INFO] [stderr] --> src/lib.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | fn reverse_split_buffer<'a>(buffer: &'a str, split: &str) -> Vec<&'a str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `reverse_split_buffer` [INFO] [stderr] --> src/lib.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | fn reverse_split_buffer<'a>(buffer: &'a str, split: &str) -> Vec<&'a str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/cat.rs:40:23 [INFO] [stderr] | [INFO] [stderr] 40 | fn print_files(files: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[File]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bin/yes.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let ref slice = &repeated.as_slice(); [INFO] [stderr] | ----^^^^^^^^^------------------------ help: try: `let slice = &(&repeated.as_slice());` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bin/yes.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let ref slice = &repeated.as_slice(); [INFO] [stderr] | ----^^^^^^^^^------------------------ help: try: `let slice = &(&repeated.as_slice());` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/tac.rs:40:23 [INFO] [stderr] | [INFO] [stderr] 40 | fn print_files(files: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[File]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/cat.rs:40:23 [INFO] [stderr] | [INFO] [stderr] 40 | fn print_files(files: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[File]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/tac.rs:40:23 [INFO] [stderr] | [INFO] [stderr] 40 | fn print_files(files: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[File]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.81s [INFO] running `"docker" "inspect" "afeb6998570df97fdd1e11a9c1cae170b738494ba02c016655a7ee30a1b1d5d1"` [INFO] running `"docker" "rm" "-f" "afeb6998570df97fdd1e11a9c1cae170b738494ba02c016655a7ee30a1b1d5d1"` [INFO] [stdout] afeb6998570df97fdd1e11a9c1cae170b738494ba02c016655a7ee30a1b1d5d1