[INFO] updating cached repository Grazfather/nes_level [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Grazfather/nes_level [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Grazfather/nes_level" "work/ex/clippy-test-run/sources/stable/gh/Grazfather/nes_level"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Grazfather/nes_level'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Grazfather/nes_level" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Grazfather/nes_level"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Grazfather/nes_level'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 24b99c73e801f2243c56cf1d86bf23db6a328497 [INFO] sha for GitHub repo Grazfather/nes_level: 24b99c73e801f2243c56cf1d86bf23db6a328497 [INFO] validating manifest of Grazfather/nes_level on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Grazfather/nes_level on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Grazfather/nes_level [INFO] finished frobbing Grazfather/nes_level [INFO] frobbed toml for Grazfather/nes_level written to work/ex/clippy-test-run/sources/stable/gh/Grazfather/nes_level/Cargo.toml [INFO] started frobbing Grazfather/nes_level [INFO] finished frobbing Grazfather/nes_level [INFO] frobbed toml for Grazfather/nes_level written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Grazfather/nes_level/Cargo.toml [INFO] crate Grazfather/nes_level has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Grazfather/nes_level against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Grazfather/nes_level:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d92e8cd4dfbc46790d200f26fa7c442c984e63caddc9a3aef923d4f95b461c48 [INFO] running `"docker" "start" "-a" "d92e8cd4dfbc46790d200f26fa7c442c984e63caddc9a3aef923d4f95b461c48"` [INFO] [stderr] Checking nes v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mem.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | rom: rom, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rom` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rom.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rom.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | prg: prg, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `prg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rom.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | chr: chr, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `chr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mem.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | rom: rom, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rom` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rom.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rom.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | prg: prg, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `prg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rom.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | chr: chr, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `chr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cpu.rs:208:9 [INFO] [stderr] | [INFO] [stderr] 208 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cpu.rs:215:9 [INFO] [stderr] | [INFO] [stderr] 215 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cpu.rs:618:5 [INFO] [stderr] | [INFO] [stderr] 618 | return dump; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `dump` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rom.rs:8:32 [INFO] [stderr] | [INFO] [stderr] 8 | const INES_HEADER_MAGIC: u32 = 0x1A53454E; // ELF\x1A [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1A53_454E` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rom.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / return ROM { [INFO] [stderr] 39 | | header: header, [INFO] [stderr] 40 | | prg: prg, [INFO] [stderr] 41 | | chr: chr, [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 38 | ROM { [INFO] [stderr] 39 | header: header, [INFO] [stderr] 40 | prg: prg, [INFO] [stderr] 41 | chr: chr, [INFO] [stderr] 42 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rom.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | return header [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rom.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | return header [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return Ok(args) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(args)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cpu.rs:208:9 [INFO] [stderr] | [INFO] [stderr] 208 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cpu.rs:215:9 [INFO] [stderr] | [INFO] [stderr] 215 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cpu.rs:618:5 [INFO] [stderr] | [INFO] [stderr] 618 | return dump; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `dump` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rom.rs:8:32 [INFO] [stderr] | [INFO] [stderr] 8 | const INES_HEADER_MAGIC: u32 = 0x1A53454E; // ELF\x1A [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1A53_454E` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rom.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / return ROM { [INFO] [stderr] 39 | | header: header, [INFO] [stderr] 40 | | prg: prg, [INFO] [stderr] 41 | | chr: chr, [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 38 | ROM { [INFO] [stderr] 39 | header: header, [INFO] [stderr] 40 | prg: prg, [INFO] [stderr] 41 | chr: chr, [INFO] [stderr] 42 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rom.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | return header [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rom.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | return header [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return Ok(args) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(args)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/cpu.rs:25:24 [INFO] [stderr] | [INFO] [stderr] 25 | const CARRY_FLAG: u8 = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:78:20 [INFO] [stderr] | [INFO] [stderr] 78 | let addr = cpu.memory.loadb(cpu.regs.pc) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.memory.loadb(cpu.regs.pc))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | addr += cpu.regs.x as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | addr += cpu.regs.x as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:104:24 [INFO] [stderr] | [INFO] [stderr] 104 | let mut addr = cpu.memory.loadb(cpu.regs.pc) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.memory.loadb(cpu.regs.pc))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | addr += cpu.regs.x as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | addr += cpu.regs.x as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | addr += cpu.regs.y as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | addr += cpu.regs.y as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:132:20 [INFO] [stderr] | [INFO] [stderr] 132 | let addr = cpu.loadb_move() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.loadb_move())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:136:20 [INFO] [stderr] | [INFO] [stderr] 136 | let addr = cpu.loadb_move() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.loadb_move())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:144:20 [INFO] [stderr] | [INFO] [stderr] 144 | let addr = cpu.memory.loadb(cpu.regs.pc) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.memory.loadb(cpu.regs.pc))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:148:20 [INFO] [stderr] | [INFO] [stderr] 148 | let addr = cpu.loadb_move() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.loadb_move())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:156:24 [INFO] [stderr] | [INFO] [stderr] 156 | let mut addr = cpu.loadb_move() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.loadb_move())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | addr += cpu.regs.x as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:161:24 [INFO] [stderr] | [INFO] [stderr] 161 | let mut addr = cpu.loadb_move() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.loadb_move())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:162:17 [INFO] [stderr] | [INFO] [stderr] 162 | addr += cpu.regs.x as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:170:24 [INFO] [stderr] | [INFO] [stderr] 170 | let mut addr = cpu.memory.loadb(cpu.regs.pc) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.memory.loadb(cpu.regs.pc))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:171:17 [INFO] [stderr] | [INFO] [stderr] 171 | addr += cpu.regs.x as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:175:24 [INFO] [stderr] | [INFO] [stderr] 175 | let mut addr = cpu.loadb_move() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.loadb_move())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:176:17 [INFO] [stderr] | [INFO] [stderr] 176 | addr += cpu.regs.x as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:184:24 [INFO] [stderr] | [INFO] [stderr] 184 | let mut addr = cpu.loadb_move() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.loadb_move())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:185:17 [INFO] [stderr] | [INFO] [stderr] 185 | addr += cpu.regs.y as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:189:24 [INFO] [stderr] | [INFO] [stderr] 189 | let mut addr = cpu.loadb_move() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.loadb_move())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:190:17 [INFO] [stderr] | [INFO] [stderr] 190 | addr += cpu.regs.y as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/cpu.rs:25:24 [INFO] [stderr] | [INFO] [stderr] 25 | const CARRY_FLAG: u8 = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:78:20 [INFO] [stderr] | [INFO] [stderr] 78 | let addr = cpu.memory.loadb(cpu.regs.pc) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.memory.loadb(cpu.regs.pc))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | addr += cpu.regs.x as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | addr += cpu.regs.x as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:104:24 [INFO] [stderr] | [INFO] [stderr] 104 | let mut addr = cpu.memory.loadb(cpu.regs.pc) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.memory.loadb(cpu.regs.pc))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | addr += cpu.regs.x as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:388:26 [INFO] [stderr] | [INFO] [stderr] 388 | let mut result = self.regs.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.regs.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:391:19 [INFO] [stderr] | [INFO] [stderr] 391 | result += val as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:400:26 [INFO] [stderr] | [INFO] [stderr] 400 | let mut result = self.regs.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.regs.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:403:19 [INFO] [stderr] | [INFO] [stderr] 403 | result -= val as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | addr += cpu.regs.x as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | addr += cpu.regs.y as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | addr += cpu.regs.y as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:132:20 [INFO] [stderr] | [INFO] [stderr] 132 | let addr = cpu.loadb_move() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.loadb_move())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:136:20 [INFO] [stderr] | [INFO] [stderr] 136 | let addr = cpu.loadb_move() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.loadb_move())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:144:20 [INFO] [stderr] | [INFO] [stderr] 144 | let addr = cpu.memory.loadb(cpu.regs.pc) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.memory.loadb(cpu.regs.pc))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:148:20 [INFO] [stderr] | [INFO] [stderr] 148 | let addr = cpu.loadb_move() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.loadb_move())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:156:24 [INFO] [stderr] | [INFO] [stderr] 156 | let mut addr = cpu.loadb_move() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.loadb_move())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | addr += cpu.regs.x as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:161:24 [INFO] [stderr] | [INFO] [stderr] 161 | let mut addr = cpu.loadb_move() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.loadb_move())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:162:17 [INFO] [stderr] | [INFO] [stderr] 162 | addr += cpu.regs.x as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:450:22 [INFO] [stderr] | [INFO] [stderr] 450 | let result = (first as u16).wrapping_sub(second as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(first)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:450:50 [INFO] [stderr] | [INFO] [stderr] 450 | let result = (first as u16).wrapping_sub(second as u16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(second)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:479:29 [INFO] [stderr] | [INFO] [stderr] 479 | self.regs.pc += offset as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:170:24 [INFO] [stderr] | [INFO] [stderr] 170 | let mut addr = cpu.memory.loadb(cpu.regs.pc) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.memory.loadb(cpu.regs.pc))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:171:17 [INFO] [stderr] | [INFO] [stderr] 171 | addr += cpu.regs.x as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:175:24 [INFO] [stderr] | [INFO] [stderr] 175 | let mut addr = cpu.loadb_move() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.loadb_move())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:488:29 [INFO] [stderr] | [INFO] [stderr] 488 | self.regs.pc += offset as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(offset)` [INFO] [stderr] | [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:176:17 [INFO] [stderr] | [INFO] [stderr] 176 | addr += cpu.regs.x as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:184:24 [INFO] [stderr] | [INFO] [stderr] 184 | let mut addr = cpu.loadb_move() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.loadb_move())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:185:17 [INFO] [stderr] | [INFO] [stderr] 185 | addr += cpu.regs.y as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:189:24 [INFO] [stderr] | [INFO] [stderr] 189 | let mut addr = cpu.loadb_move() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.loadb_move())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:190:17 [INFO] [stderr] | [INFO] [stderr] 190 | addr += cpu.regs.y as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:497:29 [INFO] [stderr] | [INFO] [stderr] 497 | self.regs.pc += offset as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:506:29 [INFO] [stderr] | [INFO] [stderr] 506 | self.regs.pc += offset as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:515:29 [INFO] [stderr] | [INFO] [stderr] 515 | self.regs.pc += offset as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:524:29 [INFO] [stderr] | [INFO] [stderr] 524 | self.regs.pc += offset as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:533:29 [INFO] [stderr] | [INFO] [stderr] 533 | self.regs.pc += offset as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:542:29 [INFO] [stderr] | [INFO] [stderr] 542 | self.regs.pc += offset as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:388:26 [INFO] [stderr] | [INFO] [stderr] 388 | let mut result = self.regs.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.regs.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:391:19 [INFO] [stderr] | [INFO] [stderr] 391 | result += val as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:400:26 [INFO] [stderr] | [INFO] [stderr] 400 | let mut result = self.regs.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.regs.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:403:19 [INFO] [stderr] | [INFO] [stderr] 403 | result -= val as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/mem.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | self.loadb(addr) as u16 | (self.loadb(addr + 1) as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.loadb(addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/mem.rs:8:35 [INFO] [stderr] | [INFO] [stderr] 8 | self.loadb(addr) as u16 | (self.loadb(addr + 1) as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.loadb(addr + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/mem.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | self.loadb(addr) as u16 | (self.loadb(addr + 1) as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.loadb(addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/mem.rs:23:35 [INFO] [stderr] | [INFO] [stderr] 23 | self.loadb(addr) as u16 | (self.loadb(addr + 1) as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.loadb(addr + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/rom.rs:83:48 [INFO] [stderr] | [INFO] [stderr] 83 | let as_slice: &mut [u8; 16] = unsafe { std::mem::transmute(&mut header) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut header as *mut rom::INESHeader as *mut [u8; 16])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:450:22 [INFO] [stderr] | [INFO] [stderr] 450 | let result = (first as u16).wrapping_sub(second as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(first)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:450:50 [INFO] [stderr] | [INFO] [stderr] 450 | let result = (first as u16).wrapping_sub(second as u16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(second)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:479:29 [INFO] [stderr] | [INFO] [stderr] 479 | self.regs.pc += offset as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:488:29 [INFO] [stderr] | [INFO] [stderr] 488 | self.regs.pc += offset as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:497:29 [INFO] [stderr] | [INFO] [stderr] 497 | self.regs.pc += offset as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:506:29 [INFO] [stderr] | [INFO] [stderr] 506 | self.regs.pc += offset as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:515:29 [INFO] [stderr] | [INFO] [stderr] 515 | self.regs.pc += offset as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:524:29 [INFO] [stderr] | [INFO] [stderr] 524 | self.regs.pc += offset as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:533:29 [INFO] [stderr] | [INFO] [stderr] 533 | self.regs.pc += offset as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:542:29 [INFO] [stderr] | [INFO] [stderr] 542 | self.regs.pc += offset as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/mem.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | self.loadb(addr) as u16 | (self.loadb(addr + 1) as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.loadb(addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/mem.rs:8:35 [INFO] [stderr] | [INFO] [stderr] 8 | self.loadb(addr) as u16 | (self.loadb(addr + 1) as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.loadb(addr + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/mem.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | self.loadb(addr) as u16 | (self.loadb(addr + 1) as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.loadb(addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/mem.rs:23:35 [INFO] [stderr] | [INFO] [stderr] 23 | self.loadb(addr) as u16 | (self.loadb(addr + 1) as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.loadb(addr + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/rom.rs:83:48 [INFO] [stderr] | [INFO] [stderr] 83 | let as_slice: &mut [u8; 16] = unsafe { std::mem::transmute(&mut header) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut header as *mut rom::INESHeader as *mut [u8; 16])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.15s [INFO] running `"docker" "inspect" "d92e8cd4dfbc46790d200f26fa7c442c984e63caddc9a3aef923d4f95b461c48"` [INFO] running `"docker" "rm" "-f" "d92e8cd4dfbc46790d200f26fa7c442c984e63caddc9a3aef923d4f95b461c48"` [INFO] [stdout] d92e8cd4dfbc46790d200f26fa7c442c984e63caddc9a3aef923d4f95b461c48