[INFO] updating cached repository Gisleburt/pfwd [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Gisleburt/pfwd [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Gisleburt/pfwd" "work/ex/clippy-test-run/sources/stable/gh/Gisleburt/pfwd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Gisleburt/pfwd'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Gisleburt/pfwd" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Gisleburt/pfwd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Gisleburt/pfwd'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] eefd2a2eb59dd939529af754e31f0ef15b5439d8 [INFO] sha for GitHub repo Gisleburt/pfwd: eefd2a2eb59dd939529af754e31f0ef15b5439d8 [INFO] validating manifest of Gisleburt/pfwd on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Gisleburt/pfwd on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Gisleburt/pfwd [INFO] finished frobbing Gisleburt/pfwd [INFO] frobbed toml for Gisleburt/pfwd written to work/ex/clippy-test-run/sources/stable/gh/Gisleburt/pfwd/Cargo.toml [INFO] started frobbing Gisleburt/pfwd [INFO] finished frobbing Gisleburt/pfwd [INFO] frobbed toml for Gisleburt/pfwd written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Gisleburt/pfwd/Cargo.toml [INFO] crate Gisleburt/pfwd has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Gisleburt/pfwd against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Gisleburt/pfwd:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 456d8e41fdb31b8cfb9ba38e67f1edde329abd7fa90f6c5130938ef5d73ce7e2 [INFO] running `"docker" "start" "-a" "456d8e41fdb31b8cfb9ba38e67f1edde329abd7fa90f6c5130938ef5d73ce7e2"` [INFO] [stderr] Checking pfwd v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | / return match from_stream.read(&mut buffer) { [INFO] [stderr] 84 | | Ok(0) => Err(()), [INFO] [stderr] 85 | | Ok(_) => { [INFO] [stderr] 86 | | if let Err(e) = to_stream.write(&buffer) { [INFO] [stderr] ... | [INFO] [stderr] 95 | | } [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 83 | match from_stream.read(&mut buffer) { [INFO] [stderr] 84 | Ok(0) => Err(()), [INFO] [stderr] 85 | Ok(_) => { [INFO] [stderr] 86 | if let Err(e) = to_stream.write(&buffer) { [INFO] [stderr] 87 | eprintln!("Something bad happened writing to to_steam: {}", e); [INFO] [stderr] 88 | return Err(()); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | / return match from_stream.read(&mut buffer) { [INFO] [stderr] 84 | | Ok(0) => Err(()), [INFO] [stderr] 85 | | Ok(_) => { [INFO] [stderr] 86 | | if let Err(e) = to_stream.write(&buffer) { [INFO] [stderr] ... | [INFO] [stderr] 95 | | } [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 83 | match from_stream.read(&mut buffer) { [INFO] [stderr] 84 | Ok(0) => Err(()), [INFO] [stderr] 85 | Ok(_) => { [INFO] [stderr] 86 | if let Err(e) = to_stream.write(&buffer) { [INFO] [stderr] 87 | eprintln!("Something bad happened writing to to_steam: {}", e); [INFO] [stderr] 88 | return Err(()); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | / match stream_to_stream_non_blocking(&incoming, &outgoing) { [INFO] [stderr] 32 | | Err(_) => break, [INFO] [stderr] 33 | | _ => {} [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________________________^ help: try this: `if let Err(_) = stream_to_stream_non_blocking(&incoming, &outgoing) { break }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:36:21 [INFO] [stderr] | [INFO] [stderr] 36 | tx1.send(()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | incoming.shutdown(Shutdown::Read); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:38:21 [INFO] [stderr] | [INFO] [stderr] 38 | outgoing.shutdown(Shutdown::Write); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:49:25 [INFO] [stderr] | [INFO] [stderr] 49 | / match stream_to_stream_non_blocking(&outgoing2, &incoming2) { [INFO] [stderr] 50 | | Err(_) => break, [INFO] [stderr] 51 | | _ => {} [INFO] [stderr] 52 | | } [INFO] [stderr] | |_________________________^ help: try this: `if let Err(_) = stream_to_stream_non_blocking(&outgoing2, &incoming2) { break }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | tx2.send(()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:55:21 [INFO] [stderr] | [INFO] [stderr] 55 | outgoing2.shutdown(Shutdown::Read); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | incoming2.shutdown(Shutdown::Write); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | / match stream_to_stream_non_blocking(&incoming, &outgoing) { [INFO] [stderr] 32 | | Err(_) => break, [INFO] [stderr] 33 | | _ => {} [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________________________^ help: try this: `if let Err(_) = stream_to_stream_non_blocking(&incoming, &outgoing) { break }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:36:21 [INFO] [stderr] | [INFO] [stderr] 36 | tx1.send(()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | incoming.shutdown(Shutdown::Read); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:38:21 [INFO] [stderr] | [INFO] [stderr] 38 | outgoing.shutdown(Shutdown::Write); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:49:25 [INFO] [stderr] | [INFO] [stderr] 49 | / match stream_to_stream_non_blocking(&outgoing2, &incoming2) { [INFO] [stderr] 50 | | Err(_) => break, [INFO] [stderr] 51 | | _ => {} [INFO] [stderr] 52 | | } [INFO] [stderr] | |_________________________^ help: try this: `if let Err(_) = stream_to_stream_non_blocking(&outgoing2, &incoming2) { break }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | tx2.send(()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:55:21 [INFO] [stderr] | [INFO] [stderr] 55 | outgoing2.shutdown(Shutdown::Read); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | incoming2.shutdown(Shutdown::Write); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.84s [INFO] running `"docker" "inspect" "456d8e41fdb31b8cfb9ba38e67f1edde329abd7fa90f6c5130938ef5d73ce7e2"` [INFO] running `"docker" "rm" "-f" "456d8e41fdb31b8cfb9ba38e67f1edde329abd7fa90f6c5130938ef5d73ce7e2"` [INFO] [stdout] 456d8e41fdb31b8cfb9ba38e67f1edde329abd7fa90f6c5130938ef5d73ce7e2