[INFO] updating cached repository FrontMage/servo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/FrontMage/servo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/FrontMage/servo" "work/ex/clippy-test-run/sources/stable/gh/FrontMage/servo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/FrontMage/servo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/FrontMage/servo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FrontMage/servo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FrontMage/servo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6246b036d717e13b19e8e2500ab3d2823416a2a7 [INFO] sha for GitHub repo FrontMage/servo: 6246b036d717e13b19e8e2500ab3d2823416a2a7 [INFO] validating manifest of FrontMage/servo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of FrontMage/servo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing FrontMage/servo [INFO] finished frobbing FrontMage/servo [INFO] frobbed toml for FrontMage/servo written to work/ex/clippy-test-run/sources/stable/gh/FrontMage/servo/Cargo.toml [INFO] started frobbing FrontMage/servo [INFO] finished frobbing FrontMage/servo [INFO] frobbed toml for FrontMage/servo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FrontMage/servo/Cargo.toml [INFO] crate FrontMage/servo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting FrontMage/servo against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FrontMage/servo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fac374413e803efe292b25322289205e457f386527d842093ef87837d475b265 [INFO] running `"docker" "start" "-a" "fac374413e803efe292b25322289205e457f386527d842093ef87837d475b265"` [INFO] [stderr] Checking servo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | query: query, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `query` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | method: method, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/response.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | query: query, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `query` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | method: method, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/response.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / return match stream.read(&mut buf) { [INFO] [stderr] 60 | | Ok(_) => Ok(String::from_utf8_lossy(&buf).into_owned()), [INFO] [stderr] 61 | | Err(e) => { [INFO] [stderr] 62 | | Err(Error { [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 59 | match stream.read(&mut buf) { [INFO] [stderr] 60 | Ok(_) => Ok(String::from_utf8_lossy(&buf).into_owned()), [INFO] [stderr] 61 | Err(e) => { [INFO] [stderr] 62 | Err(Error { [INFO] [stderr] 63 | code: 500, [INFO] [stderr] 64 | level: "Critical".to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | / return match self.stream.write(&response) { [INFO] [stderr] 51 | | Ok(_) => Ok("Response sent".to_string()), [INFO] [stderr] 52 | | Err(e) => Err(e), [INFO] [stderr] 53 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 50 | match self.stream.write(&response) { [INFO] [stderr] 51 | Ok(_) => Ok("Response sent".to_string()), [INFO] [stderr] 52 | Err(e) => Err(e), [INFO] [stderr] 53 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / return match File::open(file_path) { [INFO] [stderr] 34 | | Ok(file) => read_file(file), [INFO] [stderr] 35 | | Err(e) => { [INFO] [stderr] 36 | | Err(Error { [INFO] [stderr] ... | [INFO] [stderr] 41 | | } [INFO] [stderr] 42 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | match File::open(file_path) { [INFO] [stderr] 34 | Ok(file) => read_file(file), [INFO] [stderr] 35 | Err(e) => { [INFO] [stderr] 36 | Err(Error { [INFO] [stderr] 37 | code: 404, [INFO] [stderr] 38 | msg: format!("Not Found: {}", file_path), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / return match file.read_to_end(&mut buf) { [INFO] [stderr] 48 | | Ok(_) => chunk_encode(buf), [INFO] [stderr] 49 | | Err(e) => { [INFO] [stderr] 50 | | Err(Error { [INFO] [stderr] ... | [INFO] [stderr] 55 | | } [INFO] [stderr] 56 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 47 | match file.read_to_end(&mut buf) { [INFO] [stderr] 48 | Ok(_) => chunk_encode(buf), [INFO] [stderr] 49 | Err(e) => { [INFO] [stderr] 50 | Err(Error { [INFO] [stderr] 51 | code: 500, [INFO] [stderr] 52 | msg: "Read file error".to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / return match stream.read(&mut buf) { [INFO] [stderr] 60 | | Ok(_) => Ok(String::from_utf8_lossy(&buf).into_owned()), [INFO] [stderr] 61 | | Err(e) => { [INFO] [stderr] 62 | | Err(Error { [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 59 | match stream.read(&mut buf) { [INFO] [stderr] 60 | Ok(_) => Ok(String::from_utf8_lossy(&buf).into_owned()), [INFO] [stderr] 61 | Err(e) => { [INFO] [stderr] 62 | Err(Error { [INFO] [stderr] 63 | code: 500, [INFO] [stderr] 64 | level: "Critical".to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | / return match self.stream.write(&response) { [INFO] [stderr] 51 | | Ok(_) => Ok("Response sent".to_string()), [INFO] [stderr] 52 | | Err(e) => Err(e), [INFO] [stderr] 53 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 50 | match self.stream.write(&response) { [INFO] [stderr] 51 | Ok(_) => Ok("Response sent".to_string()), [INFO] [stderr] 52 | Err(e) => Err(e), [INFO] [stderr] 53 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / return match File::open(file_path) { [INFO] [stderr] 34 | | Ok(file) => read_file(file), [INFO] [stderr] 35 | | Err(e) => { [INFO] [stderr] 36 | | Err(Error { [INFO] [stderr] ... | [INFO] [stderr] 41 | | } [INFO] [stderr] 42 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | match File::open(file_path) { [INFO] [stderr] 34 | Ok(file) => read_file(file), [INFO] [stderr] 35 | Err(e) => { [INFO] [stderr] 36 | Err(Error { [INFO] [stderr] 37 | code: 404, [INFO] [stderr] 38 | msg: format!("Not Found: {}", file_path), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / return match file.read_to_end(&mut buf) { [INFO] [stderr] 48 | | Ok(_) => chunk_encode(buf), [INFO] [stderr] 49 | | Err(e) => { [INFO] [stderr] 50 | | Err(Error { [INFO] [stderr] ... | [INFO] [stderr] 55 | | } [INFO] [stderr] 56 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 47 | match file.read_to_end(&mut buf) { [INFO] [stderr] 48 | Ok(_) => chunk_encode(buf), [INFO] [stderr] 49 | Err(e) => { [INFO] [stderr] 50 | Err(Error { [INFO] [stderr] 51 | code: 500, [INFO] [stderr] 52 | msg: "Read file error".to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/request.rs:33:50 [INFO] [stderr] | [INFO] [stderr] 33 | let lines: Vec<&str> = headers.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/request.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | fn get_request_string<'a>(mut stream: &TcpStream) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/request.rs:73:65 [INFO] [stderr] | [INFO] [stderr] 73 | let path: Vec<&str> = req_str.lines().next().unwrap().split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/request.rs:75:68 [INFO] [stderr] | [INFO] [stderr] 75 | let path_query_string_vec: Vec<&str> = path_query_string.split("?").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/request.rs:77:70 [INFO] [stderr] | [INFO] [stderr] 77 | let query_string: Vec<&str> = path_query_string_vec[1].split("&").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'&'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/request.rs:80:39 [INFO] [stderr] | [INFO] [stderr] 80 | let key = key_value.split("=").collect::>()[0]; [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/request.rs:81:41 [INFO] [stderr] | [INFO] [stderr] 81 | let value = key_value.split("=").collect::>()[1]; [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/request.rs:91:67 [INFO] [stderr] | [INFO] [stderr] 91 | let method: Vec<&str> = req_str.lines().next().unwrap().split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/request.rs:96:65 [INFO] [stderr] | [INFO] [stderr] 96 | let path: Vec<&str> = req_str.lines().next().unwrap().split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/request.rs:98:68 [INFO] [stderr] | [INFO] [stderr] 98 | let path_query_string_vec: Vec<&str> = path_query_string.split("?").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:13:54 [INFO] [stderr] | [INFO] [stderr] 13 | println!("Listening for connections on port {}", 9527); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/request.rs:33:50 [INFO] [stderr] | [INFO] [stderr] 33 | let lines: Vec<&str> = headers.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:13:54 [INFO] [stderr] | [INFO] [stderr] 13 | println!("Listening for connections on port {}", 9527); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/request.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | fn get_request_string<'a>(mut stream: &TcpStream) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/request.rs:73:65 [INFO] [stderr] | [INFO] [stderr] 73 | let path: Vec<&str> = req_str.lines().next().unwrap().split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/request.rs:75:68 [INFO] [stderr] | [INFO] [stderr] 75 | let path_query_string_vec: Vec<&str> = path_query_string.split("?").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/request.rs:77:70 [INFO] [stderr] | [INFO] [stderr] 77 | let query_string: Vec<&str> = path_query_string_vec[1].split("&").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'&'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/request.rs:80:39 [INFO] [stderr] | [INFO] [stderr] 80 | let key = key_value.split("=").collect::>()[0]; [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/request.rs:81:41 [INFO] [stderr] | [INFO] [stderr] 81 | let value = key_value.split("=").collect::>()[1]; [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/request.rs:91:67 [INFO] [stderr] | [INFO] [stderr] 91 | let method: Vec<&str> = req_str.lines().next().unwrap().split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/request.rs:96:65 [INFO] [stderr] | [INFO] [stderr] 96 | let path: Vec<&str> = req_str.lines().next().unwrap().split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/request.rs:98:68 [INFO] [stderr] | [INFO] [stderr] 98 | let path_query_string_vec: Vec<&str> = path_query_string.split("?").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | .expect(&format!("Failed to send response: {}", &e.msg)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to send response: {}", &e.msg))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | .expect(&format!("Failed to send response: {}", &e.msg)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to send response: {}", &e.msg))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.50s [INFO] running `"docker" "inspect" "fac374413e803efe292b25322289205e457f386527d842093ef87837d475b265"` [INFO] running `"docker" "rm" "-f" "fac374413e803efe292b25322289205e457f386527d842093ef87837d475b265"` [INFO] [stdout] fac374413e803efe292b25322289205e457f386527d842093ef87837d475b265