[INFO] updating cached repository FrogBomb/ulam_spiral [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/FrogBomb/ulam_spiral [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/FrogBomb/ulam_spiral" "work/ex/clippy-test-run/sources/stable/gh/FrogBomb/ulam_spiral"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/FrogBomb/ulam_spiral'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/FrogBomb/ulam_spiral" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FrogBomb/ulam_spiral"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FrogBomb/ulam_spiral'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dceecb927deda5de5b20e09bd5236cd2ed318326 [INFO] sha for GitHub repo FrogBomb/ulam_spiral: dceecb927deda5de5b20e09bd5236cd2ed318326 [INFO] validating manifest of FrogBomb/ulam_spiral on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of FrogBomb/ulam_spiral on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing FrogBomb/ulam_spiral [INFO] finished frobbing FrogBomb/ulam_spiral [INFO] frobbed toml for FrogBomb/ulam_spiral written to work/ex/clippy-test-run/sources/stable/gh/FrogBomb/ulam_spiral/Cargo.toml [INFO] started frobbing FrogBomb/ulam_spiral [INFO] finished frobbing FrogBomb/ulam_spiral [INFO] frobbed toml for FrogBomb/ulam_spiral written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FrogBomb/ulam_spiral/Cargo.toml [INFO] crate FrogBomb/ulam_spiral has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting FrogBomb/ulam_spiral against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FrogBomb/ulam_spiral:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8eb80852bf6ccac5958d5106f94b10d3c9206df45bf655778da9c33dbd8530b3 [INFO] running `"docker" "start" "-a" "8eb80852bf6ccac5958d5106f94b10d3c9206df45bf655778da9c33dbd8530b3"` [INFO] [stderr] Checking deflate v0.7.4 [INFO] [stderr] Checking concurrent_prime_sieve v0.2.2 [INFO] [stderr] Checking num-rational v0.1.35 [INFO] [stderr] Checking rayon v0.6.0 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Checking jpeg-decoder v0.1.11 [INFO] [stderr] Checking image v0.12.2 [INFO] [stderr] Checking ulam_spiral v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/draw_spiral.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | img [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/draw_spiral.rs:42:15 [INFO] [stderr] | [INFO] [stderr] 42 | let img = ImageBuffer::from_fn(x_size as u32, x_size as u32, |x, y| { [INFO] [stderr] | _______________^ [INFO] [stderr] 43 | | match from_vec[point_on_spiral_to_array_index(x_size, x as usize, y as usize)] { [INFO] [stderr] 44 | | true => image::Luma([0u8]), [INFO] [stderr] 45 | | false => image::Luma([255u8]), [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | }); [INFO] [stderr] | |______^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/draw_spiral.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | let ref mut four = File::create(w_path).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^--------------------------------- help: try: `let four = &mut File::create(w_path).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/draw_spiral.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / match from_vec[point_on_spiral_to_array_index(x_size, x as usize, y as usize)] { [INFO] [stderr] 44 | | true => image::Luma([0u8]), [INFO] [stderr] 45 | | false => image::Luma([255u8]), [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if from_vec[point_on_spiral_to_array_index(x_size, x as usize, y as usize)] { image::Luma([0u8]) } else { image::Luma([255u8]) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:11:32 [INFO] [stderr] | [INFO] [stderr] 11 | fn get_size_from_env(env_args: &Vec, default_size: usize) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/draw_spiral.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | img [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/draw_spiral.rs:42:15 [INFO] [stderr] | [INFO] [stderr] 42 | let img = ImageBuffer::from_fn(x_size as u32, x_size as u32, |x, y| { [INFO] [stderr] | _______________^ [INFO] [stderr] 43 | | match from_vec[point_on_spiral_to_array_index(x_size, x as usize, y as usize)] { [INFO] [stderr] 44 | | true => image::Luma([0u8]), [INFO] [stderr] 45 | | false => image::Luma([255u8]), [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | }); [INFO] [stderr] | |______^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/draw_spiral.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | let ref mut four = File::create(w_path).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^--------------------------------- help: try: `let four = &mut File::create(w_path).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/draw_spiral.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / match from_vec[point_on_spiral_to_array_index(x_size, x as usize, y as usize)] { [INFO] [stderr] 44 | | true => image::Luma([0u8]), [INFO] [stderr] 45 | | false => image::Luma([255u8]), [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if from_vec[point_on_spiral_to_array_index(x_size, x as usize, y as usize)] { image::Luma([0u8]) } else { image::Luma([255u8]) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:11:32 [INFO] [stderr] | [INFO] [stderr] 11 | fn get_size_from_env(env_args: &Vec, default_size: usize) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.18s [INFO] running `"docker" "inspect" "8eb80852bf6ccac5958d5106f94b10d3c9206df45bf655778da9c33dbd8530b3"` [INFO] running `"docker" "rm" "-f" "8eb80852bf6ccac5958d5106f94b10d3c9206df45bf655778da9c33dbd8530b3"` [INFO] [stdout] 8eb80852bf6ccac5958d5106f94b10d3c9206df45bf655778da9c33dbd8530b3