[INFO] updating cached repository Freyert/sortssortssorts [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Freyert/sortssortssorts [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Freyert/sortssortssorts" "work/ex/clippy-test-run/sources/stable/gh/Freyert/sortssortssorts"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Freyert/sortssortssorts'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Freyert/sortssortssorts" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Freyert/sortssortssorts"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Freyert/sortssortssorts'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3e2997c94402485f447e6eb95926495413cc79e1 [INFO] sha for GitHub repo Freyert/sortssortssorts: 3e2997c94402485f447e6eb95926495413cc79e1 [INFO] validating manifest of Freyert/sortssortssorts on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Freyert/sortssortssorts on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Freyert/sortssortssorts [INFO] finished frobbing Freyert/sortssortssorts [INFO] frobbed toml for Freyert/sortssortssorts written to work/ex/clippy-test-run/sources/stable/gh/Freyert/sortssortssorts/Cargo.toml [INFO] started frobbing Freyert/sortssortssorts [INFO] finished frobbing Freyert/sortssortssorts [INFO] frobbed toml for Freyert/sortssortssorts written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Freyert/sortssortssorts/Cargo.toml [INFO] crate Freyert/sortssortssorts has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Freyert/sortssortssorts against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Freyert/sortssortssorts:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 67f2fde30e9383d6f80fabeaebd02cfbdfcda84f3106949efb19ddd638d98f40 [INFO] running `"docker" "start" "-a" "67f2fde30e9383d6f80fabeaebd02cfbdfcda84f3106949efb19ddd638d98f40"` [INFO] [stderr] Checking sortssortssorts v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/bubble.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if swapped == false { break 'outer } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!swapped` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/merge.rs:8:46 [INFO] [stderr] | [INFO] [stderr] 8 | fn bottom_up_merge(a: &mut Vec, i_left: &usize, i_right: &usize, i_end: &usize, b: &mut Vec) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/merge.rs:8:63 [INFO] [stderr] | [INFO] [stderr] 8 | fn bottom_up_merge(a: &mut Vec, i_left: &usize, i_right: &usize, i_end: &usize, b: &mut Vec) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/merge.rs:8:78 [INFO] [stderr] | [INFO] [stderr] 8 | fn bottom_up_merge(a: &mut Vec, i_left: &usize, i_right: &usize, i_end: &usize, b: &mut Vec) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is only used to index `b`. [INFO] [stderr] --> src/merge.rs:11:14 [INFO] [stderr] | [INFO] [stderr] 11 | for k in *i_left..*i_end { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 11 | for in b.iter_mut().take(*i_end).skip(*i_left) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/merge.rs:17:12 [INFO] [stderr] | [INFO] [stderr] 17 | left_head = left_head + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `left_head += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/merge.rs:20:12 [INFO] [stderr] | [INFO] [stderr] 20 | right_head = right_head + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `right_head += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/bubble.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if swapped == false { break 'outer } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!swapped` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/merge.rs:8:46 [INFO] [stderr] | [INFO] [stderr] 8 | fn bottom_up_merge(a: &mut Vec, i_left: &usize, i_right: &usize, i_end: &usize, b: &mut Vec) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/merge.rs:8:63 [INFO] [stderr] | [INFO] [stderr] 8 | fn bottom_up_merge(a: &mut Vec, i_left: &usize, i_right: &usize, i_end: &usize, b: &mut Vec) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/merge.rs:8:78 [INFO] [stderr] | [INFO] [stderr] 8 | fn bottom_up_merge(a: &mut Vec, i_left: &usize, i_right: &usize, i_end: &usize, b: &mut Vec) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is only used to index `b`. [INFO] [stderr] --> src/merge.rs:11:14 [INFO] [stderr] | [INFO] [stderr] 11 | for k in *i_left..*i_end { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 11 | for in b.iter_mut().take(*i_end).skip(*i_left) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/merge.rs:17:12 [INFO] [stderr] | [INFO] [stderr] 17 | left_head = left_head + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `left_head += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/merge.rs:20:12 [INFO] [stderr] | [INFO] [stderr] 20 | right_head = right_head + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `right_head += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bubble.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `sortssortssorts`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "67f2fde30e9383d6f80fabeaebd02cfbdfcda84f3106949efb19ddd638d98f40"` [INFO] running `"docker" "rm" "-f" "67f2fde30e9383d6f80fabeaebd02cfbdfcda84f3106949efb19ddd638d98f40"` [INFO] [stdout] 67f2fde30e9383d6f80fabeaebd02cfbdfcda84f3106949efb19ddd638d98f40