[INFO] updating cached repository FreeMasen/cs_to_ts [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/FreeMasen/cs_to_ts [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/FreeMasen/cs_to_ts" "work/ex/clippy-test-run/sources/stable/gh/FreeMasen/cs_to_ts"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/FreeMasen/cs_to_ts'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/FreeMasen/cs_to_ts" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FreeMasen/cs_to_ts"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FreeMasen/cs_to_ts'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3bc5c16a489a9e0735d7be0e18b7865543da0532 [INFO] sha for GitHub repo FreeMasen/cs_to_ts: 3bc5c16a489a9e0735d7be0e18b7865543da0532 [INFO] validating manifest of FreeMasen/cs_to_ts on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of FreeMasen/cs_to_ts on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing FreeMasen/cs_to_ts [INFO] finished frobbing FreeMasen/cs_to_ts [INFO] frobbed toml for FreeMasen/cs_to_ts written to work/ex/clippy-test-run/sources/stable/gh/FreeMasen/cs_to_ts/Cargo.toml [INFO] started frobbing FreeMasen/cs_to_ts [INFO] finished frobbing FreeMasen/cs_to_ts [INFO] frobbed toml for FreeMasen/cs_to_ts written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FreeMasen/cs_to_ts/Cargo.toml [INFO] crate FreeMasen/cs_to_ts has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting FreeMasen/cs_to_ts against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FreeMasen/cs_to_ts:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b92762be1a925e754b3e49eaaeffd187945e180e2ad640284edfa94e5ee726d7 [INFO] running `"docker" "start" "-a" "b92762be1a925e754b3e49eaaeffd187945e180e2ad640284edfa94e5ee726d7"` [INFO] [stderr] Checking cs_to_ts v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `ret` [INFO] [stderr] --> src/c_sharp.rs:151:17 [INFO] [stderr] | [INFO] [stderr] 151 | let ret = parts.0; [INFO] [stderr] | ^^^ help: consider using `_ret` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `default` [INFO] [stderr] --> src/c_sharp.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | fn default() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `default` [INFO] [stderr] --> src/c_sharp.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn default() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/c_sharp.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | / match self.check_line(line.expect("Unable to read line")) { [INFO] [stderr] 26 | | Some(prop) => { [INFO] [stderr] 27 | | match prop.data_type { [INFO] [stderr] 28 | | DataType::Class => { [INFO] [stderr] ... | [INFO] [stderr] 52 | | None => (), [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 25 | if let Some(prop) = self.check_line(line.expect("Unable to read line")) { [INFO] [stderr] 26 | match prop.data_type { [INFO] [stderr] 27 | DataType::Class => { [INFO] [stderr] 28 | classes.push( [INFO] [stderr] 29 | Class { [INFO] [stderr] 30 | name: prop.name, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/c_sharp.rs:84:34 [INFO] [stderr] | [INFO] [stderr] 84 | } else if line.ends_with(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/c_sharp.rs:92:37 [INFO] [stderr] | [INFO] [stderr] 92 | if let Some(_i) = line.find("(") { [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/c_sharp.rs:101:53 [INFO] [stderr] | [INFO] [stderr] 101 | let (name, dt) = if let Some(i) = line.find(" ") { [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/c_sharp.rs:121:27 [INFO] [stderr] | [INFO] [stderr] 121 | if line.ends_with(")") || line.ends_with("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/c_sharp.rs:121:50 [INFO] [stderr] | [INFO] [stderr] 121 | if line.ends_with(")") || line.ends_with("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/c_sharp.rs:132:47 [INFO] [stderr] | [INFO] [stderr] 132 | let optional = if data_type.ends_with("?") { [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/c_sharp.rs:146:35 [INFO] [stderr] | [INFO] [stderr] 146 | let arg_start = line.find("("); [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/c_sharp.rs:147:37 [INFO] [stderr] | [INFO] [stderr] 147 | let first_space = line.find(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/c_sharp.rs:160:62 [INFO] [stderr] | [INFO] [stderr] 160 | let (ret, optional) = if first_split.0.ends_with("?") { [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/c_sharp.rs:199:18 [INFO] [stderr] | [INFO] [stderr] 199 | fn to_string(self) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/c_sharp.rs:234:18 [INFO] [stderr] | [INFO] [stderr] 234 | fn to_string(self) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/c_sharp.rs:238:42 [INFO] [stderr] | [INFO] [stderr] 238 | let postfix: String = if val_str.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!val_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/c_sharp.rs:306:18 [INFO] [stderr] | [INFO] [stderr] 306 | fn to_string(self) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ret` [INFO] [stderr] --> src/c_sharp.rs:151:17 [INFO] [stderr] | [INFO] [stderr] 151 | let ret = parts.0; [INFO] [stderr] | ^^^ help: consider using `_ret` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `default` [INFO] [stderr] --> src/c_sharp.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | fn default() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `default` [INFO] [stderr] --> src/c_sharp.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn default() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/c_sharp.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | / match self.check_line(line.expect("Unable to read line")) { [INFO] [stderr] 26 | | Some(prop) => { [INFO] [stderr] 27 | | match prop.data_type { [INFO] [stderr] 28 | | DataType::Class => { [INFO] [stderr] ... | [INFO] [stderr] 52 | | None => (), [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 25 | if let Some(prop) = self.check_line(line.expect("Unable to read line")) { [INFO] [stderr] 26 | match prop.data_type { [INFO] [stderr] 27 | DataType::Class => { [INFO] [stderr] 28 | classes.push( [INFO] [stderr] 29 | Class { [INFO] [stderr] 30 | name: prop.name, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/c_sharp.rs:84:34 [INFO] [stderr] | [INFO] [stderr] 84 | } else if line.ends_with(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/c_sharp.rs:92:37 [INFO] [stderr] | [INFO] [stderr] 92 | if let Some(_i) = line.find("(") { [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/c_sharp.rs:101:53 [INFO] [stderr] | [INFO] [stderr] 101 | let (name, dt) = if let Some(i) = line.find(" ") { [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/c_sharp.rs:121:27 [INFO] [stderr] | [INFO] [stderr] 121 | if line.ends_with(")") || line.ends_with("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/c_sharp.rs:121:50 [INFO] [stderr] | [INFO] [stderr] 121 | if line.ends_with(")") || line.ends_with("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/c_sharp.rs:132:47 [INFO] [stderr] | [INFO] [stderr] 132 | let optional = if data_type.ends_with("?") { [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/c_sharp.rs:146:35 [INFO] [stderr] | [INFO] [stderr] 146 | let arg_start = line.find("("); [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/c_sharp.rs:147:37 [INFO] [stderr] | [INFO] [stderr] 147 | let first_space = line.find(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/c_sharp.rs:160:62 [INFO] [stderr] | [INFO] [stderr] 160 | let (ret, optional) = if first_split.0.ends_with("?") { [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/c_sharp.rs:199:18 [INFO] [stderr] | [INFO] [stderr] 199 | fn to_string(self) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/c_sharp.rs:234:18 [INFO] [stderr] | [INFO] [stderr] 234 | fn to_string(self) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/c_sharp.rs:238:42 [INFO] [stderr] | [INFO] [stderr] 238 | let postfix: String = if val_str.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!val_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/c_sharp.rs:306:18 [INFO] [stderr] | [INFO] [stderr] 306 | fn to_string(self) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.35s [INFO] running `"docker" "inspect" "b92762be1a925e754b3e49eaaeffd187945e180e2ad640284edfa94e5ee726d7"` [INFO] running `"docker" "rm" "-f" "b92762be1a925e754b3e49eaaeffd187945e180e2ad640284edfa94e5ee726d7"` [INFO] [stdout] b92762be1a925e754b3e49eaaeffd187945e180e2ad640284edfa94e5ee726d7