[INFO] updating cached repository FranklinChen/baker-samefringe-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/FranklinChen/baker-samefringe-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/FranklinChen/baker-samefringe-rust" "work/ex/clippy-test-run/sources/stable/gh/FranklinChen/baker-samefringe-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/FranklinChen/baker-samefringe-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/FranklinChen/baker-samefringe-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FranklinChen/baker-samefringe-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FranklinChen/baker-samefringe-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7ababe2474a14033a21a039955aef4cb5584f4eb [INFO] sha for GitHub repo FranklinChen/baker-samefringe-rust: 7ababe2474a14033a21a039955aef4cb5584f4eb [INFO] validating manifest of FranklinChen/baker-samefringe-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of FranklinChen/baker-samefringe-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing FranklinChen/baker-samefringe-rust [INFO] finished frobbing FranklinChen/baker-samefringe-rust [INFO] frobbed toml for FranklinChen/baker-samefringe-rust written to work/ex/clippy-test-run/sources/stable/gh/FranklinChen/baker-samefringe-rust/Cargo.toml [INFO] started frobbing FranklinChen/baker-samefringe-rust [INFO] finished frobbing FranklinChen/baker-samefringe-rust [INFO] frobbed toml for FranklinChen/baker-samefringe-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FranklinChen/baker-samefringe-rust/Cargo.toml [INFO] crate FranklinChen/baker-samefringe-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting FranklinChen/baker-samefringe-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FranklinChen/baker-samefringe-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 80c6c565d2a7c7ee237b820c8cc23c3a9553296305236a86516936f9ffa60938 [INFO] running `"docker" "start" "-a" "80c6c565d2a7c7ee237b820c8cc23c3a9553296305236a86516936f9ffa60938"` [INFO] [stderr] Checking baker-samefringe-rust v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/immutable.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / match self { [INFO] [stderr] 17 | | &Leaf(ref leaf) => [INFO] [stderr] 18 | | Leaf(f(leaf)), [INFO] [stderr] 19 | | &Forest(ref forest) => [INFO] [stderr] ... | [INFO] [stderr] 22 | | .collect()) [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 16 | match *self { [INFO] [stderr] 17 | Leaf(ref leaf) => [INFO] [stderr] 18 | Leaf(f(leaf)), [INFO] [stderr] 19 | Forest(ref forest) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/immutable.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / match self { [INFO] [stderr] 54 | | &Leaf(ref leaf) => [INFO] [stderr] 55 | | f(init, leaf), [INFO] [stderr] 56 | | &Forest(ref forest) => [INFO] [stderr] 57 | | forest.iter() [INFO] [stderr] 58 | | .fold(init, |b, tree| tree.fold(b, f)) [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 53 | match *self { [INFO] [stderr] 54 | Leaf(ref leaf) => [INFO] [stderr] 55 | f(init, leaf), [INFO] [stderr] 56 | Forest(ref forest) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/iterators.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn iter<'a>(&'a self) -> Iter<'a, T> { [INFO] [stderr] 11 | | Iter { [INFO] [stderr] 12 | | stack: vec![self] [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/iterators.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn iter_mut<'a>(&'a mut self) -> IterMut<'a, T> { [INFO] [stderr] 18 | | IterMut { [INFO] [stderr] 19 | | stack: vec![self] [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/iterators.rs:69:31 [INFO] [stderr] | [INFO] [stderr] 69 | Some(tree) => match tree { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 70 | | &Tree::Leaf(ref leaf) => [INFO] [stderr] 71 | | return Some(leaf), [INFO] [stderr] 72 | | &Tree::Forest(ref forest) => { [INFO] [stderr] ... | [INFO] [stderr] 79 | | [INFO] [stderr] 80 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 69 | Some(tree) => match *tree { [INFO] [stderr] 70 | Tree::Leaf(ref leaf) => [INFO] [stderr] 71 | return Some(leaf), [INFO] [stderr] 72 | Tree::Forest(ref forest) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/iterators.rs:97:31 [INFO] [stderr] | [INFO] [stderr] 97 | Some(tree) => match tree { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 98 | | &mut Tree::Leaf(ref mut leaf) => [INFO] [stderr] 99 | | return Some(leaf), [INFO] [stderr] 100 | | &mut Tree::Forest(ref mut forest) => { [INFO] [stderr] ... | [INFO] [stderr] 107 | | [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 97 | Some(tree) => match *tree { [INFO] [stderr] 98 | Tree::Leaf(ref mut leaf) => [INFO] [stderr] 99 | return Some(leaf), [INFO] [stderr] 100 | Tree::Forest(ref mut forest) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/algorithm/continuations.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / match tree { [INFO] [stderr] 63 | | &Tree::Leaf(ref leaf) => c.0(Some((leaf, g))), [INFO] [stderr] 64 | | &Tree::Forest(ref forest) => gen_fringe_l(&forest, c, g) [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 62 | match *tree { [INFO] [stderr] 63 | Tree::Leaf(ref leaf) => c.0(Some((leaf, g))), [INFO] [stderr] 64 | Tree::Forest(ref forest) => gen_fringe_l(&forest, c, g) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/immutable.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / match self { [INFO] [stderr] 17 | | &Leaf(ref leaf) => [INFO] [stderr] 18 | | Leaf(f(leaf)), [INFO] [stderr] 19 | | &Forest(ref forest) => [INFO] [stderr] ... | [INFO] [stderr] 22 | | .collect()) [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 16 | match *self { [INFO] [stderr] 17 | Leaf(ref leaf) => [INFO] [stderr] 18 | Leaf(f(leaf)), [INFO] [stderr] 19 | Forest(ref forest) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/immutable.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / match self { [INFO] [stderr] 54 | | &Leaf(ref leaf) => [INFO] [stderr] 55 | | f(init, leaf), [INFO] [stderr] 56 | | &Forest(ref forest) => [INFO] [stderr] 57 | | forest.iter() [INFO] [stderr] 58 | | .fold(init, |b, tree| tree.fold(b, f)) [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 53 | match *self { [INFO] [stderr] 54 | Leaf(ref leaf) => [INFO] [stderr] 55 | f(init, leaf), [INFO] [stderr] 56 | Forest(ref forest) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/iterators.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn iter<'a>(&'a self) -> Iter<'a, T> { [INFO] [stderr] 11 | | Iter { [INFO] [stderr] 12 | | stack: vec![self] [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/iterators.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn iter_mut<'a>(&'a mut self) -> IterMut<'a, T> { [INFO] [stderr] 18 | | IterMut { [INFO] [stderr] 19 | | stack: vec![self] [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/iterators.rs:69:31 [INFO] [stderr] | [INFO] [stderr] 69 | Some(tree) => match tree { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 70 | | &Tree::Leaf(ref leaf) => [INFO] [stderr] 71 | | return Some(leaf), [INFO] [stderr] 72 | | &Tree::Forest(ref forest) => { [INFO] [stderr] ... | [INFO] [stderr] 79 | | [INFO] [stderr] 80 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 69 | Some(tree) => match *tree { [INFO] [stderr] 70 | Tree::Leaf(ref leaf) => [INFO] [stderr] 71 | return Some(leaf), [INFO] [stderr] 72 | Tree::Forest(ref forest) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/iterators.rs:97:31 [INFO] [stderr] | [INFO] [stderr] 97 | Some(tree) => match tree { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 98 | | &mut Tree::Leaf(ref mut leaf) => [INFO] [stderr] 99 | | return Some(leaf), [INFO] [stderr] 100 | | &mut Tree::Forest(ref mut forest) => { [INFO] [stderr] ... | [INFO] [stderr] 107 | | [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 97 | Some(tree) => match *tree { [INFO] [stderr] 98 | Tree::Leaf(ref mut leaf) => [INFO] [stderr] 99 | return Some(leaf), [INFO] [stderr] 100 | Tree::Forest(ref mut forest) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/algorithm/continuations.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / match tree { [INFO] [stderr] 63 | | &Tree::Leaf(ref leaf) => c.0(Some((leaf, g))), [INFO] [stderr] 64 | | &Tree::Forest(ref forest) => gen_fringe_l(&forest, c, g) [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 62 | match *tree { [INFO] [stderr] 63 | Tree::Leaf(ref leaf) => c.0(Some((leaf, g))), [INFO] [stderr] 64 | Tree::Forest(ref forest) => gen_fringe_l(&forest, c, g) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.42s [INFO] running `"docker" "inspect" "80c6c565d2a7c7ee237b820c8cc23c3a9553296305236a86516936f9ffa60938"` [INFO] running `"docker" "rm" "-f" "80c6c565d2a7c7ee237b820c8cc23c3a9553296305236a86516936f9ffa60938"` [INFO] [stdout] 80c6c565d2a7c7ee237b820c8cc23c3a9553296305236a86516936f9ffa60938