[INFO] updating cached repository FrancisRussell/oocla-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/FrancisRussell/oocla-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/FrancisRussell/oocla-rs" "work/ex/clippy-test-run/sources/stable/gh/FrancisRussell/oocla-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/FrancisRussell/oocla-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/FrancisRussell/oocla-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FrancisRussell/oocla-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FrancisRussell/oocla-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2f0a130945068ef4b1f578a97032012cf750a861 [INFO] sha for GitHub repo FrancisRussell/oocla-rs: 2f0a130945068ef4b1f578a97032012cf750a861 [INFO] validating manifest of FrancisRussell/oocla-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of FrancisRussell/oocla-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing FrancisRussell/oocla-rs [INFO] finished frobbing FrancisRussell/oocla-rs [INFO] frobbed toml for FrancisRussell/oocla-rs written to work/ex/clippy-test-run/sources/stable/gh/FrancisRussell/oocla-rs/Cargo.toml [INFO] started frobbing FrancisRussell/oocla-rs [INFO] finished frobbing FrancisRussell/oocla-rs [INFO] frobbed toml for FrancisRussell/oocla-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FrancisRussell/oocla-rs/Cargo.toml [INFO] crate FrancisRussell/oocla-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting FrancisRussell/oocla-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FrancisRussell/oocla-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fa0c4e8f1e69b9e168f44ce1421bdee08301f7332a62b0bf7ecccdc12a95e322 [INFO] running `"docker" "start" "-a" "fa0c4e8f1e69b9e168f44ce1421bdee08301f7332a62b0bf7ecccdc12a95e322"` [INFO] [stderr] Checking nix v0.9.0 [INFO] [stderr] Checking ooc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dense_matrix.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dense_matrix.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dense_matrix.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dense_matrix.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | generator: generator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `generator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dense_matrix.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | generator: generator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `generator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dense_matrix.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dense_matrix.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dense_matrix.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dense_matrix.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | generator: generator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `generator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dense_matrix.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | generator: generator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `generator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/dense_matrix.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `slice` [INFO] [stderr] --> src/dense_matrix.rs:8:21 [INFO] [stderr] | [INFO] [stderr] 8 | use std::{mem, ptr, slice}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/dense_matrix.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `slice` [INFO] [stderr] --> src/dense_matrix.rs:8:21 [INFO] [stderr] | [INFO] [stderr] 8 | use std::{mem, ptr, slice}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_data_length_elements` [INFO] [stderr] --> src/dense_matrix.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | fn get_data_length_elements(&self) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `file` [INFO] [stderr] --> src/dense_matrix.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | file: File, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_data_length_elements` [INFO] [stderr] --> src/dense_matrix.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | fn get_data_length_elements(&self) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `file` [INFO] [stderr] --> src/dense_matrix.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | file: File, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/dense_matrix.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | (start as *mut u8).offset(HEADER_SIZE as isize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(start as *mut u8).add(HEADER_SIZE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/dense_matrix.rs:129:33 [INFO] [stderr] | [INFO] [stderr] 129 | fn get_header_mut(&self) -> &mut MatrixHeader { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mut_from_ref)] on by default [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/dense_matrix.rs:129:23 [INFO] [stderr] | [INFO] [stderr] 129 | fn get_header_mut(&self) -> &mut MatrixHeader { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/dense_matrix.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | / pub fn element_iter<'a>(&'a self) -> ElementIter<'a, T> { [INFO] [stderr] 153 | | let generator = self.create_index_generator(); [INFO] [stderr] 154 | | ElementIter { [INFO] [stderr] 155 | | lifetime: PhantomData, [INFO] [stderr] ... | [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/dense_matrix.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | / pub fn element_iter_mut<'a>(&'a mut self) -> ElementIterMut<'a, T> { [INFO] [stderr] 162 | | let generator = self.create_index_generator(); [INFO] [stderr] 163 | | ElementIterMut { [INFO] [stderr] 164 | | lifetime: PhantomData, [INFO] [stderr] ... | [INFO] [stderr] 167 | | } [INFO] [stderr] 168 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/dense_matrix.rs:233:35 [INFO] [stderr] | [INFO] [stderr] 233 | Some(idx) => unsafe { self.data.offset(idx as isize).as_ref() }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data.add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/dense_matrix.rs:260:35 [INFO] [stderr] | [INFO] [stderr] 260 | Some(idx) => unsafe { self.data.offset(idx as isize).as_mut() }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data.add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `ooc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/dense_matrix.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | (start as *mut u8).offset(HEADER_SIZE as isize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(start as *mut u8).add(HEADER_SIZE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/dense_matrix.rs:129:33 [INFO] [stderr] | [INFO] [stderr] 129 | fn get_header_mut(&self) -> &mut MatrixHeader { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mut_from_ref)] on by default [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/dense_matrix.rs:129:23 [INFO] [stderr] | [INFO] [stderr] 129 | fn get_header_mut(&self) -> &mut MatrixHeader { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/dense_matrix.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | / pub fn element_iter<'a>(&'a self) -> ElementIter<'a, T> { [INFO] [stderr] 153 | | let generator = self.create_index_generator(); [INFO] [stderr] 154 | | ElementIter { [INFO] [stderr] 155 | | lifetime: PhantomData, [INFO] [stderr] ... | [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/dense_matrix.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | / pub fn element_iter_mut<'a>(&'a mut self) -> ElementIterMut<'a, T> { [INFO] [stderr] 162 | | let generator = self.create_index_generator(); [INFO] [stderr] 163 | | ElementIterMut { [INFO] [stderr] 164 | | lifetime: PhantomData, [INFO] [stderr] ... | [INFO] [stderr] 167 | | } [INFO] [stderr] 168 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/dense_matrix.rs:233:35 [INFO] [stderr] | [INFO] [stderr] 233 | Some(idx) => unsafe { self.data.offset(idx as isize).as_ref() }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data.add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/dense_matrix.rs:260:35 [INFO] [stderr] | [INFO] [stderr] 260 | Some(idx) => unsafe { self.data.offset(idx as isize).as_mut() }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data.add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `ooc`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fa0c4e8f1e69b9e168f44ce1421bdee08301f7332a62b0bf7ecccdc12a95e322"` [INFO] running `"docker" "rm" "-f" "fa0c4e8f1e69b9e168f44ce1421bdee08301f7332a62b0bf7ecccdc12a95e322"` [INFO] [stdout] fa0c4e8f1e69b9e168f44ce1421bdee08301f7332a62b0bf7ecccdc12a95e322