[INFO] updating cached repository Fonan15/vier_gewinnt [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Fonan15/vier_gewinnt [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Fonan15/vier_gewinnt" "work/ex/clippy-test-run/sources/stable/gh/Fonan15/vier_gewinnt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Fonan15/vier_gewinnt'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Fonan15/vier_gewinnt" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Fonan15/vier_gewinnt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Fonan15/vier_gewinnt'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5b8a7901028c1cb6b9e5e5b15a36c8587e2cfec2 [INFO] sha for GitHub repo Fonan15/vier_gewinnt: 5b8a7901028c1cb6b9e5e5b15a36c8587e2cfec2 [INFO] validating manifest of Fonan15/vier_gewinnt on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Fonan15/vier_gewinnt on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Fonan15/vier_gewinnt [INFO] finished frobbing Fonan15/vier_gewinnt [INFO] frobbed toml for Fonan15/vier_gewinnt written to work/ex/clippy-test-run/sources/stable/gh/Fonan15/vier_gewinnt/Cargo.toml [INFO] started frobbing Fonan15/vier_gewinnt [INFO] finished frobbing Fonan15/vier_gewinnt [INFO] frobbed toml for Fonan15/vier_gewinnt written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Fonan15/vier_gewinnt/Cargo.toml [INFO] crate Fonan15/vier_gewinnt has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Fonan15/vier_gewinnt against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Fonan15/vier_gewinnt:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b4dbfa51dd06bb6ac98733e54d789a250c17f5fc8ccd2207451b6eab54c854ef [INFO] running `"docker" "start" "-a" "b4dbfa51dd06bb6ac98733e54d789a250c17f5fc8ccd2207451b6eab54c854ef"` [INFO] [stderr] Checking vier_gewinnt v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:71:2 [INFO] [stderr] | [INFO] [stderr] 71 | return player; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `player` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:153:1 [INFO] [stderr] | [INFO] [stderr] 153 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:108:11 [INFO] [stderr] | [INFO] [stderr] 108 | if(ground[x][y] != 0 && [INFO] [stderr] | ___________^ [INFO] [stderr] 109 | | ground[x][y]==ground[x][y+1] && [INFO] [stderr] 110 | | ground[x][y]==ground[x][y+2] && [INFO] [stderr] 111 | | ground[x][y]==ground[x][y+3]){ [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 108 | ifground[x][y] != 0 && [INFO] [stderr] 109 | ground[x][y]==ground[x][y+1] && [INFO] [stderr] 110 | ground[x][y]==ground[x][y+2] && [INFO] [stderr] 111 | ground[x][y]==ground[x][y+3]{ [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:120:11 [INFO] [stderr] | [INFO] [stderr] 120 | if(ground[x][y] != 0 && [INFO] [stderr] | ___________^ [INFO] [stderr] 121 | | ground[x][y]==ground[x+1][y] && [INFO] [stderr] 122 | | ground[x][y]==ground[x+2][y] && [INFO] [stderr] 123 | | ground[x][y]==ground[x+3][y]){ [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 120 | ifground[x][y] != 0 && [INFO] [stderr] 121 | ground[x][y]==ground[x+1][y] && [INFO] [stderr] 122 | ground[x][y]==ground[x+2][y] && [INFO] [stderr] 123 | ground[x][y]==ground[x+3][y]{ [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:132:11 [INFO] [stderr] | [INFO] [stderr] 132 | if(ground[x][y] != 0 && [INFO] [stderr] | ___________^ [INFO] [stderr] 133 | | ground[x][y]==ground[x+1][y+1] && [INFO] [stderr] 134 | | ground[x][y]==ground[x+2][y+2] && [INFO] [stderr] 135 | | ground[x][y]==ground[x+3][y+3]){ [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 132 | ifground[x][y] != 0 && [INFO] [stderr] 133 | ground[x][y]==ground[x+1][y+1] && [INFO] [stderr] 134 | ground[x][y]==ground[x+2][y+2] && [INFO] [stderr] 135 | ground[x][y]==ground[x+3][y+3]{ [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:144:11 [INFO] [stderr] | [INFO] [stderr] 144 | if(ground[x][y] != 0 && [INFO] [stderr] | ___________^ [INFO] [stderr] 145 | | ground[x][y]==ground[x+1][y-1] && [INFO] [stderr] 146 | | ground[x][y]==ground[x+2][y-2] && [INFO] [stderr] 147 | | ground[x][y]==ground[x+3][y-3]){ [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 144 | ifground[x][y] != 0 && [INFO] [stderr] 145 | ground[x][y]==ground[x+1][y-1] && [INFO] [stderr] 146 | ground[x][y]==ground[x+2][y-2] && [INFO] [stderr] 147 | ground[x][y]==ground[x+3][y-3]{ [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:71:2 [INFO] [stderr] | [INFO] [stderr] 71 | return player; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `player` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:153:1 [INFO] [stderr] | [INFO] [stderr] 153 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:108:11 [INFO] [stderr] | [INFO] [stderr] 108 | if(ground[x][y] != 0 && [INFO] [stderr] | ___________^ [INFO] [stderr] 109 | | ground[x][y]==ground[x][y+1] && [INFO] [stderr] 110 | | ground[x][y]==ground[x][y+2] && [INFO] [stderr] 111 | | ground[x][y]==ground[x][y+3]){ [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 108 | ifground[x][y] != 0 && [INFO] [stderr] 109 | ground[x][y]==ground[x][y+1] && [INFO] [stderr] 110 | ground[x][y]==ground[x][y+2] && [INFO] [stderr] 111 | ground[x][y]==ground[x][y+3]{ [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:120:11 [INFO] [stderr] | [INFO] [stderr] 120 | if(ground[x][y] != 0 && [INFO] [stderr] | ___________^ [INFO] [stderr] 121 | | ground[x][y]==ground[x+1][y] && [INFO] [stderr] 122 | | ground[x][y]==ground[x+2][y] && [INFO] [stderr] 123 | | ground[x][y]==ground[x+3][y]){ [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 120 | ifground[x][y] != 0 && [INFO] [stderr] 121 | ground[x][y]==ground[x+1][y] && [INFO] [stderr] 122 | ground[x][y]==ground[x+2][y] && [INFO] [stderr] 123 | ground[x][y]==ground[x+3][y]{ [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:132:11 [INFO] [stderr] | [INFO] [stderr] 132 | if(ground[x][y] != 0 && [INFO] [stderr] | ___________^ [INFO] [stderr] 133 | | ground[x][y]==ground[x+1][y+1] && [INFO] [stderr] 134 | | ground[x][y]==ground[x+2][y+2] && [INFO] [stderr] 135 | | ground[x][y]==ground[x+3][y+3]){ [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 132 | ifground[x][y] != 0 && [INFO] [stderr] 133 | ground[x][y]==ground[x+1][y+1] && [INFO] [stderr] 134 | ground[x][y]==ground[x+2][y+2] && [INFO] [stderr] 135 | ground[x][y]==ground[x+3][y+3]{ [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:144:11 [INFO] [stderr] | [INFO] [stderr] 144 | if(ground[x][y] != 0 && [INFO] [stderr] | ___________^ [INFO] [stderr] 145 | | ground[x][y]==ground[x+1][y-1] && [INFO] [stderr] 146 | | ground[x][y]==ground[x+2][y-2] && [INFO] [stderr] 147 | | ground[x][y]==ground[x+3][y-3]){ [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 144 | ifground[x][y] != 0 && [INFO] [stderr] 145 | ground[x][y]==ground[x+1][y-1] && [INFO] [stderr] 146 | ground[x][y]==ground[x+2][y-2] && [INFO] [stderr] 147 | ground[x][y]==ground[x+3][y-3]{ [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/main.rs:89:20 [INFO] [stderr] | [INFO] [stderr] 89 | continue; 0}; //If lane is out of bounds go to beginning of input [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/main.rs:89:20 [INFO] [stderr] | [INFO] [stderr] 89 | continue; 0}; //If lane is out of bounds go to beginning of input [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:45:3 [INFO] [stderr] | [INFO] [stderr] 45 | round = round + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `round += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:59:8 [INFO] [stderr] | [INFO] [stderr] 59 | while win == false { [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `!win` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:45:3 [INFO] [stderr] | [INFO] [stderr] 45 | round = round + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `round += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:59:8 [INFO] [stderr] | [INFO] [stderr] 59 | while win == false { [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `!win` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | row = row -1; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `row -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | row = row -1; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `row -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `ground`. [INFO] [stderr] --> src/main.rs:158:14 [INFO] [stderr] | [INFO] [stderr] 158 | for x in 0..7 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 158 | for in ground.iter().take(7) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `ground`. [INFO] [stderr] --> src/main.rs:158:14 [INFO] [stderr] | [INFO] [stderr] 158 | for x in 0..7 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 158 | for in ground.iter().take(7) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.37s [INFO] running `"docker" "inspect" "b4dbfa51dd06bb6ac98733e54d789a250c17f5fc8ccd2207451b6eab54c854ef"` [INFO] running `"docker" "rm" "-f" "b4dbfa51dd06bb6ac98733e54d789a250c17f5fc8ccd2207451b6eab54c854ef"` [INFO] [stdout] b4dbfa51dd06bb6ac98733e54d789a250c17f5fc8ccd2207451b6eab54c854ef