[INFO] updating cached repository Fiveside/farore
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Fiveside/farore
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Fiveside/farore" "work/ex/clippy-test-run/sources/stable/gh/Fiveside/farore"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Fiveside/farore'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Fiveside/farore" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Fiveside/farore"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Fiveside/farore'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 663decc6330e551e1f786ad2b6b0612cbd459e8d
[INFO] sha for GitHub repo Fiveside/farore: 663decc6330e551e1f786ad2b6b0612cbd459e8d
[INFO] validating manifest of Fiveside/farore on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Fiveside/farore on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Fiveside/farore
[INFO] finished frobbing Fiveside/farore
[INFO] frobbed toml for Fiveside/farore written to work/ex/clippy-test-run/sources/stable/gh/Fiveside/farore/Cargo.toml
[INFO] started frobbing Fiveside/farore
[INFO] finished frobbing Fiveside/farore
[INFO] frobbed toml for Fiveside/farore written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Fiveside/farore/Cargo.toml
[INFO] crate Fiveside/farore has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Fiveside/farore against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Fiveside/farore:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7527a28f4c6ace57fa2515fa8790f1917cb65fb63f7228166c1ba755acc11320
[INFO] running `"docker" "start" "-a" "7527a28f4c6ace57fa2515fa8790f1917cb65fb63f7228166c1ba755acc11320"`
[INFO] [stderr]     Checking farore v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cart.rs:82:5
[INFO] [stderr]    |
[INFO] [stderr] 82 |     return iter.fold(Wrapping(0u16), |acc, x| acc + Wrapping(x as u16)).0;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `iter.fold(Wrapping(0u16), |acc, x| acc + Wrapping(x as u16)).0`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cart.rs:82:5
[INFO] [stderr]    |
[INFO] [stderr] 82 |     return iter.fold(Wrapping(0u16), |acc, x| acc + Wrapping(x as u16)).0;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `iter.fold(Wrapping(0u16), |acc, x| acc + Wrapping(x as u16)).0`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]   --> src/cart.rs:69:9
[INFO] [stderr]    |
[INFO] [stderr] 69 |     buf.into_iter().skip(0x0134).take(0x014C - 0x0134 + 1)
[INFO] [stderr]    |         ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]   --> src/cart.rs:74:20
[INFO] [stderr]    |
[INFO] [stderr] 74 |     let iter = buf.into_iter().enumerate().filter_map(|(i, &x)| {
[INFO] [stderr]    |                    ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/cart.rs:82:62
[INFO] [stderr]    |
[INFO] [stderr] 82 |     return iter.fold(Wrapping(0u16), |acc, x| acc + Wrapping(x as u16)).0;
[INFO] [stderr]    |                                                              ^^^^^^^^ help: try: `u16::from(x)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/cart.rs:106:26
[INFO] [stderr]     |
[INFO] [stderr] 106 |     let first_zero = buf.into_iter().enumerate().find(|(_idx, &x)| x == 0).map(|(idx, _)| idx);
[INFO] [stderr]     |                          ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]   --> src/cart.rs:69:9
[INFO] [stderr]    |
[INFO] [stderr] 69 |     buf.into_iter().skip(0x0134).take(0x014C - 0x0134 + 1)
[INFO] [stderr]    |         ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]   --> src/cart.rs:74:20
[INFO] [stderr]    |
[INFO] [stderr] 74 |     let iter = buf.into_iter().enumerate().filter_map(|(i, &x)| {
[INFO] [stderr]    |                    ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/cart.rs:82:62
[INFO] [stderr]    |
[INFO] [stderr] 82 |     return iter.fold(Wrapping(0u16), |acc, x| acc + Wrapping(x as u16)).0;
[INFO] [stderr]    |                                                              ^^^^^^^^ help: try: `u16::from(x)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/cart.rs:106:26
[INFO] [stderr]     |
[INFO] [stderr] 106 |     let first_zero = buf.into_iter().enumerate().find(|(_idx, &x)| x == 0).map(|(idx, _)| idx);
[INFO] [stderr]     |                          ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.92s
[INFO] running `"docker" "inspect" "7527a28f4c6ace57fa2515fa8790f1917cb65fb63f7228166c1ba755acc11320"`
[INFO] running `"docker" "rm" "-f" "7527a28f4c6ace57fa2515fa8790f1917cb65fb63f7228166c1ba755acc11320"`
[INFO] [stdout] 7527a28f4c6ace57fa2515fa8790f1917cb65fb63f7228166c1ba755acc11320