[INFO] updating cached repository Fittings/router_log_data [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Fittings/router_log_data [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Fittings/router_log_data" "work/ex/clippy-test-run/sources/stable/gh/Fittings/router_log_data"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Fittings/router_log_data'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Fittings/router_log_data" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Fittings/router_log_data"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Fittings/router_log_data'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 44b7722ce96df706240852e0e8f32b26acfd2f13 [INFO] sha for GitHub repo Fittings/router_log_data: 44b7722ce96df706240852e0e8f32b26acfd2f13 [INFO] validating manifest of Fittings/router_log_data on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Fittings/router_log_data on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Fittings/router_log_data [INFO] finished frobbing Fittings/router_log_data [INFO] frobbed toml for Fittings/router_log_data written to work/ex/clippy-test-run/sources/stable/gh/Fittings/router_log_data/Cargo.toml [INFO] started frobbing Fittings/router_log_data [INFO] finished frobbing Fittings/router_log_data [INFO] frobbed toml for Fittings/router_log_data written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Fittings/router_log_data/Cargo.toml [INFO] crate Fittings/router_log_data has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Fittings/router_log_data against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Fittings/router_log_data:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1719a397dda545f6c4ae7d9cb4407de16cc489cef5b031dc391ce0c2d1cc17b1 [INFO] running `"docker" "start" "-a" "1719a397dda545f6c4ae7d9cb4407de16cc489cef5b031dc391ce0c2d1cc17b1"` [INFO] [stderr] Checking syslog_reader v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `line` [INFO] [stderr] --> src/sys_log/sys_log_data.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | for line in self.log_lines.iter() { [INFO] [stderr] | ^^^^ help: consider using `_line` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `line` [INFO] [stderr] --> src/sys_log/sys_log_data.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | for line in self.log_lines.iter() { [INFO] [stderr] | ^^^^ help: consider using `_line` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `sys_log::sys_log_data::SysLogData` [INFO] [stderr] --> src/sys_log/sys_log_data.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new<'b>() -> Self { [INFO] [stderr] 10 | | SysLogData { [INFO] [stderr] 11 | | log_lines: Vec::new(), [INFO] [stderr] 12 | | } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/sys_log/sys_log_data.rs:9:16 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn new<'b>() -> Self { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/sys_log/sys_log_data.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn add_line<'b>(&'b mut self, line: SysLogLine) { [INFO] [stderr] 20 | | self.log_lines.push(line); [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `sys_log::sys_log_data::SysLogData` [INFO] [stderr] --> src/sys_log/sys_log_data.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new<'b>() -> Self { [INFO] [stderr] 10 | | SysLogData { [INFO] [stderr] 11 | | log_lines: Vec::new(), [INFO] [stderr] 12 | | } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/sys_log/sys_log_data.rs:9:16 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn new<'b>() -> Self { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/sys_log/sys_log_data.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn add_line<'b>(&'b mut self, line: SysLogLine) { [INFO] [stderr] 20 | | self.log_lines.push(line); [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/log_bin.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | ip_address: ip_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ip_address` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/log_bin.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/log_bin.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | hostname: hostname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `hostname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/log_bin.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | facility: facility, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `facility` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/log_bin.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | priority: priority, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `priority` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/log_bin.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/log_bin.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | ip_address: ip_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ip_address` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/log_bin.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/log_bin.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | hostname: hostname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `hostname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/log_bin.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | facility: facility, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `facility` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/log_bin.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | priority: priority, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `priority` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/log_bin.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/bin/log_bin.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | fn retrieve_sys_log_data<'a, R: BufRead>(reader : R) -> sys_log_data::SysLogData { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/log_bin.rs:45:41 [INFO] [stderr] | [INFO] [stderr] 45 | for (i, token) in line_string.split("\t").enumerate() { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bin/log_bin.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | _ => tag_and_msg = tag_and_msg + token, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tag_and_msg += token` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/log_bin.rs:56:45 [INFO] [stderr] | [INFO] [stderr] 56 | let mut tag_and_msg = tag_and_msg.split("]"); [INFO] [stderr] | ^^^ help: try using a char instead: `']'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/bin/log_bin.rs:59:30 [INFO] [stderr] | [INFO] [stderr] 59 | while let Some(string) = tag_and_msg.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `for string in tag_and_msg { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/bin/log_bin.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | fn retrieve_sys_log_data<'a, R: BufRead>(reader : R) -> sys_log_data::SysLogData { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/log_bin.rs:45:41 [INFO] [stderr] | [INFO] [stderr] 45 | for (i, token) in line_string.split("\t").enumerate() { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bin/log_bin.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | _ => tag_and_msg = tag_and_msg + token, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tag_and_msg += token` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/log_bin.rs:56:45 [INFO] [stderr] | [INFO] [stderr] 56 | let mut tag_and_msg = tag_and_msg.split("]"); [INFO] [stderr] | ^^^ help: try using a char instead: `']'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/bin/log_bin.rs:59:30 [INFO] [stderr] | [INFO] [stderr] 59 | while let Some(string) = tag_and_msg.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `for string in tag_and_msg { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.95s [INFO] running `"docker" "inspect" "1719a397dda545f6c4ae7d9cb4407de16cc489cef5b031dc391ce0c2d1cc17b1"` [INFO] running `"docker" "rm" "-f" "1719a397dda545f6c4ae7d9cb4407de16cc489cef5b031dc391ce0c2d1cc17b1"` [INFO] [stdout] 1719a397dda545f6c4ae7d9cb4407de16cc489cef5b031dc391ce0c2d1cc17b1