[INFO] updating cached repository FilipNordmark/Math
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/FilipNordmark/Math
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/FilipNordmark/Math" "work/ex/clippy-test-run/sources/stable/gh/FilipNordmark/Math"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/FilipNordmark/Math'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/FilipNordmark/Math" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FilipNordmark/Math"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FilipNordmark/Math'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 62ec5789ce38955e6cd4381b6b4119960e180637
[INFO] sha for GitHub repo FilipNordmark/Math: 62ec5789ce38955e6cd4381b6b4119960e180637
[INFO] validating manifest of FilipNordmark/Math on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of FilipNordmark/Math on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing FilipNordmark/Math
[INFO] finished frobbing FilipNordmark/Math
[INFO] frobbed toml for FilipNordmark/Math written to work/ex/clippy-test-run/sources/stable/gh/FilipNordmark/Math/Cargo.toml
[INFO] started frobbing FilipNordmark/Math
[INFO] finished frobbing FilipNordmark/Math
[INFO] frobbed toml for FilipNordmark/Math written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FilipNordmark/Math/Cargo.toml
[INFO] crate FilipNordmark/Math has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting FilipNordmark/Math against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FilipNordmark/Math:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6862e236573a9bf66a90064ac8957e06c4298f777c5ef778d582f85a5c202ac0
[INFO] running `"docker" "start" "-a" "6862e236573a9bf66a90064ac8957e06c4298f777c5ef778d582f85a5c202ac0"`
[INFO] [stderr]     Checking calculator v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused variable: `input`
[INFO] [stderr]   --> src/lib.rs:37:21
[INFO] [stderr]    |
[INFO] [stderr] 37 |     pub fn to_expr( input: String ) -> Result<Expr<'a>, &'static str> {
[INFO] [stderr]    |                     ^^^^^ help: consider using `_input` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `input`
[INFO] [stderr]   --> src/lib.rs:37:21
[INFO] [stderr]    |
[INFO] [stderr] 37 |     pub fn to_expr( input: String ) -> Result<Expr<'a>, &'static str> {
[INFO] [stderr]    |                     ^^^^^ help: consider using `_input` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/lib.rs:28:9
[INFO] [stderr]    |
[INFO] [stderr] 28 | /         match self {
[INFO] [stderr] 29 | |             &Value(v) => v,
[INFO] [stderr] 30 | |             &Sum(x, y) => x.to_float() + y.to_float(),
[INFO] [stderr] 31 | |             &Dif(x, y) => x.to_float() - y.to_float(),
[INFO] [stderr] 32 | |             &Pro(x, y) => x.to_float() * y.to_float(),
[INFO] [stderr] 33 | |             &Div(x, y) => x.to_float() / y.to_float(),
[INFO] [stderr] 34 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 28 |         match *self {
[INFO] [stderr] 29 |             Value(v) => v,
[INFO] [stderr] 30 |             Sum(x, y) => x.to_float() + y.to_float(),
[INFO] [stderr] 31 |             Dif(x, y) => x.to_float() - y.to_float(),
[INFO] [stderr] 32 |             Pro(x, y) => x.to_float() * y.to_float(),
[INFO] [stderr] 33 |             Div(x, y) => x.to_float() / y.to_float(),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/lib.rs:37:21
[INFO] [stderr]    |
[INFO] [stderr] 37 |     pub fn to_expr( input: String ) -> Result<Expr<'a>, &'static str> {
[INFO] [stderr]    |                     ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/lib.rs:28:9
[INFO] [stderr]    |
[INFO] [stderr] 28 | /         match self {
[INFO] [stderr] 29 | |             &Value(v) => v,
[INFO] [stderr] 30 | |             &Sum(x, y) => x.to_float() + y.to_float(),
[INFO] [stderr] 31 | |             &Dif(x, y) => x.to_float() - y.to_float(),
[INFO] [stderr] 32 | |             &Pro(x, y) => x.to_float() * y.to_float(),
[INFO] [stderr] 33 | |             &Div(x, y) => x.to_float() / y.to_float(),
[INFO] [stderr] 34 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 28 |         match *self {
[INFO] [stderr] 29 |             Value(v) => v,
[INFO] [stderr] 30 |             Sum(x, y) => x.to_float() + y.to_float(),
[INFO] [stderr] 31 |             Dif(x, y) => x.to_float() - y.to_float(),
[INFO] [stderr] 32 |             Pro(x, y) => x.to_float() * y.to_float(),
[INFO] [stderr] 33 |             Div(x, y) => x.to_float() / y.to_float(),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/lib.rs:37:21
[INFO] [stderr]    |
[INFO] [stderr] 37 |     pub fn to_expr( input: String ) -> Result<Expr<'a>, &'static str> {
[INFO] [stderr]    |                     ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.29s
[INFO] running `"docker" "inspect" "6862e236573a9bf66a90064ac8957e06c4298f777c5ef778d582f85a5c202ac0"`
[INFO] running `"docker" "rm" "-f" "6862e236573a9bf66a90064ac8957e06c4298f777c5ef778d582f85a5c202ac0"`
[INFO] [stdout] 6862e236573a9bf66a90064ac8957e06c4298f777c5ef778d582f85a5c202ac0