[INFO] updating cached repository FeliciousX/tetrimino-solver [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/FeliciousX/tetrimino-solver [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/FeliciousX/tetrimino-solver" "work/ex/clippy-test-run/sources/stable/gh/FeliciousX/tetrimino-solver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/FeliciousX/tetrimino-solver'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/FeliciousX/tetrimino-solver" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FeliciousX/tetrimino-solver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FeliciousX/tetrimino-solver'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 25d278f95be7e88f8bd10e067c82dd5e4abc299e [INFO] sha for GitHub repo FeliciousX/tetrimino-solver: 25d278f95be7e88f8bd10e067c82dd5e4abc299e [INFO] validating manifest of FeliciousX/tetrimino-solver on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of FeliciousX/tetrimino-solver on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing FeliciousX/tetrimino-solver [INFO] finished frobbing FeliciousX/tetrimino-solver [INFO] frobbed toml for FeliciousX/tetrimino-solver written to work/ex/clippy-test-run/sources/stable/gh/FeliciousX/tetrimino-solver/Cargo.toml [INFO] started frobbing FeliciousX/tetrimino-solver [INFO] finished frobbing FeliciousX/tetrimino-solver [INFO] frobbed toml for FeliciousX/tetrimino-solver written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FeliciousX/tetrimino-solver/Cargo.toml [INFO] crate FeliciousX/tetrimino-solver has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting FeliciousX/tetrimino-solver against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/FeliciousX/tetrimino-solver:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 20b65a65e1ef79395872031e54935d6aeb28780e58c7611f78c8c66cbe2c6a97 [INFO] running `"docker" "start" "-a" "20b65a65e1ef79395872031e54935d6aeb28780e58c7611f78c8c66cbe2c6a97"` [INFO] [stderr] Checking tetrimino v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/board/mod.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | squares: squares, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `squares` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/board/mod.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/board/mod.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/coordinate/mod.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | row: row, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/coordinate/mod.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | col: col, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/board/mod.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | squares: squares, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `squares` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/board/mod.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/board/mod.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/coordinate/mod.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | row: row, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/coordinate/mod.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | col: col, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | return Board::new(row, column); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Board::new(row, column)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | return Board::new(row, column); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Board::new(row, column)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `coordinate` [INFO] [stderr] warning: unused variable: `coordinate` [INFO] [stderr] --> src/main.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | let coordinate = coordinate::Coordinate::new(3, 4); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_coordinate` instead [INFO] [stderr] --> src/main.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | let coordinate = coordinate::Coordinate::new(3, 4); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_coordinate` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / match x { [INFO] [stderr] 33 | | &Block { shape: Tetromino::I, .. } => println!("I shape"), [INFO] [stderr] 34 | | &Block { shape: Tetromino::O, .. } => println!("O shape"), [INFO] [stderr] 35 | | &Block { shape: Tetromino::T, .. } => println!("T shape"), [INFO] [stderr] ... | [INFO] [stderr] 39 | | &Block { shape: Tetromino::Z, .. } => println!("Z shape"), [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | match *x { [INFO] [stderr] 33 | Block { shape: Tetromino::I, .. } => println!("I shape"), [INFO] [stderr] 34 | Block { shape: Tetromino::O, .. } => println!("O shape"), [INFO] [stderr] 35 | Block { shape: Tetromino::T, .. } => println!("T shape"), [INFO] [stderr] 36 | Block { shape: Tetromino::J, .. } => println!("J shape"), [INFO] [stderr] 37 | Block { shape: Tetromino::L, .. } => println!("L shape"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / match x { [INFO] [stderr] 33 | | &Block { shape: Tetromino::I, .. } => println!("I shape"), [INFO] [stderr] 34 | | &Block { shape: Tetromino::O, .. } => println!("O shape"), [INFO] [stderr] 35 | | &Block { shape: Tetromino::T, .. } => println!("T shape"), [INFO] [stderr] ... | [INFO] [stderr] 39 | | &Block { shape: Tetromino::Z, .. } => println!("Z shape"), [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | / match col.filled { [INFO] [stderr] 46 | | true => print!("[X]"), [INFO] [stderr] 47 | | false => print!("[ ]") [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if col.filled { print!("[X]") } else { print!("[ ]") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | match *x { [INFO] [stderr] 33 | Block { shape: Tetromino::I, .. } => println!("I shape"), [INFO] [stderr] 34 | Block { shape: Tetromino::O, .. } => println!("O shape"), [INFO] [stderr] 35 | Block { shape: Tetromino::T, .. } => println!("T shape"), [INFO] [stderr] 36 | Block { shape: Tetromino::J, .. } => println!("J shape"), [INFO] [stderr] 37 | Block { shape: Tetromino::L, .. } => println!("L shape"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / io::stdin().read_line(&mut row) [INFO] [stderr] 62 | | .ok() [INFO] [stderr] 63 | | .expect("Failed to read line!"); [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:65:20 [INFO] [stderr] | [INFO] [stderr] 65 | let row: i32 = row.trim().parse() [INFO] [stderr] | ____________________^ [INFO] [stderr] 66 | | .ok() [INFO] [stderr] 67 | | .expect("Please type a number!"); [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | / match col.filled { [INFO] [stderr] 46 | | true => print!("[X]"), [INFO] [stderr] 47 | | false => print!("[ ]") [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if col.filled { print!("[X]") } else { print!("[ ]") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / io::stdin().read_line(&mut column) [INFO] [stderr] 72 | | .ok() [INFO] [stderr] 73 | | .expect("Failed to read line!"); [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:75:23 [INFO] [stderr] | [INFO] [stderr] 75 | let column: i32 = column.trim().parse() [INFO] [stderr] | _______________________^ [INFO] [stderr] 76 | | .ok() [INFO] [stderr] 77 | | .expect("Please type a number!"); [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / io::stdin().read_line(&mut row) [INFO] [stderr] 62 | | .ok() [INFO] [stderr] 63 | | .expect("Failed to read line!"); [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:65:20 [INFO] [stderr] | [INFO] [stderr] 65 | let row: i32 = row.trim().parse() [INFO] [stderr] | ____________________^ [INFO] [stderr] 66 | | .ok() [INFO] [stderr] 67 | | .expect("Please type a number!"); [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / io::stdin().read_line(&mut column) [INFO] [stderr] 72 | | .ok() [INFO] [stderr] 73 | | .expect("Failed to read line!"); [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:75:23 [INFO] [stderr] | [INFO] [stderr] 75 | let column: i32 = column.trim().parse() [INFO] [stderr] | _______________________^ [INFO] [stderr] 76 | | .ok() [INFO] [stderr] 77 | | .expect("Please type a number!"); [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.41s [INFO] running `"docker" "inspect" "20b65a65e1ef79395872031e54935d6aeb28780e58c7611f78c8c66cbe2c6a97"` [INFO] running `"docker" "rm" "-f" "20b65a65e1ef79395872031e54935d6aeb28780e58c7611f78c8c66cbe2c6a97"` [INFO] [stdout] 20b65a65e1ef79395872031e54935d6aeb28780e58c7611f78c8c66cbe2c6a97