[INFO] updating cached repository EvilRobotOverlord/minigrep [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/EvilRobotOverlord/minigrep [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/EvilRobotOverlord/minigrep" "work/ex/clippy-test-run/sources/stable/gh/EvilRobotOverlord/minigrep"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/EvilRobotOverlord/minigrep'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/EvilRobotOverlord/minigrep" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EvilRobotOverlord/minigrep"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EvilRobotOverlord/minigrep'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a13abeae7c74703c14fa42282a7602a942234bae [INFO] sha for GitHub repo EvilRobotOverlord/minigrep: a13abeae7c74703c14fa42282a7602a942234bae [INFO] validating manifest of EvilRobotOverlord/minigrep on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of EvilRobotOverlord/minigrep on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing EvilRobotOverlord/minigrep [INFO] finished frobbing EvilRobotOverlord/minigrep [INFO] frobbed toml for EvilRobotOverlord/minigrep written to work/ex/clippy-test-run/sources/stable/gh/EvilRobotOverlord/minigrep/Cargo.toml [INFO] started frobbing EvilRobotOverlord/minigrep [INFO] finished frobbing EvilRobotOverlord/minigrep [INFO] frobbed toml for EvilRobotOverlord/minigrep written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EvilRobotOverlord/minigrep/Cargo.toml [INFO] crate EvilRobotOverlord/minigrep has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting EvilRobotOverlord/minigrep against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EvilRobotOverlord/minigrep:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 048e838a03569c676ddfa9f22071b86d9d42afb6cdc5c63ca7a183d5a7f4a721 [INFO] running `"docker" "start" "-a" "048e838a03569c676ddfa9f22071b86d9d42afb6cdc5c63ca7a183d5a7f4a721"` [INFO] [stderr] Checking minigrep v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/config.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / let mut match_case: u32 = 0; [INFO] [stderr] 32 | | [INFO] [stderr] 33 | | if args.len() > 3 { [INFO] [stderr] 34 | | let res = args.remove(3).parse::(); [INFO] [stderr] ... | [INFO] [stderr] 40 | | match_case = res.unwrap(); [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let match_case = if args.len() > 3 { ..; res.unwrap() } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/config.rs:36:20 [INFO] [stderr] | [INFO] [stderr] 36 | if let Err(_) = res { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 37 | | return Err("Argument #3 is not a u32."); [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____________- help: try this: `if res.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/config.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / let mut match_case: u32 = 0; [INFO] [stderr] 32 | | [INFO] [stderr] 33 | | if args.len() > 3 { [INFO] [stderr] 34 | | let res = args.remove(3).parse::(); [INFO] [stderr] ... | [INFO] [stderr] 40 | | match_case = res.unwrap(); [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let match_case = if args.len() > 3 { ..; res.unwrap() } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/config.rs:36:20 [INFO] [stderr] | [INFO] [stderr] 36 | if let Err(_) = res { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 37 | | return Err("Argument #3 is not a u32."); [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____________- help: try this: `if res.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:51:16 [INFO] [stderr] | [INFO] [stderr] 51 | if let Err(_) = config::Config::new(&mut vec) {} else { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 52 | | panic!("Config::new did not return an error for invalid input where types are mismatched."); [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________- help: try this: `if config::Config::new(&mut vec).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.05s [INFO] running `"docker" "inspect" "048e838a03569c676ddfa9f22071b86d9d42afb6cdc5c63ca7a183d5a7f4a721"` [INFO] running `"docker" "rm" "-f" "048e838a03569c676ddfa9f22071b86d9d42afb6cdc5c63ca7a183d5a7f4a721"` [INFO] [stdout] 048e838a03569c676ddfa9f22071b86d9d42afb6cdc5c63ca7a183d5a7f4a721