[INFO] updating cached repository ErikBZ/private-island [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ErikBZ/private-island [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ErikBZ/private-island" "work/ex/clippy-test-run/sources/stable/gh/ErikBZ/private-island"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ErikBZ/private-island'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ErikBZ/private-island" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ErikBZ/private-island"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ErikBZ/private-island'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 34c3f08f01b71015af60335d3e7444495be667d6 [INFO] sha for GitHub repo ErikBZ/private-island: 34c3f08f01b71015af60335d3e7444495be667d6 [INFO] validating manifest of ErikBZ/private-island on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ErikBZ/private-island on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ErikBZ/private-island [INFO] finished frobbing ErikBZ/private-island [INFO] frobbed toml for ErikBZ/private-island written to work/ex/clippy-test-run/sources/stable/gh/ErikBZ/private-island/Cargo.toml [INFO] started frobbing ErikBZ/private-island [INFO] finished frobbing ErikBZ/private-island [INFO] frobbed toml for ErikBZ/private-island written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ErikBZ/private-island/Cargo.toml [INFO] crate ErikBZ/private-island has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ErikBZ/private-island against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ErikBZ/private-island:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2d1f31197ecf41d356abbc9321b0b90d1374618c638ad8cf952d010cb5bb1d58 [INFO] running `"docker" "start" "-a" "2d1f31197ecf41d356abbc9321b0b90d1374618c638ad8cf952d010cb5bb1d58"` [INFO] [stderr] Checking socket2 v0.2.4 [INFO] [stderr] Checking clap v2.27.1 [INFO] [stderr] Checking private-island v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused imports: `TcpListener`, `TcpStream` [INFO] [stderr] --> src/main.rs:2:16 [INFO] [stderr] | [INFO] [stderr] 2 | use std::net::{TcpListener, TcpStream}; [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `SubCommand` [INFO] [stderr] --> src/main.rs:9:22 [INFO] [stderr] | [INFO] [stderr] 9 | use clap::{Arg, App, SubCommand}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::time::Duration` [INFO] [stderr] --> src/server.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::time::Duration; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude::*` [INFO] [stderr] --> src/server.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Path` [INFO] [stderr] --> src/server.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | use std::path::{Path, PathBuf}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `clap` [INFO] [stderr] --> src/server.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | use clap; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/server.rs:159:17 [INFO] [stderr] | [INFO] [stderr] 159 | request [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/server.rs:155:31 [INFO] [stderr] | [INFO] [stderr] 155 | let request = match str::from_utf8(&buffer){ [INFO] [stderr] | _______________________________^ [INFO] [stderr] 156 | | Ok(s) => s, [INFO] [stderr] 157 | | Err(e) => panic!("Improper message, cannot convert to string. {:?}", e), [INFO] [stderr] 158 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/main.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | Err(e) => panic!("Input cannot be parsed to unsinged 16 bit number"), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cfg` [INFO] [stderr] --> src/server.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | let cfg = &self.config.logging; [INFO] [stderr] | ^^^ help: consider using `_cfg` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `p` [INFO] [stderr] --> src/server.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | p => { [INFO] [stderr] | ^ help: consider using `_p` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/http.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | let mut content_type = match self{ [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `PathOutOfBounds` [INFO] [stderr] --> src/server.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | PathOutOfBounds, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `LoggingLevel` [INFO] [stderr] --> src/server.rs:54:1 [INFO] [stderr] | [INFO] [stderr] 54 | enum LoggingLevel{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `create_new_server` [INFO] [stderr] --> src/server.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | pub fn create_new_server() -> Server{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `load_file` [INFO] [stderr] --> src/server.rs:242:1 [INFO] [stderr] | [INFO] [stderr] 242 | pub fn load_file(path: &str) -> Result{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Plaintext` [INFO] [stderr] --> src/http.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | Plaintext, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused attribute [INFO] [stderr] --> src/server.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_attributes)] on by default [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/http.rs:12:22 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn to_string(self) -> String{ [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/http.rs:56:22 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn to_string(self) -> Result{ [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: unused imports: `TcpListener`, `TcpStream` [INFO] [stderr] --> src/main.rs:2:16 [INFO] [stderr] | [INFO] [stderr] 2 | use std::net::{TcpListener, TcpStream}; [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `SubCommand` [INFO] [stderr] --> src/main.rs:9:22 [INFO] [stderr] | [INFO] [stderr] 9 | use clap::{Arg, App, SubCommand}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::time::Duration` [INFO] [stderr] --> src/server.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::time::Duration; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude::*` [INFO] [stderr] --> src/server.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Path` [INFO] [stderr] --> src/server.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | use std::path::{Path, PathBuf}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `clap` [INFO] [stderr] --> src/server.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | use clap; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/server.rs:159:17 [INFO] [stderr] | [INFO] [stderr] 159 | request [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/server.rs:155:31 [INFO] [stderr] | [INFO] [stderr] 155 | let request = match str::from_utf8(&buffer){ [INFO] [stderr] | _______________________________^ [INFO] [stderr] 156 | | Ok(s) => s, [INFO] [stderr] 157 | | Err(e) => panic!("Improper message, cannot convert to string. {:?}", e), [INFO] [stderr] 158 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/main.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | Err(e) => panic!("Input cannot be parsed to unsinged 16 bit number"), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cfg` [INFO] [stderr] --> src/server.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | let cfg = &self.config.logging; [INFO] [stderr] | ^^^ help: consider using `_cfg` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `p` [INFO] [stderr] --> src/server.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | p => { [INFO] [stderr] | ^ help: consider using `_p` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/http.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | let mut content_type = match self{ [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `PathOutOfBounds` [INFO] [stderr] --> src/server.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | PathOutOfBounds, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `LoggingLevel` [INFO] [stderr] --> src/server.rs:54:1 [INFO] [stderr] | [INFO] [stderr] 54 | enum LoggingLevel{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `create_new_server` [INFO] [stderr] --> src/server.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | pub fn create_new_server() -> Server{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `load_file` [INFO] [stderr] --> src/server.rs:242:1 [INFO] [stderr] | [INFO] [stderr] 242 | pub fn load_file(path: &str) -> Result{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Plaintext` [INFO] [stderr] --> src/http.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | Plaintext, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused attribute [INFO] [stderr] --> src/server.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_attributes)] on by default [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/http.rs:12:22 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn to_string(self) -> String{ [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/http.rs:56:22 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn to_string(self) -> Result{ [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.26s [INFO] running `"docker" "inspect" "2d1f31197ecf41d356abbc9321b0b90d1374618c638ad8cf952d010cb5bb1d58"` [INFO] running `"docker" "rm" "-f" "2d1f31197ecf41d356abbc9321b0b90d1374618c638ad8cf952d010cb5bb1d58"` [INFO] [stdout] 2d1f31197ecf41d356abbc9321b0b90d1374618c638ad8cf952d010cb5bb1d58