[INFO] updating cached repository EmmaLa/tokio-chat [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/EmmaLa/tokio-chat [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/EmmaLa/tokio-chat" "work/ex/clippy-test-run/sources/stable/gh/EmmaLa/tokio-chat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/EmmaLa/tokio-chat'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/EmmaLa/tokio-chat" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EmmaLa/tokio-chat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EmmaLa/tokio-chat'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bf17a85c54d53a88e8ceb4789897defe10667c70 [INFO] sha for GitHub repo EmmaLa/tokio-chat: bf17a85c54d53a88e8ceb4789897defe10667c70 [INFO] validating manifest of EmmaLa/tokio-chat on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of EmmaLa/tokio-chat on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing EmmaLa/tokio-chat [INFO] finished frobbing EmmaLa/tokio-chat [INFO] frobbed toml for EmmaLa/tokio-chat written to work/ex/clippy-test-run/sources/stable/gh/EmmaLa/tokio-chat/Cargo.toml [INFO] started frobbing EmmaLa/tokio-chat [INFO] finished frobbing EmmaLa/tokio-chat [INFO] frobbed toml for EmmaLa/tokio-chat written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EmmaLa/tokio-chat/Cargo.toml [INFO] crate EmmaLa/tokio-chat has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting EmmaLa/tokio-chat against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EmmaLa/tokio-chat:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 381532a08db2f4764834a1ebb9594173a512e35ecc69f3856f4409c4cccb8cb2 [INFO] running `"docker" "start" "-a" "381532a08db2f4764834a1ebb9594173a512e35ecc69f3856f4409c4cccb8cb2"` [INFO] [stderr] Checking tokio-io v0.1.5 [INFO] [stderr] Checking mio v0.6.13 [INFO] [stderr] Checking tokio v0.1.1 [INFO] [stderr] Checking tokio-chat v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `AsyncWrite` [INFO] [stderr] --> src/main.rs:9:28 [INFO] [stderr] | [INFO] [stderr] 9 | use tokio_io::{ AsyncRead, AsyncWrite}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Write` [INFO] [stderr] --> src/main.rs:16:15 [INFO] [stderr] | [INFO] [stderr] 16 | use std::io::{Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::Arc` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | use std::sync::Arc; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::Mutex` [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | use std::sync::Mutex; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:70:36 [INFO] [stderr] | [INFO] [stderr] 70 | Ok(Async::Ready(0)) => return Ok(Async::Ready( None )), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::Ready( None ))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:71:36 [INFO] [stderr] | [INFO] [stderr] 71 | Ok(Async::Ready(_)) => return Ok(Async::Ready( Some(self.buffer.clone()) )), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::Ready( Some(self.buffer.clone()) ))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:72:23 [INFO] [stderr] | [INFO] [stderr] 72 | Err(_) => return Err(Error) , [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:73:18 [INFO] [stderr] | [INFO] [stderr] 73 | _ => return Ok(Async::NotReady), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::NotReady)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `AsyncWrite` [INFO] [stderr] --> src/main.rs:9:28 [INFO] [stderr] | [INFO] [stderr] 9 | use tokio_io::{ AsyncRead, AsyncWrite}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Write` [INFO] [stderr] --> src/main.rs:16:15 [INFO] [stderr] | [INFO] [stderr] 16 | use std::io::{Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::Arc` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | use std::sync::Arc; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::Mutex` [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | use std::sync::Mutex; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:70:36 [INFO] [stderr] | [INFO] [stderr] 70 | Ok(Async::Ready(0)) => return Ok(Async::Ready( None )), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::Ready( None ))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:71:36 [INFO] [stderr] | [INFO] [stderr] 71 | Ok(Async::Ready(_)) => return Ok(Async::Ready( Some(self.buffer.clone()) )), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::Ready( Some(self.buffer.clone()) ))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:72:23 [INFO] [stderr] | [INFO] [stderr] 72 | Err(_) => return Err(Error) , [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:73:18 [INFO] [stderr] | [INFO] [stderr] 73 | _ => return Ok(Async::NotReady), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::NotReady)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | let mut chuck_data = chunk_data.for_each(move |data| { [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `Rx` [INFO] [stderr] --> src/main.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | type Rx = mpsc::UnboundedReceiver; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `state` [INFO] [stderr] --> src/main.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | state: Rc> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / loop { [INFO] [stderr] 52 | | self.buffer.reserve(1024); [INFO] [stderr] 53 | | let result = self.socket.read_buf(&mut self.buffer); [INFO] [stderr] 54 | | match result { [INFO] [stderr] ... | [INFO] [stderr] 59 | | [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:84:24 [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(_) = result { [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 85 | | eprintln!("warning: client no longer connected ({:?})", addr); [INFO] [stderr] 86 | | } [INFO] [stderr] | |_________________- help: try this: `if result.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `tokio-chat`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | let mut chuck_data = chunk_data.for_each(move |data| { [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `Rx` [INFO] [stderr] --> src/main.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | type Rx = mpsc::UnboundedReceiver; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `state` [INFO] [stderr] --> src/main.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | state: Rc> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / loop { [INFO] [stderr] 52 | | self.buffer.reserve(1024); [INFO] [stderr] 53 | | let result = self.socket.read_buf(&mut self.buffer); [INFO] [stderr] 54 | | match result { [INFO] [stderr] ... | [INFO] [stderr] 59 | | [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:84:24 [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(_) = result { [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 85 | | eprintln!("warning: client no longer connected ({:?})", addr); [INFO] [stderr] 86 | | } [INFO] [stderr] | |_________________- help: try this: `if result.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `tokio-chat`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "381532a08db2f4764834a1ebb9594173a512e35ecc69f3856f4409c4cccb8cb2"` [INFO] running `"docker" "rm" "-f" "381532a08db2f4764834a1ebb9594173a512e35ecc69f3856f4409c4cccb8cb2"` [INFO] [stdout] 381532a08db2f4764834a1ebb9594173a512e35ecc69f3856f4409c4cccb8cb2