[INFO] updating cached repository Embracethevoid/evjson [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Embracethevoid/evjson [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Embracethevoid/evjson" "work/ex/clippy-test-run/sources/stable/gh/Embracethevoid/evjson"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Embracethevoid/evjson'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Embracethevoid/evjson" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Embracethevoid/evjson"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Embracethevoid/evjson'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3a172a28fec274b9abff63f71d9cc9deb2a9a4e5 [INFO] sha for GitHub repo Embracethevoid/evjson: 3a172a28fec274b9abff63f71d9cc9deb2a9a4e5 [INFO] validating manifest of Embracethevoid/evjson on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Embracethevoid/evjson on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Embracethevoid/evjson [INFO] finished frobbing Embracethevoid/evjson [INFO] frobbed toml for Embracethevoid/evjson written to work/ex/clippy-test-run/sources/stable/gh/Embracethevoid/evjson/Cargo.toml [INFO] started frobbing Embracethevoid/evjson [INFO] finished frobbing Embracethevoid/evjson [INFO] frobbed toml for Embracethevoid/evjson written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Embracethevoid/evjson/Cargo.toml [INFO] crate Embracethevoid/evjson has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Embracethevoid/evjson against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Embracethevoid/evjson:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2852de3d9df768dccf2e82908d22362b7ea72430a8b4477b9a4b06f25a4134c6 [INFO] running `"docker" "start" "-a" "2852de3d9df768dccf2e82908d22362b7ea72430a8b4477b9a4b06f25a4134c6"` [INFO] [stderr] Checking evjson v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/evjson.rs:177:5 [INFO] [stderr] | [INFO] [stderr] 177 | return Ok((_ind, _key, _value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((_ind, _key, _value))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/evjson.rs:241:16 [INFO] [stderr] | [INFO] [stderr] 241 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 242 | | if dot { [INFO] [stderr] 243 | | match num.parse::() { [INFO] [stderr] 244 | | Ok(_f) => return Ok((index, EVValue::Number(Number::Float(_f)))), [INFO] [stderr] ... | [INFO] [stderr] 252 | | } [INFO] [stderr] 253 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 241 | } else if dot { [INFO] [stderr] 242 | match num.parse::() { [INFO] [stderr] 243 | Ok(_f) => return Ok((index, EVValue::Number(Number::Float(_f)))), [INFO] [stderr] 244 | _ => return Err("failed to parse number".to_string()), [INFO] [stderr] 245 | } [INFO] [stderr] 246 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/evjson.rs:263:17 [INFO] [stderr] | [INFO] [stderr] 263 | return Ok((index + 4, EVValue::Boolean(true))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((index + 4, EVValue::Boolean(true)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/evjson.rs:265:17 [INFO] [stderr] | [INFO] [stderr] 265 | / return Err(format!( [INFO] [stderr] 266 | | "Invalid Syntax of charactor {},at position {}.", [INFO] [stderr] 267 | | c, _index [INFO] [stderr] 268 | | )); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 265 | Err(format!( [INFO] [stderr] 266 | "Invalid Syntax of charactor {},at position {}.", [INFO] [stderr] 267 | c, _index [INFO] [stderr] 268 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/evjson.rs:273:17 [INFO] [stderr] | [INFO] [stderr] 273 | return Ok((index + 5, EVValue::Boolean(false))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((index + 5, EVValue::Boolean(false)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/evjson.rs:275:17 [INFO] [stderr] | [INFO] [stderr] 275 | / return Err(format!( [INFO] [stderr] 276 | | "Invalid Syntax of charactor {},at position {}.", [INFO] [stderr] 277 | | c, _index [INFO] [stderr] 278 | | )); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 275 | Err(format!( [INFO] [stderr] 276 | "Invalid Syntax of charactor {},at position {}.", [INFO] [stderr] 277 | c, _index [INFO] [stderr] 278 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/evjson.rs:282:13 [INFO] [stderr] | [INFO] [stderr] 282 | / return Err(format!( [INFO] [stderr] 283 | | "Invalid Syntax of charactor {},at position {}.", [INFO] [stderr] 284 | | c, _index [INFO] [stderr] 285 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 282 | Err(format!( [INFO] [stderr] 283 | "Invalid Syntax of charactor {},at position {}.", [INFO] [stderr] 284 | c, _index [INFO] [stderr] 285 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/evjson.rs:291:9 [INFO] [stderr] | [INFO] [stderr] 291 | return Ok((index + 4, EVValue::Null)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((index + 4, EVValue::Null))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/evjson.rs:293:9 [INFO] [stderr] | [INFO] [stderr] 293 | / return Err(format!( [INFO] [stderr] 294 | | "Invalid Syntax of charactor {},at position {}.", [INFO] [stderr] 295 | | chars[index], index [INFO] [stderr] 296 | | )); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 293 | Err(format!( [INFO] [stderr] 294 | "Invalid Syntax of charactor {},at position {}.", [INFO] [stderr] 295 | chars[index], index [INFO] [stderr] 296 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/evjson.rs:349:5 [INFO] [stderr] | [INFO] [stderr] 349 | return Err("Invalid JSON end".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Invalid JSON end".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/evjson.rs:177:5 [INFO] [stderr] | [INFO] [stderr] 177 | return Ok((_ind, _key, _value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((_ind, _key, _value))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/evjson.rs:241:16 [INFO] [stderr] | [INFO] [stderr] 241 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 242 | | if dot { [INFO] [stderr] 243 | | match num.parse::() { [INFO] [stderr] 244 | | Ok(_f) => return Ok((index, EVValue::Number(Number::Float(_f)))), [INFO] [stderr] ... | [INFO] [stderr] 252 | | } [INFO] [stderr] 253 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 241 | } else if dot { [INFO] [stderr] 242 | match num.parse::() { [INFO] [stderr] 243 | Ok(_f) => return Ok((index, EVValue::Number(Number::Float(_f)))), [INFO] [stderr] 244 | _ => return Err("failed to parse number".to_string()), [INFO] [stderr] 245 | } [INFO] [stderr] 246 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/evjson.rs:263:17 [INFO] [stderr] | [INFO] [stderr] 263 | return Ok((index + 4, EVValue::Boolean(true))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((index + 4, EVValue::Boolean(true)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/evjson.rs:265:17 [INFO] [stderr] | [INFO] [stderr] 265 | / return Err(format!( [INFO] [stderr] 266 | | "Invalid Syntax of charactor {},at position {}.", [INFO] [stderr] 267 | | c, _index [INFO] [stderr] 268 | | )); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 265 | Err(format!( [INFO] [stderr] 266 | "Invalid Syntax of charactor {},at position {}.", [INFO] [stderr] 267 | c, _index [INFO] [stderr] 268 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/evjson.rs:273:17 [INFO] [stderr] | [INFO] [stderr] 273 | return Ok((index + 5, EVValue::Boolean(false))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((index + 5, EVValue::Boolean(false)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/evjson.rs:275:17 [INFO] [stderr] | [INFO] [stderr] 275 | / return Err(format!( [INFO] [stderr] 276 | | "Invalid Syntax of charactor {},at position {}.", [INFO] [stderr] 277 | | c, _index [INFO] [stderr] 278 | | )); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 275 | Err(format!( [INFO] [stderr] 276 | "Invalid Syntax of charactor {},at position {}.", [INFO] [stderr] 277 | c, _index [INFO] [stderr] 278 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/evjson.rs:282:13 [INFO] [stderr] | [INFO] [stderr] 282 | / return Err(format!( [INFO] [stderr] 283 | | "Invalid Syntax of charactor {},at position {}.", [INFO] [stderr] 284 | | c, _index [INFO] [stderr] 285 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 282 | Err(format!( [INFO] [stderr] 283 | "Invalid Syntax of charactor {},at position {}.", [INFO] [stderr] 284 | c, _index [INFO] [stderr] 285 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/evjson.rs:291:9 [INFO] [stderr] | [INFO] [stderr] 291 | return Ok((index + 4, EVValue::Null)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((index + 4, EVValue::Null))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/evjson.rs:293:9 [INFO] [stderr] | [INFO] [stderr] 293 | / return Err(format!( [INFO] [stderr] 294 | | "Invalid Syntax of charactor {},at position {}.", [INFO] [stderr] 295 | | chars[index], index [INFO] [stderr] 296 | | )); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 293 | Err(format!( [INFO] [stderr] 294 | "Invalid Syntax of charactor {},at position {}.", [INFO] [stderr] 295 | chars[index], index [INFO] [stderr] 296 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/evjson.rs:349:5 [INFO] [stderr] | [INFO] [stderr] 349 | return Err("Invalid JSON end".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Invalid JSON end".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: function is never used: `stringify` [INFO] [stderr] --> src/evjson.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn stringify(object: &EVObject, space: u8) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `stringify_object` [INFO] [stderr] --> src/evjson.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | fn stringify_object(object: &EVObject, space: u8, current_space: u8) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `stringify_value` [INFO] [stderr] --> src/evjson.rs:62:1 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn stringify_value(value: &EVValue, space: u8, current_space: u8) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/evjson.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | String::from(" ".repeat(current_space as usize)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `" ".repeat(current_space as usize)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/evjson.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | String::from(" ".repeat(current_space as usize)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `" ".repeat(current_space as usize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/evjson.rs:100:35 [INFO] [stderr] | [INFO] [stderr] 100 | fn parse_key(index: usize, chars: &Vec) -> Result<(usize, String), String> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/evjson.rs:123:37 [INFO] [stderr] | [INFO] [stderr] 123 | fn parse_array(index: usize, chars: &Vec) -> Result<(usize, EVValue), String> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/evjson.rs:151:36 [INFO] [stderr] | [INFO] [stderr] 151 | fn parse_pair(index: usize, chars: &Vec) -> Result<(usize, String, EVValue), String> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/evjson.rs:179:38 [INFO] [stderr] | [INFO] [stderr] 179 | fn parse_object(index: usize, chars: &Vec) -> Result<(usize, EVObject), String> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/evjson.rs:212:39 [INFO] [stderr] | [INFO] [stderr] 212 | fn parse_number(_index: usize, chars: &Vec) -> Result<(usize, EVValue), String> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/evjson.rs:257:39 [INFO] [stderr] | [INFO] [stderr] 257 | fn parse_boolean(index: usize, chars: &Vec) -> Result<(usize, EVValue), String> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/evjson.rs:289:36 [INFO] [stderr] | [INFO] [stderr] 289 | fn parse_null(index: usize, chars: &Vec) -> Result<(usize, EVValue), String> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/evjson.rs:299:37 [INFO] [stderr] | [INFO] [stderr] 299 | fn parse_value(index: usize, chars: &Vec) -> Result<(usize, EVValue), String> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/evjson.rs:334:38 [INFO] [stderr] | [INFO] [stderr] 334 | fn parse_string(index: usize, chars: &Vec) -> Result<(usize, String), String> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: function is never used: `stringify` [INFO] [stderr] --> src/evjson.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn stringify(object: &EVObject, space: u8) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `stringify_object` [INFO] [stderr] --> src/evjson.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | fn stringify_object(object: &EVObject, space: u8, current_space: u8) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `stringify_value` [INFO] [stderr] --> src/evjson.rs:62:1 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn stringify_value(value: &EVValue, space: u8, current_space: u8) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/evjson.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | String::from(" ".repeat(current_space as usize)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `" ".repeat(current_space as usize)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/evjson.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | String::from(" ".repeat(current_space as usize)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `" ".repeat(current_space as usize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/evjson.rs:100:35 [INFO] [stderr] | [INFO] [stderr] 100 | fn parse_key(index: usize, chars: &Vec) -> Result<(usize, String), String> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/evjson.rs:123:37 [INFO] [stderr] | [INFO] [stderr] 123 | fn parse_array(index: usize, chars: &Vec) -> Result<(usize, EVValue), String> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/evjson.rs:151:36 [INFO] [stderr] | [INFO] [stderr] 151 | fn parse_pair(index: usize, chars: &Vec) -> Result<(usize, String, EVValue), String> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/evjson.rs:179:38 [INFO] [stderr] | [INFO] [stderr] 179 | fn parse_object(index: usize, chars: &Vec) -> Result<(usize, EVObject), String> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/evjson.rs:212:39 [INFO] [stderr] | [INFO] [stderr] 212 | fn parse_number(_index: usize, chars: &Vec) -> Result<(usize, EVValue), String> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/evjson.rs:257:39 [INFO] [stderr] | [INFO] [stderr] 257 | fn parse_boolean(index: usize, chars: &Vec) -> Result<(usize, EVValue), String> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/evjson.rs:289:36 [INFO] [stderr] | [INFO] [stderr] 289 | fn parse_null(index: usize, chars: &Vec) -> Result<(usize, EVValue), String> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/evjson.rs:299:37 [INFO] [stderr] | [INFO] [stderr] 299 | fn parse_value(index: usize, chars: &Vec) -> Result<(usize, EVValue), String> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/evjson.rs:334:38 [INFO] [stderr] | [INFO] [stderr] 334 | fn parse_string(index: usize, chars: &Vec) -> Result<(usize, String), String> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [optimized + debuginfo] target(s) in 1.19s [INFO] running `"docker" "inspect" "2852de3d9df768dccf2e82908d22362b7ea72430a8b4477b9a4b06f25a4134c6"` [INFO] running `"docker" "rm" "-f" "2852de3d9df768dccf2e82908d22362b7ea72430a8b4477b9a4b06f25a4134c6"` [INFO] [stdout] 2852de3d9df768dccf2e82908d22362b7ea72430a8b4477b9a4b06f25a4134c6