[INFO] updating cached repository ElectricCoffee/cards-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ElectricCoffee/cards-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ElectricCoffee/cards-rust" "work/ex/clippy-test-run/sources/stable/gh/ElectricCoffee/cards-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ElectricCoffee/cards-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ElectricCoffee/cards-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ElectricCoffee/cards-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ElectricCoffee/cards-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5dae56dc5e55e87b66e7d671cc7f04f7b728bfde [INFO] sha for GitHub repo ElectricCoffee/cards-rust: 5dae56dc5e55e87b66e7d671cc7f04f7b728bfde [INFO] validating manifest of ElectricCoffee/cards-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ElectricCoffee/cards-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ElectricCoffee/cards-rust [INFO] finished frobbing ElectricCoffee/cards-rust [INFO] frobbed toml for ElectricCoffee/cards-rust written to work/ex/clippy-test-run/sources/stable/gh/ElectricCoffee/cards-rust/Cargo.toml [INFO] started frobbing ElectricCoffee/cards-rust [INFO] finished frobbing ElectricCoffee/cards-rust [INFO] frobbed toml for ElectricCoffee/cards-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ElectricCoffee/cards-rust/Cargo.toml [INFO] crate ElectricCoffee/cards-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ElectricCoffee/cards-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ElectricCoffee/cards-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4580b89f6f47bdec370a33b1f9be0008a8e4618376e0a78fc3052373ee42b57a [INFO] running `"docker" "start" "-a" "4580b89f6f47bdec370a33b1f9be0008a8e4618376e0a78fc3052373ee42b57a"` [INFO] [stderr] Checking cards v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:21:16 [INFO] [stderr] | [INFO] [stderr] 21 | Card { suit: suit, name: name, value: value } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `suit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:21:28 [INFO] [stderr] | [INFO] [stderr] 21 | Card { suit: suit, name: name, value: value } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:21:40 [INFO] [stderr] | [INFO] [stderr] 21 | Card { suit: suit, name: name, value: value } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:21:16 [INFO] [stderr] | [INFO] [stderr] 21 | Card { suit: suit, name: name, value: value } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `suit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:21:28 [INFO] [stderr] | [INFO] [stderr] 21 | Card { suit: suit, name: name, value: value } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:21:40 [INFO] [stderr] | [INFO] [stderr] 21 | Card { suit: suit, name: name, value: value } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | return Deck::from_vec_deque(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Deck::from_vec_deque(result)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | return Deck::from_vec_deque(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Deck::from_vec_deque(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | return Deck::from_vec_deque(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Deck::from_vec_deque(result)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | return Deck::from_vec_deque(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Deck::from_vec_deque(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: item `Deck` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | / impl Deck { [INFO] [stderr] 42 | | pub fn from_vec_deque(input: VecDeque) -> Deck { [INFO] [stderr] 43 | | Deck { cards: input } [INFO] [stderr] 44 | | } [INFO] [stderr] ... | [INFO] [stderr] 118 | | } [INFO] [stderr] 119 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `Deck` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | / impl Deck { [INFO] [stderr] 42 | | pub fn from_vec_deque(input: VecDeque) -> Deck { [INFO] [stderr] 43 | | Deck { cards: input } [INFO] [stderr] 44 | | } [INFO] [stderr] ... | [INFO] [stderr] 118 | | } [INFO] [stderr] 119 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.67s [INFO] running `"docker" "inspect" "4580b89f6f47bdec370a33b1f9be0008a8e4618376e0a78fc3052373ee42b57a"` [INFO] running `"docker" "rm" "-f" "4580b89f6f47bdec370a33b1f9be0008a8e4618376e0a78fc3052373ee42b57a"` [INFO] [stdout] 4580b89f6f47bdec370a33b1f9be0008a8e4618376e0a78fc3052373ee42b57a