[INFO] updating cached repository EkardNT/sudoku [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/EkardNT/sudoku [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/EkardNT/sudoku" "work/ex/clippy-test-run/sources/stable/gh/EkardNT/sudoku"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/EkardNT/sudoku'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/EkardNT/sudoku" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EkardNT/sudoku"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EkardNT/sudoku'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3d13dad9d3a68019eab7c5cce1291d514f6f6e5e [INFO] sha for GitHub repo EkardNT/sudoku: 3d13dad9d3a68019eab7c5cce1291d514f6f6e5e [INFO] validating manifest of EkardNT/sudoku on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of EkardNT/sudoku on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing EkardNT/sudoku [INFO] finished frobbing EkardNT/sudoku [INFO] frobbed toml for EkardNT/sudoku written to work/ex/clippy-test-run/sources/stable/gh/EkardNT/sudoku/Cargo.toml [INFO] started frobbing EkardNT/sudoku [INFO] finished frobbing EkardNT/sudoku [INFO] frobbed toml for EkardNT/sudoku written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EkardNT/sudoku/Cargo.toml [INFO] crate EkardNT/sudoku has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting EkardNT/sudoku against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/EkardNT/sudoku:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ee2e652b56046924d49c576784926a22d8c2ea0c77c63078b124a33f4009f2c6 [INFO] running `"docker" "start" "-a" "ee2e652b56046924d49c576784926a22d8c2ea0c77c63078b124a33f4009f2c6"` [INFO] [stderr] Checking sudoku v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around `while` condition [INFO] [stderr] --> src/matrix.rs:185:15 [INFO] [stderr] | [INFO] [stderr] 185 | while (current_down_index != header_index) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `while` condition [INFO] [stderr] --> src/matrix.rs:191:19 [INFO] [stderr] | [INFO] [stderr] 191 | while (current_right_index != current_down_index) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `while` condition [INFO] [stderr] --> src/matrix.rs:223:15 [INFO] [stderr] | [INFO] [stderr] 223 | while (current_up_index != header_index) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `while` condition [INFO] [stderr] --> src/matrix.rs:229:19 [INFO] [stderr] | [INFO] [stderr] 229 | while (current_left_index != current_up_index) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `while` condition [INFO] [stderr] --> src/matrix.rs:307:15 [INFO] [stderr] | [INFO] [stderr] 307 | while (current_down_index != min_header_index) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `while` condition [INFO] [stderr] --> src/matrix.rs:313:19 [INFO] [stderr] | [INFO] [stderr] 313 | while (current_right_index != current_down_index) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `while` condition [INFO] [stderr] --> src/matrix.rs:332:19 [INFO] [stderr] | [INFO] [stderr] 332 | while (current_left_index != current_down_index) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `while` condition [INFO] [stderr] --> src/matrix.rs:358:15 [INFO] [stderr] | [INFO] [stderr] 358 | while (current_header_index != Matrix::ROOT_INDEX) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/matrix.rs:376:24 [INFO] [stderr] | [INFO] [stderr] 376 | if (current_index == row_front_index) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Debug`, `Display`, `Formatter`, `Write` [INFO] [stderr] --> src/lib.rs:5:16 [INFO] [stderr] | [INFO] [stderr] 5 | use std::fmt::{Display, Write, Formatter, Debug}; [INFO] [stderr] | ^^^^^^^ ^^^^^ ^^^^^^^^^ ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str::FromStr` [INFO] [stderr] --> src/lib.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::str::FromStr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `matrix::*` [INFO] [stderr] --> src/lib.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use matrix::*; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `while` condition [INFO] [stderr] --> src/matrix.rs:185:15 [INFO] [stderr] | [INFO] [stderr] 185 | while (current_down_index != header_index) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `while` condition [INFO] [stderr] --> src/matrix.rs:191:19 [INFO] [stderr] | [INFO] [stderr] 191 | while (current_right_index != current_down_index) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `while` condition [INFO] [stderr] --> src/matrix.rs:223:15 [INFO] [stderr] | [INFO] [stderr] 223 | while (current_up_index != header_index) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `while` condition [INFO] [stderr] --> src/matrix.rs:229:19 [INFO] [stderr] | [INFO] [stderr] 229 | while (current_left_index != current_up_index) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `while` condition [INFO] [stderr] --> src/matrix.rs:307:15 [INFO] [stderr] | [INFO] [stderr] 307 | while (current_down_index != min_header_index) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `while` condition [INFO] [stderr] --> src/matrix.rs:313:19 [INFO] [stderr] | [INFO] [stderr] 313 | while (current_right_index != current_down_index) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `while` condition [INFO] [stderr] --> src/matrix.rs:332:19 [INFO] [stderr] | [INFO] [stderr] 332 | while (current_left_index != current_down_index) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `while` condition [INFO] [stderr] --> src/matrix.rs:358:15 [INFO] [stderr] | [INFO] [stderr] 358 | while (current_header_index != Matrix::ROOT_INDEX) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/matrix.rs:376:24 [INFO] [stderr] | [INFO] [stderr] 376 | if (current_index == row_front_index) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused imports: `NodeKind`, `Node` [INFO] [stderr] --> src/matrix.rs:389:25 [INFO] [stderr] | [INFO] [stderr] 389 | use super::{Matrix, Node, NodeKind}; [INFO] [stderr] | ^^^^ ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Debug`, `Display`, `Formatter`, `Write` [INFO] [stderr] --> src/lib.rs:5:16 [INFO] [stderr] | [INFO] [stderr] 5 | use std::fmt::{Display, Write, Formatter, Debug}; [INFO] [stderr] | ^^^^^^^ ^^^^^ ^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str::FromStr` [INFO] [stderr] --> src/lib.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::str::FromStr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `matrix::*` [INFO] [stderr] --> src/lib.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use matrix::*; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/board.rs:211:13 [INFO] [stderr] | [INFO] [stderr] 211 | let i = col + row * 9; [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `column` [INFO] [stderr] --> src/coords.rs:119:28 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn to_dense(&self, column: &SparseColumn) -> DenseRow { [INFO] [stderr] | ^^^^^^ help: consider using `_column` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sparse_row` [INFO] [stderr] --> src/lib.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | let sparse_row = SparseRow::new(row_index); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_sparse_row` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `board` [INFO] [stderr] --> src/lib.rs:123:25 [INFO] [stderr] | [INFO] [stderr] 123 | fn solve(&mut self, board: &mut Board) -> Result<(), ()> { [INFO] [stderr] | ^^^^^ help: consider using `_board` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | let mut matrix = [[Link::default(); NONZERO_CONSTRAINTS_PER_POSSIBILITY]; POSSIBILITIES]; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | let mut headers = [Header::default(); CONSTRAINTS]; [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | let mut constraint: &mut Link = &mut row[dense_column_index]; [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `to_sparse` [INFO] [stderr] --> src/coords.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn to_sparse(&self) -> SparseRow { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `to_sparse` [INFO] [stderr] --> src/coords.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | pub fn to_sparse(&self, row: &DenseRow) -> SparseColumn { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `POSSIBILITIES` [INFO] [stderr] --> src/matrix.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | const POSSIBILITIES: usize = 9 * 9 * 9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `CONSTRAINTS` [INFO] [stderr] --> src/matrix.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | const CONSTRAINTS: usize = 9 * 9 + 9 * 9 + 9 * 9 + 9 * 9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NONZERO_CONSTRAINTS_PER_POSSIBILITY` [INFO] [stderr] --> src/matrix.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | const NONZERO_CONSTRAINTS_PER_POSSIBILITY: usize = 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MATRIX_NODE_COUNT` [INFO] [stderr] --> src/matrix.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | const MATRIX_NODE_COUNT: usize = 1 + CONSTRAINTS + POSSIBILITIES * NONZERO_CONSTRAINTS_PER_POSSIBILITY; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn to_sparse(&self) -> SparseRow { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:24:23 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn natural_up(&self, column: &DenseColumn) -> DenseRow { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:24:38 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn natural_up(&self, column: &DenseColumn) -> DenseRow { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `DenseColumn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn natural_down(&self, column: &DenseColumn) -> DenseRow { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:68:40 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn natural_down(&self, column: &DenseColumn) -> DenseRow { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `DenseColumn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:119:21 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn to_dense(&self, column: &SparseColumn) -> DenseRow { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:119:36 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn to_dense(&self, column: &SparseColumn) -> DenseRow { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `SparseColumn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:130:22 [INFO] [stderr] | [INFO] [stderr] 130 | pub fn to_sparse(&self, row: &DenseRow) -> SparseColumn { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:130:34 [INFO] [stderr] | [INFO] [stderr] 130 | pub fn to_sparse(&self, row: &DenseRow) -> SparseColumn { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `DenseRow` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `81` [INFO] [stderr] --> src/coords.rs:134:45 [INFO] [stderr] | [INFO] [stderr] 134 | Constraint::Row => SparseColumn(81 * 1 + row.0 % 9 + 9 * (row.0 / 81)), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:140:19 [INFO] [stderr] | [INFO] [stderr] 140 | fn constraint(&self) -> Constraint { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:152:25 [INFO] [stderr] | [INFO] [stderr] 152 | pub fn natural_left(&self) -> DenseColumn { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:164:26 [INFO] [stderr] | [INFO] [stderr] 164 | pub fn natural_right(&self) -> DenseColumn { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:181:21 [INFO] [stderr] | [INFO] [stderr] 181 | pub fn to_dense(&self) -> DenseColumn { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:185:22 [INFO] [stderr] | [INFO] [stderr] 185 | pub fn first_row(&self) -> SparseRow { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.0` [INFO] [stderr] --> src/coords.rs:190:41 [INFO] [stderr] | [INFO] [stderr] 190 | let constraint_offset = self.0 - 0 * 9 * 9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/coords.rs:190:50 [INFO] [stderr] | [INFO] [stderr] 190 | let constraint_offset = self.0 - 0 * 9 * 9; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::erasing_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/coords.rs:190:50 [INFO] [stderr] | [INFO] [stderr] 190 | let constraint_offset = self.0 - 0 * 9 * 9; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `9` [INFO] [stderr] --> src/coords.rs:194:50 [INFO] [stderr] | [INFO] [stderr] 194 | let constraint_offset = self.0 - 1 * 9 * 9; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/matrix.rs:359:13 [INFO] [stderr] | [INFO] [stderr] 359 | writeln!(f, "col {:?}", self.nodes[current_header_index]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `81` [INFO] [stderr] --> src/board.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | 81 * 1 + self.row * 9 + self.number - 1 [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `board::Board` [INFO] [stderr] --> src/board.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | / pub fn new() -> Board { [INFO] [stderr] 77 | | Board { [INFO] [stderr] 78 | | entries: [0; 9 * 9] [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 75 | impl Default for board::Board { [INFO] [stderr] 76 | fn default() -> Self { [INFO] [stderr] 77 | Self::new() [INFO] [stderr] 78 | } [INFO] [stderr] 79 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/board.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | write!(to, "{} ", c); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/board.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | write!(to, "{}", self.entries[9*9-1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: comparison is useless due to type limits [INFO] [stderr] --> src/board.rs:158:25 [INFO] [stderr] | [INFO] [stderr] 158 | assert!(value >= 0 && value <= 9); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_comparisons)] on by default [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/board.rs:158:25 [INFO] [stderr] | [INFO] [stderr] 158 | assert!(value >= 0 && value <= 9); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, this comparison is always true [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/board.rs:202:13 [INFO] [stderr] | [INFO] [stderr] 202 | fmt_row(self, f, &mut buf, row); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `DLXSolver` [INFO] [stderr] --> src/lib.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / pub fn new() -> DLXSolver { [INFO] [stderr] 64 | | // Allocate memory for matrix and headers. [INFO] [stderr] 65 | | let mut matrix = [[Link::default(); NONZERO_CONSTRAINTS_PER_POSSIBILITY]; POSSIBILITIES]; [INFO] [stderr] 66 | | let mut headers = [Header::default(); CONSTRAINTS]; [INFO] [stderr] ... | [INFO] [stderr] 75 | | solver [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | impl Default for DLXSolver { [INFO] [stderr] 63 | fn default() -> Self { [INFO] [stderr] 64 | Self::new() [INFO] [stderr] 65 | } [INFO] [stderr] 66 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | for ref link in row { [INFO] [stderr] | ^^^^^^^^ --- help: try: `let link = &row;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:113:44 [INFO] [stderr] | [INFO] [stderr] 113 | fn reset_link(row: &mut [Link], dense_row: &DenseRow, dense_column_index: usize) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `DenseRow` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sudoku`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/board.rs:211:13 [INFO] [stderr] | [INFO] [stderr] 211 | let i = col + row * 9; [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `dense_row_index` [INFO] [stderr] --> src/coords.rs:276:17 [INFO] [stderr] | [INFO] [stderr] 276 | for dense_row_index in 0..9*9*9 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using `_dense_row_index` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `column` [INFO] [stderr] --> src/coords.rs:119:28 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn to_dense(&self, column: &SparseColumn) -> DenseRow { [INFO] [stderr] | ^^^^^^ help: consider using `_column` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sparse_row` [INFO] [stderr] --> src/lib.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | let sparse_row = SparseRow::new(row_index); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_sparse_row` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `board` [INFO] [stderr] --> src/lib.rs:123:25 [INFO] [stderr] | [INFO] [stderr] 123 | fn solve(&mut self, board: &mut Board) -> Result<(), ()> { [INFO] [stderr] | ^^^^^ help: consider using `_board` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | let mut matrix = [[Link::default(); NONZERO_CONSTRAINTS_PER_POSSIBILITY]; POSSIBILITIES]; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | let mut headers = [Header::default(); CONSTRAINTS]; [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | let mut constraint: &mut Link = &mut row[dense_column_index]; [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `to_sparse` [INFO] [stderr] --> src/coords.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn to_sparse(&self) -> SparseRow { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `POSSIBILITIES` [INFO] [stderr] --> src/matrix.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | const POSSIBILITIES: usize = 9 * 9 * 9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `CONSTRAINTS` [INFO] [stderr] --> src/matrix.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | const CONSTRAINTS: usize = 9 * 9 + 9 * 9 + 9 * 9 + 9 * 9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NONZERO_CONSTRAINTS_PER_POSSIBILITY` [INFO] [stderr] --> src/matrix.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | const NONZERO_CONSTRAINTS_PER_POSSIBILITY: usize = 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MATRIX_NODE_COUNT` [INFO] [stderr] --> src/matrix.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | const MATRIX_NODE_COUNT: usize = 1 + CONSTRAINTS + POSSIBILITIES * NONZERO_CONSTRAINTS_PER_POSSIBILITY; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn to_sparse(&self) -> SparseRow { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:24:23 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn natural_up(&self, column: &DenseColumn) -> DenseRow { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:24:38 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn natural_up(&self, column: &DenseColumn) -> DenseRow { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `DenseColumn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn natural_down(&self, column: &DenseColumn) -> DenseRow { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:68:40 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn natural_down(&self, column: &DenseColumn) -> DenseRow { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `DenseColumn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:119:21 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn to_dense(&self, column: &SparseColumn) -> DenseRow { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:119:36 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn to_dense(&self, column: &SparseColumn) -> DenseRow { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `SparseColumn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:130:22 [INFO] [stderr] | [INFO] [stderr] 130 | pub fn to_sparse(&self, row: &DenseRow) -> SparseColumn { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:130:34 [INFO] [stderr] | [INFO] [stderr] 130 | pub fn to_sparse(&self, row: &DenseRow) -> SparseColumn { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `DenseRow` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `81` [INFO] [stderr] --> src/coords.rs:134:45 [INFO] [stderr] | [INFO] [stderr] 134 | Constraint::Row => SparseColumn(81 * 1 + row.0 % 9 + 9 * (row.0 / 81)), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:140:19 [INFO] [stderr] | [INFO] [stderr] 140 | fn constraint(&self) -> Constraint { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:152:25 [INFO] [stderr] | [INFO] [stderr] 152 | pub fn natural_left(&self) -> DenseColumn { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:164:26 [INFO] [stderr] | [INFO] [stderr] 164 | pub fn natural_right(&self) -> DenseColumn { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:181:21 [INFO] [stderr] | [INFO] [stderr] 181 | pub fn to_dense(&self) -> DenseColumn { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coords.rs:185:22 [INFO] [stderr] | [INFO] [stderr] 185 | pub fn first_row(&self) -> SparseRow { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.0` [INFO] [stderr] --> src/coords.rs:190:41 [INFO] [stderr] | [INFO] [stderr] 190 | let constraint_offset = self.0 - 0 * 9 * 9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/coords.rs:190:50 [INFO] [stderr] | [INFO] [stderr] 190 | let constraint_offset = self.0 - 0 * 9 * 9; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::erasing_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/coords.rs:190:50 [INFO] [stderr] | [INFO] [stderr] 190 | let constraint_offset = self.0 - 0 * 9 * 9; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `9` [INFO] [stderr] --> src/coords.rs:194:50 [INFO] [stderr] | [INFO] [stderr] 194 | let constraint_offset = self.0 - 1 * 9 * 9; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/matrix.rs:359:13 [INFO] [stderr] | [INFO] [stderr] 359 | writeln!(f, "col {:?}", self.nodes[current_header_index]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `81` [INFO] [stderr] --> src/board.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | 81 * 1 + self.row * 9 + self.number - 1 [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `board::Board` [INFO] [stderr] --> src/board.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | / pub fn new() -> Board { [INFO] [stderr] 77 | | Board { [INFO] [stderr] 78 | | entries: [0; 9 * 9] [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 75 | impl Default for board::Board { [INFO] [stderr] 76 | fn default() -> Self { [INFO] [stderr] 77 | Self::new() [INFO] [stderr] 78 | } [INFO] [stderr] 79 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/board.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | write!(to, "{} ", c); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/board.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | write!(to, "{}", self.entries[9*9-1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: comparison is useless due to type limits [INFO] [stderr] --> src/board.rs:158:25 [INFO] [stderr] | [INFO] [stderr] 158 | assert!(value >= 0 && value <= 9); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_comparisons)] on by default [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/board.rs:158:25 [INFO] [stderr] | [INFO] [stderr] 158 | assert!(value >= 0 && value <= 9); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, this comparison is always true [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/board.rs:202:13 [INFO] [stderr] | [INFO] [stderr] 202 | fmt_row(self, f, &mut buf, row); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `DLXSolver` [INFO] [stderr] --> src/lib.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / pub fn new() -> DLXSolver { [INFO] [stderr] 64 | | // Allocate memory for matrix and headers. [INFO] [stderr] 65 | | let mut matrix = [[Link::default(); NONZERO_CONSTRAINTS_PER_POSSIBILITY]; POSSIBILITIES]; [INFO] [stderr] 66 | | let mut headers = [Header::default(); CONSTRAINTS]; [INFO] [stderr] ... | [INFO] [stderr] 75 | | solver [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | impl Default for DLXSolver { [INFO] [stderr] 63 | fn default() -> Self { [INFO] [stderr] 64 | Self::new() [INFO] [stderr] 65 | } [INFO] [stderr] 66 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | for ref link in row { [INFO] [stderr] | ^^^^^^^^ --- help: try: `let link = &row;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:113:44 [INFO] [stderr] | [INFO] [stderr] 113 | fn reset_link(row: &mut [Link], dense_row: &DenseRow, dense_column_index: usize) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `DenseRow` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sudoku`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ee2e652b56046924d49c576784926a22d8c2ea0c77c63078b124a33f4009f2c6"` [INFO] running `"docker" "rm" "-f" "ee2e652b56046924d49c576784926a22d8c2ea0c77c63078b124a33f4009f2c6"` [INFO] [stdout] ee2e652b56046924d49c576784926a22d8c2ea0c77c63078b124a33f4009f2c6