[INFO] updating cached repository Ecnavda/weight_for_weight [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Ecnavda/weight_for_weight [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Ecnavda/weight_for_weight" "work/ex/clippy-test-run/sources/stable/gh/Ecnavda/weight_for_weight"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Ecnavda/weight_for_weight'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Ecnavda/weight_for_weight" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ecnavda/weight_for_weight"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ecnavda/weight_for_weight'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 27b1b8412dd8d1d1bba3e06b09d4a01a19c4f27b [INFO] sha for GitHub repo Ecnavda/weight_for_weight: 27b1b8412dd8d1d1bba3e06b09d4a01a19c4f27b [INFO] validating manifest of Ecnavda/weight_for_weight on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Ecnavda/weight_for_weight on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Ecnavda/weight_for_weight [INFO] finished frobbing Ecnavda/weight_for_weight [INFO] frobbed toml for Ecnavda/weight_for_weight written to work/ex/clippy-test-run/sources/stable/gh/Ecnavda/weight_for_weight/Cargo.toml [INFO] started frobbing Ecnavda/weight_for_weight [INFO] finished frobbing Ecnavda/weight_for_weight [INFO] frobbed toml for Ecnavda/weight_for_weight written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ecnavda/weight_for_weight/Cargo.toml [INFO] crate Ecnavda/weight_for_weight has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Ecnavda/weight_for_weight against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ecnavda/weight_for_weight:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 939fc3edb6998a506ad10e9efacd97ec6fe4b9c6d6fadafacbf4dd2fef421eae [INFO] running `"docker" "start" "-a" "939fc3edb6998a506ad10e9efacd97ec6fe4b9c6d6fadafacbf4dd2fef421eae"` [INFO] [stderr] Checking weight_for_weight v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | return a.0.cmp(&b.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `a.0.cmp(&b.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | return a.1.cmp(&b.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `a.1.cmp(&b.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:8:31 [INFO] [stderr] | [INFO] [stderr] 8 | let original: Vec<&str> = s.clone().split_whitespace().collect(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 8 | let original: Vec<&str> = &(*s).clone().split_whitespace().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 8 | let original: Vec<&str> = &str::clone(s).split_whitespace().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `weight_for_weight`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | return a.0.cmp(&b.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `a.0.cmp(&b.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | return a.1.cmp(&b.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `a.1.cmp(&b.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:8:31 [INFO] [stderr] | [INFO] [stderr] 8 | let original: Vec<&str> = s.clone().split_whitespace().collect(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 8 | let original: Vec<&str> = &(*s).clone().split_whitespace().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 8 | let original: Vec<&str> = &str::clone(s).split_whitespace().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `weight_for_weight`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "939fc3edb6998a506ad10e9efacd97ec6fe4b9c6d6fadafacbf4dd2fef421eae"` [INFO] running `"docker" "rm" "-f" "939fc3edb6998a506ad10e9efacd97ec6fe4b9c6d6fadafacbf4dd2fef421eae"` [INFO] [stdout] 939fc3edb6998a506ad10e9efacd97ec6fe4b9c6d6fadafacbf4dd2fef421eae