[INFO] updating cached repository Drunkendarknut/tilext
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Drunkendarknut/tilext
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Drunkendarknut/tilext" "work/ex/clippy-test-run/sources/stable/gh/Drunkendarknut/tilext"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Drunkendarknut/tilext'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Drunkendarknut/tilext" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Drunkendarknut/tilext"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Drunkendarknut/tilext'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 33370b96dd5368814c5b0e8d6e39afb963590ebc
[INFO] sha for GitHub repo Drunkendarknut/tilext: 33370b96dd5368814c5b0e8d6e39afb963590ebc
[INFO] validating manifest of Drunkendarknut/tilext on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Drunkendarknut/tilext on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Drunkendarknut/tilext
[INFO] finished frobbing Drunkendarknut/tilext
[INFO] frobbed toml for Drunkendarknut/tilext written to work/ex/clippy-test-run/sources/stable/gh/Drunkendarknut/tilext/Cargo.toml
[INFO] started frobbing Drunkendarknut/tilext
[INFO] finished frobbing Drunkendarknut/tilext
[INFO] frobbed toml for Drunkendarknut/tilext written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Drunkendarknut/tilext/Cargo.toml
[INFO] crate Drunkendarknut/tilext has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Drunkendarknut/tilext against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Drunkendarknut/tilext:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 4fa860d49d4b4fa31f9d6d9ba47861e77e0415552bae88dd45b1bd75eca50d0b
[INFO] running `"docker" "start" "-a" "4fa860d49d4b4fa31f9d6d9ba47861e77e0415552bae88dd45b1bd75eca50d0b"`
[INFO] [stderr]     Checking rgb v0.8.10
[INFO] [stderr]     Checking lodepng v2.1.5
[INFO] [stderr]     Checking tilext v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:99:5
[INFO] [stderr]    |
[INFO] [stderr] 99 |     return Ok(c);
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(c)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:121:5
[INFO] [stderr]     |
[INFO] [stderr] 121 |     return count;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `count`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:291:5
[INFO] [stderr]     |
[INFO] [stderr] 291 |     return Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:99:5
[INFO] [stderr]    |
[INFO] [stderr] 99 |     return Ok(c);
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(c)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:121:5
[INFO] [stderr]     |
[INFO] [stderr] 121 |     return count;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `count`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:291:5
[INFO] [stderr]     |
[INFO] [stderr] 291 |     return Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:27:25
[INFO] [stderr]    |
[INFO] [stderr] 27 | fn parse_args<'a>(args: &'a Vec<String>) -> Result<Config<'a>, Box<Error>>
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:81:8
[INFO] [stderr]    |
[INFO] [stderr] 81 |     if input_paths.len() == 0
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input_paths.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/main.rs:269:36
[INFO] [stderr]     |
[INFO] [stderr] 269 |                         let from = image.buffer[from_i].clone();
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `image.buffer[from_i]`
[INFO] [stderr]     |
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:27:25
[INFO] [stderr]    |
[INFO] [stderr] 27 | fn parse_args<'a>(args: &'a Vec<String>) -> Result<Config<'a>, Box<Error>>
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:81:8
[INFO] [stderr]    |
[INFO] [stderr] 81 |     if input_paths.len() == 0
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input_paths.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/main.rs:269:36
[INFO] [stderr]     |
[INFO] [stderr] 269 |                         let from = image.buffer[from_i].clone();
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `image.buffer[from_i]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.44s
[INFO] running `"docker" "inspect" "4fa860d49d4b4fa31f9d6d9ba47861e77e0415552bae88dd45b1bd75eca50d0b"`
[INFO] running `"docker" "rm" "-f" "4fa860d49d4b4fa31f9d6d9ba47861e77e0415552bae88dd45b1bd75eca50d0b"`
[INFO] [stdout] 4fa860d49d4b4fa31f9d6d9ba47861e77e0415552bae88dd45b1bd75eca50d0b