[INFO] updating cached repository DonkeySchote/rust-erathostenes-sieve [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/DonkeySchote/rust-erathostenes-sieve [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/DonkeySchote/rust-erathostenes-sieve" "work/ex/clippy-test-run/sources/stable/gh/DonkeySchote/rust-erathostenes-sieve"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/DonkeySchote/rust-erathostenes-sieve'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/DonkeySchote/rust-erathostenes-sieve" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DonkeySchote/rust-erathostenes-sieve"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DonkeySchote/rust-erathostenes-sieve'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7c308d780da275ea05059d19e43c6558c7d72064 [INFO] sha for GitHub repo DonkeySchote/rust-erathostenes-sieve: 7c308d780da275ea05059d19e43c6558c7d72064 [INFO] validating manifest of DonkeySchote/rust-erathostenes-sieve on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of DonkeySchote/rust-erathostenes-sieve on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing DonkeySchote/rust-erathostenes-sieve [INFO] finished frobbing DonkeySchote/rust-erathostenes-sieve [INFO] frobbed toml for DonkeySchote/rust-erathostenes-sieve written to work/ex/clippy-test-run/sources/stable/gh/DonkeySchote/rust-erathostenes-sieve/Cargo.toml [INFO] started frobbing DonkeySchote/rust-erathostenes-sieve [INFO] finished frobbing DonkeySchote/rust-erathostenes-sieve [INFO] frobbed toml for DonkeySchote/rust-erathostenes-sieve written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DonkeySchote/rust-erathostenes-sieve/Cargo.toml [INFO] crate DonkeySchote/rust-erathostenes-sieve has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting DonkeySchote/rust-erathostenes-sieve against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DonkeySchote/rust-erathostenes-sieve:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 43b020ad93d81725f232280795da5c408d686ade80b6573cac4f501affad0802 [INFO] running `"docker" "start" "-a" "43b020ad93d81725f232280795da5c408d686ade80b6573cac4f501affad0802"` [INFO] [stderr] Checking rust-erathostenes-sieve v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:51:14 [INFO] [stderr] | [INFO] [stderr] 51 | for x in start..end+1 { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `start..=end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | if x % y == 0 {true} else {false} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `x % y == 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:51:14 [INFO] [stderr] | [INFO] [stderr] 51 | for x in start..end+1 { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `start..=end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | if x % y == 0 {true} else {false} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `x % y == 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.70s [INFO] running `"docker" "inspect" "43b020ad93d81725f232280795da5c408d686ade80b6573cac4f501affad0802"` [INFO] running `"docker" "rm" "-f" "43b020ad93d81725f232280795da5c408d686ade80b6573cac4f501affad0802"` [INFO] [stdout] 43b020ad93d81725f232280795da5c408d686ade80b6573cac4f501affad0802