[INFO] updating cached repository DocWatson/tcg-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/DocWatson/tcg-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/DocWatson/tcg-rust" "work/ex/clippy-test-run/sources/stable/gh/DocWatson/tcg-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/DocWatson/tcg-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/DocWatson/tcg-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DocWatson/tcg-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DocWatson/tcg-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 997bf18dac8cd4d71d1be4e8ba4ef3c4dd77bab6 [INFO] sha for GitHub repo DocWatson/tcg-rust: 997bf18dac8cd4d71d1be4e8ba4ef3c4dd77bab6 [INFO] validating manifest of DocWatson/tcg-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of DocWatson/tcg-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing DocWatson/tcg-rust [INFO] finished frobbing DocWatson/tcg-rust [INFO] frobbed toml for DocWatson/tcg-rust written to work/ex/clippy-test-run/sources/stable/gh/DocWatson/tcg-rust/Cargo.toml [INFO] started frobbing DocWatson/tcg-rust [INFO] finished frobbing DocWatson/tcg-rust [INFO] frobbed toml for DocWatson/tcg-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DocWatson/tcg-rust/Cargo.toml [INFO] crate DocWatson/tcg-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting DocWatson/tcg-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DocWatson/tcg-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aeb3bbf64c534f5ddfd7eae49c2c5fa9e9a15b854ed6eab9792eb16ab7f4a857 [INFO] running `"docker" "start" "-a" "aeb3bbf64c534f5ddfd7eae49c2c5fa9e9a15b854ed6eab9792eb16ab7f4a857"` [INFO] [stderr] Checking tcg-kata v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/card.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | cost: cost [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cost` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/deck.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | cards: cards [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cards` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/mana.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | current: current, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `current` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/mana.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | maximum: maximum [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `maximum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/player.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/player.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | deck: deck, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `deck` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/mod.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | player1: player1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `player1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/mod.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | player2: player2 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `player2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/card.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | cost: cost [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cost` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/deck.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | cards: cards [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cards` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/mana.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | current: current, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `current` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/mana.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | maximum: maximum [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `maximum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/player.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/player.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | deck: deck, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `deck` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/mod.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | player1: player1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `player1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/mod.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | player2: player2 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `player2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/game/deck.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | drawn_card [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/game/deck.rs:37:26 [INFO] [stderr] | [INFO] [stderr] 37 | let drawn_card = self.cards.pop(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/mod.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/game/deck.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | drawn_card [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/game/deck.rs:37:26 [INFO] [stderr] | [INFO] [stderr] 37 | let drawn_card = self.cards.pop(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/mod.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `game::deck::Deck` [INFO] [stderr] --> src/game/deck.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Deck { [INFO] [stderr] 14 | | let mut cards: Vec = vec![]; [INFO] [stderr] 15 | | // counts as defined by the Kata rules [INFO] [stderr] 16 | | let mana_counts = [0,0,1,1,2,2,2,3,3,3,3,4,4,4,5,5,6,6,7,8]; [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/game/mod.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | &self.player1.update_turn_mana(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.player1.update_turn_mana();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/game/mod.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | &self.player2.update_turn_mana(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.player2.update_turn_mana();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/game/mod.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | &self.player1.draw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.player1.draw();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/game/mod.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | &self.player2.draw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.player2.draw();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `game::deck::Deck` [INFO] [stderr] --> src/game/deck.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Deck { [INFO] [stderr] 14 | | let mut cards: Vec = vec![]; [INFO] [stderr] 15 | | // counts as defined by the Kata rules [INFO] [stderr] 16 | | let mana_counts = [0,0,1,1,2,2,2,3,3,3,3,4,4,4,5,5,6,6,7,8]; [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/game/mod.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | &self.player1.update_turn_mana(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.player1.update_turn_mana();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/game/mod.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | &self.player2.update_turn_mana(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.player2.update_turn_mana();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/game/mod.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | &self.player1.draw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.player1.draw();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/game/mod.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | &self.player2.draw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.player2.draw();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.76s [INFO] running `"docker" "inspect" "aeb3bbf64c534f5ddfd7eae49c2c5fa9e9a15b854ed6eab9792eb16ab7f4a857"` [INFO] running `"docker" "rm" "-f" "aeb3bbf64c534f5ddfd7eae49c2c5fa9e9a15b854ed6eab9792eb16ab7f4a857"` [INFO] [stdout] aeb3bbf64c534f5ddfd7eae49c2c5fa9e9a15b854ed6eab9792eb16ab7f4a857