[INFO] updating cached repository Divoolej/advent_of_code
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Divoolej/advent_of_code
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Divoolej/advent_of_code" "work/ex/clippy-test-run/sources/stable/gh/Divoolej/advent_of_code"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Divoolej/advent_of_code'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Divoolej/advent_of_code" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Divoolej/advent_of_code"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Divoolej/advent_of_code'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] b01e674bb9da4d8ae5f199c1a4a351e162d0052d
[INFO] sha for GitHub repo Divoolej/advent_of_code: b01e674bb9da4d8ae5f199c1a4a351e162d0052d
[INFO] validating manifest of Divoolej/advent_of_code on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Divoolej/advent_of_code on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Divoolej/advent_of_code
[INFO] finished frobbing Divoolej/advent_of_code
[INFO] frobbed toml for Divoolej/advent_of_code written to work/ex/clippy-test-run/sources/stable/gh/Divoolej/advent_of_code/Cargo.toml
[INFO] started frobbing Divoolej/advent_of_code
[INFO] finished frobbing Divoolej/advent_of_code
[INFO] frobbed toml for Divoolej/advent_of_code written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Divoolej/advent_of_code/Cargo.toml
[INFO] crate Divoolej/advent_of_code has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Divoolej/advent_of_code against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Divoolej/advent_of_code:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ed7b96fac8301d95ef562ec7b69d8d808c7f038abed7becbc0173b1f817033b3
[INFO] running `"docker" "start" "-a" "ed7b96fac8301d95ef562ec7b69d8d808c7f038abed7becbc0173b1f817033b3"`
[INFO] [stderr]     Checking advent_of_code v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/year_2015/day_2/a.rs:4:39
[INFO] [stderr]   |
[INFO] [stderr] 4 | fn calculate_needed_paper(dimensions: &Vec<i32>) -> i32 {
[INFO] [stderr]   |                                       ^^^^^^^^^ help: change this to: `&[i32]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/year_2015/day_2/a.rs:14:53
[INFO] [stderr]    |
[INFO] [stderr] 14 |     let dimensions_list: Vec<&str> = contents.split("\n").collect();
[INFO] [stderr]    |                                                     ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/year_2015/day_2/a.rs:17:62
[INFO] [stderr]    |
[INFO] [stderr] 17 |       let mut dimensions: Vec<i32> = dimensions_string.split("x").filter_map( |d| d.parse().ok() ).collect();
[INFO] [stderr]    |                                                              ^^^ help: try using a char instead: `'x'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/year_2015/day_2/b.rs:4:39
[INFO] [stderr]   |
[INFO] [stderr] 4 | fn calculate_needed_paper(dimensions: &Vec<i32>) -> i32 {
[INFO] [stderr]   |                                       ^^^^^^^^^ help: change this to: `&[i32]`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/year_2015/day_2/b.rs:14:53
[INFO] [stderr]    |
[INFO] [stderr] 14 |     let dimensions_list: Vec<&str> = contents.split("\n").collect();
[INFO] [stderr]    |                                                     ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/year_2015/day_2/b.rs:17:62
[INFO] [stderr]    |
[INFO] [stderr] 17 |       let mut dimensions: Vec<i32> = dimensions_string.split("x").filter_map( |d| d.parse().ok() ).collect();
[INFO] [stderr]    |                                                              ^^^ help: try using a char instead: `'x'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/year_2017/day_2/a.rs:5:40
[INFO] [stderr]   |
[INFO] [stderr] 5 |     let numbers: Vec<i32> = line.split("\t").filter_map( |c| c.parse().ok() ).collect();
[INFO] [stderr]   |                                        ^^^^ help: try using a char instead: `'\t'`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/year_2017/day_2/a.rs:19:43
[INFO] [stderr]    |
[INFO] [stderr] 19 |     let lines: Vec<&str> = contents.split("\n").collect();
[INFO] [stderr]    |                                           ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/year_2017/day_2/b.rs:5:40
[INFO] [stderr]   |
[INFO] [stderr] 5 |     let numbers: Vec<i32> = line.split("\t").filter_map( |c| c.parse().ok() ).collect();
[INFO] [stderr]   |                                        ^^^^ help: try using a char instead: `'\t'`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/year_2017/day_2/b.rs:19:43
[INFO] [stderr]    |
[INFO] [stderr] 19 |     let lines: Vec<&str> = contents.split("\n").collect();
[INFO] [stderr]    |                                           ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/year_2017/day_3/a.rs:14:29
[INFO] [stderr]    |
[INFO] [stderr] 14 | fn level_for_target(target: &i32) -> i32 {
[INFO] [stderr]    |                             ^^^^ help: consider passing by value instead: `i32`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/year_2017/day_3/a.rs:24:25
[INFO] [stderr]    |
[INFO] [stderr] 24 | fn move_impossible(pos: &(i32, i32), level: i32, direction: &char) -> bool {
[INFO] [stderr]    |                         ^^^^^^^^^^^ help: consider passing by value instead: `(i32, i32)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/year_2017/day_3/a.rs:24:61
[INFO] [stderr]    |
[INFO] [stderr] 24 | fn move_impossible(pos: &(i32, i32), level: i32, direction: &char) -> bool {
[INFO] [stderr]    |                                                             ^^^^^ help: consider passing by value instead: `char`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/year_2017/day_3/a.rs:26:18
[INFO] [stderr]    |
[INFO] [stderr] 26 |         'N' => { if pos.1 == level { true } else { false } },
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `pos.1 == level`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/year_2017/day_3/a.rs:27:18
[INFO] [stderr]    |
[INFO] [stderr] 27 |         'E' => { if pos.0 == level { true } else { false } },
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `pos.0 == level`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/year_2017/day_3/a.rs:28:18
[INFO] [stderr]    |
[INFO] [stderr] 28 |         'S' => { if pos.1 == -level { true } else { false } },
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `pos.1 == -level`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/year_2017/day_3/a.rs:29:18
[INFO] [stderr]    |
[INFO] [stderr] 29 |         'W' => { if pos.0 == -level { true } else { false } },
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `pos.0 == -level`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/year_2017/day_3/a.rs:34:27
[INFO] [stderr]    |
[INFO] [stderr] 34 | fn move_in_direction(pos: &(i32, i32), direction: &char) -> (i32, i32) {
[INFO] [stderr]    |                           ^^^^^^^^^^^ help: consider passing by value instead: `(i32, i32)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/year_2017/day_3/a.rs:34:51
[INFO] [stderr]    |
[INFO] [stderr] 34 | fn move_in_direction(pos: &(i32, i32), direction: &char) -> (i32, i32) {
[INFO] [stderr]    |                                                   ^^^^^ help: consider passing by value instead: `char`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/year_2017/day_3/a.rs:44:22
[INFO] [stderr]    |
[INFO] [stderr] 44 | fn rotate(direction: &char) -> char {
[INFO] [stderr]    |                      ^^^^^ help: consider passing by value instead: `char`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/year_2017/day_3/b.rs:5:25
[INFO] [stderr]   |
[INFO] [stderr] 5 | fn move_impossible(pos: &(i32, i32), level: i32, direction: &char) -> bool {
[INFO] [stderr]   |                         ^^^^^^^^^^^ help: consider passing by value instead: `(i32, i32)`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/year_2017/day_3/b.rs:5:61
[INFO] [stderr]   |
[INFO] [stderr] 5 | fn move_impossible(pos: &(i32, i32), level: i32, direction: &char) -> bool {
[INFO] [stderr]   |                                                             ^^^^^ help: consider passing by value instead: `char`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]  --> src/year_2017/day_3/b.rs:7:18
[INFO] [stderr]   |
[INFO] [stderr] 7 |         'N' => { if pos.1 == level { true } else { false } },
[INFO] [stderr]   |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `pos.1 == level`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]  --> src/year_2017/day_3/b.rs:8:18
[INFO] [stderr]   |
[INFO] [stderr] 8 |         'E' => { if pos.0 == level { true } else { false } },
[INFO] [stderr]   |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `pos.0 == level`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]  --> src/year_2017/day_3/b.rs:9:18
[INFO] [stderr]   |
[INFO] [stderr] 9 |         'S' => { if pos.1 == -level { true } else { false } },
[INFO] [stderr]   |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `pos.1 == -level`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/year_2017/day_3/b.rs:10:18
[INFO] [stderr]    |
[INFO] [stderr] 10 |         'W' => { if pos.0 == -level { true } else { false } },
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `pos.0 == -level`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/year_2017/day_3/b.rs:15:22
[INFO] [stderr]    |
[INFO] [stderr] 15 | fn rotate(direction: &char) -> char {
[INFO] [stderr]    |                      ^^^^^ help: consider passing by value instead: `char`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/year_2017/day_3/b.rs:25:27
[INFO] [stderr]    |
[INFO] [stderr] 25 | fn move_in_direction(pos: &(i32, i32), direction: &char) -> (i32, i32) {
[INFO] [stderr]    |                           ^^^^^^^^^^^ help: consider passing by value instead: `(i32, i32)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/year_2017/day_3/b.rs:25:51
[INFO] [stderr]    |
[INFO] [stderr] 25 | fn move_in_direction(pos: &(i32, i32), direction: &char) -> (i32, i32) {
[INFO] [stderr]    |                                                   ^^^^^ help: consider passing by value instead: `char`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/year_2017/day_3/b.rs:35:57
[INFO] [stderr]    |
[INFO] [stderr] 35 | fn sum_adjacent(spiral: &HashMap<(i32, i32), i32>, pos: &(i32, i32)) -> i32 {
[INFO] [stderr]    |                                                         ^^^^^^^^^^^ help: consider passing by value instead: `(i32, i32)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/year_2015/day_2/a.rs:4:39
[INFO] [stderr]   |
[INFO] [stderr] 4 | fn calculate_needed_paper(dimensions: &Vec<i32>) -> i32 {
[INFO] [stderr]   |                                       ^^^^^^^^^ help: change this to: `&[i32]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/year_2015/day_2/a.rs:14:53
[INFO] [stderr]    |
[INFO] [stderr] 14 |     let dimensions_list: Vec<&str> = contents.split("\n").collect();
[INFO] [stderr]    |                                                     ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/year_2015/day_2/a.rs:17:62
[INFO] [stderr]    |
[INFO] [stderr] 17 |       let mut dimensions: Vec<i32> = dimensions_string.split("x").filter_map( |d| d.parse().ok() ).collect();
[INFO] [stderr]    |                                                              ^^^ help: try using a char instead: `'x'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/year_2015/day_2/b.rs:4:39
[INFO] [stderr]   |
[INFO] [stderr] 4 | fn calculate_needed_paper(dimensions: &Vec<i32>) -> i32 {
[INFO] [stderr]   |                                       ^^^^^^^^^ help: change this to: `&[i32]`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/year_2015/day_2/b.rs:14:53
[INFO] [stderr]    |
[INFO] [stderr] 14 |     let dimensions_list: Vec<&str> = contents.split("\n").collect();
[INFO] [stderr]    |                                                     ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/year_2015/day_2/b.rs:17:62
[INFO] [stderr]    |
[INFO] [stderr] 17 |       let mut dimensions: Vec<i32> = dimensions_string.split("x").filter_map( |d| d.parse().ok() ).collect();
[INFO] [stderr]    |                                                              ^^^ help: try using a char instead: `'x'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/year_2017/day_2/a.rs:5:40
[INFO] [stderr]   |
[INFO] [stderr] 5 |     let numbers: Vec<i32> = line.split("\t").filter_map( |c| c.parse().ok() ).collect();
[INFO] [stderr]   |                                        ^^^^ help: try using a char instead: `'\t'`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/year_2017/day_2/a.rs:19:43
[INFO] [stderr]    |
[INFO] [stderr] 19 |     let lines: Vec<&str> = contents.split("\n").collect();
[INFO] [stderr]    |                                           ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/year_2017/day_2/b.rs:5:40
[INFO] [stderr]   |
[INFO] [stderr] 5 |     let numbers: Vec<i32> = line.split("\t").filter_map( |c| c.parse().ok() ).collect();
[INFO] [stderr]   |                                        ^^^^ help: try using a char instead: `'\t'`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/year_2017/day_2/b.rs:19:43
[INFO] [stderr]    |
[INFO] [stderr] 19 |     let lines: Vec<&str> = contents.split("\n").collect();
[INFO] [stderr]    |                                           ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/year_2017/day_3/a.rs:14:29
[INFO] [stderr]    |
[INFO] [stderr] 14 | fn level_for_target(target: &i32) -> i32 {
[INFO] [stderr]    |                             ^^^^ help: consider passing by value instead: `i32`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/year_2017/day_3/a.rs:24:25
[INFO] [stderr]    |
[INFO] [stderr] 24 | fn move_impossible(pos: &(i32, i32), level: i32, direction: &char) -> bool {
[INFO] [stderr]    |                         ^^^^^^^^^^^ help: consider passing by value instead: `(i32, i32)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/year_2017/day_3/a.rs:24:61
[INFO] [stderr]    |
[INFO] [stderr] 24 | fn move_impossible(pos: &(i32, i32), level: i32, direction: &char) -> bool {
[INFO] [stderr]    |                                                             ^^^^^ help: consider passing by value instead: `char`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/year_2017/day_3/a.rs:26:18
[INFO] [stderr]    |
[INFO] [stderr] 26 |         'N' => { if pos.1 == level { true } else { false } },
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `pos.1 == level`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/year_2017/day_3/a.rs:27:18
[INFO] [stderr]    |
[INFO] [stderr] 27 |         'E' => { if pos.0 == level { true } else { false } },
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `pos.0 == level`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/year_2017/day_3/a.rs:28:18
[INFO] [stderr]    |
[INFO] [stderr] 28 |         'S' => { if pos.1 == -level { true } else { false } },
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `pos.1 == -level`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/year_2017/day_3/a.rs:29:18
[INFO] [stderr]    |
[INFO] [stderr] 29 |         'W' => { if pos.0 == -level { true } else { false } },
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `pos.0 == -level`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/year_2017/day_3/a.rs:34:27
[INFO] [stderr]    |
[INFO] [stderr] 34 | fn move_in_direction(pos: &(i32, i32), direction: &char) -> (i32, i32) {
[INFO] [stderr]    |                           ^^^^^^^^^^^ help: consider passing by value instead: `(i32, i32)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/year_2017/day_3/a.rs:34:51
[INFO] [stderr]    |
[INFO] [stderr] 34 | fn move_in_direction(pos: &(i32, i32), direction: &char) -> (i32, i32) {
[INFO] [stderr]    |                                                   ^^^^^ help: consider passing by value instead: `char`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/year_2017/day_3/a.rs:44:22
[INFO] [stderr]    |
[INFO] [stderr] 44 | fn rotate(direction: &char) -> char {
[INFO] [stderr]    |                      ^^^^^ help: consider passing by value instead: `char`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/year_2017/day_3/b.rs:5:25
[INFO] [stderr]   |
[INFO] [stderr] 5 | fn move_impossible(pos: &(i32, i32), level: i32, direction: &char) -> bool {
[INFO] [stderr]   |                         ^^^^^^^^^^^ help: consider passing by value instead: `(i32, i32)`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/year_2017/day_3/b.rs:5:61
[INFO] [stderr]   |
[INFO] [stderr] 5 | fn move_impossible(pos: &(i32, i32), level: i32, direction: &char) -> bool {
[INFO] [stderr]   |                                                             ^^^^^ help: consider passing by value instead: `char`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]  --> src/year_2017/day_3/b.rs:7:18
[INFO] [stderr]   |
[INFO] [stderr] 7 |         'N' => { if pos.1 == level { true } else { false } },
[INFO] [stderr]   |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `pos.1 == level`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]  --> src/year_2017/day_3/b.rs:8:18
[INFO] [stderr]   |
[INFO] [stderr] 8 |         'E' => { if pos.0 == level { true } else { false } },
[INFO] [stderr]   |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `pos.0 == level`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]  --> src/year_2017/day_3/b.rs:9:18
[INFO] [stderr]   |
[INFO] [stderr] 9 |         'S' => { if pos.1 == -level { true } else { false } },
[INFO] [stderr]   |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `pos.1 == -level`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/year_2017/day_3/b.rs:10:18
[INFO] [stderr]    |
[INFO] [stderr] 10 |         'W' => { if pos.0 == -level { true } else { false } },
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `pos.0 == -level`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/year_2017/day_3/b.rs:15:22
[INFO] [stderr]    |
[INFO] [stderr] 15 | fn rotate(direction: &char) -> char {
[INFO] [stderr]    |                      ^^^^^ help: consider passing by value instead: `char`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/year_2017/day_3/b.rs:25:27
[INFO] [stderr]    |
[INFO] [stderr] 25 | fn move_in_direction(pos: &(i32, i32), direction: &char) -> (i32, i32) {
[INFO] [stderr]    |                           ^^^^^^^^^^^ help: consider passing by value instead: `(i32, i32)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/year_2017/day_3/b.rs:25:51
[INFO] [stderr]    |
[INFO] [stderr] 25 | fn move_in_direction(pos: &(i32, i32), direction: &char) -> (i32, i32) {
[INFO] [stderr]    |                                                   ^^^^^ help: consider passing by value instead: `char`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/year_2017/day_3/b.rs:35:57
[INFO] [stderr]    |
[INFO] [stderr] 35 | fn sum_adjacent(spiral: &HashMap<(i32, i32), i32>, pos: &(i32, i32)) -> i32 {
[INFO] [stderr]    |                                                         ^^^^^^^^^^^ help: consider passing by value instead: `(i32, i32)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.86s
[INFO] running `"docker" "inspect" "ed7b96fac8301d95ef562ec7b69d8d808c7f038abed7becbc0173b1f817033b3"`
[INFO] running `"docker" "rm" "-f" "ed7b96fac8301d95ef562ec7b69d8d808c7f038abed7becbc0173b1f817033b3"`
[INFO] [stdout] ed7b96fac8301d95ef562ec7b69d8d808c7f038abed7becbc0173b1f817033b3