[INFO] updating cached repository DerJesko/Rusty_Satellite [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/DerJesko/Rusty_Satellite [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/DerJesko/Rusty_Satellite" "work/ex/clippy-test-run/sources/stable/gh/DerJesko/Rusty_Satellite"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/DerJesko/Rusty_Satellite'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/DerJesko/Rusty_Satellite" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DerJesko/Rusty_Satellite"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DerJesko/Rusty_Satellite'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6ce3a4521f5c32f7841f267a168c2485e3bb7240 [INFO] sha for GitHub repo DerJesko/Rusty_Satellite: 6ce3a4521f5c32f7841f267a168c2485e3bb7240 [INFO] validating manifest of DerJesko/Rusty_Satellite on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of DerJesko/Rusty_Satellite on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing DerJesko/Rusty_Satellite [INFO] finished frobbing DerJesko/Rusty_Satellite [INFO] frobbed toml for DerJesko/Rusty_Satellite written to work/ex/clippy-test-run/sources/stable/gh/DerJesko/Rusty_Satellite/Cargo.toml [INFO] started frobbing DerJesko/Rusty_Satellite [INFO] finished frobbing DerJesko/Rusty_Satellite [INFO] frobbed toml for DerJesko/Rusty_Satellite written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DerJesko/Rusty_Satellite/Cargo.toml [INFO] crate DerJesko/Rusty_Satellite has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting DerJesko/Rusty_Satellite against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DerJesko/Rusty_Satellite:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5f5175d8779c42bc76824100761f2897ed42272b141486b1dd8dc30bcaf26268 [INFO] running `"docker" "start" "-a" "5f5175d8779c42bc76824100761f2897ed42272b141486b1dd8dc30bcaf26268"` [INFO] [stderr] Checking satsolve v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formula.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | clauses: clauses, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `clauses` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cdcl.rs:273:69 [INFO] [stderr] | [INFO] [stderr] 273 | return CdClInstance{formula: initialFormula, stack: vec!(), receiver: receiver, senders: senders}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cdcl.rs:273:89 [INFO] [stderr] | [INFO] [stderr] 273 | return CdClInstance{formula: initialFormula, stack: vec!(), receiver: receiver, senders: senders}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `senders` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formula.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | clauses: clauses, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `clauses` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cdcl.rs:273:69 [INFO] [stderr] | [INFO] [stderr] 273 | return CdClInstance{formula: initialFormula, stack: vec!(), receiver: receiver, senders: senders}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cdcl.rs:273:89 [INFO] [stderr] | [INFO] [stderr] 273 | return CdClInstance{formula: initialFormula, stack: vec!(), receiver: receiver, senders: senders}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `senders` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/formula.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/formula.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | return if return_clause_is_conflict {FormulaState::Conflict(return_clause)} else if return_clause_is_unit {FormulaState::Unit(return_clause)} else {FormulaState::Else}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if return_clause_is_conflict {FormulaState::Conflict(return_clause)} else if return_clause_is_unit {FormulaState::Unit(return_clause)} else {FormulaState::Else}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cdcl.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cdcl.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | return Some((clause, -1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((clause, -1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cdcl.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | return Some((clause, secondHighest+1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((clause, secondHighest+1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cdcl.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | return -1; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `-1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cdcl.rs:185:9 [INFO] [stderr] | [INFO] [stderr] 185 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cdcl.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cdcl.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | return CdClInstance{formula: initialFormula, stack: vec!(), receiver: receiver, senders: senders}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CdClInstance{formula: initialFormula, stack: vec!(), receiver: receiver, senders: senders}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cdcl.rs:363:9 [INFO] [stderr] | [INFO] [stderr] 363 | return Some(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | return (res, solver.formula.assignments); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(res, solver.formula.assignments)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/formula.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/formula.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | return if return_clause_is_conflict {FormulaState::Conflict(return_clause)} else if return_clause_is_unit {FormulaState::Unit(return_clause)} else {FormulaState::Else}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if return_clause_is_conflict {FormulaState::Conflict(return_clause)} else if return_clause_is_unit {FormulaState::Unit(return_clause)} else {FormulaState::Else}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cdcl.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cdcl.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | return Some((clause, -1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((clause, -1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cdcl.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | return Some((clause, secondHighest+1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((clause, secondHighest+1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cdcl.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | return -1; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `-1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cdcl.rs:185:9 [INFO] [stderr] | [INFO] [stderr] 185 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cdcl.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cdcl.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | return CdClInstance{formula: initialFormula, stack: vec!(), receiver: receiver, senders: senders}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CdClInstance{formula: initialFormula, stack: vec!(), receiver: receiver, senders: senders}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cdcl.rs:363:9 [INFO] [stderr] | [INFO] [stderr] 363 | return Some(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | return (res, solver.formula.assignments); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(res, solver.formula.assignments)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/clause.rs:7:52 [INFO] [stderr] | [INFO] [stderr] 7 | fn update_clause_state(&mut self, assignments: &Vec>); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/clause.rs:60:16 [INFO] [stderr] | [INFO] [stderr] 60 | if let Some(_) = assignments[self.literals[pointer_1].value()] { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 61 | | let mut i = 0; [INFO] [stderr] 62 | | while i < self.literals.len() { [INFO] [stderr] 63 | | if i != pointer_2 { [INFO] [stderr] ... | [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } else { amount_of_undefined += 1; } [INFO] [stderr] | |____________________________________________- help: try this: `if assignments[self.literals[pointer_1].value()].is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/clause.rs:99:16 [INFO] [stderr] | [INFO] [stderr] 99 | if let Some(_) = assignments[self.literals[pointer_2].value()] { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 100 | | let mut i = 0; [INFO] [stderr] 101 | | while i < self.literals.len() { [INFO] [stderr] 102 | | if i != pointer_1 { [INFO] [stderr] ... | [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | } else { amount_of_undefined += 1; } [INFO] [stderr] | |____________________________________________- help: try this: `if assignments[self.literals[pointer_2].value()].is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/literal.rs:6:39 [INFO] [stderr] | [INFO] [stderr] 6 | fn is_satisfied(&self, variables: &Vec>) -> bool; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `order` [INFO] [stderr] --> src/cdcl.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | for i in 0..self.formula.assignments.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 51 | for (i, ) in order.iter_mut().enumerate().take(self.formula.assignments.len()){ [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/cdcl.rs:213:17 [INFO] [stderr] | [INFO] [stderr] 213 | let ref mut receiver = self.receiver.as_ref().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^----------------------------------- help: try: `let receiver = &mut self.receiver.as_ref().unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/cdcl.rs:284:12 [INFO] [stderr] | [INFO] [stderr] 284 | if !self.unitPropagation(level).is_none(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.unitPropagation(level).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/cdcl.rs:309:19 [INFO] [stderr] | [INFO] [stderr] 309 | while !conflict.is_none() { //backtracking (some failure) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `conflict.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/cdcl.rs:335:23 [INFO] [stderr] | [INFO] [stderr] 335 | while !conflict.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `conflict.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cdcl.rs:346:21 [INFO] [stderr] | [INFO] [stderr] 346 | level = level - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `level -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `senders` [INFO] [stderr] --> src/main.rs:56:18 [INFO] [stderr] | [INFO] [stderr] 56 | for j in 0..threadAmount { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 56 | for (j, ) in senders.iter().enumerate().take(threadAmount) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/clause.rs:7:52 [INFO] [stderr] | [INFO] [stderr] 7 | fn update_clause_state(&mut self, assignments: &Vec>); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/clause.rs:60:16 [INFO] [stderr] | [INFO] [stderr] 60 | if let Some(_) = assignments[self.literals[pointer_1].value()] { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 61 | | let mut i = 0; [INFO] [stderr] 62 | | while i < self.literals.len() { [INFO] [stderr] 63 | | if i != pointer_2 { [INFO] [stderr] ... | [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } else { amount_of_undefined += 1; } [INFO] [stderr] | |____________________________________________- help: try this: `if assignments[self.literals[pointer_1].value()].is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/clause.rs:99:16 [INFO] [stderr] | [INFO] [stderr] 99 | if let Some(_) = assignments[self.literals[pointer_2].value()] { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 100 | | let mut i = 0; [INFO] [stderr] 101 | | while i < self.literals.len() { [INFO] [stderr] 102 | | if i != pointer_1 { [INFO] [stderr] ... | [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | } else { amount_of_undefined += 1; } [INFO] [stderr] | |____________________________________________- help: try this: `if assignments[self.literals[pointer_2].value()].is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/literal.rs:6:39 [INFO] [stderr] | [INFO] [stderr] 6 | fn is_satisfied(&self, variables: &Vec>) -> bool; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `order` [INFO] [stderr] --> src/cdcl.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | for i in 0..self.formula.assignments.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 51 | for (i, ) in order.iter_mut().enumerate().take(self.formula.assignments.len()){ [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/cdcl.rs:213:17 [INFO] [stderr] | [INFO] [stderr] 213 | let ref mut receiver = self.receiver.as_ref().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^----------------------------------- help: try: `let receiver = &mut self.receiver.as_ref().unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/cdcl.rs:284:12 [INFO] [stderr] | [INFO] [stderr] 284 | if !self.unitPropagation(level).is_none(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.unitPropagation(level).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/cdcl.rs:309:19 [INFO] [stderr] | [INFO] [stderr] 309 | while !conflict.is_none() { //backtracking (some failure) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `conflict.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/cdcl.rs:335:23 [INFO] [stderr] | [INFO] [stderr] 335 | while !conflict.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `conflict.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cdcl.rs:346:21 [INFO] [stderr] | [INFO] [stderr] 346 | level = level - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `level -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `senders` [INFO] [stderr] --> src/main.rs:56:18 [INFO] [stderr] | [INFO] [stderr] 56 | for j in 0..threadAmount { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 56 | for (j, ) in senders.iter().enumerate().take(threadAmount) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.10s [INFO] running `"docker" "inspect" "5f5175d8779c42bc76824100761f2897ed42272b141486b1dd8dc30bcaf26268"` [INFO] running `"docker" "rm" "-f" "5f5175d8779c42bc76824100761f2897ed42272b141486b1dd8dc30bcaf26268"` [INFO] [stdout] 5f5175d8779c42bc76824100761f2897ed42272b141486b1dd8dc30bcaf26268