[INFO] updating cached repository DavidBadura/maexchen [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/DavidBadura/maexchen [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/DavidBadura/maexchen" "work/ex/clippy-test-run/sources/stable/gh/DavidBadura/maexchen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/DavidBadura/maexchen'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/DavidBadura/maexchen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DavidBadura/maexchen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DavidBadura/maexchen'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6cadd821c0b43bbf8f2d02101fd118dd86c991d1 [INFO] sha for GitHub repo DavidBadura/maexchen: 6cadd821c0b43bbf8f2d02101fd118dd86c991d1 [INFO] validating manifest of DavidBadura/maexchen on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of DavidBadura/maexchen on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing DavidBadura/maexchen [INFO] finished frobbing DavidBadura/maexchen [INFO] frobbed toml for DavidBadura/maexchen written to work/ex/clippy-test-run/sources/stable/gh/DavidBadura/maexchen/Cargo.toml [INFO] started frobbing DavidBadura/maexchen [INFO] finished frobbing DavidBadura/maexchen [INFO] frobbed toml for DavidBadura/maexchen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DavidBadura/maexchen/Cargo.toml [INFO] crate DavidBadura/maexchen has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting DavidBadura/maexchen against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DavidBadura/maexchen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8bd4a856f0e7c83af9f5442e3cff578fa9da00ede7ac5a395fcc3430ef64389c [INFO] running `"docker" "start" "-a" "8bd4a856f0e7c83af9f5442e3cff578fa9da00ede7ac5a395fcc3430ef64389c"` [INFO] [stderr] Checking maexchen-bot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:177:5 [INFO] [stderr] | [INFO] [stderr] 177 | return Dice { d1: pair[0].parse::().unwrap(), d2: pair[1].parse::().unwrap() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Dice { d1: pair[0].parse::().unwrap(), d2: pair[1].parse::().unwrap() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:182:5 [INFO] [stderr] | [INFO] [stderr] 182 | / return Dice { [INFO] [stderr] 183 | | d1: rand::thread_rng().gen_range(1, 6), [INFO] [stderr] 184 | | d2: rand::thread_rng().gen_range(1, 6), [INFO] [stderr] 185 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 182 | Dice { [INFO] [stderr] 183 | d1: rand::thread_rng().gen_range(1, 6), [INFO] [stderr] 184 | d2: rand::thread_rng().gen_range(1, 6), [INFO] [stderr] 185 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | return self.d1 * 10 + self.d2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.d1 * 10 + self.d2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | return self.d1 == self.d2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.d1 == self.d2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:220:9 [INFO] [stderr] | [INFO] [stderr] 220 | return self.d1 == 2 && self.d2 == 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.d1 == 2 && self.d2 == 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:259:9 [INFO] [stderr] | [INFO] [stderr] 259 | / return Dice { [INFO] [stderr] 260 | | d1: new.d1, [INFO] [stderr] 261 | | d2: new.d2 + 1, [INFO] [stderr] 262 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 259 | Dice { [INFO] [stderr] 260 | d1: new.d1, [INFO] [stderr] 261 | d2: new.d2 + 1, [INFO] [stderr] 262 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:267:40 [INFO] [stderr] | [INFO] [stderr] 267 | Dice { d1: 3, d2: 1 } => { return 100; } [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:268:40 [INFO] [stderr] | [INFO] [stderr] 268 | Dice { d1: 3, d2: 2 } => { return 94; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `94` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:269:40 [INFO] [stderr] | [INFO] [stderr] 269 | Dice { d1: 4, d2: 1 } => { return 88; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `88` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:270:40 [INFO] [stderr] | [INFO] [stderr] 270 | Dice { d1: 4, d2: 2 } => { return 83; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `83` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:271:40 [INFO] [stderr] | [INFO] [stderr] 271 | Dice { d1: 4, d2: 3 } => { return 77; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `77` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:272:40 [INFO] [stderr] | [INFO] [stderr] 272 | Dice { d1: 5, d2: 1 } => { return 72; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `72` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:273:40 [INFO] [stderr] | [INFO] [stderr] 273 | Dice { d1: 5, d2: 2 } => { return 66; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `66` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:274:40 [INFO] [stderr] | [INFO] [stderr] 274 | Dice { d1: 5, d2: 3 } => { return 61; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `61` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:275:40 [INFO] [stderr] | [INFO] [stderr] 275 | Dice { d1: 5, d2: 4 } => { return 55; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `55` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:276:40 [INFO] [stderr] | [INFO] [stderr] 276 | Dice { d1: 6, d2: 1 } => { return 50; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `50` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:277:40 [INFO] [stderr] | [INFO] [stderr] 277 | Dice { d1: 6, d2: 2 } => { return 44; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `44` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:278:40 [INFO] [stderr] | [INFO] [stderr] 278 | Dice { d1: 6, d2: 3 } => { return 39; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `39` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:279:40 [INFO] [stderr] | [INFO] [stderr] 279 | Dice { d1: 6, d2: 4 } => { return 33; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `33` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:280:40 [INFO] [stderr] | [INFO] [stderr] 280 | Dice { d1: 6, d2: 5 } => { return 28; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `28` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:281:40 [INFO] [stderr] | [INFO] [stderr] 281 | Dice { d1: 1, d2: 1 } => { return 22; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `22` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:282:40 [INFO] [stderr] | [INFO] [stderr] 282 | Dice { d1: 2, d2: 2 } => { return 19; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `19` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:283:40 [INFO] [stderr] | [INFO] [stderr] 283 | Dice { d1: 3, d2: 3 } => { return 17; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `17` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:284:40 [INFO] [stderr] | [INFO] [stderr] 284 | Dice { d1: 4, d2: 4 } => { return 14; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `14` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:285:40 [INFO] [stderr] | [INFO] [stderr] 285 | Dice { d1: 5, d2: 5 } => { return 11; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `11` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:286:40 [INFO] [stderr] | [INFO] [stderr] 286 | Dice { d1: 6, d2: 6 } => { return 8; } [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:287:40 [INFO] [stderr] | [INFO] [stderr] 287 | Dice { d1: 2, d2: 1 } => { return 6; } [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:288:20 [INFO] [stderr] | [INFO] [stderr] 288 | _ => { return 0; } [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:327:9 [INFO] [stderr] | [INFO] [stderr] 327 | return Ordering::Less; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ordering::Less` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:340:9 [INFO] [stderr] | [INFO] [stderr] 340 | return self.d1 == other.d1 && self.d2 == other.d2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.d1 == other.d1 && self.d2 == other.d2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: function is never used: `bigger_random_dice` [INFO] [stderr] --> src/main.rs:189:1 [INFO] [stderr] | [INFO] [stderr] 189 | fn bigger_random_dice(before: Dice) -> Dice { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | server.send(format!("REGISTER;Amazing")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"REGISTER;Amazing".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:25:58 [INFO] [stderr] | [INFO] [stderr] 25 | let arguments: Vec<&str> = message.split(";").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:66:8 [INFO] [stderr] | [INFO] [stderr] 66 | if game.dices.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `game.dices.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:107:8 [INFO] [stderr] | [INFO] [stderr] 107 | if game.dices.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `game.dices.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:175:40 [INFO] [stderr] | [INFO] [stderr] 175 | let pair: Vec<&str> = string.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:177:5 [INFO] [stderr] | [INFO] [stderr] 177 | return Dice { d1: pair[0].parse::().unwrap(), d2: pair[1].parse::().unwrap() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Dice { d1: pair[0].parse::().unwrap(), d2: pair[1].parse::().unwrap() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:182:5 [INFO] [stderr] | [INFO] [stderr] 182 | / return Dice { [INFO] [stderr] 183 | | d1: rand::thread_rng().gen_range(1, 6), [INFO] [stderr] 184 | | d2: rand::thread_rng().gen_range(1, 6), [INFO] [stderr] 185 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 182 | Dice { [INFO] [stderr] 183 | d1: rand::thread_rng().gen_range(1, 6), [INFO] [stderr] 184 | d2: rand::thread_rng().gen_range(1, 6), [INFO] [stderr] 185 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | return self.d1 * 10 + self.d2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.d1 * 10 + self.d2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | return self.d1 == self.d2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.d1 == self.d2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:220:9 [INFO] [stderr] | [INFO] [stderr] 220 | return self.d1 == 2 && self.d2 == 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.d1 == 2 && self.d2 == 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:259:9 [INFO] [stderr] | [INFO] [stderr] 259 | / return Dice { [INFO] [stderr] 260 | | d1: new.d1, [INFO] [stderr] 261 | | d2: new.d2 + 1, [INFO] [stderr] 262 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 259 | Dice { [INFO] [stderr] 260 | d1: new.d1, [INFO] [stderr] 261 | d2: new.d2 + 1, [INFO] [stderr] 262 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:267:40 [INFO] [stderr] | [INFO] [stderr] 267 | Dice { d1: 3, d2: 1 } => { return 100; } [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:268:40 [INFO] [stderr] | [INFO] [stderr] 268 | Dice { d1: 3, d2: 2 } => { return 94; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `94` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:269:40 [INFO] [stderr] | [INFO] [stderr] 269 | Dice { d1: 4, d2: 1 } => { return 88; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `88` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:270:40 [INFO] [stderr] | [INFO] [stderr] 270 | Dice { d1: 4, d2: 2 } => { return 83; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `83` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:271:40 [INFO] [stderr] | [INFO] [stderr] 271 | Dice { d1: 4, d2: 3 } => { return 77; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `77` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:272:40 [INFO] [stderr] | [INFO] [stderr] 272 | Dice { d1: 5, d2: 1 } => { return 72; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `72` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:273:40 [INFO] [stderr] | [INFO] [stderr] 273 | Dice { d1: 5, d2: 2 } => { return 66; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `66` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:274:40 [INFO] [stderr] | [INFO] [stderr] 274 | Dice { d1: 5, d2: 3 } => { return 61; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `61` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:275:40 [INFO] [stderr] | [INFO] [stderr] 275 | Dice { d1: 5, d2: 4 } => { return 55; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `55` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:276:40 [INFO] [stderr] | [INFO] [stderr] 276 | Dice { d1: 6, d2: 1 } => { return 50; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `50` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:277:40 [INFO] [stderr] | [INFO] [stderr] 277 | Dice { d1: 6, d2: 2 } => { return 44; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `44` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:278:40 [INFO] [stderr] | [INFO] [stderr] 278 | Dice { d1: 6, d2: 3 } => { return 39; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `39` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:279:40 [INFO] [stderr] | [INFO] [stderr] 279 | Dice { d1: 6, d2: 4 } => { return 33; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `33` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:280:40 [INFO] [stderr] | [INFO] [stderr] 280 | Dice { d1: 6, d2: 5 } => { return 28; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `28` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:281:40 [INFO] [stderr] | [INFO] [stderr] 281 | Dice { d1: 1, d2: 1 } => { return 22; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `22` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:282:40 [INFO] [stderr] | [INFO] [stderr] 282 | Dice { d1: 2, d2: 2 } => { return 19; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `19` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:283:40 [INFO] [stderr] | [INFO] [stderr] 283 | Dice { d1: 3, d2: 3 } => { return 17; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `17` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:284:40 [INFO] [stderr] | [INFO] [stderr] 284 | Dice { d1: 4, d2: 4 } => { return 14; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `14` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:285:40 [INFO] [stderr] | [INFO] [stderr] 285 | Dice { d1: 5, d2: 5 } => { return 11; } [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `11` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:286:40 [INFO] [stderr] | [INFO] [stderr] 286 | Dice { d1: 6, d2: 6 } => { return 8; } [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:287:40 [INFO] [stderr] | [INFO] [stderr] 287 | Dice { d1: 2, d2: 1 } => { return 6; } [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:288:20 [INFO] [stderr] | [INFO] [stderr] 288 | _ => { return 0; } [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:327:9 [INFO] [stderr] | [INFO] [stderr] 327 | return Ordering::Less; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ordering::Less` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:340:9 [INFO] [stderr] | [INFO] [stderr] 340 | return self.d1 == other.d1 && self.d2 == other.d2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.d1 == other.d1 && self.d2 == other.d2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: function is never used: `bigger_random_dice` [INFO] [stderr] --> src/main.rs:189:1 [INFO] [stderr] | [INFO] [stderr] 189 | fn bigger_random_dice(before: Dice) -> Dice { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | server.send(format!("REGISTER;Amazing")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"REGISTER;Amazing".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:25:58 [INFO] [stderr] | [INFO] [stderr] 25 | let arguments: Vec<&str> = message.split(";").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:66:8 [INFO] [stderr] | [INFO] [stderr] 66 | if game.dices.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `game.dices.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:107:8 [INFO] [stderr] | [INFO] [stderr] 107 | if game.dices.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `game.dices.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:175:40 [INFO] [stderr] | [INFO] [stderr] 175 | let pair: Vec<&str> = string.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.92s [INFO] running `"docker" "inspect" "8bd4a856f0e7c83af9f5442e3cff578fa9da00ede7ac5a395fcc3430ef64389c"` [INFO] running `"docker" "rm" "-f" "8bd4a856f0e7c83af9f5442e3cff578fa9da00ede7ac5a395fcc3430ef64389c"` [INFO] [stdout] 8bd4a856f0e7c83af9f5442e3cff578fa9da00ede7ac5a395fcc3430ef64389c