[INFO] updating cached repository DataTriny/Fortuna [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/DataTriny/Fortuna [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/DataTriny/Fortuna" "work/ex/clippy-test-run/sources/stable/gh/DataTriny/Fortuna"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/DataTriny/Fortuna'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/DataTriny/Fortuna" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DataTriny/Fortuna"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DataTriny/Fortuna'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c1f62ae70db84b8e293670d4734f45d4c967386b [INFO] sha for GitHub repo DataTriny/Fortuna: c1f62ae70db84b8e293670d4734f45d4c967386b [INFO] validating manifest of DataTriny/Fortuna on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of DataTriny/Fortuna on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing DataTriny/Fortuna [INFO] finished frobbing DataTriny/Fortuna [INFO] frobbed toml for DataTriny/Fortuna written to work/ex/clippy-test-run/sources/stable/gh/DataTriny/Fortuna/Cargo.toml [INFO] started frobbing DataTriny/Fortuna [INFO] finished frobbing DataTriny/Fortuna [INFO] frobbed toml for DataTriny/Fortuna written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DataTriny/Fortuna/Cargo.toml [INFO] crate DataTriny/Fortuna has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting DataTriny/Fortuna against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DataTriny/Fortuna:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8807483c243aeafbce3690b03c06a066c0fca33763091125047a98cb99cf3468 [INFO] running `"docker" "start" "-a" "8807483c243aeafbce3690b03c06a066c0fca33763091125047a98cb99cf3468"` [INFO] [stderr] Checking fortuna v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `game` [INFO] [stderr] --> src/input/commands.rs:41:20 [INFO] [stderr] | [INFO] [stderr] 41 | fn execute(&self, game: &Game, args: Vec>) -> PlayerAction { [INFO] [stderr] | ^^^^ help: consider using `_game` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/input/commands.rs:41:33 [INFO] [stderr] | [INFO] [stderr] 41 | fn execute(&self, game: &Game, args: Vec>) -> PlayerAction { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/input/commands.rs:130:33 [INFO] [stderr] | [INFO] [stderr] 130 | fn execute(&self, game: &Game, args: Vec>) -> PlayerAction { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `game` [INFO] [stderr] --> src/input/selectors.rs:37:16 [INFO] [stderr] | [INFO] [stderr] 37 | fn get(&self, game: &Game, input: &str) -> (usize, Selectable) { [INFO] [stderr] | ^^^^ help: consider using `_game` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `game` [INFO] [stderr] --> src/input/commands.rs:41:20 [INFO] [stderr] | [INFO] [stderr] 41 | fn execute(&self, game: &Game, args: Vec>) -> PlayerAction { [INFO] [stderr] | ^^^^ help: consider using `_game` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/input/commands.rs:41:33 [INFO] [stderr] | [INFO] [stderr] 41 | fn execute(&self, game: &Game, args: Vec>) -> PlayerAction { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/input/commands.rs:130:33 [INFO] [stderr] | [INFO] [stderr] 130 | fn execute(&self, game: &Game, args: Vec>) -> PlayerAction { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `game` [INFO] [stderr] --> src/input/selectors.rs:37:16 [INFO] [stderr] | [INFO] [stderr] 37 | fn get(&self, game: &Game, input: &str) -> (usize, Selectable) { [INFO] [stderr] | ^^^^ help: consider using `_game` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/game.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | let mut offset = min(parsed.0 + 1, input.len()); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/game.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | let mut offset = min(parsed.0 + 1, input.len()); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::Game` [INFO] [stderr] --> src/game.rs:16:2 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new() -> Game { [INFO] [stderr] | _____^ [INFO] [stderr] 17 | | Game { [INFO] [stderr] 18 | | commands: CommandVec::new(), [INFO] [stderr] 19 | | is_running: false, [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for game::Game { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `input::commands::ExitCommand` [INFO] [stderr] --> src/input/commands.rs:32:2 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn new() -> ExitCommand { [INFO] [stderr] | _____^ [INFO] [stderr] 33 | | ExitCommand { [INFO] [stderr] 34 | | name: String::from("exit"), [INFO] [stderr] 35 | | selectors: Vec::new() [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `input::commands::HelpCommand` [INFO] [stderr] --> src/input/commands.rs:57:2 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn new() -> HelpCommand { [INFO] [stderr] | _____^ [INFO] [stderr] 58 | | HelpCommand { [INFO] [stderr] 59 | | name: String::from("help"), [INFO] [stderr] 60 | | selectors: vec![Box::new(CommandSelector { })] [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 51 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `input::commands::GoCommand` [INFO] [stderr] --> src/input/commands.rs:90:2 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 91 | | Self { [INFO] [stderr] 92 | | name: String::from("go"), [INFO] [stderr] 93 | | selectors: vec![Box::new(DirectionSelector { is_optional: false })] [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `input::commands::LookCommand` [INFO] [stderr] --> src/input/commands.rs:121:2 [INFO] [stderr] | [INFO] [stderr] 121 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 122 | | Self { [INFO] [stderr] 123 | | name: String::from("look"), [INFO] [stderr] 124 | | selectors: Vec::new() [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 115 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `input::CommandVec` [INFO] [stderr] --> src/input/mod.rs:12:2 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn new() -> CommandVec { [INFO] [stderr] | _____^ [INFO] [stderr] 13 | | CommandVec { commands: Vec::new() } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/input/mod.rs:22:36 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn get_at(&self, i: usize) -> &Box { &self.commands[i] } [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&Command` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `world::World` [INFO] [stderr] --> src/world/mod.rs:33:2 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn new() -> World { [INFO] [stderr] | _____^ [INFO] [stderr] 34 | | World { [INFO] [stderr] 35 | | player: Player::new(0), [INFO] [stderr] 36 | | rooms: World::create_rooms() [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | impl Default for world::World { [INFO] [stderr] 33 | fn default() -> Self { [INFO] [stderr] 34 | Self::new() [INFO] [stderr] 35 | } [INFO] [stderr] 36 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::Game` [INFO] [stderr] --> src/game.rs:16:2 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new() -> Game { [INFO] [stderr] | _____^ [INFO] [stderr] 17 | | Game { [INFO] [stderr] 18 | | commands: CommandVec::new(), [INFO] [stderr] 19 | | is_running: false, [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for game::Game { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `input::commands::ExitCommand` [INFO] [stderr] --> src/input/commands.rs:32:2 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn new() -> ExitCommand { [INFO] [stderr] | _____^ [INFO] [stderr] 33 | | ExitCommand { [INFO] [stderr] 34 | | name: String::from("exit"), [INFO] [stderr] 35 | | selectors: Vec::new() [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `input::commands::HelpCommand` [INFO] [stderr] --> src/input/commands.rs:57:2 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn new() -> HelpCommand { [INFO] [stderr] | _____^ [INFO] [stderr] 58 | | HelpCommand { [INFO] [stderr] 59 | | name: String::from("help"), [INFO] [stderr] 60 | | selectors: vec![Box::new(CommandSelector { })] [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 51 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `input::commands::GoCommand` [INFO] [stderr] --> src/input/commands.rs:90:2 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 91 | | Self { [INFO] [stderr] 92 | | name: String::from("go"), [INFO] [stderr] 93 | | selectors: vec![Box::new(DirectionSelector { is_optional: false })] [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `input::commands::LookCommand` [INFO] [stderr] --> src/input/commands.rs:121:2 [INFO] [stderr] | [INFO] [stderr] 121 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 122 | | Self { [INFO] [stderr] 123 | | name: String::from("look"), [INFO] [stderr] 124 | | selectors: Vec::new() [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 115 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `input::CommandVec` [INFO] [stderr] --> src/input/mod.rs:12:2 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn new() -> CommandVec { [INFO] [stderr] | _____^ [INFO] [stderr] 13 | | CommandVec { commands: Vec::new() } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/input/mod.rs:22:36 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn get_at(&self, i: usize) -> &Box { &self.commands[i] } [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&Command` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `world::World` [INFO] [stderr] --> src/world/mod.rs:33:2 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn new() -> World { [INFO] [stderr] | _____^ [INFO] [stderr] 34 | | World { [INFO] [stderr] 35 | | player: Player::new(0), [INFO] [stderr] 36 | | rooms: World::create_rooms() [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | impl Default for world::World { [INFO] [stderr] 33 | fn default() -> Self { [INFO] [stderr] 34 | Self::new() [INFO] [stderr] 35 | } [INFO] [stderr] 36 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.02s [INFO] running `"docker" "inspect" "8807483c243aeafbce3690b03c06a066c0fca33763091125047a98cb99cf3468"` [INFO] running `"docker" "rm" "-f" "8807483c243aeafbce3690b03c06a066c0fca33763091125047a98cb99cf3468"` [INFO] [stdout] 8807483c243aeafbce3690b03c06a066c0fca33763091125047a98cb99cf3468