[INFO] updating cached repository DaanHoogland/tr [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/DaanHoogland/tr [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/DaanHoogland/tr" "work/ex/clippy-test-run/sources/stable/gh/DaanHoogland/tr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/DaanHoogland/tr'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/DaanHoogland/tr" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DaanHoogland/tr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DaanHoogland/tr'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ef036497a42a42e18e3d22b79b053e9643dd419d [INFO] sha for GitHub repo DaanHoogland/tr: ef036497a42a42e18e3d22b79b053e9643dd419d [INFO] validating manifest of DaanHoogland/tr on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of DaanHoogland/tr on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing DaanHoogland/tr [INFO] finished frobbing DaanHoogland/tr [INFO] frobbed toml for DaanHoogland/tr written to work/ex/clippy-test-run/sources/stable/gh/DaanHoogland/tr/Cargo.toml [INFO] started frobbing DaanHoogland/tr [INFO] finished frobbing DaanHoogland/tr [INFO] frobbed toml for DaanHoogland/tr written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DaanHoogland/tr/Cargo.toml [INFO] crate DaanHoogland/tr has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting DaanHoogland/tr against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DaanHoogland/tr:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fa0eb832d18113440df5274a42dc63c86d717cb82d042eebb0bfef41128600d4 [INFO] running `"docker" "start" "-a" "fa0eb832d18113440df5274a42dc63c86d717cb82d042eebb0bfef41128600d4"` [INFO] [stderr] Checking strsim v0.4.0 [INFO] [stderr] Checking ansi_term v0.6.3 [INFO] [stderr] Checking clap v1.2.1 [INFO] [stderr] Checking tr v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | const MAN_PAGE: &'static str = /* @MANSTART{tr} */ r#"NAME [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | const MAN_PAGE: &'static str = /* @MANSTART{tr} */ r#"NAME [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:75:19 [INFO] [stderr] | [INFO] [stderr] 75 | while ! search.next().is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `search.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:76:20 [INFO] [stderr] | [INFO] [stderr] 76 | if ! nextkar.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `nextkar.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:119:45 [INFO] [stderr] | [INFO] [stderr] 119 | if !self.delete && !self.squeeze && self.replace.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.replace.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MAN_PAGE` [INFO] [stderr] --> src/main.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / const MAN_PAGE: &'static str = /* @MANSTART{tr} */ r#"NAME [INFO] [stderr] 7 | | tr - translate characters [INFO] [stderr] 8 | | [INFO] [stderr] 9 | | SYNOPSIS [INFO] [stderr] ... | [INFO] [stderr] 47 | | loads. [INFO] [stderr] 48 | | "#; /* @MANEND */ [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `complement` [INFO] [stderr] --> src/main.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | complement: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `delete` [INFO] [stderr] --> src/main.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | delete: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `squeeze` [INFO] [stderr] --> src/main.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | squeeze: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `print_opts` [INFO] [stderr] --> src/main.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | fn print_opts(&self) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_opts` [INFO] [stderr] --> src/main.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | fn get_opts(&mut self) -> &mut Translation { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `check_opts` [INFO] [stderr] --> src/main.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | fn check_opts(&mut self) -> &mut Translation { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:75:19 [INFO] [stderr] | [INFO] [stderr] 75 | while ! search.next().is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `search.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:76:20 [INFO] [stderr] | [INFO] [stderr] 76 | if ! nextkar.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `nextkar.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:119:45 [INFO] [stderr] | [INFO] [stderr] 119 | if !self.delete && !self.squeeze && self.replace.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.replace.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.96s [INFO] running `"docker" "inspect" "fa0eb832d18113440df5274a42dc63c86d717cb82d042eebb0bfef41128600d4"` [INFO] running `"docker" "rm" "-f" "fa0eb832d18113440df5274a42dc63c86d717cb82d042eebb0bfef41128600d4"` [INFO] [stdout] fa0eb832d18113440df5274a42dc63c86d717cb82d042eebb0bfef41128600d4